17 Commits
Author SHA1 Message Date
Algis DumbrisandClaude Opus 4.6 e4b0439e6e merge: 006-admin-cli-docker-fixes — alpine base, channels create/join CLI, absolute socket path
Release / Build darwin/amd64 (push) Canceled after 0s
Release / Build linux/amd64 (push) Canceled after 0s
Release / Build darwin/arm64 (push) Canceled after 0s
Release / Build linux/arm64 (push) Canceled after 0s
Release / Generate Homebrew Formula (push) Canceled after 0s
Release / GitHub Release (push) Canceled after 0s
Release / Docker Image (push) Canceled after 0s
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 15:09:12 +02:00
Algis DumbrisandClaude Opus 4.6 9dd27c4b9b feat: admin CLI & Docker fixes — alpine base, channels create/join, absolute socket path
Switch Docker runtime from scratch to alpine:3.19 so kubectl exec works
for admin CLI operations. Add `synapbus channels create` and
`synapbus channels join` CLI commands with corresponding admin socket
handlers. Change default socket path to /data/synapbus.sock (absolute).
Also add Helm envFrom support and NodePort configuration.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 14:54:13 +02:00
Algis DumbrisandClaude Opus 4.6 5143e32f83 fix: notification bugs — human-agent-only counts, Svelte 5 lifecycle, API response parsing
Release / Build darwin/amd64 (push) Canceled after 0s
Release / Build linux/amd64 (push) Canceled after 0s
Release / Build darwin/arm64 (push) Canceled after 0s
Release / Build linux/arm64 (push) Canceled after 0s
Release / Generate Homebrew Formula (push) Canceled after 0s
Release / GitHub Release (push) Canceled after 0s
Release / Docker Image (push) Canceled after 0s
- Use human agent's perspective only for unread counts (avoids system agent inflation)
- Replace onDestroy + get() with $effect cleanup in channel/DM pages (Svelte 5 compat)
- Fix notification store to parse array-of-objects API response format
- Add last_read_message_id to DM messages endpoint
- Fix test agent type seeding for GetHumanAgentForUser

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 09:56:29 +02:00
Algis DumbrisandClaude Opus 4.6 eec06f5b5f feat: web UI notifications — unread badges, new message line, auto mark-as-read
Backend:
- GET /api/notifications/unread returns channel + DM unread counts
- POST /api/notifications/mark-read updates inbox_state for channels/DMs
- SSE broadcaster wired into message send for real-time push
- last_read_message_id added to channel/DM message responses

Frontend:
- Notification store tracks unread counts per channel/DM
- SSE listener for new_message and unread_update events
- Red circular badges in sidebar (Slack-style)
- "New messages" separator line in channel/DM views
- Auto mark-as-read after 2 seconds of viewing

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 09:18:36 +02:00
Algis DumbrisandClaude Opus 4.6 68b7d946b3 fix: scan SQLite text timestamps in channel summary query
sql.NullTime cannot scan SQLite's text-format timestamps from
modernc.org/sqlite. Switch to sql.NullString with manual time.Parse.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 08:43:18 +02:00
Algis DumbrisandClaude Opus 4.6 fe8928a7fc refactor: consolidate 30 MCP tools into 4 hybrid tools (my_status, search, execute, send_message)
- JS/TS execution engine (goja + esbuild) with sandboxed runtime and call() bridge
- BM25 action discovery index over 23 registered actions
- ServiceBridge mapping call() invocations to existing service methods
- Admin CLI subcommands for webhook/k8s/gc operations
- Pagination support (offset/limit) in read_inbox, search_messages, get_channel_messages
- Fixed test assertions for call() envelope structure {ok, result}

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 08:29:37 +02:00
Algis DumbrisandClaude Opus 4.6 fef84ed538 refactor: consolidate 30 MCP tools into 4 hybrid tools
Replace 5 separate tool registrars (messaging, channels, swarm,
attachments, webhooks) with a single HybridToolRegistrar exposing
4 tools: my_status, send_message, search, and execute.

New foundation packages:
- internal/actions: action registry (22 actions) + BM25 search index
- internal/jsruntime: lightweight call() expression parser with
  concurrency-limited execution pool

The `execute` tool dispatches call() expressions through a
ServiceBridge that maps action names to existing service methods,
preserving all original handler logic. The `search` tool enables
agents to discover available actions by keyword. The `send_message`
tool merges DM and channel sending with mutual exclusion.

All unit tests, integration tests, build, and vet pass.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 08:16:41 +02:00
Algis Dumbris 275a80326f merge: Task C - Pagination + advanced filtering 2026-03-15 08:00:15 +02:00
Algis Dumbris 8e62319166 merge: Task B - Action registry + BM25 search (internal/actions/) 2026-03-15 08:00:12 +02:00
Algis Dumbris b47070533b merge: Task A - JS/TS runtime engine (internal/jsruntime/) 2026-03-15 08:00:06 +02:00
Algis DumbrisandClaude Opus 4.6 b9d402c135 feat: add offset-based pagination and advanced filtering to service layer
Add Offset, After, Before date filters to ReadOptions and SearchOptions.
Add Channel name filter to SearchOptions. Introduce PaginatedMessages,
PaginatedChannels, and PaginatedTasks types with total counts. Update
ReadInbox, SearchMessages, and GetChannelMessages to return paginated
results. Add CountInboxMessages, CountSearchMessages, CountChannelMessages,
and CountTasks store methods. Update all callers in MCP tools, REST API
handlers, and search service. Add comprehensive tests for offset
pagination, date filtering, channel name filtering, and combined
filters with pagination.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 07:59:33 +02:00
Algis DumbrisandClaude Opus 4.6 7f74357437 feat: add action registry with BM25 search index for tool discovery
Register all 23 agent-callable operations (messaging, channels, swarm,
attachments) with full parameter metadata and usage examples. Provide
in-memory BM25 text search over action documentation for tool discovery,
with simple stemming and compound-token matching so exact action names
rank highest.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 07:54:13 +02:00
Algis DumbrisandClaude Opus 4.6 d5ca5b915f feat: add webhook, k8s, and attachments gc CLI subcommands
Add admin CLI subcommands for managing webhooks, K8s job handlers,
and running attachment garbage collection via the Unix admin socket.

Server-side:
- Add WebhookServiceProvider and K8sServiceProvider interfaces to admin pkg
- Add 7 new command handlers: webhook.{register,list,delete},
  k8s.{register,list,delete}, attachments.gc
- Wire webhook and k8s services into admin.Services struct in main.go

CLI-side:
- Add `synapbus webhook {register,list,delete}` commands
- Add `synapbus k8s {register,list,delete}` commands
- Add `synapbus attachments gc` command
- All commands follow existing patterns (adminRequest, printTable, printJSON)

Tests:
- Add cmd/synapbus/admin_test.go with 9 tests covering command
  registration, required flag validation, and existing command preservation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 07:53:53 +02:00
Algis DumbrisandClaude Opus 4.6 e8165511de feat: add sandboxed JS/TS runtime engine (internal/jsruntime)
Pure Go JavaScript/TypeScript execution engine using goja + esbuild.
Provides sandboxed code execution with a call() bridge for agent
actions, automatic TypeScript detection and transpilation, timeout
enforcement, max-calls limits, and a concurrent execution pool.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 07:53:25 +02:00
Algis DumbrisandClaude Opus 4.6 0469a7d2e1 plan: implementation plan for 005-hybrid-mcp-tools
3-phase plan: foundation (jsruntime, actions, pagination, CLI),
MCP rewrite (4 tools), website docs. Phase 1 runs in parallel.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 07:48:50 +02:00
Algis DumbrisandClaude Opus 4.6 7502c9fbd7 spec: address review feedback for 005-hybrid-mcp-tools
- Enumerate all 23 actions explicitly in FR-003 action catalog table
- Remove esbuild reference from FR-032 (moved to Assumptions)
- Add FR-043 (channel broadcast semantics), FR-044 (reply_to validation)
- Add FR-039a (memory limit enforcement for code execution)
- Rephrase FR-039 as testable concurrent behavior requirement
- Clarify search tool is for action discovery only (not message search)
- Add relevance score to search results (FR-021)
- Add edge cases: reply_to, memory limits, search vs search_messages
- Add breaking change migration note to Assumptions
- Fix SC-001 to be objectively measurable (count, not token estimate)
- Fix checklist self-assessment accuracy

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 07:36:39 +02:00
Algis DumbrisandClaude Opus 4.6 babf6b89e2 spec: hybrid MCP tool architecture (005)
Redesign 30 MCP tools into 4-tool hybrid architecture:
my_status, search, execute, send_message. Includes JS/TS
code execution engine, BM25 tool discovery, pagination,
advanced filtering, and CLI subcommands for admin ops.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-15 07:32:55 +02:00
75 changed files with 9020 additions and 2762 deletions
+2
View File
@@ -98,6 +98,8 @@ make lint # Run linters
- modernc.org/sqlite (pure Go), migration 009_webhooks.sql (003-webhooks-k8s-runner)
- Go 1.25+ (per go.mod) + mark3labs/mcp-go (MCP tools), go-chi/chi (HTTP), spf13/cobra (CLI), modernc.org/sqlite (storage), TFMV/hnsw (vectors) (004-embeddings-retention-inbox)
- SQLite (modernc.org/sqlite, pure Go) — single DB file in `--data` directory (004-embeddings-retention-inbox)
- Go 1.25+ (per go.mod) + spf13/cobra (CLI), go-chi/chi (HTTP), mark3labs/mcp-go (MCP) (006-admin-cli-docker-fixes)
- modernc.org/sqlite (pure Go, zero CGO) (006-admin-cli-docker-fixes)
## Recent Changes
- 002-mcp-auth-ux-polish: Added Go 1.23+ + ory/fosite (OAuth 2.1), mark3labs/mcp-go (MCP server), go-chi/chi (HTTP), Svelte 5 + Tailwind (Web UI)
+2 -3
View File
@@ -18,9 +18,8 @@ COPY --from=web-builder /app/web/build internal/web/dist/
RUN CGO_ENABLED=0 GOOS=linux go build -ldflags="-s -w -X main.version=${VERSION}" -o /synapbus ./cmd/synapbus/
# Stage 3: Runtime
FROM scratch
COPY --from=go-builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
COPY --from=go-builder /usr/share/zoneinfo /usr/share/zoneinfo
FROM alpine:3.19
RUN apk add --no-cache ca-certificates tzdata
COPY --from=go-builder /synapbus /synapbus
EXPOSE 8080
VOLUME ["/data"]
+96
View File
@@ -0,0 +1,96 @@
# Autonomous Implementation Summary
**Feature**: Admin CLI & Docker Fixes
**Branch**: `006-admin-cli-docker-fixes`
**Date**: 2026-03-15
**Status**: COMPLETE — 8 of 8 tasks implemented, all tests pass, binary builds
## What Was Built
### 1. Alpine Docker Base Image (T06)
**Problem**: `scratch` base image has no shell — `kubectl exec` into the pod can't run admin CLI commands.
**Solution**: Changed `FROM scratch` to `FROM alpine:3.19` in the runtime stage. Alpine provides `/bin/sh` and a working process environment. TLS certs and timezone data are now installed via `apk` instead of copied from the builder stage.
**File Modified**: `Dockerfile`
### 2. `synapbus channels create` CLI Command (T02, T04)
**Problem**: No CLI command to create channels — had to use REST API with session cookies.
**Solution**: Added `channels.create` admin socket handler and `synapbus channels create` cobra command:
- `--name` (required): Channel name
- `--description` (optional): Channel description
- Creates channel via the channel service with `created_by: "system"`, type `"standard"`
- Returns channel details as JSON
**Files Modified**: `cmd/synapbus/admin.go`, `internal/admin/socket.go`
### 3. `synapbus channels join` CLI Command (T03, T05)
**Problem**: No CLI command to add agents to channels.
**Solution**: Added `channels.join` admin socket handler and `synapbus channels join` cobra command:
- `--channel` (required): Channel name to join
- `--agent` (required): Agent name to add
- Looks up channel by name, calls `JoinChannel` (idempotent)
- Reports `"joined"` or `"already_member"` status
**Files Modified**: `cmd/synapbus/admin.go`, `internal/admin/socket.go`
### 4. Absolute Default Socket Path (T01)
**Problem**: Default `./data/synapbus.sock` is confusing in containers where CWD varies.
**Solution**: Changed default socket path from `./data/synapbus.sock` to `/data/synapbus.sock` in both the `--socket` flag definition and the `SYNAPBUS_SOCKET` env var comparison.
**File Modified**: `cmd/synapbus/admin.go`
## Tests Added (T07)
| Test | Description |
|------|-------------|
| `TestChannelsCreateCommandRegistered` | Verifies `channels create` subcommand exists |
| `TestChannelsCreateRequiredFlags` | Verifies `--name` is required, `--description` is optional |
| `TestChannelsJoinCommandRegistered` | Verifies `channels join` subcommand exists |
| `TestChannelsJoinRequiredFlags` | Verifies `--channel` and `--agent` are both required |
| `TestDefaultSocketPath` | Verifies default is `/data/synapbus.sock` |
## Verification Results (T08)
| Check | Result |
|-------|--------|
| `go build ./...` | PASS |
| `go test ./...` | ALL PASS (24 packages, 0 failures) |
| Zero CGO | Confirmed (CGO_ENABLED=0 in Dockerfile) |
| No regressions | All 14 existing CLI tests still pass |
## Files Changed
| File | Changes |
|------|---------|
| `Dockerfile` | `FROM scratch` → `FROM alpine:3.19` + `apk add --no-cache ca-certificates tzdata` |
| `cmd/synapbus/admin.go` | Default socket `/data/synapbus.sock`, `channels create` + `channels join` commands |
| `cmd/synapbus/admin_test.go` | 5 new tests for commands, flags, and default socket |
| `internal/admin/socket.go` | `channels.create` + `channels.join` handlers, `channels` import |
## CLI Commands Added
| Command | Description |
|---------|-------------|
| `synapbus channels create --name X [--description Y]` | Create a new channel |
| `synapbus channels join --channel X --agent Y` | Add an agent to a channel |
## Usage Examples
```bash
# In Kubernetes (now works with alpine base)
kubectl exec -n synapbus deploy/synapbus -- /synapbus channels create --name news-feed --description "News feed"
kubectl exec -n synapbus deploy/synapbus -- /synapbus channels join --channel news-feed --agent research-mcpproxy
kubectl exec -n synapbus deploy/synapbus -- /synapbus channels list
# Local development
synapbus --socket ./data/synapbus.sock channels create --name test-channel
synapbus --socket ./data/synapbus.sock channels join --channel test-channel --agent my-agent
```
+265 -5
View File
@@ -17,7 +17,7 @@ var adminSocket string
// adminRequest sends a command over the Unix socket and returns the parsed response.
func adminRequest(command string, args interface{}) (map[string]interface{}, error) {
socket := adminSocket
if s := os.Getenv("SYNAPBUS_SOCKET"); s != "" && socket == "./data/synapbus.sock" {
if s := os.Getenv("SYNAPBUS_SOCKET"); s != "" && socket == "/data/synapbus.sock" {
socket = s
}
@@ -561,7 +561,54 @@ func addAdminCommands(rootCmd *cobra.Command) {
channelsShowCmd.Flags().StringVar(&channelsShowName, "name", "", "Channel name")
channelsShowCmd.MarkFlagRequired("name")
channelsCmd.AddCommand(channelsListCmd, channelsShowCmd)
var (
channelsCreateName string
channelsCreateDesc string
)
channelsCreateCmd := &cobra.Command{
Use: "create",
Short: "Create a new channel",
RunE: func(cmd *cobra.Command, args []string) error {
resp, err := adminRequest("channels.create", map[string]string{
"name": channelsCreateName,
"description": channelsCreateDesc,
})
if err != nil {
return err
}
printJSON(resp["data"])
return nil
},
}
channelsCreateCmd.Flags().StringVar(&channelsCreateName, "name", "", "Channel name")
channelsCreateCmd.Flags().StringVar(&channelsCreateDesc, "description", "", "Channel description")
channelsCreateCmd.MarkFlagRequired("name")
var (
channelsJoinChannel string
channelsJoinAgent string
)
channelsJoinCmd := &cobra.Command{
Use: "join",
Short: "Add an agent to a channel",
RunE: func(cmd *cobra.Command, args []string) error {
resp, err := adminRequest("channels.join", map[string]string{
"channel": channelsJoinChannel,
"agent": channelsJoinAgent,
})
if err != nil {
return err
}
printJSON(resp["data"])
return nil
},
}
channelsJoinCmd.Flags().StringVar(&channelsJoinChannel, "channel", "", "Channel name")
channelsJoinCmd.Flags().StringVar(&channelsJoinAgent, "agent", "", "Agent name")
channelsJoinCmd.MarkFlagRequired("channel")
channelsJoinCmd.MarkFlagRequired("agent")
channelsCmd.AddCommand(channelsListCmd, channelsShowCmd, channelsCreateCmd, channelsJoinCmd)
// ----- conversations commands -----
conversationsCmd := &cobra.Command{
@@ -705,10 +752,223 @@ func addAdminCommands(rootCmd *cobra.Command) {
retentionCmd.AddCommand(retentionStatusCmd)
// ----- add persistent flag and commands to root -----
rootCmd.PersistentFlags().StringVar(&adminSocket, "socket", "./data/synapbus.sock", "Path to admin Unix socket")
// ----- webhook commands -----
webhookCmd := &cobra.Command{
Use: "webhook",
Short: "Manage webhooks",
}
rootCmd.AddCommand(userCmd, agentCmd, auditCmd, backupCmd, messagesCmd, channelsCmd, conversationsCmd, embeddingsCmd, dbCmd, retentionCmd)
var (
webhookRegisterURL string
webhookRegisterEvents string
webhookRegisterSecret string
webhookRegisterAgent string
)
webhookRegisterCmd := &cobra.Command{
Use: "register",
Short: "Register a webhook",
RunE: func(cmd *cobra.Command, args []string) error {
resp, err := adminRequest("webhook.register", map[string]string{
"url": webhookRegisterURL,
"events": webhookRegisterEvents,
"secret": webhookRegisterSecret,
"agent_name": webhookRegisterAgent,
})
if err != nil {
return err
}
printJSON(resp["data"])
return nil
},
}
webhookRegisterCmd.Flags().StringVar(&webhookRegisterURL, "url", "", "Webhook endpoint URL")
webhookRegisterCmd.Flags().StringVar(&webhookRegisterEvents, "events", "", "Comma-separated event types (e.g. message.received,channel.message)")
webhookRegisterCmd.Flags().StringVar(&webhookRegisterSecret, "secret", "", "HMAC signing secret")
webhookRegisterCmd.Flags().StringVar(&webhookRegisterAgent, "agent", "", "Agent name to hook events for")
webhookRegisterCmd.MarkFlagRequired("url")
webhookRegisterCmd.MarkFlagRequired("events")
webhookRegisterCmd.MarkFlagRequired("secret")
webhookRegisterCmd.MarkFlagRequired("agent")
var webhookListAgent string
webhookListCmd := &cobra.Command{
Use: "list",
Short: "List webhooks",
RunE: func(cmd *cobra.Command, args []string) error {
reqArgs := map[string]interface{}{}
if webhookListAgent != "" {
reqArgs["agent_name"] = webhookListAgent
}
resp, err := adminRequest("webhook.list", reqArgs)
if err != nil {
return err
}
rows := toMapSlice(resp["data"])
if len(rows) == 0 {
fmt.Println("No webhooks found.")
return nil
}
printTable([]string{"ID", "AGENT", "URL", "EVENTS", "STATUS", "FAILURES", "CREATED_AT"}, toTableRows(rows, map[string]string{
"ID": "id", "AGENT": "agent_name", "URL": "url", "EVENTS": "events",
"STATUS": "status", "FAILURES": "consecutive_failures", "CREATED_AT": "created_at",
}))
return nil
},
}
webhookListCmd.Flags().StringVar(&webhookListAgent, "agent", "", "Filter by agent name")
var webhookDeleteID int64
webhookDeleteCmd := &cobra.Command{
Use: "delete",
Short: "Delete a webhook",
RunE: func(cmd *cobra.Command, args []string) error {
resp, err := adminRequest("webhook.delete", map[string]interface{}{
"id": webhookDeleteID,
})
if err != nil {
return err
}
printJSON(resp["data"])
return nil
},
}
webhookDeleteCmd.Flags().Int64Var(&webhookDeleteID, "id", 0, "Webhook ID to delete")
webhookDeleteCmd.MarkFlagRequired("id")
webhookCmd.AddCommand(webhookRegisterCmd, webhookListCmd, webhookDeleteCmd)
// ----- k8s commands -----
k8sCmd := &cobra.Command{
Use: "k8s",
Short: "Manage Kubernetes job handlers",
}
var (
k8sRegisterImage string
k8sRegisterEvents string
k8sRegisterAgent string
k8sRegisterNamespace string
k8sRegisterMemory string
k8sRegisterCPU string
k8sRegisterEnv string
k8sRegisterTimeout int
)
k8sRegisterCmd := &cobra.Command{
Use: "register",
Short: "Register a K8s job handler",
RunE: func(cmd *cobra.Command, args []string) error {
reqArgs := map[string]interface{}{
"image": k8sRegisterImage,
"events": k8sRegisterEvents,
"agent_name": k8sRegisterAgent,
}
if k8sRegisterNamespace != "" {
reqArgs["namespace"] = k8sRegisterNamespace
}
if k8sRegisterMemory != "" {
reqArgs["resources_memory"] = k8sRegisterMemory
}
if k8sRegisterCPU != "" {
reqArgs["resources_cpu"] = k8sRegisterCPU
}
if k8sRegisterEnv != "" {
reqArgs["env"] = k8sRegisterEnv
}
if k8sRegisterTimeout > 0 {
reqArgs["timeout_seconds"] = k8sRegisterTimeout
}
resp, err := adminRequest("k8s.register", reqArgs)
if err != nil {
return err
}
printJSON(resp["data"])
return nil
},
}
k8sRegisterCmd.Flags().StringVar(&k8sRegisterImage, "image", "", "Container image")
k8sRegisterCmd.Flags().StringVar(&k8sRegisterEvents, "events", "", "Comma-separated event types")
k8sRegisterCmd.Flags().StringVar(&k8sRegisterAgent, "agent", "", "Agent name")
k8sRegisterCmd.Flags().StringVar(&k8sRegisterNamespace, "namespace", "", "Kubernetes namespace (optional)")
k8sRegisterCmd.Flags().StringVar(&k8sRegisterMemory, "memory", "", "Memory resource limit (e.g. 256Mi)")
k8sRegisterCmd.Flags().StringVar(&k8sRegisterCPU, "cpu", "", "CPU resource limit (e.g. 500m)")
k8sRegisterCmd.Flags().StringVar(&k8sRegisterEnv, "env", "", "Comma-separated KEY=VALUE environment variables")
k8sRegisterCmd.Flags().IntVar(&k8sRegisterTimeout, "timeout", 300, "Job timeout in seconds")
k8sRegisterCmd.MarkFlagRequired("image")
k8sRegisterCmd.MarkFlagRequired("events")
k8sRegisterCmd.MarkFlagRequired("agent")
var k8sListAgent string
k8sListCmd := &cobra.Command{
Use: "list",
Short: "List K8s job handlers",
RunE: func(cmd *cobra.Command, args []string) error {
reqArgs := map[string]interface{}{}
if k8sListAgent != "" {
reqArgs["agent_name"] = k8sListAgent
}
resp, err := adminRequest("k8s.list", reqArgs)
if err != nil {
return err
}
rows := toMapSlice(resp["data"])
if len(rows) == 0 {
fmt.Println("No K8s handlers found.")
return nil
}
printTable([]string{"ID", "AGENT", "IMAGE", "EVENTS", "NAMESPACE", "STATUS", "CREATED_AT"}, toTableRows(rows, map[string]string{
"ID": "id", "AGENT": "agent_name", "IMAGE": "image", "EVENTS": "events",
"NAMESPACE": "namespace", "STATUS": "status", "CREATED_AT": "created_at",
}))
return nil
},
}
k8sListCmd.Flags().StringVar(&k8sListAgent, "agent", "", "Filter by agent name")
var k8sDeleteID int64
k8sDeleteCmd := &cobra.Command{
Use: "delete",
Short: "Delete a K8s job handler",
RunE: func(cmd *cobra.Command, args []string) error {
resp, err := adminRequest("k8s.delete", map[string]interface{}{
"id": k8sDeleteID,
})
if err != nil {
return err
}
printJSON(resp["data"])
return nil
},
}
k8sDeleteCmd.Flags().Int64Var(&k8sDeleteID, "id", 0, "Handler ID to delete")
k8sDeleteCmd.MarkFlagRequired("id")
k8sCmd.AddCommand(k8sRegisterCmd, k8sListCmd, k8sDeleteCmd)
// ----- attachments commands -----
attachmentsCmd := &cobra.Command{
Use: "attachments",
Short: "Manage attachments",
}
attachmentsGCCmd := &cobra.Command{
Use: "gc",
Short: "Run attachment garbage collection to remove orphaned files",
RunE: func(cmd *cobra.Command, args []string) error {
resp, err := adminRequest("attachments.gc", nil)
if err != nil {
return err
}
printJSON(resp["data"])
return nil
},
}
attachmentsCmd.AddCommand(attachmentsGCCmd)
// ----- add persistent flag and commands to root -----
rootCmd.PersistentFlags().StringVar(&adminSocket, "socket", "/data/synapbus.sock", "Path to admin Unix socket")
rootCmd.AddCommand(userCmd, agentCmd, auditCmd, backupCmd, messagesCmd, channelsCmd, conversationsCmd, embeddingsCmd, dbCmd, retentionCmd, webhookCmd, k8sCmd, attachmentsCmd)
}
// toTableRows remaps []map[string]string using a header->key mapping.
+289
View File
@@ -0,0 +1,289 @@
package main
import (
"testing"
"github.com/spf13/cobra"
)
// findSubcommand finds a subcommand by name in a cobra.Command tree.
func findSubcommand(root *cobra.Command, names ...string) *cobra.Command {
cmd := root
for _, name := range names {
found := false
for _, sub := range cmd.Commands() {
if sub.Name() == name {
cmd = sub
found = true
break
}
}
if !found {
return nil
}
}
return cmd
}
// buildTestRoot creates a root command with all admin commands registered.
func buildTestRoot() *cobra.Command {
root := &cobra.Command{Use: "synapbus"}
addAdminCommands(root)
return root
}
func TestWebhookCommandsRegistered(t *testing.T) {
root := buildTestRoot()
tests := []struct {
path []string
}{
{[]string{"webhook"}},
{[]string{"webhook", "register"}},
{[]string{"webhook", "list"}},
{[]string{"webhook", "delete"}},
}
for _, tt := range tests {
cmd := findSubcommand(root, tt.path...)
if cmd == nil {
t.Errorf("command %v not found", tt.path)
}
}
}
func TestK8sCommandsRegistered(t *testing.T) {
root := buildTestRoot()
tests := []struct {
path []string
}{
{[]string{"k8s"}},
{[]string{"k8s", "register"}},
{[]string{"k8s", "list"}},
{[]string{"k8s", "delete"}},
}
for _, tt := range tests {
cmd := findSubcommand(root, tt.path...)
if cmd == nil {
t.Errorf("command %v not found", tt.path)
}
}
}
func TestAttachmentsCommandsRegistered(t *testing.T) {
root := buildTestRoot()
tests := []struct {
path []string
}{
{[]string{"attachments"}},
{[]string{"attachments", "gc"}},
}
for _, tt := range tests {
cmd := findSubcommand(root, tt.path...)
if cmd == nil {
t.Errorf("command %v not found", tt.path)
}
}
}
func TestWebhookRegisterRequiredFlags(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "webhook", "register")
if cmd == nil {
t.Fatal("webhook register command not found")
}
requiredFlags := []string{"url", "events", "secret", "agent"}
for _, flag := range requiredFlags {
f := cmd.Flag(flag)
if f == nil {
t.Errorf("flag --%s not found on webhook register", flag)
continue
}
ann := f.Annotations
if ann == nil {
t.Errorf("flag --%s should be required", flag)
continue
}
if _, ok := ann[cobra.BashCompOneRequiredFlag]; !ok {
t.Errorf("flag --%s should be required", flag)
}
}
}
func TestWebhookDeleteRequiredFlags(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "webhook", "delete")
if cmd == nil {
t.Fatal("webhook delete command not found")
}
f := cmd.Flag("id")
if f == nil {
t.Fatal("flag --id not found on webhook delete")
}
ann := f.Annotations
if ann == nil {
t.Fatal("flag --id should be required")
}
if _, ok := ann[cobra.BashCompOneRequiredFlag]; !ok {
t.Fatal("flag --id should be required")
}
}
func TestK8sRegisterRequiredFlags(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "k8s", "register")
if cmd == nil {
t.Fatal("k8s register command not found")
}
requiredFlags := []string{"image", "events", "agent"}
for _, flag := range requiredFlags {
f := cmd.Flag(flag)
if f == nil {
t.Errorf("flag --%s not found on k8s register", flag)
continue
}
ann := f.Annotations
if ann == nil {
t.Errorf("flag --%s should be required", flag)
continue
}
if _, ok := ann[cobra.BashCompOneRequiredFlag]; !ok {
t.Errorf("flag --%s should be required", flag)
}
}
}
func TestK8sDeleteRequiredFlags(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "k8s", "delete")
if cmd == nil {
t.Fatal("k8s delete command not found")
}
f := cmd.Flag("id")
if f == nil {
t.Fatal("flag --id not found on k8s delete")
}
ann := f.Annotations
if ann == nil {
t.Fatal("flag --id should be required")
}
if _, ok := ann[cobra.BashCompOneRequiredFlag]; !ok {
t.Fatal("flag --id should be required")
}
}
func TestK8sRegisterOptionalFlags(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "k8s", "register")
if cmd == nil {
t.Fatal("k8s register command not found")
}
optionalFlags := []string{"namespace", "memory", "cpu", "env", "timeout"}
for _, flag := range optionalFlags {
f := cmd.Flag(flag)
if f == nil {
t.Errorf("optional flag --%s not found on k8s register", flag)
}
}
}
func TestChannelsCreateCommandRegistered(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "channels", "create")
if cmd == nil {
t.Fatal("channels create command not found")
}
}
func TestChannelsCreateRequiredFlags(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "channels", "create")
if cmd == nil {
t.Fatal("channels create command not found")
}
// --name is required
f := cmd.Flag("name")
if f == nil {
t.Fatal("flag --name not found on channels create")
}
ann := f.Annotations
if ann == nil {
t.Fatal("flag --name should be required")
}
if _, ok := ann[cobra.BashCompOneRequiredFlag]; !ok {
t.Fatal("flag --name should be required")
}
// --description is optional
df := cmd.Flag("description")
if df == nil {
t.Fatal("flag --description not found on channels create")
}
}
func TestChannelsJoinCommandRegistered(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "channels", "join")
if cmd == nil {
t.Fatal("channels join command not found")
}
}
func TestChannelsJoinRequiredFlags(t *testing.T) {
root := buildTestRoot()
cmd := findSubcommand(root, "channels", "join")
if cmd == nil {
t.Fatal("channels join command not found")
}
requiredFlags := []string{"channel", "agent"}
for _, flag := range requiredFlags {
f := cmd.Flag(flag)
if f == nil {
t.Errorf("flag --%s not found on channels join", flag)
continue
}
ann := f.Annotations
if ann == nil {
t.Errorf("flag --%s should be required", flag)
continue
}
if _, ok := ann[cobra.BashCompOneRequiredFlag]; !ok {
t.Errorf("flag --%s should be required", flag)
}
}
}
func TestDefaultSocketPath(t *testing.T) {
root := buildTestRoot()
f := root.PersistentFlags().Lookup("socket")
if f == nil {
t.Fatal("--socket persistent flag not found")
}
if f.DefValue != "/data/synapbus.sock" {
t.Errorf("default socket path = %q, want %q", f.DefValue, "/data/synapbus.sock")
}
}
func TestExistingCommandsStillPresent(t *testing.T) {
root := buildTestRoot()
// Verify existing commands are not broken by our additions.
existingCmds := []string{"user", "agent", "audit", "backup", "messages", "channels", "conversations", "embeddings", "db", "retention"}
for _, name := range existingCmds {
cmd := findSubcommand(root, name)
if cmd == nil {
t.Errorf("existing command %q not found after adding new commands", name)
}
}
}
+14 -3
View File
@@ -23,6 +23,7 @@ import (
"github.com/prometheus/client_golang/prometheus/promhttp"
"github.com/spf13/cobra"
"github.com/synapbus/synapbus/internal/actions"
"github.com/synapbus/synapbus/internal/admin"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/api"
@@ -33,6 +34,7 @@ import (
"github.com/synapbus/synapbus/internal/console"
"github.com/synapbus/synapbus/internal/dispatcher"
"github.com/synapbus/synapbus/internal/health"
"github.com/synapbus/synapbus/internal/jsruntime"
k8spkg "github.com/synapbus/synapbus/internal/k8s"
mcpserver "github.com/synapbus/synapbus/internal/mcp"
"github.com/synapbus/synapbus/internal/messaging"
@@ -423,7 +425,7 @@ func runServe(cmd *cobra.Command, args []string) error {
// Create K8s job runner and service
k8sRunner := k8spkg.NewJobRunner(slog.Default())
k8sStore := k8spkg.NewSQLiteK8sStore(db.DB)
k8sService := k8spkg.NewK8sService(k8sStore, k8sRunner)
k8sService := k8spkg.NewK8sService(k8sStore, k8sRunner) // K8s service for CLI admin commands; not passed to MCP
k8sDispatcher := k8spkg.NewK8sDispatcher(k8sStore, k8sRunner, slog.Default())
if k8sRunner.IsAvailable() {
@@ -436,8 +438,15 @@ func runServe(cmd *cobra.Command, args []string) error {
eventDispatcher := dispatcher.NewMultiDispatcher(slog.Default(), deliveryEngine, k8sDispatcher)
msgService.SetDispatcher(eventDispatcher)
// Create MCP server (with swarm + attachment + search + webhook + K8s tools)
mcpSrv := mcpserver.NewMCPServer(msgService, agentService, channelService, swarmService, attachmentService, searchService, con, webhookService, k8sService, db.DB)
// Create JS runtime pool and action registry for hybrid MCP tools
jsPool := jsruntime.NewPool(10)
defer jsPool.Close()
actionRegistry := actions.NewRegistry()
actionIndex := actions.NewIndex(actionRegistry.List())
// Create MCP server (4 hybrid tools: my_status, send_message, search, execute)
mcpSrv := mcpserver.NewMCPServer(msgService, agentService, channelService, swarmService, attachmentService, searchService, con, jsPool, actionRegistry, actionIndex, db.DB)
startTime := time.Now()
// Start task expiry worker
@@ -564,6 +573,8 @@ func runServe(cmd *cobra.Command, args []string) error {
if retentionWorker != nil {
adminSvcs.RetentionWorker = retentionWorker
}
adminSvcs.WebhookService = webhookService
adminSvcs.K8sService = k8sService
adminServer := admin.NewServer(adminSocketPath, db.DB, adminSvcs, logger)
if err := adminServer.Start(); err != nil {
return fmt.Errorf("start admin socket: %w", err)
@@ -39,6 +39,10 @@ spec:
- name: {{ $key }}
value: {{ $value | quote }}
{{- end }}
{{- with .Values.envFrom }}
envFrom:
{{- toYaml . | nindent 12 }}
{{- end }}
livenessProbe:
httpGet:
path: /healthz
@@ -11,5 +11,8 @@ spec:
targetPort: http
protocol: TCP
name: http
{{- if and (eq .Values.service.type "NodePort") .Values.service.nodePort }}
nodePort: {{ .Values.service.nodePort }}
{{- end }}
selector:
{{- include "synapbus.selectorLabels" . | nindent 4 }}
+5
View File
@@ -30,8 +30,11 @@ require (
github.com/cristalhq/jwt/v4 v4.0.2 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/dgraph-io/ristretto v1.0.0 // indirect
github.com/dlclark/regexp2 v1.11.4 // indirect
github.com/dop251/goja v0.0.0-20260311135729-065cd970411c // indirect
github.com/dustin/go-humanize v1.0.1 // indirect
github.com/emicklei/go-restful/v3 v3.12.2 // indirect
github.com/evanw/esbuild v0.27.4 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fsnotify/fsnotify v1.6.0 // indirect
github.com/fxamacker/cbor/v2 v2.9.0 // indirect
@@ -41,10 +44,12 @@ require (
github.com/go-openapi/jsonpointer v0.21.0 // indirect
github.com/go-openapi/jsonreference v0.20.2 // indirect
github.com/go-openapi/swag v0.23.0 // indirect
github.com/go-sourcemap/sourcemap v2.1.3+incompatible // indirect
github.com/gobuffalo/pop/v6 v6.1.1 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/mock v1.6.0 // indirect
github.com/google/gnostic-models v0.7.0 // indirect
github.com/google/pprof v0.0.0-20250403155104-27863c87afa6 // indirect
github.com/google/renameio v1.0.1 // indirect
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.18.1 // indirect
+8
View File
@@ -82,6 +82,10 @@ github.com/dgraph-io/ristretto v1.0.0 h1:SYG07bONKMlFDUYu5pEu3DGAh8c2OFNzKm6G9J4
github.com/dgraph-io/ristretto v1.0.0/go.mod h1:jTi2FiYEhQ1NsMmA7DeBykizjOuY88NhKBkepyu1jPc=
github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13 h1:fAjc9m62+UWV/WAFKLNi6ZS0675eEUC9y3AlwSbQu1Y=
github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13/go.mod h1:SqUrOPUnsFjfmXRMNPybcSiG0BgUW2AuFH8PAnS2iTw=
github.com/dlclark/regexp2 v1.11.4 h1:rPYF9/LECdNymJufQKmri9gV604RvvABwgOA8un7yAo=
github.com/dlclark/regexp2 v1.11.4/go.mod h1:DHkYz0B9wPfa6wondMfaivmHpzrQ3v9q8cnmRbL6yW8=
github.com/dop251/goja v0.0.0-20260311135729-065cd970411c h1:OcLmPfx1T1RmZVHHFwWMPaZDdRf0DBMZOFMVWJa7Pdk=
github.com/dop251/goja v0.0.0-20260311135729-065cd970411c/go.mod h1:MxLav0peU43GgvwVgNbLAj1s/bSGboKkhuULvq/7hx4=
github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkpeCY=
github.com/dustin/go-humanize v1.0.1/go.mod h1:Mu1zIs6XwVuF/gI1OepvI0qD18qycQx+mFykh5fBlto=
github.com/emicklei/go-restful/v3 v3.12.2 h1:DhwDP0vY3k8ZzE0RunuJy8GhNpPL6zqLkDf9B/a0/xU=
@@ -92,6 +96,8 @@ github.com/envoyproxy/go-control-plane v0.9.4/go.mod h1:6rpuAdCZL397s3pYoYcLgu1m
github.com/envoyproxy/go-control-plane v0.9.7/go.mod h1:cwu0lG7PUMfa9snN8LXBig5ynNVH9qI8YYLbd1fK2po=
github.com/envoyproxy/go-control-plane v0.9.9-0.20201210154907-fd9021fe5dad/go.mod h1:cXg6YxExXjJnVBQHBLXeUAgxn2UodCpnH306RInaBQk=
github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7+kN2VEUnK/pcBlmesArF7c=
github.com/evanw/esbuild v0.27.4 h1:8opEixKkH9EDsdjxC/aPmpk1KPwQOcyknDo5m5xIFxI=
github.com/evanw/esbuild v0.27.4/go.mod h1:D2vIQZqV/vIf/VRHtViaUtViZmG7o+kKmlBfVQuRi48=
github.com/fatih/color v1.13.0/go.mod h1:kLAiJbzzSOZDVNGyDpeOxJ47H46qBXwg5ILebYFFOfk=
github.com/fatih/color v1.16.0 h1:zmkK9Ngbjj+K0yRhTVONQh1p/HknKYSlNT+vZCzyokM=
github.com/fatih/color v1.16.0/go.mod h1:fL2Sau1YI5c0pdGEVCbKQbLXB6edEj1ZgiY4NijnWvE=
@@ -126,6 +132,8 @@ github.com/go-openapi/jsonreference v0.20.2/go.mod h1:Bl1zwGIM8/wsvqjsOQLJ/SH+En
github.com/go-openapi/swag v0.22.3/go.mod h1:UzaqsxGiab7freDnrUUra0MwWfN/q7tE4j+VcZ0yl14=
github.com/go-openapi/swag v0.23.0 h1:vsEVJDUo2hPJ2tu0/Xc+4noaxyEffXNIs3cOULZ+GrE=
github.com/go-openapi/swag v0.23.0/go.mod h1:esZ8ITTYEsH1V2trKHjAN8Ai7xHb8RV+YSZ577vPjgQ=
github.com/go-sourcemap/sourcemap v2.1.3+incompatible h1:W1iEw64niKVGogNgBN3ePyLFfuisuzeidWPMPWmECqU=
github.com/go-sourcemap/sourcemap v2.1.3+incompatible/go.mod h1:F8jJfvm2KbVjc5NqelyYJmf/v5J0dwNLS2mL4sNA1Jg=
github.com/go-sql-driver/mysql v1.6.0/go.mod h1:DCzpHaOWr8IXmIStZouvnhqoel9Qv2LBy8hT2VhHyBg=
github.com/go-sql-driver/mysql v1.7.0/go.mod h1:OXbVy3sEdcQ2Doequ6Z5BW6fXNQTmx+9S1MCJN5yJMI=
github.com/go-stack/stack v1.8.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
+169
View File
@@ -0,0 +1,169 @@
package actions
import (
"math"
"sort"
"strings"
)
// SearchResult pairs an action with a relevance score.
type SearchResult struct {
Action Action `json:"action"`
Score float64 `json:"score"`
}
// Index provides BM25 search over the action catalog.
type Index struct {
actions []Action
// Pre-computed document tokens (name + category + description + param names).
docs [][]string
// IDF values per term across all documents.
idf map[string]float64
// Average document length.
avgDL float64
}
// NewIndex builds a BM25 index from the provided actions.
func NewIndex(actions []Action) *Index {
idx := &Index{
actions: actions,
docs: make([][]string, len(actions)),
idf: make(map[string]float64),
}
// Tokenize each action into a bag of words.
df := make(map[string]int) // document frequency per term
totalLen := 0
for i, a := range actions {
tokens := tokenize(a)
idx.docs[i] = tokens
totalLen += len(tokens)
// Count unique terms in this document.
seen := make(map[string]bool)
for _, t := range tokens {
if !seen[t] {
df[t]++
seen[t] = true
}
}
}
n := float64(len(actions))
if n > 0 {
idx.avgDL = float64(totalLen) / n
}
// Compute IDF for each term.
for term, freq := range df {
idx.idf[term] = math.Log(1 + (n-float64(freq)+0.5)/(float64(freq)+0.5))
}
return idx
}
// Search returns actions matching the query, sorted by relevance score.
// If query is empty, returns all actions with score 0 (browse mode).
func (idx *Index) Search(query string, limit int) []SearchResult {
if limit <= 0 {
limit = 5
}
if limit > 20 {
limit = 20
}
// Browse mode: return all actions.
if strings.TrimSpace(query) == "" {
results := make([]SearchResult, len(idx.actions))
for i, a := range idx.actions {
results[i] = SearchResult{Action: a, Score: 0}
}
if len(results) > limit {
results = results[:limit]
}
return results
}
queryTerms := strings.Fields(strings.ToLower(query))
// BM25 parameters.
const k1 = 1.2
const b = 0.75
type scored struct {
idx int
score float64
}
var scored_docs []scored
for i, docTokens := range idx.docs {
score := 0.0
dl := float64(len(docTokens))
tf := termFrequency(docTokens)
for _, qt := range queryTerms {
idfVal := idx.idf[qt]
freq := float64(tf[qt])
if freq == 0 {
continue
}
numerator := freq * (k1 + 1)
denominator := freq + k1*(1-b+b*dl/idx.avgDL)
score += idfVal * numerator / denominator
}
if score > 0 {
scored_docs = append(scored_docs, scored{idx: i, score: score})
}
}
sort.Slice(scored_docs, func(i, j int) bool {
return scored_docs[i].score > scored_docs[j].score
})
if len(scored_docs) > limit {
scored_docs = scored_docs[:limit]
}
results := make([]SearchResult, len(scored_docs))
for i, sd := range scored_docs {
results[i] = SearchResult{
Action: idx.actions[sd.idx],
Score: sd.score,
}
}
return results
}
// tokenize extracts searchable tokens from an action.
func tokenize(a Action) []string {
var parts []string
parts = append(parts, strings.Fields(strings.ToLower(a.Name))...)
parts = append(parts, strings.Fields(strings.ToLower(a.Category))...)
parts = append(parts, strings.Fields(strings.ToLower(a.Description))...)
for _, p := range a.Params {
parts = append(parts, strings.Fields(strings.ToLower(p.Name))...)
parts = append(parts, strings.Fields(strings.ToLower(p.Description))...)
}
// Split compound names (e.g. "read_inbox" -> "read", "inbox").
var expanded []string
for _, p := range parts {
expanded = append(expanded, p)
if strings.Contains(p, "_") {
expanded = append(expanded, strings.Split(p, "_")...)
}
if strings.Contains(p, "-") {
expanded = append(expanded, strings.Split(p, "-")...)
}
}
return expanded
}
// termFrequency counts occurrences of each term in a token list.
func termFrequency(tokens []string) map[string]int {
tf := make(map[string]int)
for _, t := range tokens {
tf[t]++
}
return tf
}
+122
View File
@@ -0,0 +1,122 @@
package actions
import (
"testing"
)
func TestRegistry_List(t *testing.T) {
reg := NewRegistry()
actions := reg.List()
if len(actions) == 0 {
t.Fatal("expected actions to be registered")
}
// Check that core actions exist
expectedNames := []string{
"read_inbox", "claim_messages", "mark_done", "search_messages",
"discover_agents", "create_channel", "join_channel", "list_channels",
"send_channel_message", "post_task", "upload_attachment",
}
nameSet := make(map[string]bool)
for _, a := range actions {
nameSet[a.Name] = true
}
for _, name := range expectedNames {
if !nameSet[name] {
t.Errorf("expected action %q in registry", name)
}
}
}
func TestRegistry_Get(t *testing.T) {
reg := NewRegistry()
t.Run("existing action", func(t *testing.T) {
a, ok := reg.Get("read_inbox")
if !ok {
t.Fatal("expected to find read_inbox")
}
if a.Category != "messaging" {
t.Errorf("category = %q, want messaging", a.Category)
}
})
t.Run("missing action", func(t *testing.T) {
_, ok := reg.Get("nonexistent")
if ok {
t.Error("expected not found for nonexistent action")
}
})
}
func TestIndex_Search(t *testing.T) {
reg := NewRegistry()
idx := NewIndex(reg.List())
t.Run("messaging query", func(t *testing.T) {
results := idx.Search("read inbox messages", 5)
if len(results) == 0 {
t.Fatal("expected results for 'read inbox messages'")
}
// read_inbox should be the top result
if results[0].Action.Name != "read_inbox" {
t.Errorf("top result = %q, want read_inbox", results[0].Action.Name)
}
if results[0].Score <= 0 {
t.Error("expected positive relevance score")
}
})
t.Run("channel query", func(t *testing.T) {
results := idx.Search("create channel", 5)
if len(results) == 0 {
t.Fatal("expected results for 'create channel'")
}
foundCreateChannel := false
for _, r := range results {
if r.Action.Name == "create_channel" {
foundCreateChannel = true
break
}
}
if !foundCreateChannel {
t.Error("expected create_channel in results")
}
})
t.Run("swarm query", func(t *testing.T) {
results := idx.Search("task auction bid", 5)
if len(results) == 0 {
t.Fatal("expected results for 'task auction bid'")
}
})
t.Run("empty query returns all", func(t *testing.T) {
results := idx.Search("", 20)
if len(results) == 0 {
t.Fatal("expected results for empty query")
}
// Should return all registered actions (up to limit)
totalActions := len(reg.List())
if len(results) > 20 {
t.Errorf("returned %d results but limit is 20", len(results))
}
if totalActions <= 20 && len(results) != totalActions {
t.Errorf("expected %d results in browse mode, got %d", totalActions, len(results))
}
})
t.Run("limit enforced", func(t *testing.T) {
results := idx.Search("message", 2)
if len(results) > 2 {
t.Errorf("expected at most 2 results, got %d", len(results))
}
})
t.Run("max limit capped at 20", func(t *testing.T) {
results := idx.Search("", 100)
if len(results) > 20 {
t.Errorf("expected at most 20 results, got %d", len(results))
}
})
}
+458
View File
@@ -0,0 +1,458 @@
package actions
// Registry holds all action definitions and supports lookup.
type Registry struct {
actions map[string]Action
ordered []Action // maintains insertion order
}
// NewRegistry creates a registry pre-populated with all 23 agent-callable actions.
func NewRegistry() *Registry {
r := &Registry{
actions: make(map[string]Action, 23),
}
for _, a := range allActions() {
r.actions[a.Name] = a
r.ordered = append(r.ordered, a)
}
return r
}
// Get returns an action by name.
func (r *Registry) Get(name string) (Action, bool) {
a, ok := r.actions[name]
return a, ok
}
// List returns all registered actions.
func (r *Registry) List() []Action {
out := make([]Action, len(r.ordered))
copy(out, r.ordered)
return out
}
// ListByCategory returns actions in the given category.
func (r *Registry) ListByCategory(category string) []Action {
var out []Action
for _, a := range r.ordered {
if a.Category == category {
out = append(out, a)
}
}
return out
}
// allActions returns the canonical list of all 23 agent-callable actions.
func allActions() []Action {
return []Action{
// ── Messaging (7 actions) ──────────────────────────────────────
{
Name: "my_status",
Category: "messaging",
Description: "Get your complete status overview — identity, pending messages, channel mentions, system notifications, and statistics. Call this first when connecting to SynapBus.",
Params: []Param{},
Returns: "JSON with agent identity, direct_messages, mentions, system_notifications, channels, and stats",
Examples: []Example{
{
Description: "Check your full status on connect",
Code: `call("my_status", {})`,
},
},
},
{
Name: "send_message",
Category: "messaging",
Description: "Send a direct message to another agent. Use discover_agents first to find available agents you can communicate with. For channel messages, use send_channel_message instead.",
Params: []Param{
{Name: "to", Type: "string", Description: "Name of the recipient agent (required for DMs, omit for channel messages)"},
{Name: "body", Type: "string", Description: "Message body text", Required: true},
{Name: "subject", Type: "string", Description: "Conversation subject (optional)"},
{Name: "priority", Type: "number", Description: "Message priority (1-10, default 5)", Default: "5"},
{Name: "metadata", Type: "string", Description: "JSON metadata object (optional)"},
{Name: "channel_id", Type: "number", Description: "Channel ID for channel messages (optional)"},
{Name: "reply_to", Type: "number", Description: "ID of the message to reply to (optional, for threading)"},
},
Returns: "JSON with message_id, conversation_id, and status",
Examples: []Example{
{
Description: "Send a direct message to another agent",
Code: `call("send_message", {"to": "data-processor", "body": "Please analyze the Q4 sales data", "subject": "Q4 Analysis", "priority": 7})`,
},
},
},
{
Name: "read_inbox",
Category: "messaging",
Description: "Check your message inbox for pending messages. Call this first when connecting to see if other agents have sent you messages. Returns unread/pending direct messages addressed to you.",
Params: []Param{
{Name: "limit", Type: "number", Description: "Maximum number of messages to return (default 50)", Default: "50"},
{Name: "status_filter", Type: "string", Description: "Filter by message status: pending, processing, done, failed"},
{Name: "include_read", Type: "boolean", Description: "Include previously read messages (default false)", Default: "false"},
{Name: "min_priority", Type: "number", Description: "Minimum priority filter (1-10)"},
{Name: "from_agent", Type: "string", Description: "Filter by sender agent name"},
},
Returns: "JSON with messages array and count",
Examples: []Example{
{
Description: "Check for new messages",
Code: `call("read_inbox", {})`,
},
{
Description: "Read high-priority messages from a specific agent",
Code: `call("read_inbox", {"min_priority": 8, "from_agent": "coordinator"})`,
},
},
},
{
Name: "claim_messages",
Category: "messaging",
Description: "Atomically claim pending messages for processing",
Params: []Param{
{Name: "limit", Type: "number", Description: "Maximum number of messages to claim (default 10)", Default: "10"},
},
Returns: "JSON with claimed messages array and count",
Examples: []Example{
{
Description: "Claim up to 5 messages for processing",
Code: `call("claim_messages", {"limit": 5})`,
},
},
},
{
Name: "mark_done",
Category: "messaging",
Description: "Mark a claimed message as done or failed",
Params: []Param{
{Name: "message_id", Type: "number", Description: "ID of the message to mark", Required: true},
{Name: "status", Type: "string", Description: "New status: 'done' or 'failed' (default 'done')", Default: "done"},
{Name: "reason", Type: "string", Description: "Failure reason (only for status='failed')"},
},
Returns: "JSON with message_id and status",
Examples: []Example{
{
Description: "Mark a message as successfully processed",
Code: `call("mark_done", {"message_id": 42})`,
},
{
Description: "Mark a message as failed with reason",
Code: `call("mark_done", {"message_id": 42, "status": "failed", "reason": "invalid data format"})`,
},
},
},
{
Name: "search_messages",
Category: "messaging",
Description: "Search for messages across your inbox and channels you are a member of. Supports full-text and semantic search (if configured). Use with an empty query to browse recent messages, or provide a natural-language query to find relevant conversations.",
Params: []Param{
{Name: "query", Type: "string", Description: "Search query string — supports natural language for semantic search"},
{Name: "limit", Type: "number", Description: "Maximum results to return (default 10, max 100)", Default: "10"},
{Name: "min_priority", Type: "number", Description: "Minimum priority filter (1-10)"},
{Name: "from_agent", Type: "string", Description: "Filter by sender agent name"},
{Name: "status", Type: "string", Description: "Filter by message status"},
{Name: "search_mode", Type: "string", Description: "Search mode: 'auto' (default), 'semantic', or 'fulltext'", Default: "auto"},
{Name: "semantic", Type: "boolean", Description: "Force semantic search (shorthand for search_mode='semantic')"},
},
Returns: "JSON with results array, count, and search_mode used",
Examples: []Example{
{
Description: "Search for messages about deployment",
Code: `call("search_messages", {"query": "deployment status update", "limit": 5})`,
},
},
},
{
Name: "discover_agents",
Category: "messaging",
Description: "Discover other agents on the bus. Call this to find agents you can communicate with. Optionally filter by capability keywords, or omit the query to list all registered agents.",
Params: []Param{
{Name: "query", Type: "string", Description: "Capability keyword to search for"},
},
Returns: "JSON with agents array (name, display_name, type, capabilities, status) and count",
Examples: []Example{
{
Description: "List all available agents",
Code: `call("discover_agents", {})`,
},
{
Description: "Find agents with data analysis capabilities",
Code: `call("discover_agents", {"query": "data analysis"})`,
},
},
},
// ── Channels (9 actions) ──────────────────────────────────────
{
Name: "create_channel",
Category: "channels",
Description: "Create a new channel for group communication",
Params: []Param{
{Name: "name", Type: "string", Description: "Unique channel name (alphanumeric, hyphens, underscores, max 64 chars)", Required: true},
{Name: "description", Type: "string", Description: "Channel description"},
{Name: "topic", Type: "string", Description: "Current channel topic"},
{Name: "type", Type: "string", Description: "Channel type: 'standard', 'blackboard', or 'auction' (default 'standard')", Default: "standard"},
{Name: "is_private", Type: "boolean", Description: "Whether the channel is private (invite-only). Default false", Default: "false"},
},
Returns: "JSON with channel_id, name, description, topic, type, is_private, created_by",
Examples: []Example{
{
Description: "Create a public channel for project discussion",
Code: `call("create_channel", {"name": "project-alpha", "description": "Discussion for Project Alpha", "topic": "Sprint planning"})`,
},
},
},
{
Name: "join_channel",
Category: "channels",
Description: "Join a channel to participate in group conversations. You will receive messages sent to the channel after joining. Use list_channels first to see available channels.",
Params: []Param{
{Name: "channel_id", Type: "number", Description: "ID of the channel to join"},
{Name: "channel_name", Type: "string", Description: "Name of the channel to join (alternative to channel_id)"},
},
Returns: "JSON with channel_id and status 'joined'",
Examples: []Example{
{
Description: "Join a channel by name",
Code: `call("join_channel", {"channel_name": "project-alpha"})`,
},
},
},
{
Name: "leave_channel",
Category: "channels",
Description: "Leave a channel you are a member of",
Params: []Param{
{Name: "channel_id", Type: "number", Description: "ID of the channel to leave"},
{Name: "channel_name", Type: "string", Description: "Name of the channel to leave (alternative to channel_id)"},
},
Returns: "JSON with channel_id and status 'left'",
Examples: []Example{
{
Description: "Leave a channel by name",
Code: `call("leave_channel", {"channel_name": "project-alpha"})`,
},
},
},
{
Name: "list_channels",
Category: "channels",
Description: "List all channels visible to you. Call this when connecting to see available channels and join conversations. Shows all public channels plus private channels you are a member of or have been invited to.",
Params: []Param{},
Returns: "JSON with channels array (id, name, description, topic, type, is_private, created_by, member_count) and count",
Examples: []Example{
{
Description: "List all available channels",
Code: `call("list_channels", {})`,
},
},
},
{
Name: "invite_to_channel",
Category: "channels",
Description: "Invite an agent to a channel (only the channel owner can invite to private channels)",
Params: []Param{
{Name: "channel_id", Type: "number", Description: "ID of the channel"},
{Name: "channel_name", Type: "string", Description: "Name of the channel (alternative to channel_id)"},
{Name: "agent_name", Type: "string", Description: "Name of the agent to invite", Required: true},
},
Returns: "JSON with channel_id, agent_name, and status 'invited'",
Examples: []Example{
{
Description: "Invite an agent to a private channel",
Code: `call("invite_to_channel", {"channel_name": "secret-ops", "agent_name": "data-processor"})`,
},
},
},
{
Name: "kick_from_channel",
Category: "channels",
Description: "Remove an agent from a channel (only the channel owner can kick)",
Params: []Param{
{Name: "channel_id", Type: "number", Description: "ID of the channel"},
{Name: "channel_name", Type: "string", Description: "Name of the channel (alternative to channel_id)"},
{Name: "agent_name", Type: "string", Description: "Name of the agent to kick", Required: true},
},
Returns: "JSON with channel_id, agent_name, and status 'kicked'",
Examples: []Example{
{
Description: "Remove an agent from a channel",
Code: `call("kick_from_channel", {"channel_name": "project-alpha", "agent_name": "spambot"})`,
},
},
},
{
Name: "get_channel_messages",
Category: "channels",
Description: "Get recent messages from a channel you are a member of",
Params: []Param{
{Name: "channel_id", Type: "number", Description: "ID of the channel"},
{Name: "channel_name", Type: "string", Description: "Name of the channel (alternative to channel_id)"},
{Name: "limit", Type: "number", Description: "Max number of messages to return (default 50, max 200)", Default: "50"},
},
Returns: "JSON with channel_id, messages array, and count",
Examples: []Example{
{
Description: "Get recent messages from a channel",
Code: `call("get_channel_messages", {"channel_name": "project-alpha", "limit": 20})`,
},
},
},
{
Name: "send_channel_message",
Category: "channels",
Description: "Send a message to all members of a channel. Use @agentname in the body to mention specific agents. You must be a member of the channel to send messages.",
Params: []Param{
{Name: "channel_id", Type: "number", Description: "ID of the channel"},
{Name: "channel_name", Type: "string", Description: "Name of the channel (alternative to channel_id)"},
{Name: "body", Type: "string", Description: "Message body text", Required: true},
{Name: "priority", Type: "number", Description: "Message priority (1-10, default 5)", Default: "5"},
{Name: "metadata", Type: "string", Description: "JSON metadata object (optional)"},
},
Returns: "JSON with channel_id, message_id, and status 'sent'",
Examples: []Example{
{
Description: "Send a message to a channel with a mention",
Code: `call("send_channel_message", {"channel_name": "project-alpha", "body": "Hey @coordinator, the build is ready for review"})`,
},
},
},
{
Name: "update_channel",
Category: "channels",
Description: "Update channel topic or description (only the channel owner can update)",
Params: []Param{
{Name: "channel_id", Type: "number", Description: "ID of the channel"},
{Name: "channel_name", Type: "string", Description: "Name of the channel (alternative to channel_id)"},
{Name: "topic", Type: "string", Description: "New channel topic"},
{Name: "description", Type: "string", Description: "New channel description"},
},
Returns: "JSON with channel_id, name, description, and topic",
Examples: []Example{
{
Description: "Update a channel's topic",
Code: `call("update_channel", {"channel_name": "project-alpha", "topic": "v2.0 release planning"})`,
},
},
},
// ── Swarm (5 actions) ─────────────────────────────────────────
{
Name: "post_task",
Category: "swarm",
Description: "Post a task to an auction channel for agents to bid on",
Params: []Param{
{Name: "channel_name", Type: "string", Description: "Name of the auction channel", Required: true},
{Name: "title", Type: "string", Description: "Task title", Required: true},
{Name: "description", Type: "string", Description: "Task description"},
{Name: "requirements", Type: "string", Description: "JSON object of task requirements"},
{Name: "deadline", Type: "string", Description: "Task deadline in ISO 8601 format (e.g. 2026-03-13T15:00:00Z)"},
},
Returns: "JSON with task_id, channel_id, title, status, posted_by, deadline, created_at",
Examples: []Example{
{
Description: "Post a data analysis task to an auction channel",
Code: `call("post_task", {"channel_name": "task-marketplace", "title": "Analyze Q4 revenue", "description": "Run trend analysis on Q4 revenue data", "deadline": "2026-03-20T17:00:00Z"})`,
},
},
},
{
Name: "bid_task",
Category: "swarm",
Description: "Submit a bid on an open task in an auction channel",
Params: []Param{
{Name: "task_id", Type: "number", Description: "ID of the task to bid on", Required: true},
{Name: "capabilities", Type: "string", Description: "JSON object describing your relevant capabilities"},
{Name: "time_estimate", Type: "string", Description: "Estimated time to complete the task"},
{Name: "message", Type: "string", Description: "Message to the task poster explaining your bid"},
},
Returns: "JSON with bid_id, task_id, agent_name, time_estimate, status",
Examples: []Example{
{
Description: "Bid on a task with capabilities and time estimate",
Code: `call("bid_task", {"task_id": 7, "capabilities": "{\"skills\": [\"data-analysis\", \"python\"]}", "time_estimate": "2 hours", "message": "I have experience with revenue trend analysis"})`,
},
},
},
{
Name: "accept_bid",
Category: "swarm",
Description: "Accept a bid on a task you posted, assigning the task to the bidding agent",
Params: []Param{
{Name: "task_id", Type: "number", Description: "ID of the task", Required: true},
{Name: "bid_id", Type: "number", Description: "ID of the bid to accept", Required: true},
},
Returns: "JSON with task_id, bid_id, and status 'accepted'",
Examples: []Example{
{
Description: "Accept a bid on your task",
Code: `call("accept_bid", {"task_id": 7, "bid_id": 3})`,
},
},
},
{
Name: "complete_task",
Category: "swarm",
Description: "Mark a task as completed (only the assigned agent can do this)",
Params: []Param{
{Name: "task_id", Type: "number", Description: "ID of the task to complete", Required: true},
},
Returns: "JSON with task_id and status 'completed'",
Examples: []Example{
{
Description: "Mark an assigned task as completed",
Code: `call("complete_task", {"task_id": 7})`,
},
},
},
{
Name: "list_tasks",
Category: "swarm",
Description: "List tasks in an auction channel, optionally filtered by status",
Params: []Param{
{Name: "channel_name", Type: "string", Description: "Name of the auction channel", Required: true},
{Name: "status", Type: "string", Description: "Filter by task status: open, assigned, completed, cancelled"},
},
Returns: "JSON with tasks array (id, title, description, status, posted_by, assigned_to, deadline, created_at) and count",
Examples: []Example{
{
Description: "List open tasks in an auction channel",
Code: `call("list_tasks", {"channel_name": "task-marketplace", "status": "open"})`,
},
},
},
// ── Attachments (2 actions) ───────────────────────────────────
{
Name: "upload_attachment",
Category: "attachments",
Description: "Upload a file attachment. Content must be base64-encoded. Returns the SHA-256 hash for later retrieval. Max file size: 50MB.",
Params: []Param{
{Name: "content", Type: "string", Description: "Base64-encoded file content", Required: true},
{Name: "filename", Type: "string", Description: "Original filename (optional, used for MIME detection and display)"},
{Name: "mime_type", Type: "string", Description: "MIME type override (optional, auto-detected from content if not provided)"},
{Name: "message_id", Type: "number", Description: "Message ID to attach the file to (optional, can be linked later)"},
},
Returns: "JSON with hash, size, mime_type, original_filename",
Examples: []Example{
{
Description: "Upload a text file attachment",
Code: `call("upload_attachment", {"content": "SGVsbG8gV29ybGQ=", "filename": "hello.txt", "mime_type": "text/plain"})`,
},
},
},
{
Name: "download_attachment",
Category: "attachments",
Description: "Download an attachment by its SHA-256 hash. Returns base64-encoded content along with filename and MIME type metadata.",
Params: []Param{
{Name: "hash", Type: "string", Description: "SHA-256 hash of the attachment", Required: true},
},
Returns: "JSON with hash, content (base64), original_filename, mime_type, size",
Examples: []Example{
{
Description: "Download an attachment by hash",
Code: `call("download_attachment", {"hash": "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"})`,
},
},
},
}
}
+127
View File
@@ -0,0 +1,127 @@
package actions
import (
"testing"
)
func TestRegistryHas23Actions(t *testing.T) {
r := NewRegistry()
got := len(r.List())
if got != 23 {
t.Errorf("expected 23 actions, got %d", got)
}
}
func TestRegistryCategories(t *testing.T) {
r := NewRegistry()
tests := []struct {
category string
want int
}{
{"messaging", 7},
{"channels", 9},
{"swarm", 5},
{"attachments", 2},
}
for _, tt := range tests {
t.Run(tt.category, func(t *testing.T) {
got := len(r.ListByCategory(tt.category))
if got != tt.want {
t.Errorf("category %q: expected %d actions, got %d", tt.category, tt.want, got)
}
})
}
}
func TestRegistryGetByName(t *testing.T) {
r := NewRegistry()
allNames := []string{
// messaging
"my_status", "send_message", "read_inbox", "claim_messages", "mark_done", "search_messages", "discover_agents",
// channels
"create_channel", "join_channel", "leave_channel", "list_channels",
"invite_to_channel", "kick_from_channel", "get_channel_messages",
"send_channel_message", "update_channel",
// swarm
"post_task", "bid_task", "accept_bid", "complete_task", "list_tasks",
// attachments
"upload_attachment", "download_attachment",
}
for _, name := range allNames {
t.Run(name, func(t *testing.T) {
a, ok := r.Get(name)
if !ok {
t.Fatalf("action %q not found in registry", name)
}
if a.Name != name {
t.Errorf("expected name %q, got %q", name, a.Name)
}
})
}
}
func TestRegistryGetNotFound(t *testing.T) {
r := NewRegistry()
_, ok := r.Get("nonexistent_action")
if ok {
t.Error("expected Get to return false for nonexistent action")
}
}
func TestRegistryActionsHaveExamples(t *testing.T) {
r := NewRegistry()
for _, a := range r.List() {
t.Run(a.Name, func(t *testing.T) {
if len(a.Examples) == 0 {
t.Errorf("action %q has no examples", a.Name)
}
})
}
}
func TestRegistryActionsHaveDescriptions(t *testing.T) {
r := NewRegistry()
for _, a := range r.List() {
t.Run(a.Name, func(t *testing.T) {
if a.Description == "" {
t.Errorf("action %q has empty description", a.Name)
}
})
}
}
func TestRegistryActionsHaveReturns(t *testing.T) {
r := NewRegistry()
for _, a := range r.List() {
t.Run(a.Name, func(t *testing.T) {
if a.Returns == "" {
t.Errorf("action %q has empty Returns field", a.Name)
}
})
}
}
func TestRegistryListByUnknownCategory(t *testing.T) {
r := NewRegistry()
got := r.ListByCategory("nonexistent")
if len(got) != 0 {
t.Errorf("expected 0 actions for unknown category, got %d", len(got))
}
}
func TestRegistryListReturnsCopy(t *testing.T) {
r := NewRegistry()
list1 := r.List()
list2 := r.List()
// Mutating the first list should not affect the second.
if len(list1) > 0 {
list1[0].Name = "mutated"
if list2[0].Name == "mutated" {
t.Error("List() should return a copy, not a reference to internal slice")
}
}
}
+26
View File
@@ -0,0 +1,26 @@
package actions
// Action represents a callable operation in the system.
type Action struct {
Name string `json:"name"`
Category string `json:"category"` // messaging, channels, swarm, attachments
Description string `json:"description"`
Params []Param `json:"params"`
Returns string `json:"returns"` // Human-readable return description
Examples []Example `json:"examples"`
}
// Param describes an action parameter.
type Param struct {
Name string `json:"name"`
Type string `json:"type"` // string, number, boolean
Description string `json:"description"`
Required bool `json:"required"`
Default string `json:"default,omitempty"`
}
// Example shows a usage example for the action.
type Example struct {
Description string `json:"description"`
Code string `json:"code"` // JS code example using call()
}
+19
View File
@@ -2,6 +2,7 @@
package admin
import (
"context"
"database/sql"
"log/slog"
"net"
@@ -10,11 +11,27 @@ import (
"github.com/synapbus/synapbus/internal/attachments"
"github.com/synapbus/synapbus/internal/auth"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/k8s"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/search"
"github.com/synapbus/synapbus/internal/trace"
"github.com/synapbus/synapbus/internal/webhooks"
)
// WebhookServiceProvider defines the webhook operations needed by the admin socket.
type WebhookServiceProvider interface {
RegisterWebhook(ctx context.Context, agentName, url string, events []string, secret string) (*webhooks.Webhook, error)
ListWebhooks(ctx context.Context, agentName string) ([]*webhooks.Webhook, error)
DeleteWebhook(ctx context.Context, agentName string, webhookID int64) error
}
// K8sServiceProvider defines the K8s handler operations needed by the admin socket.
type K8sServiceProvider interface {
RegisterHandler(ctx context.Context, agentName string, req k8s.RegisterHandlerRequest) (*k8s.K8sHandler, error)
ListHandlers(ctx context.Context, agentName string) ([]*k8s.K8sHandler, error)
DeleteHandler(ctx context.Context, agentName string, handlerID int64) error
}
// Services holds references to all services the admin socket can control.
type Services struct {
Users *auth.SQLiteUserStore
@@ -27,6 +44,8 @@ type Services struct {
VectorIndex *search.VectorIndex
SearchService *search.Service
AttachmentService *attachments.Service
WebhookService WebhookServiceProvider
K8sService K8sServiceProvider
DataDir string
RetentionWorker RetentionStatusProvider
}
+461
View File
@@ -13,6 +13,8 @@ import (
"strings"
"time"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/k8s"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/trace"
)
@@ -161,6 +163,10 @@ func (s *AdminServer) dispatch(req Request) Response {
return s.handleChannelsList(ctx)
case "channels.show":
return s.handleChannelsShow(ctx, req.Args)
case "channels.create":
return s.handleChannelsCreate(ctx, req.Args)
case "channels.join":
return s.handleChannelsJoin(ctx, req.Args)
// --- conversations ---
case "conversations.list":
@@ -188,6 +194,26 @@ func (s *AdminServer) dispatch(req Request) Response {
case "retention.status":
return s.handleRetentionStatus(ctx)
// --- webhooks ---
case "webhook.register":
return s.handleWebhookRegister(ctx, req.Args)
case "webhook.list":
return s.handleWebhookList(ctx, req.Args)
case "webhook.delete":
return s.handleWebhookDelete(ctx, req.Args)
// --- k8s ---
case "k8s.register":
return s.handleK8sRegister(ctx, req.Args)
case "k8s.list":
return s.handleK8sList(ctx, req.Args)
case "k8s.delete":
return s.handleK8sDelete(ctx, req.Args)
// --- attachments ---
case "attachments.gc":
return s.handleAttachmentsGC(ctx)
default:
return Response{OK: false, Error: fmt.Sprintf("unknown command: %s", req.Command)}
}
@@ -866,6 +892,78 @@ func (s *AdminServer) handleChannelsShow(ctx context.Context, args json.RawMessa
}}
}
func (s *AdminServer) handleChannelsCreate(ctx context.Context, args json.RawMessage) Response {
var p struct {
Name string `json:"name"`
Description string `json:"description"`
}
if err := json.Unmarshal(args, &p); err != nil {
return Response{OK: false, Error: "invalid args: " + err.Error()}
}
if p.Name == "" {
return Response{OK: false, Error: "name is required"}
}
ch, err := s.services.Channels.CreateChannel(ctx, channels.CreateChannelRequest{
Name: p.Name,
Description: p.Description,
Type: "standard",
CreatedBy: "system",
})
if err != nil {
return Response{OK: false, Error: err.Error()}
}
return Response{OK: true, Data: map[string]interface{}{
"id": ch.ID,
"name": ch.Name,
"description": ch.Description,
"type": ch.Type,
"is_private": ch.IsPrivate,
"created_by": ch.CreatedBy,
"created_at": ch.CreatedAt.Format(time.RFC3339),
}}
}
func (s *AdminServer) handleChannelsJoin(ctx context.Context, args json.RawMessage) Response {
var p struct {
Channel string `json:"channel"`
Agent string `json:"agent"`
}
if err := json.Unmarshal(args, &p); err != nil {
return Response{OK: false, Error: "invalid args: " + err.Error()}
}
if p.Channel == "" {
return Response{OK: false, Error: "channel is required"}
}
if p.Agent == "" {
return Response{OK: false, Error: "agent is required"}
}
ch, err := s.services.Channels.GetChannelByName(ctx, p.Channel)
if err != nil {
return Response{OK: false, Error: fmt.Sprintf("channel not found: %s", p.Channel)}
}
// Check if already a member for status reporting
isMember, _ := s.services.Channels.IsMember(ctx, ch.ID, p.Agent)
if err := s.services.Channels.JoinChannel(ctx, ch.ID, p.Agent); err != nil {
return Response{OK: false, Error: err.Error()}
}
status := "joined"
if isMember {
status = "already_member"
}
return Response{OK: true, Data: map[string]interface{}{
"channel": p.Channel,
"agent": p.Agent,
"status": status,
}}
}
// ---------- conversations handlers ----------
func (s *AdminServer) handleConversationsList(ctx context.Context, args json.RawMessage) Response {
@@ -1139,5 +1237,368 @@ func (s *AdminServer) handleRetentionStatus(ctx context.Context) Response {
}}
}
// ---------- webhook handlers ----------
func (s *AdminServer) handleWebhookRegister(ctx context.Context, args json.RawMessage) Response {
var p struct {
URL string `json:"url"`
Events string `json:"events"`
Secret string `json:"secret"`
AgentName string `json:"agent_name"`
}
if err := json.Unmarshal(args, &p); err != nil {
return Response{OK: false, Error: "invalid args: " + err.Error()}
}
if p.URL == "" || p.Events == "" || p.Secret == "" || p.AgentName == "" {
return Response{OK: false, Error: "url, events, secret, and agent_name are required"}
}
if s.services.WebhookService == nil {
return Response{OK: false, Error: "webhook service not configured"}
}
events := strings.Split(p.Events, ",")
for i := range events {
events[i] = strings.TrimSpace(events[i])
}
wh, err := s.services.WebhookService.RegisterWebhook(ctx, p.AgentName, p.URL, events, p.Secret)
if err != nil {
return Response{OK: false, Error: err.Error()}
}
return Response{OK: true, Data: map[string]interface{}{
"id": wh.ID,
"url": wh.URL,
"events": wh.Events,
"status": wh.Status,
}}
}
func (s *AdminServer) handleWebhookList(ctx context.Context, args json.RawMessage) Response {
var p struct {
AgentName string `json:"agent_name"`
}
if args != nil {
json.Unmarshal(args, &p)
}
if s.services.WebhookService == nil {
return Response{OK: false, Error: "webhook service not configured"}
}
if p.AgentName == "" {
// Admin: list all webhooks by querying DB directly.
rows, err := s.db.QueryContext(ctx,
`SELECT id, agent_name, url, events, status, consecutive_failures, created_at
FROM webhooks ORDER BY created_at DESC`)
if err != nil {
return Response{OK: false, Error: err.Error()}
}
defer rows.Close()
type whRow struct {
ID int64 `json:"id"`
AgentName string `json:"agent_name"`
URL string `json:"url"`
Events []string `json:"events"`
Status string `json:"status"`
ConsecutiveFailures int `json:"consecutive_failures"`
CreatedAt string `json:"created_at"`
}
var result []whRow
for rows.Next() {
var r whRow
var eventsJSON string
var createdAt time.Time
if err := rows.Scan(&r.ID, &r.AgentName, &r.URL, &eventsJSON, &r.Status, &r.ConsecutiveFailures, &createdAt); err != nil {
return Response{OK: false, Error: "scan: " + err.Error()}
}
json.Unmarshal([]byte(eventsJSON), &r.Events)
if r.Events == nil {
r.Events = []string{}
}
r.CreatedAt = createdAt.Format(time.RFC3339)
result = append(result, r)
}
if result == nil {
result = []whRow{}
}
return Response{OK: true, Data: result}
}
webhookList, err := s.services.WebhookService.ListWebhooks(ctx, p.AgentName)
if err != nil {
return Response{OK: false, Error: err.Error()}
}
type whRow struct {
ID int64 `json:"id"`
AgentName string `json:"agent_name"`
URL string `json:"url"`
Events []string `json:"events"`
Status string `json:"status"`
ConsecutiveFailures int `json:"consecutive_failures"`
CreatedAt string `json:"created_at"`
}
result := make([]whRow, len(webhookList))
for i, wh := range webhookList {
result[i] = whRow{
ID: wh.ID,
AgentName: wh.AgentName,
URL: wh.URL,
Events: wh.Events,
Status: wh.Status,
ConsecutiveFailures: wh.ConsecutiveFailures,
CreatedAt: wh.CreatedAt.Format(time.RFC3339),
}
}
return Response{OK: true, Data: result}
}
func (s *AdminServer) handleWebhookDelete(ctx context.Context, args json.RawMessage) Response {
var p struct {
ID int64 `json:"id"`
}
if err := json.Unmarshal(args, &p); err != nil {
return Response{OK: false, Error: "invalid args: " + err.Error()}
}
if p.ID <= 0 {
return Response{OK: false, Error: "id is required"}
}
if s.services.WebhookService == nil {
return Response{OK: false, Error: "webhook service not configured"}
}
// Admin bypass: look up the webhook's agent_name first, then delete.
var agentName string
err := s.db.QueryRowContext(ctx, "SELECT agent_name FROM webhooks WHERE id = ?", p.ID).Scan(&agentName)
if err != nil {
return Response{OK: false, Error: "webhook not found"}
}
if err := s.services.WebhookService.DeleteWebhook(ctx, agentName, p.ID); err != nil {
return Response{OK: false, Error: err.Error()}
}
return Response{OK: true, Data: map[string]interface{}{
"deleted": p.ID,
}}
}
// ---------- k8s handlers ----------
func (s *AdminServer) handleK8sRegister(ctx context.Context, args json.RawMessage) Response {
var p struct {
Image string `json:"image"`
Events string `json:"events"`
AgentName string `json:"agent_name"`
Namespace string `json:"namespace"`
ResourcesMemory string `json:"resources_memory"`
ResourcesCPU string `json:"resources_cpu"`
Env string `json:"env"`
TimeoutSeconds int `json:"timeout_seconds"`
}
if err := json.Unmarshal(args, &p); err != nil {
return Response{OK: false, Error: "invalid args: " + err.Error()}
}
if p.Image == "" || p.Events == "" || p.AgentName == "" {
return Response{OK: false, Error: "image, events, and agent_name are required"}
}
if s.services.K8sService == nil {
return Response{OK: false, Error: "k8s service not configured"}
}
events := strings.Split(p.Events, ",")
for i := range events {
events[i] = strings.TrimSpace(events[i])
}
// Parse env from comma-separated KEY=VALUE pairs.
envMap := map[string]string{}
if p.Env != "" {
for _, pair := range strings.Split(p.Env, ",") {
pair = strings.TrimSpace(pair)
parts := strings.SplitN(pair, "=", 2)
if len(parts) == 2 {
envMap[parts[0]] = parts[1]
}
}
}
timeout := p.TimeoutSeconds
if timeout <= 0 {
timeout = 300
}
req := k8s.RegisterHandlerRequest{
Image: p.Image,
Events: events,
Namespace: p.Namespace,
ResourcesMemory: p.ResourcesMemory,
ResourcesCPU: p.ResourcesCPU,
Env: envMap,
TimeoutSeconds: timeout,
}
handler, err := s.services.K8sService.RegisterHandler(ctx, p.AgentName, req)
if err != nil {
return Response{OK: false, Error: err.Error()}
}
return Response{OK: true, Data: map[string]interface{}{
"id": handler.ID,
"image": handler.Image,
"events": handler.Events,
"status": handler.Status,
}}
}
func (s *AdminServer) handleK8sList(ctx context.Context, args json.RawMessage) Response {
var p struct {
AgentName string `json:"agent_name"`
}
if args != nil {
json.Unmarshal(args, &p)
}
if s.services.K8sService == nil {
return Response{OK: false, Error: "k8s service not configured"}
}
if p.AgentName == "" {
// Admin: list all K8s handlers by querying DB directly.
rows, err := s.db.QueryContext(ctx,
`SELECT id, agent_name, image, events, namespace, resources_memory, resources_cpu, timeout_seconds, status, created_at
FROM k8s_handlers ORDER BY created_at DESC`)
if err != nil {
return Response{OK: false, Error: err.Error()}
}
defer rows.Close()
type handlerRow struct {
ID int64 `json:"id"`
AgentName string `json:"agent_name"`
Image string `json:"image"`
Events []string `json:"events"`
Namespace string `json:"namespace"`
ResourcesMemory string `json:"resources_memory"`
ResourcesCPU string `json:"resources_cpu"`
TimeoutSeconds int `json:"timeout_seconds"`
Status string `json:"status"`
CreatedAt string `json:"created_at"`
}
var result []handlerRow
for rows.Next() {
var r handlerRow
var eventsJSON string
var createdAt time.Time
if err := rows.Scan(&r.ID, &r.AgentName, &r.Image, &eventsJSON, &r.Namespace,
&r.ResourcesMemory, &r.ResourcesCPU, &r.TimeoutSeconds, &r.Status, &createdAt); err != nil {
return Response{OK: false, Error: "scan: " + err.Error()}
}
json.Unmarshal([]byte(eventsJSON), &r.Events)
if r.Events == nil {
r.Events = []string{}
}
r.CreatedAt = createdAt.Format(time.RFC3339)
result = append(result, r)
}
if result == nil {
result = []handlerRow{}
}
return Response{OK: true, Data: result}
}
handlers, err := s.services.K8sService.ListHandlers(ctx, p.AgentName)
if err != nil {
return Response{OK: false, Error: err.Error()}
}
type handlerRow struct {
ID int64 `json:"id"`
AgentName string `json:"agent_name"`
Image string `json:"image"`
Events []string `json:"events"`
Namespace string `json:"namespace"`
ResourcesMemory string `json:"resources_memory"`
ResourcesCPU string `json:"resources_cpu"`
TimeoutSeconds int `json:"timeout_seconds"`
Status string `json:"status"`
CreatedAt string `json:"created_at"`
}
result := make([]handlerRow, len(handlers))
for i, h := range handlers {
result[i] = handlerRow{
ID: h.ID,
AgentName: h.AgentName,
Image: h.Image,
Events: h.Events,
Namespace: h.Namespace,
ResourcesMemory: h.ResourcesMemory,
ResourcesCPU: h.ResourcesCPU,
TimeoutSeconds: h.TimeoutSeconds,
Status: h.Status,
CreatedAt: h.CreatedAt.Format(time.RFC3339),
}
}
return Response{OK: true, Data: result}
}
func (s *AdminServer) handleK8sDelete(ctx context.Context, args json.RawMessage) Response {
var p struct {
ID int64 `json:"id"`
}
if err := json.Unmarshal(args, &p); err != nil {
return Response{OK: false, Error: "invalid args: " + err.Error()}
}
if p.ID <= 0 {
return Response{OK: false, Error: "id is required"}
}
if s.services.K8sService == nil {
return Response{OK: false, Error: "k8s service not configured"}
}
// Admin bypass: look up the handler's agent_name first, then delete.
var agentName string
err := s.db.QueryRowContext(ctx, "SELECT agent_name FROM k8s_handlers WHERE id = ?", p.ID).Scan(&agentName)
if err != nil {
return Response{OK: false, Error: "handler not found"}
}
if err := s.services.K8sService.DeleteHandler(ctx, agentName, p.ID); err != nil {
return Response{OK: false, Error: err.Error()}
}
return Response{OK: true, Data: map[string]interface{}{
"deleted": p.ID,
}}
}
// ---------- attachments handlers ----------
func (s *AdminServer) handleAttachmentsGC(ctx context.Context) Response {
if s.services.AttachmentService == nil {
return Response{OK: false, Error: "attachment service not configured"}
}
result, err := s.services.AttachmentService.GarbageCollect(ctx)
if err != nil {
return Response{OK: false, Error: err.Error()}
}
return Response{OK: true, Data: map[string]interface{}{
"files_removed": result.FilesRemoved,
"bytes_reclaimed": result.BytesReclaimed,
}}
}
// Ensure the messaging import is used.
var _ = messaging.StatusPending
+109
View File
@@ -0,0 +1,109 @@
package api
import (
"context"
"log/slog"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/channels"
)
// NewMessageEvent is broadcast when a new message is sent.
type NewMessageEvent struct {
Channel string `json:"channel,omitempty"` // set for channel messages
FromAgent string `json:"from_agent,omitempty"` // set for DMs
ToAgent string `json:"to_agent,omitempty"` // set for DMs
MessageID int64 `json:"message_id"`
}
// UnreadUpdateEvent is broadcast when unread counts change (e.g. mark-read).
type UnreadUpdateEvent struct {
Channel string `json:"channel,omitempty"`
Agent string `json:"agent,omitempty"`
UnreadCount int `json:"unread_count"`
}
// EventBroadcaster broadcasts real-time events to connected SSE clients.
type EventBroadcaster interface {
BroadcastNewMessage(ctx context.Context, ownerID int64, event NewMessageEvent)
BroadcastUnreadUpdate(ctx context.Context, ownerID int64, event UnreadUpdateEvent)
}
// SSEBroadcaster implements EventBroadcaster using the SSEHub.
type SSEBroadcaster struct {
hub *SSEHub
agentService *agents.AgentService
channelService *channels.Service
logger *slog.Logger
}
// NewSSEBroadcaster creates a broadcaster that sends events via SSE.
func NewSSEBroadcaster(hub *SSEHub, agentService *agents.AgentService, channelService *channels.Service) *SSEBroadcaster {
return &SSEBroadcaster{
hub: hub,
agentService: agentService,
channelService: channelService,
logger: slog.Default().With("component", "api.broadcaster"),
}
}
// BroadcastNewMessage sends a new_message event to the given owner.
func (b *SSEBroadcaster) BroadcastNewMessage(_ context.Context, ownerID int64, event NewMessageEvent) {
b.hub.Broadcast(ownerID, SSEEvent{
Type: "new_message",
Data: event,
})
}
// BroadcastUnreadUpdate sends an unread_update event to the given owner.
func (b *SSEBroadcaster) BroadcastUnreadUpdate(_ context.Context, ownerID int64, event UnreadUpdateEvent) {
b.hub.Broadcast(ownerID, SSEEvent{
Type: "unread_update",
Data: event,
})
}
// BroadcastDM broadcasts a new_message event for a direct message.
// It resolves the recipient agent's owner and sends the event to them.
func (b *SSEBroadcaster) BroadcastDM(ctx context.Context, msg NewMessageEvent) {
if msg.ToAgent == "" {
return
}
agent, err := b.agentService.GetAgent(ctx, msg.ToAgent)
if err != nil {
b.logger.Debug("could not resolve recipient owner for SSE broadcast",
"to_agent", msg.ToAgent, "error", err)
return
}
b.BroadcastNewMessage(ctx, agent.OwnerID, msg)
}
// BroadcastChannelMessage broadcasts a new_message event for a channel message.
// It resolves all channel members' owners and sends the event to each unique owner.
func (b *SSEBroadcaster) BroadcastChannelMessage(ctx context.Context, channelID int64, msg NewMessageEvent) {
if b.channelService == nil {
return
}
members, err := b.channelService.GetMembers(ctx, channelID)
if err != nil {
b.logger.Debug("could not get channel members for SSE broadcast",
"channel_id", channelID, "error", err)
return
}
// Collect unique owner IDs to avoid duplicate broadcasts.
seen := make(map[int64]bool)
for _, m := range members {
agent, err := b.agentService.GetAgent(ctx, m.AgentName)
if err != nil {
continue
}
if !seen[agent.OwnerID] {
seen[agent.OwnerID] = true
b.BroadcastNewMessage(ctx, agent.OwnerID, msg)
}
}
}
+17 -4
View File
@@ -201,7 +201,7 @@ func (h *ChannelsHandler) JoinChannel(w http.ResponseWriter, r *http.Request) {
// ChannelMessages handles GET /api/channels/{name}/messages.
func (h *ChannelsHandler) ChannelMessages(w http.ResponseWriter, r *http.Request) {
_, ok := OwnerIDFromContext(r.Context())
ownerID, ok := OwnerIDFromContext(r.Context())
if !ok {
writeJSON(w, http.StatusUnauthorized, errorBody("unauthorized", "Authentication required"))
return
@@ -221,16 +221,29 @@ func (h *ChannelsHandler) ChannelMessages(w http.ResponseWriter, r *http.Request
}
}
msgs, err := h.msgService.GetChannelMessages(r.Context(), ch.ID, limit)
paginated, err := h.msgService.GetChannelMessages(r.Context(), ch.ID, limit, 0)
if err != nil {
h.logger.Error("get channel messages failed", "error", err)
writeJSON(w, http.StatusInternalServerError, errorBody("server_error", "Failed to get messages"))
return
}
// Compute last_read_message_id across owned agents
var lastReadMessageID int64
ownedAgents, err := h.agentService.ListAgents(r.Context(), ownerID)
if err == nil {
for _, agent := range ownedAgents {
lr, err := h.msgService.GetLastReadForChannel(r.Context(), agent.Name, ch.ID)
if err == nil && lr > lastReadMessageID {
lastReadMessageID = lr
}
}
}
writeJSON(w, http.StatusOK, map[string]any{
"messages": msgs,
"total": len(msgs),
"messages": paginated.Messages,
"total": paginated.Total,
"last_read_message_id": lastReadMessageID,
})
}
+36 -8
View File
@@ -18,9 +18,15 @@ import (
type MessagesHandler struct {
msgService *messaging.MessagingService
agentService *agents.AgentService
broadcaster *SSEBroadcaster
logger *slog.Logger
}
// SetBroadcaster sets the event broadcaster for real-time SSE notifications.
func (h *MessagesHandler) SetBroadcaster(b *SSEBroadcaster) {
h.broadcaster = b
}
// NewMessagesHandler creates a new messages handler.
func NewMessagesHandler(msgService *messaging.MessagingService, agentService *agents.AgentService) *MessagesHandler {
return &MessagesHandler{
@@ -67,12 +73,12 @@ func (h *MessagesHandler) ListMessages(w http.ResponseWriter, r *http.Request) {
IncludeRead: true,
Status: status,
}
msgs, err := h.msgService.ReadInbox(r.Context(), agent.Name, opts)
result, err := h.msgService.ReadInbox(r.Context(), agent.Name, opts)
if err != nil {
h.logger.Error("read inbox failed", "agent", agent.Name, "error", err)
continue
}
allMessages = append(allMessages, msgs...)
allMessages = append(allMessages, result.Messages...)
}
if allMessages == nil {
@@ -153,11 +159,11 @@ func (h *MessagesHandler) ListConversations(w http.ResponseWriter, r *http.Reque
Limit: 100,
IncludeRead: true,
}
msgs, err := h.msgService.ReadInbox(r.Context(), agent.Name, opts)
result, err := h.msgService.ReadInbox(r.Context(), agent.Name, opts)
if err != nil {
continue
}
for _, msg := range msgs {
for _, msg := range result.Messages {
existing, exists := convMap[msg.ConversationID]
if !exists {
convMap[msg.ConversationID] = &convSummary{
@@ -309,6 +315,24 @@ func (h *MessagesHandler) SendMessage(w http.ResponseWriter, r *http.Request) {
return
}
// Broadcast real-time event to connected SSE clients
if h.broadcaster != nil {
event := NewMessageEvent{
MessageID: msg.ID,
FromAgent: msg.FromAgent,
ToAgent: msg.ToAgent,
}
if msg.ChannelID != nil && h.broadcaster.channelService != nil {
ch, chErr := h.broadcaster.channelService.GetChannel(r.Context(), *msg.ChannelID)
if chErr == nil {
event.Channel = ch.Name
}
h.broadcaster.BroadcastChannelMessage(r.Context(), *msg.ChannelID, event)
} else {
h.broadcaster.BroadcastDM(r.Context(), event)
}
}
writeJSON(w, http.StatusCreated, msg)
}
@@ -393,11 +417,11 @@ func (h *MessagesHandler) SearchMessages(w http.ResponseWriter, r *http.Request)
var allMessages []*messaging.Message
for _, agent := range ownedAgents {
opts := messaging.SearchOptions{Limit: limit}
msgs, err := h.msgService.SearchMessages(r.Context(), agent.Name, query, opts)
result, err := h.msgService.SearchMessages(r.Context(), agent.Name, query, opts)
if err != nil {
continue
}
allMessages = append(allMessages, msgs...)
allMessages = append(allMessages, result.Messages...)
}
if allMessages == nil {
@@ -489,9 +513,13 @@ func (h *MessagesHandler) DMMessages(w http.ResponseWriter, r *http.Request) {
return
}
// Include last_read_message_id for the human agent's DM with the peer
lastRead, _ := h.msgService.GetLastReadForDM(r.Context(), agentNames, peerAgent)
writeJSON(w, http.StatusOK, map[string]any{
"messages": msgs,
"total": len(msgs),
"messages": msgs,
"total": len(msgs),
"last_read_message_id": lastRead,
})
}
+203
View File
@@ -0,0 +1,203 @@
package api
import (
"encoding/json"
"log/slog"
"net/http"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/messaging"
)
// NotificationsHandler handles REST API requests for notification badges.
type NotificationsHandler struct {
msgService *messaging.MessagingService
agentService *agents.AgentService
channelService *channels.Service
logger *slog.Logger
}
// NewNotificationsHandler creates a new notifications handler.
func NewNotificationsHandler(msgService *messaging.MessagingService, agentService *agents.AgentService, channelService *channels.Service) *NotificationsHandler {
return &NotificationsHandler{
msgService: msgService,
agentService: agentService,
channelService: channelService,
logger: slog.Default().With("component", "api.notifications"),
}
}
// channelUnread is the JSON shape for a channel's unread info.
type channelUnread struct {
Name string `json:"name"`
UnreadCount int `json:"unread_count"`
LastMessageID int64 `json:"last_message_id"`
}
// dmUnread is the JSON shape for a DM peer's unread info.
type dmUnread struct {
Agent string `json:"agent"`
UnreadCount int `json:"unread_count"`
LastMessageID int64 `json:"last_message_id"`
}
// UnreadCounts handles GET /api/notifications/unread.
func (h *NotificationsHandler) UnreadCounts(w http.ResponseWriter, r *http.Request) {
ownerID, ok := OwnerIDFromContext(r.Context())
if !ok {
writeJSON(w, http.StatusUnauthorized, errorBody("unauthorized", "Authentication required"))
return
}
// Use only the human agent's perspective for notification counts.
// This avoids system/AI agents inflating unread counts.
humanAgent, err := h.agentService.GetHumanAgentForUser(r.Context(), ownerID)
if err != nil || humanAgent == nil {
writeJSON(w, http.StatusOK, map[string]any{
"channels": []channelUnread{},
"dms": []dmUnread{},
"total_unread": 0,
})
return
}
// Channel summaries for the human agent
channelsList := []channelUnread{}
if h.channelService != nil {
summaries, err := h.channelService.GetChannelSummaries(r.Context(), humanAgent.Name)
if err != nil {
h.logger.Error("get channel summaries failed", "agent", humanAgent.Name, "error", err)
} else {
for _, cs := range summaries {
channelsList = append(channelsList, channelUnread{
Name: cs.Name,
UnreadCount: cs.UnreadCount,
LastMessageID: cs.LastMessageID,
})
}
}
}
// DM unread counts for the human agent
dmMap := make(map[string]*dmUnread)
counts, err := h.msgService.GetDMUnreadCounts(r.Context(), humanAgent.Name)
if err != nil {
h.logger.Error("get dm unread counts failed", "agent", humanAgent.Name, "error", err)
} else {
for _, dc := range counts {
dmMap[dc.Agent] = &dmUnread{
Agent: dc.Agent,
UnreadCount: dc.UnreadCount,
LastMessageID: dc.LastMessageID,
}
}
}
dmsList := make([]dmUnread, 0, len(dmMap))
for _, du := range dmMap {
dmsList = append(dmsList, *du)
}
totalUnread := 0
for _, cu := range channelsList {
totalUnread += cu.UnreadCount
}
for _, du := range dmsList {
totalUnread += du.UnreadCount
}
writeJSON(w, http.StatusOK, map[string]any{
"channels": channelsList,
"dms": dmsList,
"total_unread": totalUnread,
})
}
// MarkRead handles POST /api/notifications/mark-read.
func (h *NotificationsHandler) MarkRead(w http.ResponseWriter, r *http.Request) {
ownerID, ok := OwnerIDFromContext(r.Context())
if !ok {
writeJSON(w, http.StatusUnauthorized, errorBody("unauthorized", "Authentication required"))
return
}
var req struct {
Type string `json:"type"`
Target string `json:"target"`
LastMessageID int64 `json:"last_message_id"`
}
if err := json.NewDecoder(r.Body).Decode(&req); err != nil {
writeJSON(w, http.StatusBadRequest, errorBody("invalid_request", "Invalid JSON body"))
return
}
if req.Type == "" || req.Target == "" || req.LastMessageID <= 0 {
writeJSON(w, http.StatusBadRequest, errorBody("validation_error", "type, target, and last_message_id are required"))
return
}
if req.Type != "channel" && req.Type != "dm" {
writeJSON(w, http.StatusBadRequest, errorBody("validation_error", "type must be 'channel' or 'dm'"))
return
}
humanAgent, err := h.agentService.GetHumanAgentForUser(r.Context(), ownerID)
if err != nil || humanAgent == nil {
writeJSON(w, http.StatusBadRequest, errorBody("no_agents", "No human agent found"))
return
}
agentNames := []string{humanAgent.Name}
if req.Type == "channel" {
if h.channelService == nil {
writeJSON(w, http.StatusBadRequest, errorBody("not_available", "Channel service not available"))
return
}
ch, err := h.channelService.GetChannelByName(r.Context(), req.Target)
if err != nil {
writeJSON(w, http.StatusNotFound, errorBody("not_found", "Channel not found"))
return
}
convIDs, err := h.msgService.GetConversationIDsForChannel(r.Context(), ch.ID, req.LastMessageID)
if err != nil {
h.logger.Error("get conversation ids failed", "error", err)
writeJSON(w, http.StatusInternalServerError, errorBody("server_error", "Failed to get conversations"))
return
}
for _, convID := range convIDs {
if err := h.msgService.UpdateInboxState(r.Context(), humanAgent.Name, convID, req.LastMessageID); err != nil {
h.logger.Error("update inbox state failed",
"agent", humanAgent.Name,
"conversation_id", convID,
"error", err,
)
}
}
} else {
// DM mark-read
convIDs, err := h.msgService.GetConversationIDsForDM(r.Context(), agentNames, req.Target, req.LastMessageID)
if err != nil {
h.logger.Error("get dm conversation ids failed", "error", err)
writeJSON(w, http.StatusInternalServerError, errorBody("server_error", "Failed to get conversations"))
return
}
for _, convID := range convIDs {
if err := h.msgService.UpdateInboxState(r.Context(), humanAgent.Name, convID, req.LastMessageID); err != nil {
h.logger.Error("update inbox state failed",
"agent", humanAgent.Name,
"conversation_id", convID,
"error", err,
)
}
}
}
writeJSON(w, http.StatusOK, map[string]string{"status": "ok"})
}
+373
View File
@@ -0,0 +1,373 @@
package api
import (
"bytes"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"github.com/go-chi/chi/v5"
_ "modernc.org/sqlite"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/messaging"
)
func setupNotificationsRouter(t *testing.T) (chi.Router, *messaging.MessagingService, *agents.AgentService, *channels.Service) {
t.Helper()
db := newTestDBFull(t)
msgStore := messaging.NewSQLiteMessageStore(db)
msgService := messaging.NewMessagingService(msgStore, nil)
agentStore := agents.NewSQLiteAgentStore(db)
agentService := agents.NewAgentService(agentStore, nil)
channelStore := channels.NewSQLiteChannelStore(db)
channelService := channels.NewService(channelStore, msgService, nil)
// Seed agents — human-agent must be type 'human' for GetHumanAgentForUser
seedTestAgentWithType(t, db, "human-agent", "human", 1)
seedTestAgent(t, db, "bot-alice", 2)
seedTestAgent(t, db, "bot-bob", 2)
handler := NewNotificationsHandler(msgService, agentService, channelService)
messagesHandler := NewMessagesHandler(msgService, agentService)
channelsHandler := NewChannelsHandler(channelService, agentService, msgService)
router := chi.NewRouter()
router.Group(func(r chi.Router) {
r.Use(OwnerAuthMiddleware)
r.Get("/api/notifications/unread", handler.UnreadCounts)
r.Post("/api/notifications/mark-read", handler.MarkRead)
r.Get("/api/channels/{name}/messages", channelsHandler.ChannelMessages)
r.Get("/api/agents/{name}/messages", messagesHandler.DMMessages)
})
return router, msgService, agentService, channelService
}
func TestUnreadCounts_Unauthenticated(t *testing.T) {
router, _, _, _ := setupNotificationsRouter(t)
req := httptest.NewRequest("GET", "/api/notifications/unread", nil)
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusUnauthorized {
t.Errorf("status = %d, want %d", rr.Code, http.StatusUnauthorized)
}
}
func TestUnreadCounts_NoAgents(t *testing.T) {
router, _, _, _ := setupNotificationsRouter(t)
// Owner 99 has no agents
req := httptest.NewRequest("GET", "/api/notifications/unread", nil)
req.Header.Set("X-Owner-ID", "99")
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("status = %d, want %d, body: %s", rr.Code, http.StatusOK, rr.Body.String())
}
var resp struct {
Channels []channelUnread `json:"channels"`
DMs []dmUnread `json:"dms"`
TotalUnread int `json:"total_unread"`
}
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.Channels) != 0 {
t.Errorf("channels = %d, want 0", len(resp.Channels))
}
if len(resp.DMs) != 0 {
t.Errorf("dms = %d, want 0", len(resp.DMs))
}
if resp.TotalUnread != 0 {
t.Errorf("total_unread = %d, want 0", resp.TotalUnread)
}
}
func TestUnreadCounts_WithDMs(t *testing.T) {
router, msgService, _, _ := setupNotificationsRouter(t)
ctx := t.Context()
// bot-alice sends DMs to human-agent (owner 1)
_, err := msgService.SendMessage(ctx, "bot-alice", "human-agent", "Hello from Alice", messaging.SendOptions{Subject: "dm"})
if err != nil {
t.Fatalf("send message: %v", err)
}
_, err = msgService.SendMessage(ctx, "bot-alice", "human-agent", "Second message from Alice", messaging.SendOptions{Subject: "dm"})
if err != nil {
t.Fatalf("send message: %v", err)
}
// bot-bob sends a DM to human-agent
_, err = msgService.SendMessage(ctx, "bot-bob", "human-agent", "Hello from Bob", messaging.SendOptions{Subject: "dm"})
if err != nil {
t.Fatalf("send message: %v", err)
}
req := httptest.NewRequest("GET", "/api/notifications/unread", nil)
req.Header.Set("X-Owner-ID", "1")
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("status = %d, want %d, body: %s", rr.Code, http.StatusOK, rr.Body.String())
}
var resp struct {
Channels []channelUnread `json:"channels"`
DMs []dmUnread `json:"dms"`
TotalUnread int `json:"total_unread"`
}
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.DMs) != 2 {
t.Fatalf("dms = %d, want 2; body: %s", len(resp.DMs), rr.Body.String())
}
// Find alice and bob counts
dmsByAgent := make(map[string]dmUnread)
for _, dm := range resp.DMs {
dmsByAgent[dm.Agent] = dm
}
if alice, ok := dmsByAgent["bot-alice"]; !ok {
t.Error("expected DM from bot-alice")
} else if alice.UnreadCount != 2 {
t.Errorf("bot-alice unread = %d, want 2", alice.UnreadCount)
}
if bob, ok := dmsByAgent["bot-bob"]; !ok {
t.Error("expected DM from bot-bob")
} else if bob.UnreadCount != 1 {
t.Errorf("bot-bob unread = %d, want 1", bob.UnreadCount)
}
if resp.TotalUnread != 3 {
t.Errorf("total_unread = %d, want 3", resp.TotalUnread)
}
}
func TestMarkRead_DM(t *testing.T) {
router, msgService, _, _ := setupNotificationsRouter(t)
ctx := t.Context()
// bot-alice sends 3 DMs to human-agent
msg1, _ := msgService.SendMessage(ctx, "bot-alice", "human-agent", "Message 1", messaging.SendOptions{Subject: "dm"})
_, _ = msgService.SendMessage(ctx, "bot-alice", "human-agent", "Message 2", messaging.SendOptions{Subject: "dm"})
msg3, _ := msgService.SendMessage(ctx, "bot-alice", "human-agent", "Message 3", messaging.SendOptions{Subject: "dm"})
// Mark read up to msg1
body, _ := json.Marshal(map[string]any{
"type": "dm",
"target": "bot-alice",
"last_message_id": msg1.ID,
})
req := httptest.NewRequest("POST", "/api/notifications/mark-read", bytes.NewReader(body))
req.Header.Set("X-Owner-ID", "1")
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("mark-read status = %d, want %d, body: %s", rr.Code, http.StatusOK, rr.Body.String())
}
// Check unread — should have 2 unread still
req = httptest.NewRequest("GET", "/api/notifications/unread", nil)
req.Header.Set("X-Owner-ID", "1")
rr = httptest.NewRecorder()
router.ServeHTTP(rr, req)
var resp struct {
DMs []dmUnread `json:"dms"`
TotalUnread int `json:"total_unread"`
}
json.Unmarshal(rr.Body.Bytes(), &resp)
if len(resp.DMs) != 1 {
t.Fatalf("dms = %d, want 1; body: %s", len(resp.DMs), rr.Body.String())
}
if resp.DMs[0].UnreadCount != 2 {
t.Errorf("unread after mark-read = %d, want 2", resp.DMs[0].UnreadCount)
}
// Mark all read up to msg3
body, _ = json.Marshal(map[string]any{
"type": "dm",
"target": "bot-alice",
"last_message_id": msg3.ID,
})
req = httptest.NewRequest("POST", "/api/notifications/mark-read", bytes.NewReader(body))
req.Header.Set("X-Owner-ID", "1")
rr = httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("mark-read status = %d, want %d", rr.Code, http.StatusOK)
}
// Check unread — should be 0
req = httptest.NewRequest("GET", "/api/notifications/unread", nil)
req.Header.Set("X-Owner-ID", "1")
rr = httptest.NewRecorder()
router.ServeHTTP(rr, req)
json.Unmarshal(rr.Body.Bytes(), &resp)
if resp.TotalUnread != 0 {
t.Errorf("total_unread after marking all read = %d, want 0; body: %s", resp.TotalUnread, rr.Body.String())
}
}
func TestMarkRead_Validation(t *testing.T) {
router, _, _, _ := setupNotificationsRouter(t)
tests := []struct {
name string
body map[string]any
want int
}{
{
name: "missing type",
body: map[string]any{"target": "foo", "last_message_id": 1},
want: http.StatusBadRequest,
},
{
name: "missing target",
body: map[string]any{"type": "dm", "last_message_id": 1},
want: http.StatusBadRequest,
},
{
name: "missing last_message_id",
body: map[string]any{"type": "dm", "target": "foo"},
want: http.StatusBadRequest,
},
{
name: "invalid type",
body: map[string]any{"type": "invalid", "target": "foo", "last_message_id": 1},
want: http.StatusBadRequest,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
body, _ := json.Marshal(tt.body)
req := httptest.NewRequest("POST", "/api/notifications/mark-read", bytes.NewReader(body))
req.Header.Set("X-Owner-ID", "1")
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != tt.want {
t.Errorf("status = %d, want %d, body: %s", rr.Code, tt.want, rr.Body.String())
}
})
}
}
func TestDMMessages_IncludesLastRead(t *testing.T) {
router, msgService, _, _ := setupNotificationsRouter(t)
ctx := t.Context()
// Send DMs from bot-alice to human-agent
msg1, _ := msgService.SendMessage(ctx, "bot-alice", "human-agent", "Hello", messaging.SendOptions{Subject: "dm"})
_, _ = msgService.SendMessage(ctx, "bot-alice", "human-agent", "World", messaging.SendOptions{Subject: "dm"})
// Mark read up to msg1
body, _ := json.Marshal(map[string]any{
"type": "dm",
"target": "bot-alice",
"last_message_id": msg1.ID,
})
req := httptest.NewRequest("POST", "/api/notifications/mark-read", bytes.NewReader(body))
req.Header.Set("X-Owner-ID", "1")
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("mark-read status = %d", rr.Code)
}
// GET DM messages should include last_read_message_id
req = httptest.NewRequest("GET", "/api/agents/bot-alice/messages", nil)
req.Header.Set("X-Owner-ID", "1")
rr = httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("dm messages status = %d, body: %s", rr.Code, rr.Body.String())
}
var resp map[string]any
json.Unmarshal(rr.Body.Bytes(), &resp)
lastRead, ok := resp["last_read_message_id"]
if !ok {
t.Fatal("response missing last_read_message_id")
}
if int64(lastRead.(float64)) != msg1.ID {
t.Errorf("last_read_message_id = %v, want %d", lastRead, msg1.ID)
}
}
func TestChannelMessages_IncludesLastRead(t *testing.T) {
router, _, _, channelService := setupNotificationsRouter(t)
ctx := t.Context()
// Create a channel and have human-agent join
ch, err := channelService.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "test-channel",
CreatedBy: "human-agent",
})
if err != nil {
t.Fatalf("create channel: %v", err)
}
// Broadcast messages
msgs, err := channelService.BroadcastMessage(ctx, ch.ID, "human-agent", "Hello channel", 5, "")
if err != nil {
t.Fatalf("broadcast: %v", err)
}
// Mark read up to the first channel message
body, _ := json.Marshal(map[string]any{
"type": "channel",
"target": "test-channel",
"last_message_id": msgs[0].ID,
})
req := httptest.NewRequest("POST", "/api/notifications/mark-read", bytes.NewReader(body))
req.Header.Set("X-Owner-ID", "1")
rr := httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("mark-read status = %d, body: %s", rr.Code, rr.Body.String())
}
// GET channel messages should include last_read_message_id
req = httptest.NewRequest("GET", "/api/channels/test-channel/messages", nil)
req.Header.Set("X-Owner-ID", "1")
rr = httptest.NewRecorder()
router.ServeHTTP(rr, req)
if rr.Code != http.StatusOK {
t.Fatalf("channel messages status = %d, body: %s", rr.Code, rr.Body.String())
}
var resp map[string]any
json.Unmarshal(rr.Body.Bytes(), &resp)
_, ok := resp["last_read_message_id"]
if !ok {
t.Fatal("response missing last_read_message_id")
}
}
+11
View File
@@ -85,6 +85,13 @@ func NewRouterWithConfig(cfg RouterConfig) chi.Router {
if cfg.MsgService != nil && cfg.AgentService != nil {
messagesHandler := NewMessagesHandler(cfg.MsgService, cfg.AgentService)
agentsHandler := NewAgentsHandler(cfg.AgentService, cfg.TraceStore, cfg.ChannelService)
notificationsHandler := NewNotificationsHandler(cfg.MsgService, cfg.AgentService, cfg.ChannelService)
// Wire up SSE broadcaster for real-time events
if cfg.SSEHub != nil {
broadcaster := NewSSEBroadcaster(cfg.SSEHub, cfg.AgentService, cfg.ChannelService)
messagesHandler.SetBroadcaster(broadcaster)
}
r.Group(func(r chi.Router) {
r.Use(authMiddleware)
@@ -109,6 +116,10 @@ func NewRouterWithConfig(cfg RouterConfig) chi.Router {
r.Delete("/api/agents/{name}", agentsHandler.DeleteAgent)
r.Post("/api/agents/{name}/revoke-key", agentsHandler.RevokeKey)
r.Get("/api/agents/{name}/messages", messagesHandler.DMMessages)
// Notifications
r.Get("/api/notifications/unread", notificationsHandler.UnreadCounts)
r.Post("/api/notifications/mark-read", notificationsHandler.MarkRead)
})
// API Keys
+61 -3
View File
@@ -16,6 +16,7 @@ type ChannelSummary struct {
ID int64 `json:"id"`
Name string `json:"name"`
UnreadCount int `json:"unread"`
LastMessageID int64 `json:"last_message_id"`
LastMessageAt *time.Time `json:"last_message_at"`
}
@@ -311,13 +312,13 @@ func (s *Service) KickFromChannel(ctx context.Context, channelID int64, agentNam
// ListChannels returns channels visible to the agent.
func (s *Service) ListChannels(ctx context.Context, agentName string) ([]*ChannelWithCount, error) {
channels, err := s.store.ListChannels(ctx, agentName)
chList, err := s.store.ListChannels(ctx, agentName)
if err != nil {
return nil, err
}
result := make([]*ChannelWithCount, len(channels))
for i, ch := range channels {
result := make([]*ChannelWithCount, len(chList))
for i, ch := range chList {
count, err := s.store.CountMembers(ctx, ch.ID)
if err != nil {
return nil, fmt.Errorf("count members for channel %d: %w", ch.ID, err)
@@ -337,6 +338,63 @@ func (s *Service) ListChannels(ctx context.Context, agentName string) ([]*Channe
return result, nil
}
// ListChannelsPaginated returns channels visible to the agent with pagination.
func (s *Service) ListChannelsPaginated(ctx context.Context, agentName string, opts ListChannelsOptions) (*PaginatedChannels, error) {
allChannels, err := s.store.ListChannels(ctx, agentName)
if err != nil {
return nil, err
}
total := len(allChannels)
limit := opts.Limit
if limit <= 0 {
limit = 50
}
offset := opts.Offset
if offset < 0 {
offset = 0
}
// Apply pagination
start := offset
if start > total {
start = total
}
end := start + limit
if end > total {
end = total
}
page := allChannels[start:end]
result := make([]*ChannelWithCount, len(page))
for i, ch := range page {
count, err := s.store.CountMembers(ctx, ch.ID)
if err != nil {
return nil, fmt.Errorf("count members for channel %d: %w", ch.ID, err)
}
result[i] = &ChannelWithCount{
Channel: *ch,
MemberCount: count,
}
}
if s.tracer != nil {
s.tracer.Record(ctx, agentName, "channel.list", map[string]any{
"count": len(result),
"total": total,
})
}
return &PaginatedChannels{
Channels: result,
Total: total,
Offset: offset,
Limit: limit,
}, nil
}
// GetChannel returns a channel by ID.
func (s *Service) GetChannel(ctx context.Context, id int64) (*Channel, error) {
return s.store.GetChannel(ctx, id)
+18 -18
View File
@@ -549,12 +549,12 @@ func TestService_BroadcastMessage(t *testing.T) {
})
t.Run("broadcast visible via GetChannelMessages", func(t *testing.T) {
channelMsgs, err := svc.msgService.GetChannelMessages(ctx, ch.ID, 100)
channelResult, err := svc.msgService.GetChannelMessages(ctx, ch.ID, 100, 0)
if err != nil {
t.Fatalf("GetChannelMessages: %v", err)
}
found := false
for _, m := range channelMsgs {
for _, m := range channelResult.Messages {
if m.Body == "hello" && m.FromAgent == "agent-a" {
found = true
break
@@ -574,9 +574,9 @@ func TestService_BroadcastMessage(t *testing.T) {
}
// agent-b should have an inbox notification
inbox, _ := svc.msgService.ReadInbox(ctx, "agent-b", messaging.ReadOptions{IncludeRead: true})
inboxResult, _ := svc.msgService.ReadInbox(ctx, "agent-b", messaging.ReadOptions{IncludeRead: true})
found := false
for _, m := range inbox {
for _, m := range inboxResult.Messages {
if m.Body == "multi-member test" {
found = true
break
@@ -589,8 +589,8 @@ func TestService_BroadcastMessage(t *testing.T) {
t.Run("sender does not receive own message", func(t *testing.T) {
svc.BroadcastMessage(ctx, ch.ID, "agent-a", "no self-message", 5, "")
inbox, _ := svc.msgService.ReadInbox(ctx, "agent-a", messaging.ReadOptions{IncludeRead: true})
for _, m := range inbox {
inboxResult, _ := svc.msgService.ReadInbox(ctx, "agent-a", messaging.ReadOptions{IncludeRead: true})
for _, m := range inboxResult.Messages {
if m.Body == "no self-message" {
t.Error("sender should not receive their own broadcast in inbox")
}
@@ -625,9 +625,9 @@ func TestService_BroadcastMessage_Mentions(t *testing.T) {
}
// agent-b was mentioned — inbox notification should have mention:true
inbox, _ := svc.msgService.ReadInbox(ctx, "agent-b", messaging.ReadOptions{IncludeRead: true})
inboxResult, _ := svc.msgService.ReadInbox(ctx, "agent-b", messaging.ReadOptions{IncludeRead: true})
found := false
for _, m := range inbox {
for _, m := range inboxResult.Messages {
if m.Body == "hey @agent-b check this" {
found = true
var meta map[string]any
@@ -643,8 +643,8 @@ func TestService_BroadcastMessage_Mentions(t *testing.T) {
}
// agent-c was NOT mentioned — inbox notification should NOT have mention:true
inbox, _ = svc.msgService.ReadInbox(ctx, "agent-c", messaging.ReadOptions{IncludeRead: true})
for _, m := range inbox {
inboxResult, _ = svc.msgService.ReadInbox(ctx, "agent-c", messaging.ReadOptions{IncludeRead: true})
for _, m := range inboxResult.Messages {
if m.Body == "hey @agent-b check this" {
var meta map[string]any
json.Unmarshal(m.Metadata, &meta)
@@ -666,9 +666,9 @@ func TestService_BroadcastMessage_Mentions(t *testing.T) {
t.Fatalf("BroadcastMessage: %v", err)
}
channelMsgs, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10)
channelResult2, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10, 0)
found := false
for _, m := range channelMsgs {
for _, m := range channelResult2.Messages {
if m.Body == "cc @agent-b and @agent-c" {
found = true
var meta map[string]any
@@ -696,8 +696,8 @@ func TestService_BroadcastMessage_Mentions(t *testing.T) {
t.Fatalf("BroadcastMessage: %v", err)
}
channelMsgs, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10)
for _, m := range channelMsgs {
channelResult3, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10, 0)
for _, m := range channelResult3.Messages {
if m.Body == "I am @agent-a and cc @agent-b" {
var meta map[string]any
json.Unmarshal(m.Metadata, &meta)
@@ -721,8 +721,8 @@ func TestService_BroadcastMessage_Mentions(t *testing.T) {
t.Fatalf("BroadcastMessage: %v", err)
}
channelMsgs, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10)
for _, m := range channelMsgs {
channelResult4, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10, 0)
for _, m := range channelResult4.Messages {
if m.Body == "just a normal message" {
var meta map[string]any
json.Unmarshal(m.Metadata, &meta)
@@ -741,8 +741,8 @@ func TestService_BroadcastMessage_Mentions(t *testing.T) {
t.Fatalf("BroadcastMessage: %v", err)
}
channelMsgs, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10)
for _, m := range channelMsgs {
channelResult5, _ := svc.msgService.GetChannelMessages(ctx, ch.ID, 10, 0)
for _, m := range channelResult5.Messages {
if m.Body == "hey @outsider and @agent-b" {
var meta map[string]any
json.Unmarshal(m.Metadata, &meta)
+27 -3
View File
@@ -6,6 +6,7 @@ import (
"fmt"
"log/slog"
"strings"
"time"
)
// ChannelStore defines the storage interface for channel operations.
@@ -14,6 +15,7 @@ type ChannelStore interface {
GetChannel(ctx context.Context, id int64) (*Channel, error)
GetChannelByName(ctx context.Context, name string) (*Channel, error)
ListChannels(ctx context.Context, agentName string) ([]*Channel, error)
CountChannels(ctx context.Context, agentName string) (int, error)
UpdateChannel(ctx context.Context, ch *Channel) error
DeleteChannel(ctx context.Context, id int64) error
AddMember(ctx context.Context, m *Membership) error
@@ -148,6 +150,23 @@ func (s *SQLiteChannelStore) ListChannels(ctx context.Context, agentName string)
return channels, rows.Err()
}
// CountChannels returns the total number of channels visible to the agent.
func (s *SQLiteChannelStore) CountChannels(ctx context.Context, agentName string) (int, error) {
var count int
err := s.db.QueryRowContext(ctx,
`SELECT COUNT(DISTINCT c.id)
FROM channels c
WHERE c.is_private = 0
OR EXISTS (SELECT 1 FROM channel_members cm WHERE cm.channel_id = c.id AND cm.agent_name = ?)
OR EXISTS (SELECT 1 FROM channel_invites ci WHERE ci.channel_id = c.id AND ci.agent_name = ? AND ci.status = 'pending')`,
agentName, agentName,
).Scan(&count)
if err != nil {
return 0, fmt.Errorf("count channels: %w", err)
}
return count, nil
}
// UpdateChannel updates a channel's mutable fields.
func (s *SQLiteChannelStore) UpdateChannel(ctx context.Context, ch *Channel) error {
result, err := s.db.ExecContext(ctx,
@@ -362,6 +381,7 @@ func (s *SQLiteChannelStore) GetChannelSummaries(ctx context.Context, agentName
WHERE ist.agent_name = ? AND ist.conversation_id = m.conversation_id), 0)
AND m.from_agent != ?
) AS unread_count,
COALESCE((SELECT MAX(m3.id) FROM messages m3 WHERE m3.channel_id = c.id), 0) AS last_message_id,
(SELECT MAX(m2.created_at) FROM messages m2 WHERE m2.channel_id = c.id) AS last_message_at
FROM channels c
JOIN channel_members cm ON cm.channel_id = c.id AND cm.agent_name = ?
@@ -376,12 +396,16 @@ func (s *SQLiteChannelStore) GetChannelSummaries(ctx context.Context, agentName
var summaries []ChannelSummary
for rows.Next() {
var cs ChannelSummary
var lastMsg sql.NullTime
if err := rows.Scan(&cs.ID, &cs.Name, &cs.UnreadCount, &lastMsg); err != nil {
var lastMsg sql.NullString
if err := rows.Scan(&cs.ID, &cs.Name, &cs.UnreadCount, &cs.LastMessageID, &lastMsg); err != nil {
return nil, fmt.Errorf("scan channel summary: %w", err)
}
if lastMsg.Valid {
cs.LastMessageAt = &lastMsg.Time
if t, err := time.Parse("2006-01-02T15:04:05Z", lastMsg.String); err == nil {
cs.LastMessageAt = &t
} else if t, err := time.Parse("2006-01-02 15:04:05", lastMsg.String); err == nil {
cs.LastMessageAt = &t
}
}
summaries = append(summaries, cs)
}
+35
View File
@@ -266,6 +266,41 @@ func (s *SwarmService) ListTasks(ctx context.Context, channelID int64, status st
return s.taskStore.ListTasks(ctx, channelID, status)
}
// ListTasksPaginated returns tasks for a channel with pagination.
func (s *SwarmService) ListTasksPaginated(ctx context.Context, channelID int64, status string, limit, offset int) (*PaginatedTasks, error) {
tasks, err := s.taskStore.ListTasks(ctx, channelID, status)
if err != nil {
return nil, err
}
total := len(tasks)
if limit <= 0 {
limit = 50
}
if offset < 0 {
offset = 0
}
// Apply pagination in memory (task lists are typically small)
start := offset
if start > total {
start = total
}
end := start + limit
if end > total {
end = total
}
page := tasks[start:end]
return &PaginatedTasks{
Tasks: page,
Total: total,
Offset: offset,
Limit: limit,
}, nil
}
// GetTaskWithBids returns a task and all its bids.
func (s *SwarmService) GetTaskWithBids(ctx context.Context, taskID int64) (*Task, []*Bid, error) {
task, err := s.taskStore.GetTask(ctx, taskID)
+23
View File
@@ -14,6 +14,7 @@ type TaskStore interface {
CreateTask(ctx context.Context, task *Task) error
GetTask(ctx context.Context, id int64) (*Task, error)
ListTasks(ctx context.Context, channelID int64, status string) ([]*Task, error)
CountTasks(ctx context.Context, channelID int64, status string) (int, error)
UpdateTaskStatus(ctx context.Context, id int64, status, assignedTo string) error
CreateBid(ctx context.Context, bid *Bid) error
GetBids(ctx context.Context, taskID int64) ([]*Bid, error)
@@ -130,6 +131,28 @@ func (s *SQLiteTaskStore) ListTasks(ctx context.Context, channelID int64, status
return scanTasks(rows)
}
// CountTasks returns the total number of tasks for a channel, optionally filtered by status.
func (s *SQLiteTaskStore) CountTasks(ctx context.Context, channelID int64, status string) (int, error) {
var count int
var err error
if status != "" {
err = s.db.QueryRowContext(ctx,
`SELECT COUNT(*) FROM tasks WHERE channel_id = ? AND status = ?`,
channelID, status,
).Scan(&count)
} else {
err = s.db.QueryRowContext(ctx,
`SELECT COUNT(*) FROM tasks WHERE channel_id = ?`,
channelID,
).Scan(&count)
}
if err != nil {
return 0, fmt.Errorf("count tasks: %w", err)
}
return count, nil
}
// UpdateTaskStatus updates a task's status and optionally assigned_to.
func (s *SQLiteTaskStore) UpdateTaskStatus(ctx context.Context, id int64, status, assignedTo string) error {
var result sql.Result
+22
View File
@@ -43,6 +43,28 @@ type ChannelWithCount struct {
MemberCount int `json:"member_count"`
}
// PaginatedChannels holds a page of channels with total count.
type PaginatedChannels struct {
Channels []*ChannelWithCount `json:"channels"`
Total int `json:"total"`
Offset int `json:"offset"`
Limit int `json:"limit"`
}
// ListChannelsOptions configures channel listing behavior.
type ListChannelsOptions struct {
Limit int `json:"limit,omitempty"`
Offset int `json:"offset,omitempty"`
}
// PaginatedTasks holds a page of tasks with total count.
type PaginatedTasks struct {
Tasks []*Task `json:"tasks"`
Total int `json:"total"`
Offset int `json:"offset"`
Limit int `json:"limit"`
}
// Membership represents the relationship between an agent and a channel.
type Membership struct {
ID int64 `json:"id"`
+83
View File
@@ -0,0 +1,83 @@
package jsruntime
import (
"context"
"fmt"
"sync"
)
// Pool manages a pool of reusable goja VMs for concurrent JavaScript execution.
// Each Execute call acquires a VM from the pool, runs the code, then releases
// the VM back. If all VMs are in use, callers block until one becomes available
// or the context is cancelled.
type Pool struct {
size int
available chan struct{} // semaphore — each token represents a "slot"
mu sync.Mutex
closed bool
}
// NewPool creates a new runtime pool with the given concurrency limit.
// The size determines how many concurrent Execute calls can run simultaneously.
func NewPool(size int) *Pool {
if size < 1 {
size = 1
}
p := &Pool{
size: size,
available: make(chan struct{}, size),
}
// Fill the semaphore
for i := 0; i < size; i++ {
p.available <- struct{}{}
}
return p
}
// Execute acquires a slot from the pool, runs the code, and releases the slot.
// A fresh goja VM is created for each execution to ensure clean state isolation.
// Blocks if all slots are in use; respects context cancellation.
func (p *Pool) Execute(ctx context.Context, code string, caller ToolCaller, opts ExecuteOptions) (*ExecuteResult, error) {
p.mu.Lock()
if p.closed {
p.mu.Unlock()
return nil, fmt.Errorf("pool is closed")
}
p.mu.Unlock()
// Acquire a slot (blocks if pool is exhausted)
select {
case <-p.available:
// Got a slot
case <-ctx.Done():
return nil, ctx.Err()
}
// Always release the slot when done
defer func() {
p.available <- struct{}{}
}()
// Execute with a fresh VM (created inside Execute)
return Execute(ctx, code, caller, opts)
}
// Size returns the configured pool size.
func (p *Pool) Size() int {
return p.size
}
// Available returns the number of available slots.
func (p *Pool) Available() int {
return len(p.available)
}
// Close marks the pool as closed. Subsequent Execute calls will return an error.
func (p *Pool) Close() {
p.mu.Lock()
defer p.mu.Unlock()
p.closed = true
}
+189
View File
@@ -0,0 +1,189 @@
package jsruntime
import (
"context"
"sync"
"sync/atomic"
"testing"
"time"
)
func TestNewPool(t *testing.T) {
p := NewPool(5)
if p.Size() != 5 {
t.Errorf("expected size 5, got %d", p.Size())
}
if p.Available() != 5 {
t.Errorf("expected 5 available, got %d", p.Available())
}
}
func TestNewPool_MinSize(t *testing.T) {
p := NewPool(0)
if p.Size() != 1 {
t.Errorf("expected size clamped to 1, got %d", p.Size())
}
p2 := NewPool(-5)
if p2.Size() != 1 {
t.Errorf("expected size clamped to 1, got %d", p2.Size())
}
}
func TestPool_Execute(t *testing.T) {
p := NewPool(3)
defer p.Close()
caller := newMockCaller()
result, err := p.Execute(context.Background(), `42`, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
var num int64
switch v := result.Value.(type) {
case int64:
num = v
case float64:
num = int64(v)
}
if num != 42 {
t.Errorf("expected 42, got %v", result.Value)
}
}
func TestPool_ConcurrentExecution(t *testing.T) {
poolSize := 3
p := NewPool(poolSize)
defer p.Close()
numGoroutines := 20
var wg sync.WaitGroup
var successCount int32
var errCount int32
for i := 0; i < numGoroutines; i++ {
wg.Add(1)
go func(idx int) {
defer wg.Done()
caller := newMockCaller()
result, err := p.Execute(context.Background(), `({ value: 1 })`, caller, ExecuteOptions{})
if err != nil {
atomic.AddInt32(&errCount, 1)
return
}
if result != nil {
atomic.AddInt32(&successCount, 1)
}
}(i)
}
wg.Wait()
if int(errCount) > 0 {
t.Errorf("expected 0 errors, got %d", errCount)
}
if int(successCount) != numGoroutines {
t.Errorf("expected %d successes, got %d", numGoroutines, successCount)
}
// All slots should be available again
if p.Available() != poolSize {
t.Errorf("expected %d available after all complete, got %d", poolSize, p.Available())
}
}
func TestPool_BlocksWhenExhausted(t *testing.T) {
p := NewPool(1)
defer p.Close()
// Occupy the only slot with a long-running script
started := make(chan struct{})
done := make(chan struct{})
go func() {
caller := newMockCaller()
close(started)
p.Execute(context.Background(), `
var i = 0;
while(i < 1000000) { i++; }
i
`, caller, ExecuteOptions{})
close(done)
}()
<-started
// Give the goroutine a moment to acquire the slot
time.Sleep(10 * time.Millisecond)
// Try to execute with a short timeout — should fail because the slot is occupied
ctx, cancel := context.WithTimeout(context.Background(), 50*time.Millisecond)
defer cancel()
caller := newMockCaller()
_, err := p.Execute(ctx, `42`, caller, ExecuteOptions{})
if err == nil {
t.Error("expected context deadline error when pool is exhausted, got nil")
}
// Wait for first execution to finish
<-done
}
func TestPool_ClosedPoolRejectsExecute(t *testing.T) {
p := NewPool(3)
p.Close()
caller := newMockCaller()
_, err := p.Execute(context.Background(), `42`, caller, ExecuteOptions{})
if err == nil {
t.Error("expected error from closed pool, got nil")
}
}
func TestPool_WithCallBridge(t *testing.T) {
p := NewPool(2)
defer p.Close()
caller := newMockCaller()
caller.results["greet"] = map[string]any{"greeting": "hello"}
code := `
var res = call("greet", { name: "world" });
res.ok ? res.result.greeting : "error"
`
result, err := p.Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if result.Value != "hello" {
t.Errorf("expected 'hello', got %v", result.Value)
}
if result.CallCount != 1 {
t.Errorf("expected CallCount=1, got %d", result.CallCount)
}
}
func TestPool_IsolationBetweenExecutions(t *testing.T) {
p := NewPool(1)
defer p.Close()
caller := newMockCaller()
// First execution sets a variable
_, err := p.Execute(context.Background(), `var shared = 42; shared`, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("first execution failed: %v", err)
}
// Second execution should not see the variable from the first
_, err = p.Execute(context.Background(), `
typeof shared === "undefined" ? "isolated" : "leaked"
`, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("second execution failed: %v", err)
}
// Note: since Execute creates a fresh VM each time, isolation is guaranteed
}
+273
View File
@@ -0,0 +1,273 @@
package jsruntime
import (
"context"
"encoding/json"
"fmt"
"log/slog"
"sync/atomic"
"time"
"github.com/dop251/goja"
)
// Execute runs JavaScript or TypeScript code in a sandboxed goja VM.
//
// If the code looks like TypeScript (contains type annotations, interfaces,
// generics, etc.), it is automatically transpiled to JavaScript before execution.
//
// A global `call(actionName, args)` function is provided that bridges to the
// supplied ToolCaller. It returns {ok: true, result: ...} or {ok: false, error: ...}.
//
// The value of the last expression in the code is returned as ExecuteResult.Value.
func Execute(ctx context.Context, code string, caller ToolCaller, opts ExecuteOptions) (*ExecuteResult, error) {
opts = opts.defaults()
start := time.Now()
// Auto-detect and transpile TypeScript
if looksLikeTypeScript(code) {
transpiled, err := TranspileTypeScript(code)
if err != nil {
return nil, err
}
code = transpiled
}
// Handle empty code
if len(code) == 0 {
return &ExecuteResult{
Value: nil,
CallCount: 0,
Duration: time.Since(start),
}, nil
}
// Create VM and set up sandbox
vm := goja.New()
setupSandbox(vm)
// Track call count
var callCount int32
// Register call() global function
callFn := makeCallFunction(ctx, vm, caller, opts.MaxCalls, &callCount)
if err := vm.Set("call", callFn); err != nil {
return nil, &ExecError{
Code: CodeRuntimeError,
Message: fmt.Sprintf("failed to register call() function: %v", err),
}
}
// Set up timeout via context
timeoutCtx, cancel := context.WithTimeout(ctx, opts.Timeout)
defer cancel()
// Run in a goroutine so we can enforce timeout
type execResult struct {
value goja.Value
err error
}
resultCh := make(chan execResult, 1)
go func() {
// Compile first to get better syntax error reporting
prog, compileErr := goja.Compile("", code, false)
if compileErr != nil {
resultCh <- execResult{err: compileErr}
return
}
val, runErr := vm.RunProgram(prog)
resultCh <- execResult{value: val, err: runErr}
}()
// Monitor for timeout — interrupt the VM
go func() {
<-timeoutCtx.Done()
if timeoutCtx.Err() == context.DeadlineExceeded {
vm.Interrupt("execution timeout")
}
}()
select {
case res := <-resultCh:
duration := time.Since(start)
if res.err != nil {
return nil, classifyError(res.err)
}
// Export result
exported := res.value.Export()
// Validate JSON serializability
if err := validateSerializable(exported); err != nil {
return nil, &ExecError{
Code: CodeRuntimeError,
Message: fmt.Sprintf("result is not JSON-serializable: %v", err),
}
}
return &ExecuteResult{
Value: exported,
CallCount: int(atomic.LoadInt32(&callCount)),
Duration: duration,
}, nil
case <-timeoutCtx.Done():
vm.Interrupt("execution timeout")
return nil, &ExecError{
Code: CodeTimeout,
Message: fmt.Sprintf("execution exceeded timeout of %s", opts.Timeout),
}
}
}
// setupSandbox disables dangerous global APIs in the VM.
func setupSandbox(vm *goja.Runtime) {
// Disable module loading
vm.Set("require", goja.Undefined())
vm.Set("import", goja.Undefined())
// Disable async operations
vm.Set("setTimeout", goja.Undefined())
vm.Set("setInterval", goja.Undefined())
vm.Set("clearTimeout", goja.Undefined())
vm.Set("clearInterval", goja.Undefined())
// Disable network access
vm.Set("fetch", goja.Undefined())
vm.Set("XMLHttpRequest", goja.Undefined())
// Disable process/system access
vm.Set("process", goja.Undefined())
// Note: goja does not provide filesystem or network access by default,
// so we only need to block APIs that could be expected by JS code.
}
// makeCallFunction creates the call(actionName, args) bridge function.
func makeCallFunction(
ctx context.Context,
vm *goja.Runtime,
caller ToolCaller,
maxCalls int,
callCount *int32,
) func(goja.FunctionCall) goja.Value {
return func(fc goja.FunctionCall) goja.Value {
// Validate arguments
if len(fc.Arguments) < 2 {
return vm.ToValue(map[string]any{
"ok": false,
"error": map[string]any{
"code": "INVALID_ARGS",
"message": "call() requires 2 arguments: actionName (string), args (object)",
},
})
}
// Extract and validate actionName
actionName := fc.Arguments[0].String()
if actionName == "" || actionName == "undefined" {
return vm.ToValue(map[string]any{
"ok": false,
"error": map[string]any{
"code": "INVALID_ARGS",
"message": "actionName must be a non-empty string",
},
})
}
// Extract and validate args
argsExported := fc.Arguments[1].Export()
args, ok := argsExported.(map[string]any)
if !ok {
return vm.ToValue(map[string]any{
"ok": false,
"error": map[string]any{
"code": "INVALID_ARGS",
"message": "args must be an object",
},
})
}
// Enforce MaxCalls limit
count := atomic.AddInt32(callCount, 1)
if int(count) > maxCalls {
return vm.ToValue(map[string]any{
"ok": false,
"error": map[string]any{
"code": CodeMaxCallsExceeded,
"message": fmt.Sprintf("exceeded maximum of %d call() invocations", maxCalls),
},
})
}
// Bridge to ToolCaller with context propagation
result, err := caller.Call(ctx, actionName, args)
if err != nil {
slog.Warn("call() bridge error",
"action", actionName,
"error", err,
)
return vm.ToValue(map[string]any{
"ok": false,
"error": map[string]any{
"code": "CALL_ERROR",
"message": err.Error(),
},
})
}
return vm.ToValue(map[string]any{
"ok": true,
"result": result,
})
}
}
// classifyError converts a goja error into a structured ExecError.
func classifyError(err error) *ExecError {
if err == nil {
return nil
}
// Check for interrupt (timeout)
if interrupted, ok := err.(*goja.InterruptedError); ok {
return &ExecError{
Code: CodeTimeout,
Message: interrupted.Error(),
}
}
// Check for syntax error from compilation
if syntaxErr, ok := err.(*goja.CompilerSyntaxError); ok {
return &ExecError{
Code: CodeSyntaxError,
Message: syntaxErr.Error(),
}
}
// Check for JS exception (runtime error)
if exception, ok := err.(*goja.Exception); ok {
return &ExecError{
Code: CodeRuntimeError,
Message: exception.Error(),
Stack: exception.String(),
}
}
// Generic error
return &ExecError{
Code: CodeRuntimeError,
Message: err.Error(),
}
}
// validateSerializable checks whether the value can be marshaled to JSON.
func validateSerializable(value any) error {
if value == nil {
return nil
}
_, err := json.Marshal(value)
return err
}
+524
View File
@@ -0,0 +1,524 @@
package jsruntime
import (
"context"
"fmt"
"testing"
"time"
)
// mockCaller implements ToolCaller for testing.
type mockCaller struct {
calls []mockCall
results map[string]any
errors map[string]error
}
type mockCall struct {
Action string
Args map[string]any
}
func newMockCaller() *mockCaller {
return &mockCaller{
results: make(map[string]any),
errors: make(map[string]error),
}
}
func (m *mockCaller) Call(_ context.Context, actionName string, args map[string]any) (any, error) {
m.calls = append(m.calls, mockCall{Action: actionName, Args: args})
if err, ok := m.errors[actionName]; ok {
return nil, err
}
if result, ok := m.results[actionName]; ok {
return result, nil
}
return map[string]any{"ok": true}, nil
}
func TestExecute(t *testing.T) {
tests := []struct {
name string
code string
opts ExecuteOptions
wantValue any
wantErr string // substring match on error code
}{
{
name: "simple integer",
code: `42`,
wantValue: int64(42),
},
{
name: "simple string",
code: `"hello"`,
wantValue: "hello",
},
{
name: "object literal",
code: `({ a: 1, b: "two" })`,
},
{
name: "arithmetic expression",
code: `2 + 3 * 4`,
},
{
name: "null value",
code: `null`,
wantValue: nil,
},
{
name: "array",
code: `[1, 2, 3]`,
},
{
name: "boolean true",
code: `true`,
wantValue: true,
},
{
name: "boolean false",
code: `false`,
wantValue: false,
},
{
name: "empty code",
code: "",
wantValue: nil,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
caller := newMockCaller()
result, err := Execute(context.Background(), tt.code, caller, tt.opts)
if tt.wantErr != "" {
if err == nil {
t.Fatalf("expected error containing %q, got nil", tt.wantErr)
}
execErr, ok := err.(*ExecError)
if !ok {
t.Fatalf("expected *ExecError, got %T: %v", err, err)
}
if execErr.Code != tt.wantErr {
t.Errorf("expected error code %q, got %q", tt.wantErr, execErr.Code)
}
return
}
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if tt.wantValue != nil && result.Value != tt.wantValue {
t.Errorf("expected value %v (%T), got %v (%T)", tt.wantValue, tt.wantValue, result.Value, result.Value)
}
})
}
}
func TestExecute_SyntaxError(t *testing.T) {
caller := newMockCaller()
_, err := Execute(context.Background(), `{ invalid syntax`, caller, ExecuteOptions{})
if err == nil {
t.Fatal("expected syntax error, got nil")
}
execErr, ok := err.(*ExecError)
if !ok {
t.Fatalf("expected *ExecError, got %T", err)
}
if execErr.Code != CodeSyntaxError {
t.Errorf("expected code %q, got %q", CodeSyntaxError, execErr.Code)
}
}
func TestExecute_RuntimeError(t *testing.T) {
caller := newMockCaller()
_, err := Execute(context.Background(), `throw new Error("boom")`, caller, ExecuteOptions{})
if err == nil {
t.Fatal("expected runtime error, got nil")
}
execErr, ok := err.(*ExecError)
if !ok {
t.Fatalf("expected *ExecError, got %T", err)
}
if execErr.Code != CodeRuntimeError {
t.Errorf("expected code %q, got %q", CodeRuntimeError, execErr.Code)
}
if execErr.Stack == "" {
t.Error("expected non-empty stack trace for runtime error")
}
}
func TestExecute_Timeout(t *testing.T) {
caller := newMockCaller()
start := time.Now()
_, err := Execute(context.Background(), `while(true) {}`, caller, ExecuteOptions{
Timeout: 100 * time.Millisecond,
})
elapsed := time.Since(start)
if err == nil {
t.Fatal("expected timeout error, got nil")
}
execErr, ok := err.(*ExecError)
if !ok {
t.Fatalf("expected *ExecError, got %T", err)
}
if execErr.Code != CodeTimeout {
t.Errorf("expected code %q, got %q", CodeTimeout, execErr.Code)
}
// Should complete within a reasonable margin of the timeout
if elapsed > 2*time.Second {
t.Errorf("timeout took too long: %v", elapsed)
}
}
func TestExecute_CallBridge(t *testing.T) {
caller := newMockCaller()
caller.results["get_user"] = map[string]any{
"name": "alice",
"id": 42,
}
code := `
var res = call("get_user", { id: 1 });
if (!res.ok) throw new Error("failed");
({ name: res.result.name })
`
result, err := Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(caller.calls) != 1 {
t.Fatalf("expected 1 call, got %d", len(caller.calls))
}
if caller.calls[0].Action != "get_user" {
t.Errorf("expected action 'get_user', got %q", caller.calls[0].Action)
}
if result.CallCount != 1 {
t.Errorf("expected CallCount=1, got %d", result.CallCount)
}
resultMap, ok := result.Value.(map[string]any)
if !ok {
t.Fatalf("expected map result, got %T", result.Value)
}
if resultMap["name"] != "alice" {
t.Errorf("expected name='alice', got %v", resultMap["name"])
}
}
func TestExecute_CallBridgeError(t *testing.T) {
caller := newMockCaller()
caller.errors["fail_action"] = fmt.Errorf("upstream error")
code := `
var res = call("fail_action", {});
({ ok: res.ok, code: res.error.code })
`
result, err := Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
resultMap := result.Value.(map[string]any)
if resultMap["ok"] != false {
t.Errorf("expected ok=false, got %v", resultMap["ok"])
}
if resultMap["code"] != "CALL_ERROR" {
t.Errorf("expected code='CALL_ERROR', got %v", resultMap["code"])
}
}
func TestExecute_CallInvalidArgs(t *testing.T) {
tests := []struct {
name string
code string
}{
{"no arguments", `call()`},
{"one argument", `call("action")`},
{"args not object", `call("action", "not_an_object")`},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
caller := newMockCaller()
code := fmt.Sprintf(`
var res = %s;
({ ok: res.ok, code: res.error.code })
`, tt.code)
result, err := Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
resultMap := result.Value.(map[string]any)
if resultMap["ok"] != false {
t.Errorf("expected ok=false, got %v", resultMap["ok"])
}
if resultMap["code"] != "INVALID_ARGS" {
t.Errorf("expected code='INVALID_ARGS', got %v", resultMap["code"])
}
})
}
}
func TestExecute_MaxCalls(t *testing.T) {
caller := newMockCaller()
caller.results["action"] = "ok"
code := `
var results = [];
for (var i = 0; i < 10; i++) {
var res = call("action", {});
results.push({ ok: res.ok, code: res.error ? res.error.code : null });
}
({ results: results, total: results.length })
`
result, err := Execute(context.Background(), code, caller, ExecuteOptions{
MaxCalls: 3,
})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
// Only 3 calls should have succeeded upstream
if len(caller.calls) != 3 {
t.Errorf("expected 3 upstream calls, got %d", len(caller.calls))
}
resultMap := result.Value.(map[string]any)
results := resultMap["results"].([]any)
// First 3 should be ok, rest should be MAX_CALLS_EXCEEDED
for i, r := range results {
rm := r.(map[string]any)
if i < 3 {
if rm["ok"] != true {
t.Errorf("call %d: expected ok=true, got %v", i, rm["ok"])
}
} else {
if rm["ok"] != false {
t.Errorf("call %d: expected ok=false, got %v", i, rm["ok"])
}
if rm["code"] != CodeMaxCallsExceeded {
t.Errorf("call %d: expected code=%q, got %v", i, CodeMaxCallsExceeded, rm["code"])
}
}
}
}
func TestExecute_MultipleCallsInLoop(t *testing.T) {
caller := newMockCaller()
caller.results["add"] = map[string]any{"sum": 10}
code := `
var total = 0;
for (var i = 0; i < 5; i++) {
var res = call("add", { a: i, b: 1 });
if (res.ok) total++;
}
({ total: total })
`
result, err := Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(caller.calls) != 5 {
t.Fatalf("expected 5 calls, got %d", len(caller.calls))
}
if result.CallCount != 5 {
t.Errorf("expected CallCount=5, got %d", result.CallCount)
}
}
func TestExecute_SandboxBlockedAPIs(t *testing.T) {
blockedAPIs := []struct {
name string
code string
}{
{"require", `require("fs")`},
{"fetch", `fetch("http://example.com")`},
{"setTimeout", `setTimeout(function(){}, 100)`},
{"setInterval", `setInterval(function(){}, 100)`},
{"clearTimeout", `clearTimeout(1)`},
{"clearInterval", `clearInterval(1)`},
{"XMLHttpRequest", `new XMLHttpRequest()`},
{"process.env", `process.env.HOME`},
}
for _, tt := range blockedAPIs {
t.Run(tt.name, func(t *testing.T) {
caller := newMockCaller()
result, err := Execute(context.Background(), tt.code, caller, ExecuteOptions{})
// Should either error or return undefined (not execute the blocked API)
if err == nil && result.Ok() {
// If it succeeds, the value should be undefined/nil (the API was replaced with undefined)
// This is acceptable — the key thing is the API doesn't actually work
t.Logf("%s returned: %v (blocked by sandbox)", tt.name, result.Value)
}
})
}
}
// Ok is a helper for test assertions.
func (r *ExecuteResult) Ok() bool {
return r != nil
}
func TestExecute_TypeScriptAutoDetect(t *testing.T) {
caller := newMockCaller()
code := `const x: number = 42; const msg: string = "hello"; ({ result: x, message: msg })`
result, err := Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
resultMap, ok := result.Value.(map[string]any)
if !ok {
t.Fatalf("expected map, got %T", result.Value)
}
// goja exports numbers as int64 or float64
var num int64
switch v := resultMap["result"].(type) {
case int64:
num = v
case float64:
num = int64(v)
default:
t.Fatalf("expected numeric result, got %T", resultMap["result"])
}
if num != 42 {
t.Errorf("expected 42, got %d", num)
}
if resultMap["message"] != "hello" {
t.Errorf("expected 'hello', got %v", resultMap["message"])
}
}
func TestExecute_TypeScriptWithInterface(t *testing.T) {
caller := newMockCaller()
caller.results["get_data"] = map[string]any{"value": 99}
code := `
interface Result {
ok: boolean;
result?: any;
error?: any;
}
const res: Result = call("get_data", { key: "test" });
if (!res.ok) throw new Error("failed");
({ data: res.result })
`
result, err := Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if len(caller.calls) != 1 {
t.Fatalf("expected 1 call, got %d", len(caller.calls))
}
resultMap := result.Value.(map[string]any)
data := resultMap["data"].(map[string]any)
// Values passed through the call() bridge preserve their Go types
var val int64
switch v := data["value"].(type) {
case int:
val = int64(v)
case int64:
val = v
case float64:
val = int64(v)
}
if val != 99 {
t.Errorf("expected value=99, got %v", data["value"])
}
}
func TestExecute_PlainJSNotTranspiled(t *testing.T) {
// Plain JS should work without transpilation
caller := newMockCaller()
code := `var x = 42; x`
result, err := Execute(context.Background(), code, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
var num int64
switch v := result.Value.(type) {
case int64:
num = v
case float64:
num = int64(v)
}
if num != 42 {
t.Errorf("expected 42, got %v", result.Value)
}
}
func TestExecute_Duration(t *testing.T) {
caller := newMockCaller()
result, err := Execute(context.Background(), `42`, caller, ExecuteOptions{})
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if result.Duration <= 0 {
t.Error("expected positive duration")
}
}
func TestExecute_ContextCancellation(t *testing.T) {
caller := newMockCaller()
ctx, cancel := context.WithCancel(context.Background())
cancel() // Cancel immediately
_, err := Execute(ctx, `while(true) {}`, caller, ExecuteOptions{
Timeout: 5 * time.Second,
})
if err == nil {
t.Fatal("expected error from cancelled context")
}
}
func TestExecError_Error(t *testing.T) {
tests := []struct {
name string
err ExecError
contains string
}{
{
name: "without stack",
err: ExecError{Code: CodeSyntaxError, Message: "unexpected token"},
contains: "SYNTAX_ERROR: unexpected token",
},
{
name: "with stack",
err: ExecError{Code: CodeRuntimeError, Message: "boom", Stack: "at line 1"},
contains: "at line 1",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
msg := tt.err.Error()
if msg == "" {
t.Error("expected non-empty error message")
}
})
}
}
+67
View File
@@ -0,0 +1,67 @@
package jsruntime
import (
"context"
"fmt"
"time"
)
// ToolCaller is implemented by the action registry to bridge call() invocations
// from JavaScript code to the host application.
type ToolCaller interface {
Call(ctx context.Context, actionName string, args map[string]any) (any, error)
}
// ExecuteOptions configures a single code execution.
type ExecuteOptions struct {
Timeout time.Duration // Maximum execution time. Default 120s.
MaxCalls int // Maximum number of call() invocations. Default 50.
MaxMemoryMB int // Memory limit hint in MB. Default 128.
}
// defaults fills in zero-value fields with sensible defaults.
func (o ExecuteOptions) defaults() ExecuteOptions {
if o.Timeout <= 0 {
o.Timeout = 120 * time.Second
}
if o.MaxCalls <= 0 {
o.MaxCalls = 50
}
if o.MaxMemoryMB <= 0 {
o.MaxMemoryMB = 128
}
return o
}
// ExecuteResult holds the output of a successful execution.
type ExecuteResult struct {
Value any // Final expression value (JSON-serializable)
CallCount int // Number of call() invocations made
Duration time.Duration // Wall-clock execution time
}
// ExecError wraps execution errors with structured context.
type ExecError struct {
Code string // SYNTAX_ERROR, RUNTIME_ERROR, TIMEOUT, MAX_CALLS_EXCEEDED, TRANSPILE_ERROR
Message string // Human-readable error description
Stack string // JS stack trace if available
Line int // Source line if available
Column int // Source column if available
}
// Error implements the error interface.
func (e *ExecError) Error() string {
if e.Stack != "" {
return fmt.Sprintf("%s: %s\n%s", e.Code, e.Message, e.Stack)
}
return fmt.Sprintf("%s: %s", e.Code, e.Message)
}
// Error code constants.
const (
CodeSyntaxError = "SYNTAX_ERROR"
CodeRuntimeError = "RUNTIME_ERROR"
CodeTimeout = "TIMEOUT"
CodeMaxCallsExceeded = "MAX_CALLS_EXCEEDED"
CodeTranspileError = "TRANSPILE_ERROR"
)
+78
View File
@@ -0,0 +1,78 @@
package jsruntime
import (
"fmt"
"strings"
"github.com/evanw/esbuild/pkg/api"
)
// TranspileTypeScript transpiles TypeScript code to JavaScript using esbuild.
// It performs type-stripping only (no bundling, no type checking).
// Target is ES2020 for compatibility with goja.
func TranspileTypeScript(code string) (string, error) {
result := api.Transform(code, api.TransformOptions{
Loader: api.LoaderTS,
Target: api.ES2020,
})
if len(result.Errors) > 0 {
msg := result.Errors[0]
e := &ExecError{
Code: CodeTranspileError,
Message: fmt.Sprintf("TypeScript transpilation failed: %s", msg.Text),
}
if msg.Location != nil {
e.Line = msg.Location.Line
e.Column = msg.Location.Column
e.Message = fmt.Sprintf("TypeScript transpilation failed at line %d, column %d: %s",
msg.Location.Line, msg.Location.Column, msg.Text)
}
return "", e
}
return string(result.Code), nil
}
// looksLikeTypeScript uses simple heuristics to detect TypeScript code.
// It checks for common TypeScript-only syntax patterns.
func looksLikeTypeScript(code string) bool {
// Check for type annotations like `: string`, `: number`, `: boolean`, `: any`
typeAnnotationPatterns := []string{
": string",
": number",
": boolean",
": any",
": void",
": never",
": unknown",
}
for _, pattern := range typeAnnotationPatterns {
if strings.Contains(code, pattern) {
return true
}
}
// Check for interface declarations
if strings.Contains(code, "interface ") && strings.Contains(code, "{") {
return true
}
// Check for type aliases
if strings.Contains(code, "type ") && strings.Contains(code, "=") {
return true
}
// Check for generic type parameters like <T> or <T,U>
// Simple heuristic: look for <identifier> patterns not preceded by comparison operators
if strings.Contains(code, "<T>") || strings.Contains(code, "<T,") || strings.Contains(code, "<T ") {
return true
}
// Check for 'as' type assertions
if strings.Contains(code, " as ") {
return true
}
return false
}
+145
View File
@@ -0,0 +1,145 @@
package jsruntime
import (
"strings"
"testing"
)
func TestTranspileTypeScript(t *testing.T) {
tests := []struct {
name string
code string
wantContain string // substring that must be in the output
wantAbsent string // substring that must NOT be in the output
wantErr bool
}{
{
name: "basic type annotation",
code: `const x: number = 42; x;`,
wantContain: "42",
wantAbsent: ": number",
},
{
name: "interface removed",
code: "interface User { name: string; age: number; }\nconst u: User = { name: \"Alice\", age: 30 }; u;",
wantContain: "Alice",
wantAbsent: "interface",
},
{
name: "generics stripped",
code: "function identity<T>(arg: T): T { return arg; }\nconst r = identity<number>(42); r;",
wantContain: "42",
wantAbsent: "<T>",
},
{
name: "enum produces JS",
code: "enum Dir { Up = \"UP\", Down = \"DOWN\" }\nconst d: Dir = Dir.Up; d;",
wantContain: "UP",
wantAbsent: ": Dir",
},
{
name: "type alias removed",
code: "type ID = string | number;\nconst id: ID = \"abc\"; id;",
wantContain: "abc",
wantAbsent: "type ID",
},
{
name: "as expression stripped",
code: `const x = (42 as number); x;`,
wantContain: "42",
},
{
name: "plain JS passthrough",
code: `var x = 42; x;`,
wantContain: "42",
},
{
name: "empty code",
code: "",
wantContain: "",
},
{
name: "invalid code",
code: `const x: number = ;`,
wantErr: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result, err := TranspileTypeScript(tt.code)
if tt.wantErr {
if err == nil {
t.Fatal("expected error, got nil")
}
execErr, ok := err.(*ExecError)
if !ok {
t.Fatalf("expected *ExecError, got %T", err)
}
if execErr.Code != CodeTranspileError {
t.Errorf("expected code %q, got %q", CodeTranspileError, execErr.Code)
}
return
}
if err != nil {
t.Fatalf("unexpected error: %v", err)
}
if tt.wantContain != "" && !strings.Contains(result, tt.wantContain) {
t.Errorf("output should contain %q, got: %s", tt.wantContain, result)
}
if tt.wantAbsent != "" && strings.Contains(result, tt.wantAbsent) {
t.Errorf("output should NOT contain %q, got: %s", tt.wantAbsent, result)
}
})
}
}
func TestTranspileTypeScript_ErrorDetails(t *testing.T) {
_, err := TranspileTypeScript(`const x: number = ;`)
if err == nil {
t.Fatal("expected error")
}
execErr := err.(*ExecError)
// Should include line info
if execErr.Line == 0 && execErr.Column == 0 {
// esbuild may or may not provide location for all errors;
// at minimum the message should be informative
if execErr.Message == "" {
t.Error("expected non-empty error message")
}
}
}
func TestLooksLikeTypeScript(t *testing.T) {
tests := []struct {
name string
code string
want bool
}{
{"plain JS", `var x = 42;`, false},
{"type annotation string", `const x: string = "hi";`, true},
{"type annotation number", `const x: number = 1;`, true},
{"type annotation boolean", `const x: boolean = true;`, true},
{"type annotation any", `const x: any = null;`, true},
{"interface", `interface Foo { bar: string; }`, true},
{"type alias", `type ID = string`, true},
{"generic T", `function id<T>(x: T): T { return x; }`, true},
{"as expression", `const x = 42 as number;`, true},
{"no false positive on colon in object", `var x = { a: 1, b: 2 };`, false},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := looksLikeTypeScript(tt.code)
if got != tt.want {
t.Errorf("looksLikeTypeScript(%q) = %v, want %v", tt.code, got, tt.want)
}
})
}
}
+939
View File
@@ -0,0 +1,939 @@
package mcp
import (
"bytes"
"context"
"encoding/base64"
"encoding/json"
"fmt"
"io"
"time"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/attachments"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/search"
)
// ServiceBridge implements jsruntime.ToolCaller, mapping action names to
// service method calls. It carries the authenticated agent's identity.
type ServiceBridge struct {
msgService *messaging.MessagingService
agentService *agents.AgentService
channelService *channels.Service
swarmService *channels.SwarmService
attachmentService *attachments.Service
searchService *search.Service
agentName string
}
// NewServiceBridge creates a new bridge for the given authenticated agent.
func NewServiceBridge(
msgService *messaging.MessagingService,
agentService *agents.AgentService,
channelService *channels.Service,
swarmService *channels.SwarmService,
attachmentService *attachments.Service,
searchService *search.Service,
agentName string,
) *ServiceBridge {
return &ServiceBridge{
msgService: msgService,
agentService: agentService,
channelService: channelService,
swarmService: swarmService,
attachmentService: attachmentService,
searchService: searchService,
agentName: agentName,
}
}
// Call dispatches an action by name to the appropriate service method.
func (b *ServiceBridge) Call(ctx context.Context, actionName string, args map[string]any) (any, error) {
switch actionName {
// --- Messaging ---
case "read_inbox":
return b.callReadInbox(ctx, args)
case "claim_messages":
return b.callClaimMessages(ctx, args)
case "mark_done":
return b.callMarkDone(ctx, args)
case "search_messages":
return b.callSearchMessages(ctx, args)
case "discover_agents":
return b.callDiscoverAgents(ctx, args)
// --- Channels ---
case "create_channel":
return b.callCreateChannel(ctx, args)
case "join_channel":
return b.callJoinChannel(ctx, args)
case "leave_channel":
return b.callLeaveChannel(ctx, args)
case "list_channels":
return b.callListChannels(ctx, args)
case "invite_to_channel":
return b.callInviteToChannel(ctx, args)
case "kick_from_channel":
return b.callKickFromChannel(ctx, args)
case "get_channel_messages":
return b.callGetChannelMessages(ctx, args)
case "send_channel_message":
return b.callSendChannelMessage(ctx, args)
case "update_channel":
return b.callUpdateChannel(ctx, args)
// --- Swarm ---
case "post_task":
return b.callPostTask(ctx, args)
case "bid_task":
return b.callBidTask(ctx, args)
case "accept_bid":
return b.callAcceptBid(ctx, args)
case "complete_task":
return b.callCompleteTask(ctx, args)
case "list_tasks":
return b.callListTasks(ctx, args)
// --- Attachments ---
case "upload_attachment":
return b.callUploadAttachment(ctx, args)
case "download_attachment":
return b.callDownloadAttachment(ctx, args)
// --- DM send (also accessible via bridge for execute tool) ---
case "send_message":
return b.callSendMessage(ctx, args)
default:
return nil, fmt.Errorf("unknown action: %s", actionName)
}
}
// --- Messaging implementations ---
func (b *ServiceBridge) callSendMessage(ctx context.Context, args map[string]any) (any, error) {
to := getString(args, "to", "")
body := getString(args, "body", "")
if body == "" {
return nil, fmt.Errorf("'body' parameter is required")
}
var channelID *int64
if cid := getInt(args, "channel_id", 0); cid > 0 {
v := int64(cid)
channelID = &v
}
var replyTo *int64
if rtID := getInt(args, "reply_to", 0); rtID > 0 {
v := int64(rtID)
replyTo = &v
}
opts := messaging.SendOptions{
Subject: getString(args, "subject", ""),
Priority: getInt(args, "priority", 5),
Metadata: getString(args, "metadata", ""),
ChannelID: channelID,
ReplyTo: replyTo,
}
msg, err := b.msgService.SendMessage(ctx, b.agentName, to, body, opts)
if err != nil {
return nil, err
}
return map[string]any{
"message_id": msg.ID,
"conversation_id": msg.ConversationID,
"status": msg.Status,
}, nil
}
func (b *ServiceBridge) callReadInbox(ctx context.Context, args map[string]any) (any, error) {
opts := messaging.ReadOptions{
Limit: getInt(args, "limit", 50),
Status: getString(args, "status_filter", ""),
MinPriority: getInt(args, "min_priority", 0),
FromAgent: getString(args, "from_agent", ""),
IncludeRead: getBool(args, "include_read", false),
}
page, err := b.msgService.ReadInbox(ctx, b.agentName, opts)
if err != nil {
return nil, err
}
return map[string]any{
"messages": page.Messages,
"count": len(page.Messages),
"total": page.Total,
"offset": page.Offset,
"limit": page.Limit,
}, nil
}
func (b *ServiceBridge) callClaimMessages(ctx context.Context, args map[string]any) (any, error) {
limit := getInt(args, "limit", 10)
messages, err := b.msgService.ClaimMessages(ctx, b.agentName, limit)
if err != nil {
return nil, err
}
return map[string]any{
"messages": messages,
"count": len(messages),
}, nil
}
func (b *ServiceBridge) callMarkDone(ctx context.Context, args map[string]any) (any, error) {
messageID := getInt(args, "message_id", 0)
if messageID == 0 {
return nil, fmt.Errorf("'message_id' parameter is required")
}
status := getString(args, "status", "done")
reason := getString(args, "reason", "")
switch status {
case "done":
if err := b.msgService.MarkDone(ctx, int64(messageID), b.agentName); err != nil {
return nil, err
}
case "failed":
if err := b.msgService.MarkFailed(ctx, int64(messageID), b.agentName, reason); err != nil {
return nil, err
}
default:
return nil, fmt.Errorf("status must be 'done' or 'failed'")
}
return map[string]any{
"message_id": messageID,
"status": status,
}, nil
}
func (b *ServiceBridge) callSearchMessages(ctx context.Context, args map[string]any) (any, error) {
query := getString(args, "query", "")
// If search service is available, use it for unified search.
if b.searchService != nil {
searchMode := getString(args, "search_mode", "auto")
opts := search.SearchOptions{
Query: query,
Mode: searchMode,
Limit: getInt(args, "limit", 10),
FromAgent: getString(args, "from_agent", ""),
MinPriority: getInt(args, "min_priority", 0),
}
resp, err := b.searchService.Search(ctx, b.agentName, opts)
if err != nil {
return nil, err
}
resultMsgs := make([]map[string]any, len(resp.Results))
for i, r := range resp.Results {
entry := map[string]any{
"message": r.Message,
"match_type": r.MatchType,
}
if r.SimilarityScore > 0 {
entry["similarity_score"] = r.SimilarityScore
}
if r.RelevanceScore > 0 {
entry["relevance_score"] = r.RelevanceScore
}
resultMsgs[i] = entry
}
result := map[string]any{
"results": resultMsgs,
"count": resp.TotalResults,
"search_mode": resp.SearchMode,
}
if resp.Warning != "" {
result["warning"] = resp.Warning
}
return result, nil
}
// Fallback: FTS only.
msgOpts := messaging.SearchOptions{
Limit: getInt(args, "limit", 20),
MinPriority: getInt(args, "min_priority", 0),
FromAgent: getString(args, "from_agent", ""),
Status: getString(args, "status", ""),
}
page, err := b.msgService.SearchMessages(ctx, b.agentName, query, msgOpts)
if err != nil {
return nil, err
}
return map[string]any{
"messages": page.Messages,
"count": len(page.Messages),
"total": page.Total,
"offset": page.Offset,
"limit": page.Limit,
"search_mode": "fulltext",
}, nil
}
func (b *ServiceBridge) callDiscoverAgents(ctx context.Context, args map[string]any) (any, error) {
query := getString(args, "query", "")
agentsList, err := b.agentService.DiscoverAgents(ctx, query)
if err != nil {
return nil, err
}
result := make([]map[string]any, 0, len(agentsList))
for _, a := range agentsList {
if a.Name == "system" {
continue
}
result = append(result, map[string]any{
"name": a.Name,
"display_name": a.DisplayName,
"type": a.Type,
"capabilities": a.Capabilities,
"status": a.Status,
})
}
return map[string]any{
"agents": result,
"count": len(result),
}, nil
}
// --- Channel implementations ---
func (b *ServiceBridge) callCreateChannel(ctx context.Context, args map[string]any) (any, error) {
name := getString(args, "name", "")
if name == "" {
return nil, fmt.Errorf("'name' parameter is required")
}
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
createReq := channels.CreateChannelRequest{
Name: name,
Description: getString(args, "description", ""),
Topic: getString(args, "topic", ""),
Type: getString(args, "type", "standard"),
IsPrivate: getBool(args, "is_private", false),
CreatedBy: b.agentName,
}
ch, err := b.channelService.CreateChannel(ctx, createReq)
if err != nil {
return nil, err
}
return map[string]any{
"channel_id": ch.ID,
"name": ch.Name,
"description": ch.Description,
"topic": ch.Topic,
"type": ch.Type,
"is_private": ch.IsPrivate,
"created_by": ch.CreatedBy,
}, nil
}
func (b *ServiceBridge) callJoinChannel(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelID, err := b.resolveChannelID(ctx, args)
if err != nil {
return nil, err
}
if err := b.channelService.JoinChannel(ctx, channelID, b.agentName); err != nil {
return nil, err
}
return map[string]any{
"channel_id": channelID,
"status": "joined",
}, nil
}
func (b *ServiceBridge) callLeaveChannel(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelID, err := b.resolveChannelID(ctx, args)
if err != nil {
return nil, err
}
if err := b.channelService.LeaveChannel(ctx, channelID, b.agentName); err != nil {
return nil, err
}
return map[string]any{
"channel_id": channelID,
"status": "left",
}, nil
}
func (b *ServiceBridge) callListChannels(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
chList, err := b.channelService.ListChannels(ctx, b.agentName)
if err != nil {
return nil, err
}
result := make([]map[string]any, len(chList))
for i, ch := range chList {
result[i] = map[string]any{
"id": ch.ID,
"name": ch.Name,
"description": ch.Description,
"topic": ch.Topic,
"type": ch.Type,
"is_private": ch.IsPrivate,
"created_by": ch.CreatedBy,
"member_count": ch.MemberCount,
}
}
return map[string]any{
"channels": result,
"count": len(result),
}, nil
}
func (b *ServiceBridge) callInviteToChannel(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelID, err := b.resolveChannelID(ctx, args)
if err != nil {
return nil, err
}
targetAgent := getString(args, "agent_name", "")
if targetAgent == "" {
return nil, fmt.Errorf("'agent_name' parameter is required")
}
if err := b.channelService.InviteToChannel(ctx, channelID, targetAgent, b.agentName); err != nil {
return nil, err
}
return map[string]any{
"channel_id": channelID,
"agent_name": targetAgent,
"status": "invited",
}, nil
}
func (b *ServiceBridge) callKickFromChannel(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelID, err := b.resolveChannelID(ctx, args)
if err != nil {
return nil, err
}
targetAgent := getString(args, "agent_name", "")
if targetAgent == "" {
return nil, fmt.Errorf("'agent_name' parameter is required")
}
if err := b.channelService.KickFromChannel(ctx, channelID, targetAgent, b.agentName); err != nil {
return nil, err
}
return map[string]any{
"channel_id": channelID,
"agent_name": targetAgent,
"status": "kicked",
}, nil
}
func (b *ServiceBridge) callGetChannelMessages(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelID, err := b.resolveChannelID(ctx, args)
if err != nil {
return nil, err
}
// Verify membership.
isMember, err := b.channelService.IsMember(ctx, channelID, b.agentName)
if err != nil {
return nil, err
}
if !isMember {
return nil, fmt.Errorf("you are not a member of this channel")
}
limit := getInt(args, "limit", 50)
if limit > 200 {
limit = 200
}
offset := getInt(args, "offset", 0)
page, err := b.msgService.GetChannelMessages(ctx, channelID, limit, offset)
if err != nil {
return nil, err
}
result := make([]map[string]any, len(page.Messages))
for i, msg := range page.Messages {
result[i] = map[string]any{
"id": msg.ID,
"from": msg.FromAgent,
"body": msg.Body,
"priority": msg.Priority,
"status": msg.Status,
"created_at": msg.CreatedAt,
}
if len(msg.Metadata) > 0 {
result[i]["metadata"] = msg.Metadata
}
}
return map[string]any{
"channel_id": channelID,
"messages": result,
"count": len(result),
"total": page.Total,
"offset": page.Offset,
"limit": page.Limit,
}, nil
}
func (b *ServiceBridge) callSendChannelMessage(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelID, err := b.resolveChannelID(ctx, args)
if err != nil {
return nil, err
}
body := getString(args, "body", "")
if body == "" {
return nil, fmt.Errorf("'body' parameter is required")
}
priority := getInt(args, "priority", 5)
metadata := getString(args, "metadata", "")
messages, err := b.channelService.BroadcastMessage(ctx, channelID, b.agentName, body, priority, metadata)
if err != nil {
return nil, err
}
var messageID int64
if len(messages) > 0 {
messageID = messages[0].ID
}
return map[string]any{
"channel_id": channelID,
"message_id": messageID,
"status": "sent",
}, nil
}
func (b *ServiceBridge) callUpdateChannel(ctx context.Context, args map[string]any) (any, error) {
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelID, err := b.resolveChannelID(ctx, args)
if err != nil {
return nil, err
}
updateReq := channels.UpdateChannelRequest{}
if v, ok := args["topic"]; ok {
if s, ok := v.(string); ok {
updateReq.Topic = &s
}
}
if v, ok := args["description"]; ok {
if s, ok := v.(string); ok {
updateReq.Description = &s
}
}
ch, err := b.channelService.UpdateChannel(ctx, channelID, updateReq, b.agentName)
if err != nil {
return nil, err
}
return map[string]any{
"channel_id": ch.ID,
"name": ch.Name,
"description": ch.Description,
"topic": ch.Topic,
}, nil
}
// --- Swarm implementations ---
func (b *ServiceBridge) callPostTask(ctx context.Context, args map[string]any) (any, error) {
if b.swarmService == nil {
return nil, fmt.Errorf("swarm service not available")
}
channelName := getString(args, "channel_name", "")
if channelName == "" {
return nil, fmt.Errorf("'channel_name' parameter is required")
}
title := getString(args, "title", "")
if title == "" {
return nil, fmt.Errorf("'title' parameter is required")
}
description := getString(args, "description", "")
requirementsStr := getString(args, "requirements", "{}")
deadlineStr := getString(args, "deadline", "")
var requirements json.RawMessage
if requirementsStr != "" {
if !json.Valid([]byte(requirementsStr)) {
return nil, fmt.Errorf("requirements must be valid JSON")
}
requirements = json.RawMessage(requirementsStr)
}
var deadline *time.Time
if deadlineStr != "" {
t, err := time.Parse(time.RFC3339, deadlineStr)
if err != nil {
return nil, fmt.Errorf("deadline must be ISO 8601 format: %s", err)
}
deadline = &t
}
ch, err := b.channelService.GetChannelByName(ctx, channelName)
if err != nil {
return nil, err
}
task, err := b.swarmService.PostTask(ctx, ch.ID, b.agentName, title, description, requirements, deadline)
if err != nil {
return nil, err
}
return map[string]any{
"task_id": task.ID,
"channel_id": task.ChannelID,
"title": task.Title,
"status": task.Status,
"posted_by": task.PostedBy,
"deadline": task.Deadline,
"created_at": task.CreatedAt,
}, nil
}
func (b *ServiceBridge) callBidTask(ctx context.Context, args map[string]any) (any, error) {
if b.swarmService == nil {
return nil, fmt.Errorf("swarm service not available")
}
taskID := getInt(args, "task_id", 0)
if taskID == 0 {
return nil, fmt.Errorf("'task_id' parameter is required")
}
capabilitiesStr := getString(args, "capabilities", "{}")
timeEstimate := getString(args, "time_estimate", "")
message := getString(args, "message", "")
var capabilities json.RawMessage
if capabilitiesStr != "" {
if !json.Valid([]byte(capabilitiesStr)) {
return nil, fmt.Errorf("capabilities must be valid JSON")
}
capabilities = json.RawMessage(capabilitiesStr)
}
bid, err := b.swarmService.BidOnTask(ctx, int64(taskID), b.agentName, capabilities, timeEstimate, message)
if err != nil {
return nil, err
}
return map[string]any{
"bid_id": bid.ID,
"task_id": bid.TaskID,
"agent_name": bid.AgentName,
"time_estimate": bid.TimeEstimate,
"status": bid.Status,
}, nil
}
func (b *ServiceBridge) callAcceptBid(ctx context.Context, args map[string]any) (any, error) {
if b.swarmService == nil {
return nil, fmt.Errorf("swarm service not available")
}
taskID := getInt(args, "task_id", 0)
if taskID == 0 {
return nil, fmt.Errorf("'task_id' parameter is required")
}
bidID := getInt(args, "bid_id", 0)
if bidID == 0 {
return nil, fmt.Errorf("'bid_id' parameter is required")
}
if err := b.swarmService.AcceptBid(ctx, int64(taskID), int64(bidID), b.agentName); err != nil {
return nil, err
}
return map[string]any{
"task_id": taskID,
"bid_id": bidID,
"status": "accepted",
}, nil
}
func (b *ServiceBridge) callCompleteTask(ctx context.Context, args map[string]any) (any, error) {
if b.swarmService == nil {
return nil, fmt.Errorf("swarm service not available")
}
taskID := getInt(args, "task_id", 0)
if taskID == 0 {
return nil, fmt.Errorf("'task_id' parameter is required")
}
if err := b.swarmService.CompleteTask(ctx, int64(taskID), b.agentName); err != nil {
return nil, err
}
return map[string]any{
"task_id": taskID,
"status": "completed",
}, nil
}
func (b *ServiceBridge) callListTasks(ctx context.Context, args map[string]any) (any, error) {
if b.swarmService == nil {
return nil, fmt.Errorf("swarm service not available")
}
if b.channelService == nil {
return nil, fmt.Errorf("channel service not available")
}
channelName := getString(args, "channel_name", "")
if channelName == "" {
return nil, fmt.Errorf("'channel_name' parameter is required")
}
statusFilter := getString(args, "status", "")
ch, err := b.channelService.GetChannelByName(ctx, channelName)
if err != nil {
return nil, err
}
if ch.Type != channels.TypeAuction {
return nil, fmt.Errorf("list_tasks requires a channel of type 'auction', got '%s'", ch.Type)
}
tasks, err := b.swarmService.ListTasks(ctx, ch.ID, statusFilter)
if err != nil {
return nil, err
}
result := make([]map[string]any, len(tasks))
for i, task := range tasks {
result[i] = map[string]any{
"id": task.ID,
"title": task.Title,
"description": task.Description,
"status": task.Status,
"posted_by": task.PostedBy,
"assigned_to": task.AssignedTo,
"deadline": task.Deadline,
"created_at": task.CreatedAt,
}
}
return map[string]any{
"tasks": result,
"count": len(result),
}, nil
}
// --- Attachment implementations ---
func (b *ServiceBridge) callUploadAttachment(ctx context.Context, args map[string]any) (any, error) {
if b.attachmentService == nil {
return nil, fmt.Errorf("attachment service not available")
}
contentB64 := getString(args, "content", "")
if contentB64 == "" {
return nil, fmt.Errorf("'content' parameter is required")
}
if int64(len(contentB64))*3/4 > attachments.MaxFileSize {
return nil, fmt.Errorf("file exceeds maximum size of 50MB")
}
decoded, err := base64.StdEncoding.DecodeString(contentB64)
if err != nil {
return nil, fmt.Errorf("invalid base64 content: %s", err)
}
if int64(len(decoded)) > attachments.MaxFileSize {
return nil, fmt.Errorf("file exceeds maximum size of 50MB")
}
uploadReq := attachments.UploadRequest{
Content: bytes.NewReader(decoded),
Filename: getString(args, "filename", ""),
MIMEType: getString(args, "mime_type", ""),
UploadedBy: b.agentName,
}
if mid := getInt(args, "message_id", 0); mid > 0 {
v := int64(mid)
uploadReq.MessageID = &v
}
uploadResult, err := b.attachmentService.Upload(ctx, uploadReq)
if err != nil {
return nil, err
}
return map[string]any{
"hash": uploadResult.Hash,
"size": uploadResult.Size,
"mime_type": uploadResult.MIMEType,
"original_filename": uploadResult.Filename,
}, nil
}
func (b *ServiceBridge) callDownloadAttachment(ctx context.Context, args map[string]any) (any, error) {
if b.attachmentService == nil {
return nil, fmt.Errorf("attachment service not available")
}
hash := getString(args, "hash", "")
if hash == "" {
return nil, fmt.Errorf("'hash' parameter is required")
}
dlResult, err := b.attachmentService.Download(ctx, hash)
if err != nil {
return nil, err
}
defer dlResult.Content.Close()
content, err := io.ReadAll(dlResult.Content)
if err != nil {
return nil, fmt.Errorf("read attachment content: %s", err)
}
return map[string]any{
"hash": dlResult.Hash,
"content": base64.StdEncoding.EncodeToString(content),
"original_filename": dlResult.Filename,
"mime_type": dlResult.MIMEType,
"size": dlResult.Size,
}, nil
}
// --- Helpers ---
// resolveChannelID resolves a channel ID from either channel_id or channel_name in args.
func (b *ServiceBridge) resolveChannelID(ctx context.Context, args map[string]any) (int64, error) {
if cid := getInt(args, "channel_id", 0); cid > 0 {
return int64(cid), nil
}
name := getString(args, "channel_name", "")
if name != "" {
ch, err := b.channelService.GetChannelByName(ctx, name)
if err != nil {
return 0, err
}
return ch.ID, nil
}
return 0, fmt.Errorf("either 'channel_id' or 'channel_name' is required")
}
// getString extracts a string value from args with a default.
func getString(args map[string]any, key, defaultVal string) string {
v, ok := args[key]
if !ok {
return defaultVal
}
s, ok := v.(string)
if !ok {
return defaultVal
}
return s
}
// getInt extracts an int value from args with a default.
// Handles both int and float64 (JSON numbers decode as float64).
func getInt(args map[string]any, key string, defaultVal int) int {
v, ok := args[key]
if !ok {
return defaultVal
}
switch n := v.(type) {
case int:
return n
case int64:
return int(n)
case float64:
return int(n)
case json.Number:
i, err := n.Int64()
if err != nil {
return defaultVal
}
return int(i)
}
return defaultVal
}
// getBool extracts a bool value from args with a default.
func getBool(args map[string]any, key string, defaultVal bool) bool {
v, ok := args[key]
if !ok {
return defaultVal
}
b, ok := v.(bool)
if !ok {
return defaultVal
}
return b
}
+296
View File
@@ -0,0 +1,296 @@
package mcp
import (
"context"
"testing"
_ "modernc.org/sqlite"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/storage"
"github.com/synapbus/synapbus/internal/trace"
)
func newTestBridge(t *testing.T) (*ServiceBridge, *messaging.MessagingService, *agents.AgentService, *channels.Service) {
t.Helper()
db := newTestDB(t)
tracer := trace.NewTracer(db)
t.Cleanup(func() { tracer.Close() })
msgStore := messaging.NewSQLiteMessageStore(db)
msgService := messaging.NewMessagingService(msgStore, tracer)
agentStore := agents.NewSQLiteAgentStore(db)
agentService := agents.NewAgentService(agentStore, tracer)
channelStore := channels.NewSQLiteChannelStore(db)
channelService := channels.NewService(channelStore, msgService, tracer)
taskStore := channels.NewSQLiteTaskStore(db)
swarmService := channels.NewSwarmService(taskStore, channelStore, tracer)
// Seed test agents
agentService.Register(context.Background(), "agent-a", "Agent A", "ai", nil, 1)
agentService.Register(context.Background(), "agent-b", "Agent B", "ai", nil, 1)
bridge := NewServiceBridge(
msgService,
agentService,
channelService,
swarmService,
nil, // attachmentService
nil, // searchService
"agent-a",
)
return bridge, msgService, agentService, channelService
}
func TestBridge_SendMessage(t *testing.T) {
bridge, _, _, _ := newTestBridge(t)
ctx := context.Background()
result, err := bridge.Call(ctx, "send_message", map[string]any{
"to": "agent-b",
"body": "hello from bridge",
})
if err != nil {
t.Fatalf("Call send_message: %v", err)
}
r := result.(map[string]any)
if r["message_id"] == nil {
t.Error("expected message_id")
}
}
func TestBridge_ReadInbox(t *testing.T) {
bridge, msgService, _, _ := newTestBridge(t)
ctx := context.Background()
// Send a message to agent-a
msgService.SendMessage(ctx, "agent-b", "agent-a", "test inbox msg", messaging.SendOptions{})
result, err := bridge.Call(ctx, "read_inbox", map[string]any{
"limit": 10,
})
if err != nil {
t.Fatalf("Call read_inbox: %v", err)
}
r := result.(map[string]any)
if r["count"].(int) != 1 {
t.Errorf("count = %v, want 1", r["count"])
}
}
func TestBridge_ClaimMessages(t *testing.T) {
bridge, msgService, _, _ := newTestBridge(t)
ctx := context.Background()
msgService.SendMessage(ctx, "agent-b", "agent-a", "claim me", messaging.SendOptions{})
result, err := bridge.Call(ctx, "claim_messages", map[string]any{
"limit": 1,
})
if err != nil {
t.Fatalf("Call claim_messages: %v", err)
}
r := result.(map[string]any)
count := r["count"].(int)
if count != 1 {
t.Errorf("count = %v, want 1", count)
}
}
func TestBridge_MarkDone(t *testing.T) {
bridge, msgService, _, _ := newTestBridge(t)
ctx := context.Background()
msg, _ := msgService.SendMessage(ctx, "agent-b", "agent-a", "done me", messaging.SendOptions{})
msgService.ClaimMessages(ctx, "agent-a", 1)
result, err := bridge.Call(ctx, "mark_done", map[string]any{
"message_id": int(msg.ID),
"status": "done",
})
if err != nil {
t.Fatalf("Call mark_done: %v", err)
}
r := result.(map[string]any)
if r["status"] != "done" {
t.Errorf("status = %v, want done", r["status"])
}
}
func TestBridge_MarkDone_Missing(t *testing.T) {
bridge, _, _, _ := newTestBridge(t)
ctx := context.Background()
_, err := bridge.Call(ctx, "mark_done", map[string]any{})
if err == nil {
t.Error("expected error for missing message_id")
}
}
func TestBridge_DiscoverAgents(t *testing.T) {
bridge, _, _, _ := newTestBridge(t)
ctx := context.Background()
result, err := bridge.Call(ctx, "discover_agents", map[string]any{})
if err != nil {
t.Fatalf("Call discover_agents: %v", err)
}
r := result.(map[string]any)
count := r["count"].(int)
if count < 2 {
t.Errorf("expected at least 2 agents, got %v", count)
}
}
func TestBridge_CreateChannel(t *testing.T) {
bridge, _, _, _ := newTestBridge(t)
ctx := context.Background()
result, err := bridge.Call(ctx, "create_channel", map[string]any{
"name": "bridge-test-ch",
"type": "standard",
})
if err != nil {
t.Fatalf("Call create_channel: %v", err)
}
r := result.(map[string]any)
if r["name"] != "bridge-test-ch" {
t.Errorf("name = %v, want bridge-test-ch", r["name"])
}
}
func TestBridge_JoinChannel(t *testing.T) {
bridge, _, _, channelService := newTestBridge(t)
ctx := context.Background()
channelService.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "join-bridge", Type: "standard", CreatedBy: "agent-a",
})
// Create a bridge for agent-b to join
bridgeB := NewServiceBridge(
bridge.msgService,
bridge.agentService,
bridge.channelService,
bridge.swarmService,
nil, nil,
"agent-b",
)
result, err := bridgeB.Call(ctx, "join_channel", map[string]any{
"channel_name": "join-bridge",
})
if err != nil {
t.Fatalf("Call join_channel: %v", err)
}
r := result.(map[string]any)
if r["status"] != "joined" {
t.Errorf("status = %v, want joined", r["status"])
}
}
func TestBridge_ListChannels(t *testing.T) {
bridge, _, _, channelService := newTestBridge(t)
ctx := context.Background()
channelService.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "list-ch-1", Type: "standard", CreatedBy: "agent-a",
})
channelService.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "list-ch-2", Type: "standard", CreatedBy: "agent-a",
})
result, err := bridge.Call(ctx, "list_channels", map[string]any{})
if err != nil {
t.Fatalf("Call list_channels: %v", err)
}
r := result.(map[string]any)
count := r["count"].(int)
if count < 2 {
t.Errorf("expected at least 2 channels, got %v", count)
}
}
func TestBridge_SendChannelMessage(t *testing.T) {
bridge, _, _, channelService := newTestBridge(t)
ctx := context.Background()
channelService.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "msg-bridge", Type: "standard", CreatedBy: "agent-a",
})
result, err := bridge.Call(ctx, "send_channel_message", map[string]any{
"channel_name": "msg-bridge",
"body": "hello from bridge",
})
if err != nil {
t.Fatalf("Call send_channel_message: %v", err)
}
r := result.(map[string]any)
if r["status"] != "sent" {
t.Errorf("status = %v, want sent", r["status"])
}
}
func TestBridge_UnknownAction(t *testing.T) {
bridge, _, _, _ := newTestBridge(t)
ctx := context.Background()
_, err := bridge.Call(ctx, "totally_unknown", map[string]any{})
if err == nil {
t.Error("expected error for unknown action")
}
}
func TestBridge_ParamHelpers(t *testing.T) {
args := map[string]any{
"str_val": "hello",
"int_val": float64(42),
"bool_val": true,
"nil_val": nil,
}
t.Run("getString", func(t *testing.T) {
if v := getString(args, "str_val", ""); v != "hello" {
t.Errorf("got %q, want hello", v)
}
if v := getString(args, "missing", "default"); v != "default" {
t.Errorf("got %q, want default", v)
}
})
t.Run("getInt", func(t *testing.T) {
if v := getInt(args, "int_val", 0); v != 42 {
t.Errorf("got %d, want 42", v)
}
if v := getInt(args, "missing", 99); v != 99 {
t.Errorf("got %d, want 99", v)
}
})
t.Run("getBool", func(t *testing.T) {
if v := getBool(args, "bool_val", false); v != true {
t.Errorf("got %v, want true", v)
}
if v := getBool(args, "missing", true); v != true {
t.Errorf("got %v, want true", v)
}
})
}
var _ = storage.RunMigrations
-438
View File
@@ -1,438 +0,0 @@
package mcp
import (
"context"
"fmt"
"github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/messaging"
)
// ChannelToolRegistrar registers channel MCP tools on the server.
type ChannelToolRegistrar struct {
channelService *channels.Service
msgService *messaging.MessagingService
}
// NewChannelToolRegistrar creates a new channel tool registrar.
func NewChannelToolRegistrar(channelService *channels.Service, msgService *messaging.MessagingService) *ChannelToolRegistrar {
return &ChannelToolRegistrar{
channelService: channelService,
msgService: msgService,
}
}
// RegisterAll registers all channel tools on the MCP server.
func (ctr *ChannelToolRegistrar) RegisterAll(s *server.MCPServer) {
s.AddTool(ctr.createChannelTool(), ctr.handleCreateChannel)
s.AddTool(ctr.joinChannelTool(), ctr.handleJoinChannel)
s.AddTool(ctr.leaveChannelTool(), ctr.handleLeaveChannel)
s.AddTool(ctr.listChannelsTool(), ctr.handleListChannels)
s.AddTool(ctr.inviteToChannelTool(), ctr.handleInviteToChannel)
s.AddTool(ctr.kickFromChannelTool(), ctr.handleKickFromChannel)
s.AddTool(ctr.getChannelMessagesTool(), ctr.handleGetChannelMessages)
s.AddTool(ctr.sendChannelMessageTool(), ctr.handleSendChannelMessage)
s.AddTool(ctr.updateChannelTool(), ctr.handleUpdateChannel)
}
// --- Tool Definitions ---
func (ctr *ChannelToolRegistrar) createChannelTool() mcp.Tool {
return mcp.NewTool("create_channel",
mcp.WithDescription("Create a new channel for group communication"),
mcp.WithString("name", mcp.Description("Unique channel name (alphanumeric, hyphens, underscores, max 64 chars)"), mcp.Required()),
mcp.WithString("description", mcp.Description("Channel description")),
mcp.WithString("topic", mcp.Description("Current channel topic")),
mcp.WithString("type", mcp.Description("Channel type: 'standard', 'blackboard', or 'auction' (default 'standard')")),
mcp.WithBoolean("is_private", mcp.Description("Whether the channel is private (invite-only). Default false")),
)
}
func (ctr *ChannelToolRegistrar) joinChannelTool() mcp.Tool {
return mcp.NewTool("join_channel",
mcp.WithDescription("Join a channel to participate in group conversations. You will receive messages sent to the channel after joining. Use list_channels first to see available channels."),
mcp.WithNumber("channel_id", mcp.Description("ID of the channel to join")),
mcp.WithString("channel_name", mcp.Description("Name of the channel to join (alternative to channel_id)")),
)
}
func (ctr *ChannelToolRegistrar) leaveChannelTool() mcp.Tool {
return mcp.NewTool("leave_channel",
mcp.WithDescription("Leave a channel you are a member of"),
mcp.WithNumber("channel_id", mcp.Description("ID of the channel to leave")),
mcp.WithString("channel_name", mcp.Description("Name of the channel to leave (alternative to channel_id)")),
)
}
func (ctr *ChannelToolRegistrar) listChannelsTool() mcp.Tool {
return mcp.NewTool("list_channels",
mcp.WithDescription("List all channels visible to you. Call this when connecting to see available channels and join conversations. Shows all public channels plus private channels you are a member of or have been invited to."),
)
}
func (ctr *ChannelToolRegistrar) inviteToChannelTool() mcp.Tool {
return mcp.NewTool("invite_to_channel",
mcp.WithDescription("Invite an agent to a channel (only the channel owner can invite to private channels)"),
mcp.WithNumber("channel_id", mcp.Description("ID of the channel")),
mcp.WithString("channel_name", mcp.Description("Name of the channel (alternative to channel_id)")),
mcp.WithString("agent_name", mcp.Description("Name of the agent to invite"), mcp.Required()),
)
}
func (ctr *ChannelToolRegistrar) kickFromChannelTool() mcp.Tool {
return mcp.NewTool("kick_from_channel",
mcp.WithDescription("Remove an agent from a channel (only the channel owner can kick)"),
mcp.WithNumber("channel_id", mcp.Description("ID of the channel")),
mcp.WithString("channel_name", mcp.Description("Name of the channel (alternative to channel_id)")),
mcp.WithString("agent_name", mcp.Description("Name of the agent to kick"), mcp.Required()),
)
}
func (ctr *ChannelToolRegistrar) getChannelMessagesTool() mcp.Tool {
return mcp.NewTool("get_channel_messages",
mcp.WithDescription("Get recent messages from a channel you are a member of"),
mcp.WithNumber("channel_id", mcp.Description("ID of the channel")),
mcp.WithString("channel_name", mcp.Description("Name of the channel (alternative to channel_id)")),
mcp.WithNumber("limit", mcp.Description("Max number of messages to return (default 50, max 200)")),
)
}
func (ctr *ChannelToolRegistrar) sendChannelMessageTool() mcp.Tool {
return mcp.NewTool("send_channel_message",
mcp.WithDescription("Send a message to all members of a channel. Use @agentname in the body to mention specific agents. You must be a member of the channel to send messages."),
mcp.WithNumber("channel_id", mcp.Description("ID of the channel")),
mcp.WithString("channel_name", mcp.Description("Name of the channel (alternative to channel_id)")),
mcp.WithString("body", mcp.Description("Message body text"), mcp.Required()),
mcp.WithNumber("priority", mcp.Description("Message priority (1-10, default 5)"), mcp.Min(1), mcp.Max(10)),
mcp.WithString("metadata", mcp.Description("JSON metadata object (optional)")),
)
}
func (ctr *ChannelToolRegistrar) updateChannelTool() mcp.Tool {
return mcp.NewTool("update_channel",
mcp.WithDescription("Update channel topic or description (only the channel owner can update)"),
mcp.WithNumber("channel_id", mcp.Description("ID of the channel")),
mcp.WithString("channel_name", mcp.Description("Name of the channel (alternative to channel_id)")),
mcp.WithString("topic", mcp.Description("New channel topic")),
mcp.WithString("description", mcp.Description("New channel description")),
)
}
// --- Tool Handlers ---
func (ctr *ChannelToolRegistrar) handleCreateChannel(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
name := req.GetString("name", "")
if name == "" {
return mcp.NewToolResultError("'name' parameter is required"), nil
}
isPrivate := false
args := req.GetArguments()
if v, ok := args["is_private"]; ok {
if b, ok := v.(bool); ok {
isPrivate = b
}
}
createReq := channels.CreateChannelRequest{
Name: name,
Description: req.GetString("description", ""),
Topic: req.GetString("topic", ""),
Type: req.GetString("type", "standard"),
IsPrivate: isPrivate,
CreatedBy: agentName,
}
ch, err := ctr.channelService.CreateChannel(ctx, createReq)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("create_channel failed: %s", err)), nil
}
return resultJSON(map[string]any{
"channel_id": ch.ID,
"name": ch.Name,
"description": ch.Description,
"topic": ch.Topic,
"type": ch.Type,
"is_private": ch.IsPrivate,
"created_by": ch.CreatedBy,
})
}
func (ctr *ChannelToolRegistrar) handleJoinChannel(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelID, err := ctr.resolveChannelID(ctx, req)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("join_channel failed: %s", err)), nil
}
if err := ctr.channelService.JoinChannel(ctx, channelID, agentName); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("join_channel failed: %s", err)), nil
}
return resultJSON(map[string]any{
"channel_id": channelID,
"status": "joined",
})
}
func (ctr *ChannelToolRegistrar) handleLeaveChannel(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelID, err := ctr.resolveChannelID(ctx, req)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("leave_channel failed: %s", err)), nil
}
if err := ctr.channelService.LeaveChannel(ctx, channelID, agentName); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("leave_channel failed: %s", err)), nil
}
return resultJSON(map[string]any{
"channel_id": channelID,
"status": "left",
})
}
func (ctr *ChannelToolRegistrar) handleListChannels(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
chList, err := ctr.channelService.ListChannels(ctx, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("list_channels failed: %s", err)), nil
}
result := make([]map[string]any, len(chList))
for i, ch := range chList {
result[i] = map[string]any{
"id": ch.ID,
"name": ch.Name,
"description": ch.Description,
"topic": ch.Topic,
"type": ch.Type,
"is_private": ch.IsPrivate,
"created_by": ch.CreatedBy,
"member_count": ch.MemberCount,
}
}
return resultJSON(map[string]any{
"channels": result,
"count": len(result),
})
}
func (ctr *ChannelToolRegistrar) handleInviteToChannel(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelID, err := ctr.resolveChannelID(ctx, req)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("invite_to_channel failed: %s", err)), nil
}
targetAgent := req.GetString("agent_name", "")
if targetAgent == "" {
return mcp.NewToolResultError("'agent_name' parameter is required"), nil
}
if err := ctr.channelService.InviteToChannel(ctx, channelID, targetAgent, agentName); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("invite_to_channel failed: %s", err)), nil
}
return resultJSON(map[string]any{
"channel_id": channelID,
"agent_name": targetAgent,
"status": "invited",
})
}
func (ctr *ChannelToolRegistrar) handleKickFromChannel(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelID, err := ctr.resolveChannelID(ctx, req)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("kick_from_channel failed: %s", err)), nil
}
targetAgent := req.GetString("agent_name", "")
if targetAgent == "" {
return mcp.NewToolResultError("'agent_name' parameter is required"), nil
}
if err := ctr.channelService.KickFromChannel(ctx, channelID, targetAgent, agentName); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("kick_from_channel failed: %s", err)), nil
}
return resultJSON(map[string]any{
"channel_id": channelID,
"agent_name": targetAgent,
"status": "kicked",
})
}
func (ctr *ChannelToolRegistrar) handleGetChannelMessages(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelID, err := ctr.resolveChannelID(ctx, req)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("get_channel_messages failed: %s", err)), nil
}
// Verify the agent is a member of the channel
isMember, err := ctr.channelService.IsMember(ctx, channelID, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("get_channel_messages failed: %s", err)), nil
}
if !isMember {
return mcp.NewToolResultError("you are not a member of this channel"), nil
}
limit := req.GetInt("limit", 50)
if limit > 200 {
limit = 200
}
messages, err := ctr.msgService.GetChannelMessages(ctx, channelID, limit)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("get_channel_messages failed: %s", err)), nil
}
result := make([]map[string]any, len(messages))
for i, msg := range messages {
result[i] = map[string]any{
"id": msg.ID,
"from": msg.FromAgent,
"body": msg.Body,
"priority": msg.Priority,
"status": msg.Status,
"created_at": msg.CreatedAt,
}
if len(msg.Metadata) > 0 {
result[i]["metadata"] = msg.Metadata
}
}
return resultJSON(map[string]any{
"channel_id": channelID,
"messages": result,
"count": len(result),
})
}
func (ctr *ChannelToolRegistrar) handleSendChannelMessage(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelID, err := ctr.resolveChannelID(ctx, req)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("send_channel_message failed: %s", err)), nil
}
body := req.GetString("body", "")
if body == "" {
return mcp.NewToolResultError("'body' parameter is required"), nil
}
priority := req.GetInt("priority", 5)
metadata := req.GetString("metadata", "")
messages, err := ctr.channelService.BroadcastMessage(ctx, channelID, agentName, body, priority, metadata)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("send_channel_message failed: %s", err)), nil
}
var messageID int64
if len(messages) > 0 {
messageID = messages[0].ID
}
return resultJSON(map[string]any{
"channel_id": channelID,
"message_id": messageID,
"status": "sent",
})
}
func (ctr *ChannelToolRegistrar) handleUpdateChannel(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelID, err := ctr.resolveChannelID(ctx, req)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("update_channel failed: %s", err)), nil
}
updateReq := channels.UpdateChannelRequest{}
args := req.GetArguments()
if v, ok := args["topic"]; ok {
if s, ok := v.(string); ok {
updateReq.Topic = &s
}
}
if v, ok := args["description"]; ok {
if s, ok := v.(string); ok {
updateReq.Description = &s
}
}
ch, err := ctr.channelService.UpdateChannel(ctx, channelID, updateReq, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("update_channel failed: %s", err)), nil
}
return resultJSON(map[string]any{
"channel_id": ch.ID,
"name": ch.Name,
"description": ch.Description,
"topic": ch.Topic,
})
}
// resolveChannelID resolves a channel ID from either channel_id or channel_name parameter.
func (ctr *ChannelToolRegistrar) resolveChannelID(ctx context.Context, req mcp.CallToolRequest) (int64, error) {
if cid := req.GetInt("channel_id", 0); cid > 0 {
return int64(cid), nil
}
name := req.GetString("channel_name", "")
if name != "" {
ch, err := ctr.channelService.GetChannelByName(ctx, name)
if err != nil {
return 0, err
}
return ch.ID, nil
}
return 0, fmt.Errorf("either 'channel_id' or 'channel_name' is required")
}
+119 -298
View File
@@ -8,13 +8,16 @@ import (
mcplib "github.com/mark3labs/mcp-go/mcp"
_ "modernc.org/sqlite"
"github.com/synapbus/synapbus/internal/actions"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/jsruntime"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/storage"
"github.com/synapbus/synapbus/internal/trace"
)
func newTestChannelRegistrar(t *testing.T) (*ChannelToolRegistrar, *channels.Service) {
func newTestHybridWithChannels(t *testing.T) (*HybridToolRegistrar, *channels.Service) {
t.Helper()
db := newTestDB(t)
@@ -26,12 +29,32 @@ func newTestChannelRegistrar(t *testing.T) (*ChannelToolRegistrar, *channels.Ser
msgService := messaging.NewMessagingService(msgStore, tracer)
channelService := channels.NewService(channelStore, msgService, tracer)
agentStore := agents.NewSQLiteAgentStore(db)
agentService := agents.NewAgentService(agentStore, tracer)
jsPool := jsruntime.NewPool(2)
t.Cleanup(func() { jsPool.Close() })
actionRegistry := actions.NewRegistry()
actionIndex := actions.NewIndex(actionRegistry.List())
// Seed test agents
db.Exec(`INSERT OR IGNORE INTO agents (name, display_name, type, capabilities, owner_id, api_key_hash, status) VALUES ('agent-a', 'Agent A', 'ai', '{}', 1, 'hash', 'active')`)
db.Exec(`INSERT OR IGNORE INTO agents (name, display_name, type, capabilities, owner_id, api_key_hash, status) VALUES ('agent-b', 'Agent B', 'ai', '{}', 1, 'hash', 'active')`)
db.Exec(`INSERT OR IGNORE INTO agents (name, display_name, type, capabilities, owner_id, api_key_hash, status) VALUES ('agent-c', 'Agent C', 'ai', '{}', 1, 'hash', 'active')`)
registrar := NewChannelToolRegistrar(channelService, msgService)
registrar := NewHybridToolRegistrar(
msgService,
agentService,
channelService,
nil, // swarmService
nil, // attachmentService
nil, // searchService
jsPool,
actionRegistry,
actionIndex,
db,
)
return registrar, channelService
}
@@ -45,274 +68,24 @@ func parseResponse(t *testing.T, result *mcplib.CallToolResult) map[string]any {
return resp
}
func TestChannelToolHandler_CreateChannel(t *testing.T) {
ctr, _ := newTestChannelRegistrar(t)
authCtx := ContextWithAgentName(context.Background(), "agent-a")
t.Run("successful creation", func(t *testing.T) {
req := makeRequest(map[string]any{
"name": "test-channel",
"description": "A test channel",
"type": "standard",
})
result, err := ctr.handleCreateChannel(authCtx, req)
if err != nil {
t.Fatalf("handleCreateChannel: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resp := parseResponse(t, result)
if resp["name"] != "test-channel" {
t.Errorf("name = %v, want test-channel", resp["name"])
}
if resp["channel_id"] == nil || resp["channel_id"].(float64) == 0 {
t.Error("expected non-zero channel_id")
}
})
t.Run("create private channel", func(t *testing.T) {
req := makeRequest(map[string]any{
"name": "private-test",
"is_private": true,
})
result, err := ctr.handleCreateChannel(authCtx, req)
if err != nil {
t.Fatalf("handleCreateChannel: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resp := parseResponse(t, result)
if resp["is_private"] != true {
t.Errorf("is_private = %v, want true", resp["is_private"])
}
})
t.Run("missing name", func(t *testing.T) {
req := makeRequest(map[string]any{})
result, _ := ctr.handleCreateChannel(authCtx, req)
if !result.IsError {
t.Error("expected error for missing name")
}
})
t.Run("unauthenticated", func(t *testing.T) {
req := makeRequest(map[string]any{"name": "fail"})
result, _ := ctr.handleCreateChannel(context.Background(), req)
if !result.IsError {
t.Error("expected error for unauthenticated request")
}
})
t.Run("duplicate name", func(t *testing.T) {
req := makeRequest(map[string]any{"name": "test-channel"})
result, _ := ctr.handleCreateChannel(authCtx, req)
if !result.IsError {
t.Error("expected error for duplicate name")
}
})
}
func TestChannelToolHandler_JoinChannel(t *testing.T) {
ctr, svc := newTestChannelRegistrar(t)
ctx := context.Background()
ch, _ := svc.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "join-test", Type: "standard", CreatedBy: "agent-a",
})
authCtx := ContextWithAgentName(ctx, "agent-b")
t.Run("join by channel_id", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
})
result, err := ctr.handleJoinChannel(authCtx, req)
if err != nil {
t.Fatalf("handleJoinChannel: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resp := parseResponse(t, result)
if resp["status"] != "joined" {
t.Errorf("status = %v, want joined", resp["status"])
}
})
t.Run("join by channel_name", func(t *testing.T) {
authCtxC := ContextWithAgentName(ctx, "agent-c")
req := makeRequest(map[string]any{
"channel_name": "join-test",
})
result, err := ctr.handleJoinChannel(authCtxC, req)
if err != nil {
t.Fatalf("handleJoinChannel: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
})
t.Run("no channel identifier", func(t *testing.T) {
req := makeRequest(map[string]any{})
result, _ := ctr.handleJoinChannel(authCtx, req)
if !result.IsError {
t.Error("expected error when no channel identifier provided")
}
})
}
func TestChannelToolHandler_LeaveChannel(t *testing.T) {
ctr, svc := newTestChannelRegistrar(t)
ctx := context.Background()
ch, _ := svc.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "leave-test", Type: "standard", CreatedBy: "agent-a",
})
svc.JoinChannel(ctx, ch.ID, "agent-b")
authCtx := ContextWithAgentName(ctx, "agent-b")
t.Run("successful leave", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
})
result, err := ctr.handleLeaveChannel(authCtx, req)
if err != nil {
t.Fatalf("handleLeaveChannel: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
})
t.Run("owner cannot leave", func(t *testing.T) {
ownerCtx := ContextWithAgentName(ctx, "agent-a")
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
})
result, _ := ctr.handleLeaveChannel(ownerCtx, req)
if !result.IsError {
t.Error("expected error for owner leaving")
}
})
}
func TestChannelToolHandler_ListChannels(t *testing.T) {
ctr, svc := newTestChannelRegistrar(t)
ctx := context.Background()
svc.CreateChannel(ctx, channels.CreateChannelRequest{Name: "pub-1", Type: "standard", CreatedBy: "agent-a"})
svc.CreateChannel(ctx, channels.CreateChannelRequest{Name: "pub-2", Type: "standard", CreatedBy: "agent-a"})
authCtx := ContextWithAgentName(ctx, "agent-b")
req := makeRequest(map[string]any{})
result, err := ctr.handleListChannels(authCtx, req)
if err != nil {
t.Fatalf("handleListChannels: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
// parseCallResult unwraps the execute response envelope and the call() wrapper
// to return the inner bridge result: { result: { ok, result: <bridge_data> }, calls, duration } → <bridge_data>
func parseCallResult(t *testing.T, result *mcplib.CallToolResult) map[string]any {
t.Helper()
resp := parseResponse(t, result)
count := resp["count"].(float64)
if count != 2 {
t.Errorf("count = %v, want 2", count)
callEnvelope, ok := resp["result"].(map[string]any)
if !ok {
t.Fatalf("expected result to be map, got %T", resp["result"])
}
chList := resp["channels"].([]any)
ch0 := chList[0].(map[string]any)
if ch0["name"] == nil {
t.Error("expected name field in channel")
}
if ch0["member_count"] == nil {
t.Error("expected member_count field in channel")
inner, ok := callEnvelope["result"].(map[string]any)
if !ok {
t.Fatalf("expected call result to be map, got %T (ok=%v)", callEnvelope["result"], callEnvelope["ok"])
}
return inner
}
func TestChannelToolHandler_InviteToChannel(t *testing.T) {
ctr, svc := newTestChannelRegistrar(t)
ctx := context.Background()
ch, _ := svc.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "invite-test", Type: "standard", IsPrivate: true, CreatedBy: "agent-a",
})
ownerCtx := ContextWithAgentName(ctx, "agent-a")
t.Run("owner can invite", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
"agent_name": "agent-b",
})
result, err := ctr.handleInviteToChannel(ownerCtx, req)
if err != nil {
t.Fatalf("handleInviteToChannel: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
})
t.Run("missing agent_name", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
})
result, _ := ctr.handleInviteToChannel(ownerCtx, req)
if !result.IsError {
t.Error("expected error for missing agent_name")
}
})
}
func TestChannelToolHandler_KickFromChannel(t *testing.T) {
ctr, svc := newTestChannelRegistrar(t)
ctx := context.Background()
ch, _ := svc.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "kick-test", Type: "standard", CreatedBy: "agent-a",
})
svc.JoinChannel(ctx, ch.ID, "agent-b")
ownerCtx := ContextWithAgentName(ctx, "agent-a")
t.Run("owner can kick", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
"agent_name": "agent-b",
})
result, err := ctr.handleKickFromChannel(ownerCtx, req)
if err != nil {
t.Fatalf("handleKickFromChannel: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resp := parseResponse(t, result)
if resp["status"] != "kicked" {
t.Errorf("status = %v, want kicked", resp["status"])
}
})
}
func TestChannelToolHandler_SendChannelMessage(t *testing.T) {
ctr, svc := newTestChannelRegistrar(t)
func TestHybridTool_SendMessage_Channel(t *testing.T) {
h, svc := newTestHybridWithChannels(t)
ctx := context.Background()
ch, _ := svc.CreateChannel(ctx, channels.CreateChannelRequest{
@@ -322,15 +95,15 @@ func TestChannelToolHandler_SendChannelMessage(t *testing.T) {
authCtx := ContextWithAgentName(ctx, "agent-a")
t.Run("send channel message", func(t *testing.T) {
t.Run("send to channel by name", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_name": "msg-test",
"body": "Hello channel!",
"channel": "msg-test",
"body": "Hello channel!",
})
result, err := ctr.handleSendChannelMessage(authCtx, req)
result, err := h.handleSendMessage(authCtx, req)
if err != nil {
t.Fatalf("handleSendChannelMessage: %v", err)
t.Fatalf("handleSendMessage: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
@@ -345,57 +118,105 @@ func TestChannelToolHandler_SendChannelMessage(t *testing.T) {
}
})
t.Run("missing body", func(t *testing.T) {
t.Run("missing body for channel", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_name": "msg-test",
"channel": "msg-test",
})
result, _ := ctr.handleSendChannelMessage(authCtx, req)
result, _ := h.handleSendMessage(authCtx, req)
if !result.IsError {
t.Error("expected error for missing body")
}
})
}
func TestChannelToolHandler_UpdateChannel(t *testing.T) {
ctr, svc := newTestChannelRegistrar(t)
func TestBridge_ChannelOperations(t *testing.T) {
h, svc := newTestHybridWithChannels(t)
ctx := context.Background()
authCtx := ContextWithAgentName(ctx, "agent-a")
ch, _ := svc.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "update-test", Type: "standard", Topic: "Original", CreatedBy: "agent-a",
})
ownerCtx := ContextWithAgentName(ctx, "agent-a")
t.Run("update topic", func(t *testing.T) {
t.Run("create_channel via execute", func(t *testing.T) {
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
"topic": "Updated topic",
"code": `call("create_channel", { name: "test-channel", description: "A test channel", type: "standard" })`,
})
result, err := ctr.handleUpdateChannel(ownerCtx, req)
result, err := h.handleExecute(authCtx, req)
if err != nil {
t.Fatalf("handleUpdateChannel: %v", err)
t.Fatalf("handleExecute: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resp := parseResponse(t, result)
if resp["topic"] != "Updated topic" {
t.Errorf("topic = %v, want 'Updated topic'", resp["topic"])
resultData := parseCallResult(t, result)
if resultData["name"] != "test-channel" {
t.Errorf("name = %v, want test-channel", resultData["name"])
}
})
t.Run("non-owner cannot update", func(t *testing.T) {
svc.JoinChannel(ctx, ch.ID, "agent-b")
nonOwnerCtx := ContextWithAgentName(ctx, "agent-b")
req := makeRequest(map[string]any{
"channel_id": float64(ch.ID),
"topic": "Unauthorized",
t.Run("join_channel via execute", func(t *testing.T) {
svc.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "join-test", Type: "standard", CreatedBy: "agent-a",
})
result, _ := ctr.handleUpdateChannel(nonOwnerCtx, req)
if !result.IsError {
t.Error("expected error for non-owner update")
bCtx := ContextWithAgentName(ctx, "agent-b")
req := makeRequest(map[string]any{
"code": `call("join_channel", { channel_name: "join-test" })`,
})
result, err := h.handleExecute(bCtx, req)
if err != nil {
t.Fatalf("handleExecute: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resultData := parseCallResult(t, result)
if resultData["status"] != "joined" {
t.Errorf("status = %v, want joined", resultData["status"])
}
})
t.Run("list_channels via execute", func(t *testing.T) {
req := makeRequest(map[string]any{
"code": `call("list_channels", {})`,
})
result, err := h.handleExecute(authCtx, req)
if err != nil {
t.Fatalf("handleExecute: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resultData := parseCallResult(t, result)
count := resultData["count"].(float64)
if count < 1 {
t.Errorf("expected at least 1 channel, got %v", count)
}
})
t.Run("update_channel via execute", func(t *testing.T) {
svc.CreateChannel(ctx, channels.CreateChannelRequest{
Name: "update-test", Type: "standard", Topic: "Original", CreatedBy: "agent-a",
})
req := makeRequest(map[string]any{
"code": `call("update_channel", { channel_name: "update-test", topic: "Updated topic" })`,
})
result, err := h.handleExecute(authCtx, req)
if err != nil {
t.Fatalf("handleExecute: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resultData := parseCallResult(t, result)
if resultData["topic"] != "Updated topic" {
t.Errorf("topic = %v, want 'Updated topic'", resultData["topic"])
}
})
}
+21 -42
View File
@@ -11,15 +11,15 @@ import (
mcplib "github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
"github.com/synapbus/synapbus/internal/actions"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/attachments"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/console"
"github.com/synapbus/synapbus/internal/k8s"
"github.com/synapbus/synapbus/internal/jsruntime"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/search"
"github.com/synapbus/synapbus/internal/trace"
"github.com/synapbus/synapbus/internal/webhooks"
)
// MCPServer wraps the mcp-go server with SynapBus services.
@@ -32,7 +32,7 @@ type MCPServer struct {
console *console.Printer
}
// NewMCPServer creates and configures a new MCP server with all tools registered.
// NewMCPServer creates and configures a new MCP server with 4 hybrid tools registered.
func NewMCPServer(
msgService *messaging.MessagingService,
agentService *agents.AgentService,
@@ -41,8 +41,9 @@ func NewMCPServer(
attachmentService *attachments.Service,
searchService *search.Service,
consolePrinter *console.Printer,
webhookService *webhooks.WebhookService,
k8sService *k8s.K8sService,
jsPool *jsruntime.Pool,
actionRegistry *actions.Registry,
actionIndex *actions.Index,
db *sql.DB,
) *MCPServer {
logger := slog.Default().With("component", "mcp-server")
@@ -143,42 +144,20 @@ func NewMCPServer(
server.WithHooks(hooks),
)
// Register all tools
registrar := NewToolRegistrar(msgService, agentService)
if searchService != nil {
registrar.SetSearchService(searchService)
}
if channelService != nil {
registrar.SetChannelService(channelService)
}
if db != nil {
registrar.SetDB(db)
}
registrar.RegisterAll(mcpSrv)
// Register channel tools
if channelService != nil {
channelRegistrar := NewChannelToolRegistrar(channelService, msgService)
channelRegistrar.RegisterAll(mcpSrv)
}
// Register swarm tools
if swarmService != nil && channelService != nil {
swarmRegistrar := NewSwarmToolRegistrar(swarmService, channelService)
swarmRegistrar.RegisterAll(mcpSrv)
}
// Register attachment tools
if attachmentService != nil {
attachmentRegistrar := NewAttachmentToolRegistrar(attachmentService)
attachmentRegistrar.RegisterAll(mcpSrv)
}
// Register webhook and K8s handler tools
if webhookService != nil || k8sService != nil {
webhookRegistrar := NewWebhookToolRegistrar(webhookService, k8sService)
webhookRegistrar.RegisterAll(mcpSrv)
}
// Register the 4 hybrid tools
hybridRegistrar := NewHybridToolRegistrar(
msgService,
agentService,
channelService,
swarmService,
attachmentService,
searchService,
jsPool,
actionRegistry,
actionIndex,
db,
)
hybridRegistrar.RegisterAllOnServer(mcpSrv)
// Create Streamable HTTP transport with context func for auth propagation
httpServer := server.NewStreamableHTTPServer(mcpSrv,
@@ -204,7 +183,7 @@ func NewMCPServer(
console: consolePrinter,
}
logger.Info("MCP server initialized (streamable HTTP transport)")
logger.Info("MCP server initialized (4 hybrid tools, streamable HTTP transport)")
return s
}
+46 -44
View File
@@ -2,7 +2,6 @@ package mcp
import (
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"strings"
@@ -10,14 +9,18 @@ import (
mcplib "github.com/mark3labs/mcp-go/mcp"
"github.com/synapbus/synapbus/internal/actions"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/apikeys"
"github.com/synapbus/synapbus/internal/console"
"github.com/synapbus/synapbus/internal/jsruntime"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/trace"
)
func TestNewMCPServerWithConsole(t *testing.T) {
// newTestMCPServer creates a full MCPServer for testing.
func newTestMCPServer(t *testing.T, con *console.Printer) (*MCPServer, *messaging.MessagingService, *agents.AgentService) {
t.Helper()
db := newTestDB(t)
tracer := trace.NewTracer(db)
@@ -29,9 +32,19 @@ func TestNewMCPServerWithConsole(t *testing.T) {
agentStore := agents.NewSQLiteAgentStore(db)
agentService := agents.NewAgentService(agentStore, tracer)
con := console.New()
jsPool := jsruntime.NewPool(2)
t.Cleanup(func() { jsPool.Close() })
srv := NewMCPServer(msgService, agentService, nil, nil, nil, nil, con, nil, nil, nil)
actionRegistry := actions.NewRegistry()
actionIndex := actions.NewIndex(actionRegistry.List())
srv := NewMCPServer(msgService, agentService, nil, nil, nil, nil, con, jsPool, actionRegistry, actionIndex, db)
return srv, msgService, agentService
}
func TestNewMCPServerWithConsole(t *testing.T) {
con := console.New()
srv, _, _ := newTestMCPServer(t, con)
if srv == nil {
t.Fatal("expected non-nil MCPServer")
}
@@ -44,19 +57,7 @@ func TestNewMCPServerWithConsole(t *testing.T) {
}
func TestNewMCPServerNilConsole(t *testing.T) {
db := newTestDB(t)
tracer := trace.NewTracer(db)
t.Cleanup(func() { tracer.Close() })
msgStore := messaging.NewSQLiteMessageStore(db)
msgService := messaging.NewMessagingService(msgStore, tracer)
agentStore := agents.NewSQLiteAgentStore(db)
agentService := agents.NewAgentService(agentStore, tracer)
// nil console should not panic
srv := NewMCPServer(msgService, agentService, nil, nil, nil, nil, nil, nil, nil, nil)
srv, _, _ := newTestMCPServer(t, nil)
if srv == nil {
t.Fatal("expected non-nil MCPServer")
}
@@ -99,7 +100,7 @@ func TestConnectionManagerClientInfo(t *testing.T) {
}
}
// T007: Test MCP tool calls with valid API key — agent identity is correctly resolved.
// T007: Test MCP tool calls with valid API key -- agent identity is correctly resolved.
func TestMCPToolCall_WithValidAPIKey(t *testing.T) {
db := newTestDB(t)
ctx := context.Background()
@@ -125,8 +126,14 @@ func TestMCPToolCall_WithValidAPIKey(t *testing.T) {
// Also register a receiver
agentService.Register(ctx, "receiver", "Receiver", "ai", nil, 1)
jsPool := jsruntime.NewPool(2)
defer jsPool.Close()
actionRegistry := actions.NewRegistry()
actionIndex := actions.NewIndex(actionRegistry.List())
// Create MCP server
srv := NewMCPServer(msgService, agentService, nil, nil, nil, nil, nil, nil, nil, nil)
srv := NewMCPServer(msgService, agentService, nil, nil, nil, nil, nil, jsPool, actionRegistry, actionIndex, db)
// Mount with auth middleware, just like main.go does
mux := http.NewServeMux()
@@ -156,15 +163,10 @@ func TestMCPToolCall_WithValidAPIKey(t *testing.T) {
t.Errorf("expected 200, got %d", resp.StatusCode)
}
// Verify the agent was authenticated by checking the connection manager
// (the AfterInitialize hook would have captured the agent name)
// The init should have succeeded — verify by checking no 401 was returned
t.Log("MCP connection with valid API key succeeded")
}
// T008: Test MCP tool calls without auth return 401 when auth is required.
// Note: With the current OptionalAuthMiddleware, unauthenticated requests pass through
// (returning tool-level errors). This test verifies that an invalid API key is rejected.
func TestMCPToolCall_InvalidAPIKeyReturns401(t *testing.T) {
db := newTestDB(t)
@@ -180,7 +182,13 @@ func TestMCPToolCall_InvalidAPIKeyReturns401(t *testing.T) {
apiKeyStore := apikeys.NewSQLiteStore(db)
apiKeyService := apikeys.NewService(apiKeyStore)
srv := NewMCPServer(msgService, agentService, nil, nil, nil, nil, nil, nil, nil, nil)
jsPool := jsruntime.NewPool(2)
defer jsPool.Close()
actionRegistry := actions.NewRegistry()
actionIndex := actions.NewIndex(actionRegistry.List())
srv := NewMCPServer(msgService, agentService, nil, nil, nil, nil, nil, jsPool, actionRegistry, actionIndex, db)
mux := http.NewServeMux()
handler := agents.OptionalAuthMiddlewareWithAPIKeys(agentService, apiKeyService)(srv.Handler())
@@ -212,7 +220,7 @@ func TestMCPToolCall_InvalidAPIKeyReturns401(t *testing.T) {
// T008 (continued): Test that unauthenticated MCP tool calls (no auth header at all)
// are rejected at the tool handler level.
func TestMCPToolCall_NoAuthReturnsToolError(t *testing.T) {
tr, _, agentSvc, _ := newTestRegistrar(t)
h, _, agentSvc, _ := newTestHybridRegistrar(t)
ctx := context.Background()
// Register a receiver so the send would work if auth was present
@@ -224,7 +232,7 @@ func TestMCPToolCall_NoAuthReturnsToolError(t *testing.T) {
"body": "should fail",
})
result, err := tr.handleSendMessage(ctx, req)
result, err := h.handleSendMessage(ctx, req)
if err != nil {
t.Fatalf("handleSendMessage returned error: %v", err)
}
@@ -239,10 +247,8 @@ func TestMCPToolCall_NoAuthReturnsToolError(t *testing.T) {
}
// T009: Verify send_message enforces from_agent from the authenticated context.
// The send_message tool does NOT expose a "from" parameter — the sender is always
// derived from the authenticated agent identity in the context.
func TestSendMessage_EnforcesAuthenticatedAgent(t *testing.T) {
tr, _, agentSvc, _ := newTestRegistrar(t)
h, _, agentSvc, _ := newTestHybridRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "real-sender", "Real Sender", "ai", nil, 1)
@@ -252,16 +258,13 @@ func TestSendMessage_EnforcesAuthenticatedAgent(t *testing.T) {
// Authenticate as "real-sender"
authCtx := ContextWithAgentName(ctx, "real-sender")
// Try to send a message — even if someone could supply a "from" field,
// the handler should use the authenticated agent name, not a user-supplied value.
// Send a message
req := makeRequest(map[string]any{
"to": "receiver",
"body": "message from real sender",
// Note: there is no "from" parameter in the send_message tool definition,
// but even if extra args are passed, the handler ignores them.
})
result, err := tr.handleSendMessage(authCtx, req)
result, err := h.handleSendMessage(authCtx, req)
if err != nil {
t.Fatalf("handleSendMessage: %v", err)
}
@@ -269,16 +272,15 @@ func TestSendMessage_EnforcesAuthenticatedAgent(t *testing.T) {
t.Fatalf("unexpected error: %v", result.Content)
}
// Verify the message was sent from "real-sender" by reading receiver's inbox
// Verify the message was sent from "real-sender" by reading receiver's inbox via execute
inboxCtx := ContextWithAgentName(ctx, "receiver")
inboxReq := makeRequest(map[string]any{})
inboxResult, _ := tr.handleReadInbox(inboxCtx, inboxReq)
inboxReq := makeRequest(map[string]any{
"code": `call("read_inbox", {})`,
})
inboxResult, _ := h.handleExecute(inboxCtx, inboxReq)
text := inboxResult.Content[0].(mcplib.TextContent).Text
var resp map[string]any
json.Unmarshal([]byte(text), &resp)
messages := resp["messages"].([]any)
resultData := parseCallResult(t, inboxResult)
messages := resultData["messages"].([]any)
if len(messages) != 1 {
t.Fatalf("expected 1 message, got %d", len(messages))
}
@@ -286,6 +288,6 @@ func TestSendMessage_EnforcesAuthenticatedAgent(t *testing.T) {
msg := messages[0].(map[string]any)
fromAgent := msg["from_agent"].(string)
if fromAgent != "real-sender" {
t.Errorf("message from_agent = %q, want %q — send_message must enforce authenticated agent", fromAgent, "real-sender")
t.Errorf("message from_agent = %q, want %q -- send_message must enforce authenticated agent", fromAgent, "real-sender")
}
}
-285
View File
@@ -1,285 +0,0 @@
package mcp
import (
"context"
"encoding/json"
"fmt"
"log/slog"
"time"
"github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
"github.com/synapbus/synapbus/internal/channels"
)
// SwarmToolRegistrar registers swarm-pattern MCP tools on the server.
type SwarmToolRegistrar struct {
swarmService *channels.SwarmService
channelService *channels.Service
logger *slog.Logger
}
// NewSwarmToolRegistrar creates a new swarm tool registrar.
func NewSwarmToolRegistrar(swarmService *channels.SwarmService, channelService *channels.Service) *SwarmToolRegistrar {
return &SwarmToolRegistrar{
swarmService: swarmService,
channelService: channelService,
logger: slog.Default().With("component", "mcp-swarm-tools"),
}
}
// RegisterAll registers all swarm tools on the MCP server.
func (str *SwarmToolRegistrar) RegisterAll(s *server.MCPServer) {
s.AddTool(str.postTaskTool(), str.handlePostTask)
s.AddTool(str.bidTaskTool(), str.handleBidTask)
s.AddTool(str.acceptBidTool(), str.handleAcceptBid)
s.AddTool(str.completeTaskTool(), str.handleCompleteTask)
s.AddTool(str.listTasksTool(), str.handleListTasks)
str.logger.Info("swarm MCP tools registered", "count", 5)
}
// --- Tool Definitions ---
func (str *SwarmToolRegistrar) postTaskTool() mcp.Tool {
return mcp.NewTool("post_task",
mcp.WithDescription("Post a task to an auction channel for agents to bid on"),
mcp.WithString("channel_name", mcp.Description("Name of the auction channel"), mcp.Required()),
mcp.WithString("title", mcp.Description("Task title"), mcp.Required()),
mcp.WithString("description", mcp.Description("Task description")),
mcp.WithString("requirements", mcp.Description("JSON object of task requirements")),
mcp.WithString("deadline", mcp.Description("Task deadline in ISO 8601 format (e.g. 2026-03-13T15:00:00Z)")),
)
}
func (str *SwarmToolRegistrar) bidTaskTool() mcp.Tool {
return mcp.NewTool("bid_task",
mcp.WithDescription("Submit a bid on an open task in an auction channel"),
mcp.WithNumber("task_id", mcp.Description("ID of the task to bid on"), mcp.Required()),
mcp.WithString("capabilities", mcp.Description("JSON object describing your relevant capabilities")),
mcp.WithString("time_estimate", mcp.Description("Estimated time to complete the task")),
mcp.WithString("message", mcp.Description("Message to the task poster explaining your bid")),
)
}
func (str *SwarmToolRegistrar) acceptBidTool() mcp.Tool {
return mcp.NewTool("accept_bid",
mcp.WithDescription("Accept a bid on a task you posted, assigning the task to the bidding agent"),
mcp.WithNumber("task_id", mcp.Description("ID of the task"), mcp.Required()),
mcp.WithNumber("bid_id", mcp.Description("ID of the bid to accept"), mcp.Required()),
)
}
func (str *SwarmToolRegistrar) completeTaskTool() mcp.Tool {
return mcp.NewTool("complete_task",
mcp.WithDescription("Mark a task as completed (only the assigned agent can do this)"),
mcp.WithNumber("task_id", mcp.Description("ID of the task to complete"), mcp.Required()),
)
}
func (str *SwarmToolRegistrar) listTasksTool() mcp.Tool {
return mcp.NewTool("list_tasks",
mcp.WithDescription("List tasks in an auction channel, optionally filtered by status"),
mcp.WithString("channel_name", mcp.Description("Name of the auction channel"), mcp.Required()),
mcp.WithString("status", mcp.Description("Filter by task status: open, assigned, completed, cancelled")),
)
}
// --- Tool Handlers ---
func (str *SwarmToolRegistrar) handlePostTask(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
channelName := req.GetString("channel_name", "")
if channelName == "" {
return mcp.NewToolResultError("'channel_name' parameter is required"), nil
}
title := req.GetString("title", "")
if title == "" {
return mcp.NewToolResultError("'title' parameter is required"), nil
}
description := req.GetString("description", "")
requirementsStr := req.GetString("requirements", "{}")
deadlineStr := req.GetString("deadline", "")
// Parse requirements JSON
var requirements json.RawMessage
if requirementsStr != "" {
if !json.Valid([]byte(requirementsStr)) {
return mcp.NewToolResultError("requirements must be valid JSON"), nil
}
requirements = json.RawMessage(requirementsStr)
}
// Parse deadline
var deadline *time.Time
if deadlineStr != "" {
t, err := time.Parse(time.RFC3339, deadlineStr)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("deadline must be ISO 8601 format: %s", err)), nil
}
deadline = &t
}
// Resolve channel
ch, err := str.channelService.GetChannelByName(ctx, channelName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("post_task failed: %s", err)), nil
}
task, err := str.swarmService.PostTask(ctx, ch.ID, agentName, title, description, requirements, deadline)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("post_task failed: %s", err)), nil
}
return resultJSON(map[string]any{
"task_id": task.ID,
"channel_id": task.ChannelID,
"title": task.Title,
"status": task.Status,
"posted_by": task.PostedBy,
"deadline": task.Deadline,
"created_at": task.CreatedAt,
})
}
func (str *SwarmToolRegistrar) handleBidTask(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
taskID, err := req.RequireInt("task_id")
if err != nil {
return mcp.NewToolResultError("'task_id' parameter is required"), nil
}
capabilitiesStr := req.GetString("capabilities", "{}")
timeEstimate := req.GetString("time_estimate", "")
message := req.GetString("message", "")
var capabilities json.RawMessage
if capabilitiesStr != "" {
if !json.Valid([]byte(capabilitiesStr)) {
return mcp.NewToolResultError("capabilities must be valid JSON"), nil
}
capabilities = json.RawMessage(capabilitiesStr)
}
bid, err := str.swarmService.BidOnTask(ctx, int64(taskID), agentName, capabilities, timeEstimate, message)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("bid_task failed: %s", err)), nil
}
return resultJSON(map[string]any{
"bid_id": bid.ID,
"task_id": bid.TaskID,
"agent_name": bid.AgentName,
"time_estimate": bid.TimeEstimate,
"status": bid.Status,
})
}
func (str *SwarmToolRegistrar) handleAcceptBid(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
taskID, err := req.RequireInt("task_id")
if err != nil {
return mcp.NewToolResultError("'task_id' parameter is required"), nil
}
bidID, err := req.RequireInt("bid_id")
if err != nil {
return mcp.NewToolResultError("'bid_id' parameter is required"), nil
}
if err := str.swarmService.AcceptBid(ctx, int64(taskID), int64(bidID), agentName); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("accept_bid failed: %s", err)), nil
}
return resultJSON(map[string]any{
"task_id": taskID,
"bid_id": bidID,
"status": "accepted",
})
}
func (str *SwarmToolRegistrar) handleCompleteTask(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
taskID, err := req.RequireInt("task_id")
if err != nil {
return mcp.NewToolResultError("'task_id' parameter is required"), nil
}
if err := str.swarmService.CompleteTask(ctx, int64(taskID), agentName); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("complete_task failed: %s", err)), nil
}
return resultJSON(map[string]any{
"task_id": taskID,
"status": "completed",
})
}
func (str *SwarmToolRegistrar) handleListTasks(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
_ = agentName // just verifying auth
channelName := req.GetString("channel_name", "")
if channelName == "" {
return mcp.NewToolResultError("'channel_name' parameter is required"), nil
}
statusFilter := req.GetString("status", "")
// Resolve channel
ch, err := str.channelService.GetChannelByName(ctx, channelName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("list_tasks failed: %s", err)), nil
}
// Verify channel is auction type
if ch.Type != channels.TypeAuction {
return mcp.NewToolResultError(fmt.Sprintf("list_tasks requires a channel of type 'auction', got '%s'", ch.Type)), nil
}
tasks, err := str.swarmService.ListTasks(ctx, ch.ID, statusFilter)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("list_tasks failed: %s", err)), nil
}
result := make([]map[string]any, len(tasks))
for i, task := range tasks {
result[i] = map[string]any{
"id": task.ID,
"title": task.Title,
"description": task.Description,
"status": task.Status,
"posted_by": task.PostedBy,
"assigned_to": task.AssignedTo,
"deadline": task.Deadline,
"created_at": task.CreatedAt,
}
}
return resultJSON(map[string]any{
"tasks": result,
"count": len(result),
})
}
-552
View File
@@ -1,564 +1,12 @@
package mcp
import (
"context"
"database/sql"
"encoding/json"
"fmt"
"log/slog"
"strings"
"github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/search"
)
// ToolRegistrar registers all SynapBus MCP tools on the given server.
type ToolRegistrar struct {
msgService *messaging.MessagingService
agentService *agents.AgentService
channelService *channels.Service
searchService *search.Service
db *sql.DB
logger *slog.Logger
}
// NewToolRegistrar creates a new tool registrar.
func NewToolRegistrar(msgService *messaging.MessagingService, agentService *agents.AgentService) *ToolRegistrar {
return &ToolRegistrar{
msgService: msgService,
agentService: agentService,
logger: slog.Default().With("component", "mcp-tools"),
}
}
// SetSearchService sets the search service for semantic search support.
func (tr *ToolRegistrar) SetSearchService(svc *search.Service) {
tr.searchService = svc
}
// SetChannelService sets the channel service for my_status support.
func (tr *ToolRegistrar) SetChannelService(svc *channels.Service) {
tr.channelService = svc
}
// SetDB sets the database handle for direct queries (e.g. owner name lookup).
func (tr *ToolRegistrar) SetDB(db *sql.DB) {
tr.db = db
}
// RegisterAll registers all tools on the MCP server.
// Note: Agent management tools (register, update, deregister) are NOT exposed via MCP.
// Agents are managed exclusively through the Web UI. MCP is for messaging only.
func (tr *ToolRegistrar) RegisterAll(s *server.MCPServer) {
s.AddTool(tr.myStatusTool(), tr.handleMyStatus)
s.AddTool(tr.sendMessageTool(), tr.handleSendMessage)
s.AddTool(tr.readInboxTool(), tr.handleReadInbox)
s.AddTool(tr.claimMessagesTool(), tr.handleClaimMessages)
s.AddTool(tr.markDoneTool(), tr.handleMarkDone)
s.AddTool(tr.searchMessagesTool(), tr.handleSearchMessages)
s.AddTool(tr.discoverAgentsTool(), tr.handleDiscoverAgents)
tr.logger.Info("all MCP tools registered", "count", 7)
}
// --- Tool Definitions ---
func (tr *ToolRegistrar) sendMessageTool() mcp.Tool {
return mcp.NewTool("send_message",
mcp.WithDescription("Send a direct message to another agent. Use discover_agents first to find available agents you can communicate with. For channel messages, use send_channel_message instead."),
mcp.WithString("to", mcp.Description("Name of the recipient agent (required for DMs, omit for channel messages)")),
mcp.WithString("body", mcp.Description("Message body text"), mcp.Required()),
mcp.WithString("subject", mcp.Description("Conversation subject (optional)")),
mcp.WithNumber("priority", mcp.Description("Message priority (1-10, default 5)"), mcp.Min(1), mcp.Max(10)),
mcp.WithString("metadata", mcp.Description("JSON metadata object (optional)")),
mcp.WithNumber("channel_id", mcp.Description("Channel ID for channel messages (optional)")),
mcp.WithNumber("reply_to", mcp.Description("ID of the message to reply to (optional, for threading)")),
)
}
func (tr *ToolRegistrar) readInboxTool() mcp.Tool {
return mcp.NewTool("read_inbox",
mcp.WithDescription("Check your message inbox for pending messages. Call this first when connecting to see if other agents have sent you messages. Returns unread/pending direct messages addressed to you."),
mcp.WithNumber("limit", mcp.Description("Maximum number of messages to return (default 50)")),
mcp.WithString("status_filter", mcp.Description("Filter by message status: pending, processing, done, failed")),
mcp.WithBoolean("include_read", mcp.Description("Include previously read messages (default false)")),
mcp.WithNumber("min_priority", mcp.Description("Minimum priority filter (1-10)")),
mcp.WithString("from_agent", mcp.Description("Filter by sender agent name")),
)
}
func (tr *ToolRegistrar) claimMessagesTool() mcp.Tool {
return mcp.NewTool("claim_messages",
mcp.WithDescription("Atomically claim pending messages for processing"),
mcp.WithNumber("limit", mcp.Description("Maximum number of messages to claim (default 10)")),
)
}
func (tr *ToolRegistrar) markDoneTool() mcp.Tool {
return mcp.NewTool("mark_done",
mcp.WithDescription("Mark a claimed message as done or failed"),
mcp.WithNumber("message_id", mcp.Description("ID of the message to mark"), mcp.Required()),
mcp.WithString("status", mcp.Description("New status: 'done' or 'failed' (default 'done')")),
mcp.WithString("reason", mcp.Description("Failure reason (only for status='failed')")),
)
}
func (tr *ToolRegistrar) searchMessagesTool() mcp.Tool {
return mcp.NewTool("search_messages",
mcp.WithDescription("Search for messages across your inbox and channels you are a member of. Supports full-text and semantic search (if configured). Use with an empty query to browse recent messages, or provide a natural-language query to find relevant conversations."),
mcp.WithString("query", mcp.Description("Search query string — supports natural language for semantic search")),
mcp.WithNumber("limit", mcp.Description("Maximum results to return (default 10, max 100)")),
mcp.WithNumber("min_priority", mcp.Description("Minimum priority filter (1-10)")),
mcp.WithString("from_agent", mcp.Description("Filter by sender agent name")),
mcp.WithString("status", mcp.Description("Filter by message status")),
mcp.WithString("search_mode", mcp.Description("Search mode: 'auto' (default), 'semantic', or 'fulltext'")),
mcp.WithBoolean("semantic", mcp.Description("Force semantic search (shorthand for search_mode='semantic')")),
)
}
func (tr *ToolRegistrar) discoverAgentsTool() mcp.Tool {
return mcp.NewTool("discover_agents",
mcp.WithDescription("Discover other agents on the bus. Call this to find agents you can communicate with. Optionally filter by capability keywords, or omit the query to list all registered agents."),
mcp.WithString("query", mcp.Description("Capability keyword to search for")),
)
}
func (tr *ToolRegistrar) myStatusTool() mcp.Tool {
return mcp.NewTool("my_status",
mcp.WithDescription("Get your complete status overview — identity, pending messages, channel mentions, system notifications, and statistics. Call this first when connecting to SynapBus."),
)
}
// --- Tool Handlers ---
func (tr *ToolRegistrar) handleSendMessage(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
to := req.GetString("to", "")
body := req.GetString("body", "")
subject := req.GetString("subject", "")
priority := req.GetInt("priority", 5)
metadataStr := req.GetString("metadata", "")
if body == "" {
return mcp.NewToolResultError("'body' parameter is required"), nil
}
var channelID *int64
if cid := req.GetInt("channel_id", 0); cid > 0 {
v := int64(cid)
channelID = &v
}
var replyTo *int64
if rtID := req.GetInt("reply_to", 0); rtID > 0 {
v := int64(rtID)
replyTo = &v
}
opts := messaging.SendOptions{
Subject: subject,
Priority: priority,
Metadata: metadataStr,
ChannelID: channelID,
ReplyTo: replyTo,
}
msg, err := tr.msgService.SendMessage(ctx, agentName, to, body, opts)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("send_message failed: %s", err)), nil
}
return resultJSON(map[string]any{
"message_id": msg.ID,
"conversation_id": msg.ConversationID,
"status": msg.Status,
})
}
func (tr *ToolRegistrar) handleReadInbox(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
opts := messaging.ReadOptions{
Limit: req.GetInt("limit", 50),
Status: req.GetString("status_filter", ""),
MinPriority: req.GetInt("min_priority", 0),
FromAgent: req.GetString("from_agent", ""),
}
// Handle include_read boolean
args := req.GetArguments()
if v, ok := args["include_read"]; ok {
if b, ok := v.(bool); ok {
opts.IncludeRead = b
}
}
messages, err := tr.msgService.ReadInbox(ctx, agentName, opts)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("read_inbox failed: %s", err)), nil
}
return resultJSON(map[string]any{
"messages": messages,
"count": len(messages),
})
}
func (tr *ToolRegistrar) handleClaimMessages(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
limit := req.GetInt("limit", 10)
messages, err := tr.msgService.ClaimMessages(ctx, agentName, limit)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("claim_messages failed: %s", err)), nil
}
return resultJSON(map[string]any{
"messages": messages,
"count": len(messages),
})
}
func (tr *ToolRegistrar) handleMarkDone(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
messageID, err := req.RequireInt("message_id")
if err != nil {
return mcp.NewToolResultError("'message_id' parameter is required"), nil
}
status := req.GetString("status", "done")
reason := req.GetString("reason", "")
switch status {
case "done":
if err := tr.msgService.MarkDone(ctx, int64(messageID), agentName); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("mark_done failed: %s", err)), nil
}
case "failed":
if err := tr.msgService.MarkFailed(ctx, int64(messageID), agentName, reason); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("mark_failed failed: %s", err)), nil
}
default:
return mcp.NewToolResultError("status must be 'done' or 'failed'"), nil
}
return resultJSON(map[string]any{
"message_id": messageID,
"status": status,
})
}
func (tr *ToolRegistrar) handleSearchMessages(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
query := req.GetString("query", "")
// If search service is available, use it for unified search
if tr.searchService != nil {
searchMode := req.GetString("search_mode", "auto")
// Handle boolean "semantic" shorthand
args := req.GetArguments()
if v, ok := args["semantic"]; ok {
if b, ok := v.(bool); ok && b {
searchMode = "semantic"
}
}
opts := search.SearchOptions{
Query: query,
Mode: searchMode,
Limit: req.GetInt("limit", 10),
FromAgent: req.GetString("from_agent", ""),
MinPriority: req.GetInt("min_priority", 0),
}
resp, err := tr.searchService.Search(ctx, agentName, opts)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("search_messages failed: %s", err)), nil
}
// Format results
resultMsgs := make([]map[string]any, len(resp.Results))
for i, r := range resp.Results {
entry := map[string]any{
"message": r.Message,
"match_type": r.MatchType,
}
if r.SimilarityScore > 0 {
entry["similarity_score"] = r.SimilarityScore
}
if r.RelevanceScore > 0 {
entry["relevance_score"] = r.RelevanceScore
}
resultMsgs[i] = entry
}
result := map[string]any{
"results": resultMsgs,
"count": resp.TotalResults,
"search_mode": resp.SearchMode,
}
if resp.Warning != "" {
result["warning"] = resp.Warning
}
return resultJSON(result)
}
// Fallback: use messaging service directly (no search service configured)
msgOpts := messaging.SearchOptions{
Limit: req.GetInt("limit", 20),
MinPriority: req.GetInt("min_priority", 0),
FromAgent: req.GetString("from_agent", ""),
Status: req.GetString("status", ""),
}
messages, err := tr.msgService.SearchMessages(ctx, agentName, query, msgOpts)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("search_messages failed: %s", err)), nil
}
return resultJSON(map[string]any{
"messages": messages,
"count": len(messages),
"search_mode": "fulltext",
})
}
func (tr *ToolRegistrar) handleDiscoverAgents(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
query := req.GetString("query", "")
_ = agentName // just verifying auth
agentsList, err := tr.agentService.DiscoverAgents(ctx, query)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("discover_agents failed: %s", err)), nil
}
// Strip sensitive fields, exclude system agent
result := make([]map[string]any, 0, len(agentsList))
for _, a := range agentsList {
if a.Name == "system" {
continue
}
result = append(result, map[string]any{
"name": a.Name,
"display_name": a.DisplayName,
"type": a.Type,
"capabilities": a.Capabilities,
"status": a.Status,
})
}
return resultJSON(map[string]any{
"agents": result,
"count": len(result),
})
}
func (tr *ToolRegistrar) handleMyStatus(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
// 1. Get agent identity
agent, err := tr.agentService.GetAgent(ctx, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
// Resolve owner name from users table
ownerName := ""
if tr.db != nil {
var username sql.NullString
_ = tr.db.QueryRowContext(ctx,
`SELECT username FROM users WHERE id = ?`, agent.OwnerID,
).Scan(&username)
if username.Valid {
ownerName = username.String
}
}
agentInfo := map[string]any{
"name": agent.Name,
"display_name": agent.DisplayName,
"type": agent.Type,
"owner": ownerName,
}
// 2. Get pending DMs
pendingDMs, err := tr.msgService.GetPendingDMs(ctx, agentName, 10)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
pendingDMCount, err := tr.msgService.GetPendingDMCount(ctx, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
dmList := make([]map[string]any, len(pendingDMs))
for i, msg := range pendingDMs {
body := msg.Body
if len(body) > 200 {
body = body[:200] + "..."
}
entry := map[string]any{
"id": msg.ID,
"from": msg.FromAgent,
"body": body,
"priority": msg.Priority,
"status": msg.Status,
"created_at": msg.CreatedAt,
}
// Include subject from conversation if available
if msg.ConversationID > 0 {
conv, _, _ := tr.msgService.GetConversation(ctx, msg.ConversationID)
if conv != nil && conv.Subject != "" {
entry["subject"] = conv.Subject
}
}
dmList[i] = entry
}
// 3. Get channel mentions
mentions, err := tr.msgService.GetRecentMentions(ctx, agentName, 10)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
mentionList := make([]map[string]any, len(mentions))
for i, msg := range mentions {
body := msg.Body
if len(body) > 200 {
body = body[:200] + "..."
}
entry := map[string]any{
"id": msg.ID,
"from": msg.FromAgent,
"body": body,
"created_at": msg.CreatedAt,
}
// Try to extract channel name from metadata
if len(msg.Metadata) > 0 {
var meta map[string]any
if json.Unmarshal(msg.Metadata, &meta) == nil {
if chName, ok := meta["channel_name"].(string); ok {
entry["channel"] = chName
}
}
}
mentionList[i] = entry
}
// 4. Get system notifications
sysNotifs, err := tr.msgService.GetSystemNotifications(ctx, agentName, 5)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
sysNotifList := make([]map[string]any, len(sysNotifs))
for i, msg := range sysNotifs {
body := msg.Body
if len(body) > 200 {
body = body[:200] + "..."
}
sysNotifList[i] = map[string]any{
"id": msg.ID,
"body": body,
"created_at": msg.CreatedAt,
}
}
// 5. Get channel summaries
var channelSummaries []channels.ChannelSummary
if tr.channelService != nil {
channelSummaries, err = tr.channelService.GetChannelSummaries(ctx, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
}
if channelSummaries == nil {
channelSummaries = []channels.ChannelSummary{}
}
// 6. Build stats
totalUnreadChannel := 0
for _, cs := range channelSummaries {
totalUnreadChannel += cs.UnreadCount
}
stats := map[string]any{
"pending_dms": pendingDMCount,
"channels_joined": len(channelSummaries),
"unread_channel_messages": totalUnreadChannel,
"system_notifications": len(sysNotifs),
}
// 7. Build truncation instructions
var instructionParts []string
truncated := false
if int64(len(pendingDMs)) < pendingDMCount {
truncated = true
instructionParts = append(instructionParts, fmt.Sprintf("Showing %d of %d pending messages. Use read_inbox to see all.", len(pendingDMs), pendingDMCount))
}
if len(mentions) >= 10 {
truncated = true
instructionParts = append(instructionParts, fmt.Sprintf("Showing %d mentions (may be more). Use search_messages to find all.", len(mentions)))
}
if len(sysNotifs) >= 5 {
truncated = true
instructionParts = append(instructionParts, fmt.Sprintf("Showing %d system notifications (may be more). Use read_inbox with from_agent='system' to see all.", len(sysNotifs)))
}
result := map[string]any{
"agent": agentInfo,
"direct_messages": dmList,
"direct_messages_total": pendingDMCount,
"mentions": mentionList,
"mentions_total": len(mentions),
"system_notifications": sysNotifList,
"system_notifications_total": len(sysNotifs),
"channels": channelSummaries,
"stats": stats,
"truncated": truncated,
}
if len(instructionParts) > 0 {
result["instructions"] = strings.Join(instructionParts, " ")
}
return resultJSON(result)
}
// resultJSON marshals data to a JSON text MCP result.
func resultJSON(data any) (*mcp.CallToolResult, error) {
b, err := json.Marshal(data)
-161
View File
@@ -1,161 +0,0 @@
package mcp
import (
"bytes"
"context"
"encoding/base64"
"fmt"
"io"
"github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
"github.com/synapbus/synapbus/internal/attachments"
)
// AttachmentToolRegistrar registers attachment MCP tools on the server.
type AttachmentToolRegistrar struct {
attachmentService *attachments.Service
}
// NewAttachmentToolRegistrar creates a new attachment tool registrar.
func NewAttachmentToolRegistrar(attachmentService *attachments.Service) *AttachmentToolRegistrar {
return &AttachmentToolRegistrar{
attachmentService: attachmentService,
}
}
// RegisterAll registers all attachment tools on the MCP server.
func (atr *AttachmentToolRegistrar) RegisterAll(s *server.MCPServer) {
s.AddTool(atr.uploadAttachmentTool(), atr.handleUploadAttachment)
s.AddTool(atr.downloadAttachmentTool(), atr.handleDownloadAttachment)
s.AddTool(atr.gcAttachmentsTool(), atr.handleGCAttachments)
}
// --- Tool Definitions ---
func (atr *AttachmentToolRegistrar) uploadAttachmentTool() mcp.Tool {
return mcp.NewTool("upload_attachment",
mcp.WithDescription("Upload a file attachment. Content must be base64-encoded. Returns the SHA-256 hash for later retrieval. Max file size: 50MB."),
mcp.WithString("content", mcp.Description("Base64-encoded file content"), mcp.Required()),
mcp.WithString("filename", mcp.Description("Original filename (optional, used for MIME detection and display)")),
mcp.WithString("mime_type", mcp.Description("MIME type override (optional, auto-detected from content if not provided)")),
mcp.WithNumber("message_id", mcp.Description("Message ID to attach the file to (optional, can be linked later)")),
)
}
func (atr *AttachmentToolRegistrar) downloadAttachmentTool() mcp.Tool {
return mcp.NewTool("download_attachment",
mcp.WithDescription("Download an attachment by its SHA-256 hash. Returns base64-encoded content along with filename and MIME type metadata."),
mcp.WithString("hash", mcp.Description("SHA-256 hash of the attachment"), mcp.Required()),
)
}
func (atr *AttachmentToolRegistrar) gcAttachmentsTool() mcp.Tool {
return mcp.NewTool("gc_attachments",
mcp.WithDescription("Run garbage collection to remove orphaned attachments not referenced by any message. Returns a summary of files removed and bytes reclaimed."),
)
}
// --- Tool Handlers ---
func (atr *AttachmentToolRegistrar) handleUploadAttachment(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
contentB64 := req.GetString("content", "")
if contentB64 == "" {
return mcp.NewToolResultError("'content' parameter is required"), nil
}
// Check base64 size before decoding to avoid buffering oversized content.
// Base64 expands data by ~4/3, so decoded size is roughly 3/4 of encoded.
if int64(len(contentB64))*3/4 > attachments.MaxFileSize {
return mcp.NewToolResultError("file exceeds maximum size of 50MB"), nil
}
decoded, err := base64.StdEncoding.DecodeString(contentB64)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("invalid base64 content: %s", err)), nil
}
if int64(len(decoded)) > attachments.MaxFileSize {
return mcp.NewToolResultError("file exceeds maximum size of 50MB"), nil
}
uploadReq := attachments.UploadRequest{
Content: bytes.NewReader(decoded),
Filename: req.GetString("filename", ""),
MIMEType: req.GetString("mime_type", ""),
UploadedBy: agentName,
}
// Optional message_id.
if mid := req.GetInt("message_id", 0); mid > 0 {
v := int64(mid)
uploadReq.MessageID = &v
}
result, err := atr.attachmentService.Upload(ctx, uploadReq)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("upload_attachment failed: %s", err)), nil
}
return resultJSON(map[string]any{
"hash": result.Hash,
"size": result.Size,
"mime_type": result.MIMEType,
"original_filename": result.Filename,
})
}
func (atr *AttachmentToolRegistrar) handleDownloadAttachment(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
_, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
hash := req.GetString("hash", "")
if hash == "" {
return mcp.NewToolResultError("'hash' parameter is required"), nil
}
result, err := atr.attachmentService.Download(ctx, hash)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("download_attachment failed: %s", err)), nil
}
defer result.Content.Close()
// Read content and base64-encode it.
content, err := io.ReadAll(result.Content)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("read attachment content failed: %s", err)), nil
}
return resultJSON(map[string]any{
"hash": result.Hash,
"content": base64.StdEncoding.EncodeToString(content),
"original_filename": result.Filename,
"mime_type": result.MIMEType,
"size": result.Size,
})
}
func (atr *AttachmentToolRegistrar) handleGCAttachments(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
_, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
result, err := atr.attachmentService.GarbageCollect(ctx)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("gc_attachments failed: %s", err)), nil
}
return resultJSON(map[string]any{
"files_removed": result.FilesRemoved,
"bytes_reclaimed": result.BytesReclaimed,
})
}
+477
View File
@@ -0,0 +1,477 @@
package mcp
import (
"context"
"database/sql"
"encoding/json"
"fmt"
"log/slog"
"strings"
"time"
mcplib "github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
"github.com/synapbus/synapbus/internal/actions"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/attachments"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/jsruntime"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/search"
)
// HybridToolRegistrar registers the 4 hybrid MCP tools.
type HybridToolRegistrar struct {
msgService *messaging.MessagingService
agentService *agents.AgentService
channelService *channels.Service
swarmService *channels.SwarmService
attachmentService *attachments.Service
searchService *search.Service
jsPool *jsruntime.Pool
actionRegistry *actions.Registry
actionIndex *actions.Index
db *sql.DB
logger *slog.Logger
}
// NewHybridToolRegistrar creates a new hybrid tool registrar.
func NewHybridToolRegistrar(
msgService *messaging.MessagingService,
agentService *agents.AgentService,
channelService *channels.Service,
swarmService *channels.SwarmService,
attachmentService *attachments.Service,
searchService *search.Service,
jsPool *jsruntime.Pool,
actionRegistry *actions.Registry,
actionIndex *actions.Index,
db *sql.DB,
) *HybridToolRegistrar {
return &HybridToolRegistrar{
msgService: msgService,
agentService: agentService,
channelService: channelService,
swarmService: swarmService,
attachmentService: attachmentService,
searchService: searchService,
jsPool: jsPool,
actionRegistry: actionRegistry,
actionIndex: actionIndex,
db: db,
logger: slog.Default().With("component", "mcp-hybrid-tools"),
}
}
// RegisterAllOnServer registers all 4 hybrid tools on an mcp-go MCPServer.
func (h *HybridToolRegistrar) RegisterAllOnServer(s *server.MCPServer) {
s.AddTool(h.myStatusTool(), h.handleMyStatus)
s.AddTool(h.sendMessageTool(), h.handleSendMessage)
s.AddTool(h.searchTool(), h.handleSearch)
s.AddTool(h.executeTool(), h.handleExecute)
h.logger.Info("hybrid MCP tools registered", "count", 4)
}
// --- Tool Definitions ---
func (h *HybridToolRegistrar) myStatusTool() mcplib.Tool {
return mcplib.NewTool("my_status",
mcplib.WithDescription("Get your complete status overview — identity, pending messages, channel mentions, system notifications, and statistics. Call this first when connecting to SynapBus."),
)
}
func (h *HybridToolRegistrar) sendMessageTool() mcplib.Tool {
return mcplib.NewTool("send_message",
mcplib.WithDescription("Send a message to another agent (DM) or to a channel. Specify exactly one of 'to' (agent name for DM) or 'channel' (channel name or numeric ID)."),
mcplib.WithString("to", mcplib.Description("Recipient agent name for direct messages")),
mcplib.WithString("channel", mcplib.Description("Channel name or numeric ID for channel messages")),
mcplib.WithString("body", mcplib.Description("Message body text"), mcplib.Required()),
mcplib.WithString("subject", mcplib.Description("Conversation subject (optional)")),
mcplib.WithNumber("priority", mcplib.Description("Message priority (1-10, default 5)"), mcplib.Min(1), mcplib.Max(10)),
mcplib.WithString("metadata", mcplib.Description("JSON metadata object (optional)")),
mcplib.WithNumber("reply_to", mcplib.Description("ID of the message to reply to (optional, for threading)")),
)
}
func (h *HybridToolRegistrar) searchTool() mcplib.Tool {
return mcplib.NewTool("search",
mcplib.WithDescription("Search for available actions you can perform via the 'execute' tool. Returns action names, descriptions, parameters, and examples. Use an empty query to browse all actions, or describe what you want to do."),
mcplib.WithString("query", mcplib.Description("What you want to do — e.g. 'read messages', 'create channel', 'upload file'")),
mcplib.WithNumber("limit", mcplib.Description("Maximum results to return (default 5, max 20)")),
)
}
func (h *HybridToolRegistrar) executeTool() mcplib.Tool {
return mcplib.NewTool("execute",
mcplib.WithDescription("Execute code that calls SynapBus actions. Use call(actionName, args) to invoke actions discovered via the 'search' tool. Multiple sequential calls are supported."),
mcplib.WithString("code", mcplib.Description("Code containing call() expressions. Example: call('read_inbox', { limit: 5 })"), mcplib.Required()),
mcplib.WithNumber("timeout", mcplib.Description("Execution timeout in milliseconds (default 120000, max 300000)")),
)
}
// --- Tool Handlers ---
func (h *HybridToolRegistrar) handleMyStatus(ctx context.Context, req mcplib.CallToolRequest) (*mcplib.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcplib.NewToolResultError("authentication required"), nil
}
// 1. Get agent identity.
agent, err := h.agentService.GetAgent(ctx, agentName)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
// Resolve owner name.
ownerName := ""
if h.db != nil {
var username sql.NullString
_ = h.db.QueryRowContext(ctx,
`SELECT username FROM users WHERE id = ?`, agent.OwnerID,
).Scan(&username)
if username.Valid {
ownerName = username.String
}
}
agentInfo := map[string]any{
"name": agent.Name,
"display_name": agent.DisplayName,
"type": agent.Type,
"owner": ownerName,
}
// 2. Get pending DMs.
pendingDMs, err := h.msgService.GetPendingDMs(ctx, agentName, 10)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
pendingDMCount, err := h.msgService.GetPendingDMCount(ctx, agentName)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
dmList := make([]map[string]any, len(pendingDMs))
for i, msg := range pendingDMs {
body := msg.Body
if len(body) > 200 {
body = body[:200] + "..."
}
entry := map[string]any{
"id": msg.ID,
"from": msg.FromAgent,
"body": body,
"priority": msg.Priority,
"status": msg.Status,
"created_at": msg.CreatedAt,
}
if msg.ConversationID > 0 {
conv, _, _ := h.msgService.GetConversation(ctx, msg.ConversationID)
if conv != nil && conv.Subject != "" {
entry["subject"] = conv.Subject
}
}
dmList[i] = entry
}
// 3. Get channel mentions.
mentions, err := h.msgService.GetRecentMentions(ctx, agentName, 10)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
mentionList := make([]map[string]any, len(mentions))
for i, msg := range mentions {
body := msg.Body
if len(body) > 200 {
body = body[:200] + "..."
}
entry := map[string]any{
"id": msg.ID,
"from": msg.FromAgent,
"body": body,
"created_at": msg.CreatedAt,
}
if len(msg.Metadata) > 0 {
var meta map[string]any
if json.Unmarshal(msg.Metadata, &meta) == nil {
if chName, ok := meta["channel_name"].(string); ok {
entry["channel"] = chName
}
}
}
mentionList[i] = entry
}
// 4. Get system notifications.
sysNotifs, err := h.msgService.GetSystemNotifications(ctx, agentName, 5)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
sysNotifList := make([]map[string]any, len(sysNotifs))
for i, msg := range sysNotifs {
body := msg.Body
if len(body) > 200 {
body = body[:200] + "..."
}
sysNotifList[i] = map[string]any{
"id": msg.ID,
"body": body,
"created_at": msg.CreatedAt,
}
}
// 5. Get channel summaries.
var channelSummaries []channels.ChannelSummary
if h.channelService != nil {
channelSummaries, err = h.channelService.GetChannelSummaries(ctx, agentName)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("my_status failed: %s", err)), nil
}
}
if channelSummaries == nil {
channelSummaries = []channels.ChannelSummary{}
}
// 6. Build stats.
totalUnreadChannel := 0
for _, cs := range channelSummaries {
totalUnreadChannel += cs.UnreadCount
}
stats := map[string]any{
"pending_dms": pendingDMCount,
"channels_joined": len(channelSummaries),
"unread_channel_messages": totalUnreadChannel,
"system_notifications": len(sysNotifs),
}
// 7. Build truncation instructions.
var instructionParts []string
truncated := false
if int64(len(pendingDMs)) < pendingDMCount {
truncated = true
instructionParts = append(instructionParts, fmt.Sprintf("Showing %d of %d pending messages. Use execute tool with call('read_inbox', {}) to see all.", len(pendingDMs), pendingDMCount))
}
if len(mentions) >= 10 {
truncated = true
instructionParts = append(instructionParts, fmt.Sprintf("Showing %d mentions (may be more). Use execute tool with call('search_messages', {}) to find all.", len(mentions)))
}
if len(sysNotifs) >= 5 {
truncated = true
instructionParts = append(instructionParts, fmt.Sprintf("Showing %d system notifications (may be more). Use execute tool with call('read_inbox', { from_agent: 'system' }) to see all.", len(sysNotifs)))
}
// 8. Add usage instructions for the hybrid tools.
usageInstructions := "Use 'search' tool with a query to discover available actions. " +
"Use 'execute' tool with call(action, args) to perform any action. " +
"Use 'send_message' tool directly for sending messages (DMs or channel)."
result := map[string]any{
"agent": agentInfo,
"direct_messages": dmList,
"direct_messages_total": pendingDMCount,
"mentions": mentionList,
"mentions_total": len(mentions),
"system_notifications": sysNotifList,
"system_notifications_total": len(sysNotifs),
"channels": channelSummaries,
"stats": stats,
"truncated": truncated,
"usage": usageInstructions,
}
if len(instructionParts) > 0 {
result["instructions"] = strings.Join(instructionParts, " ")
}
return resultJSON(result)
}
func (h *HybridToolRegistrar) handleSendMessage(ctx context.Context, req mcplib.CallToolRequest) (*mcplib.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcplib.NewToolResultError("authentication required"), nil
}
to := req.GetString("to", "")
channel := req.GetString("channel", "")
body := req.GetString("body", "")
subject := req.GetString("subject", "")
priority := req.GetInt("priority", 5)
metadataStr := req.GetString("metadata", "")
if body == "" {
return mcplib.NewToolResultError("'body' parameter is required"), nil
}
// Validate mutually exclusive: exactly one of to/channel.
if to == "" && channel == "" {
return mcplib.NewToolResultError("either 'to' (agent name) or 'channel' (channel name/ID) is required"), nil
}
if to != "" && channel != "" {
return mcplib.NewToolResultError("specify exactly one of 'to' (for DM) or 'channel' (for channel message), not both"), nil
}
var replyTo *int64
if rtID := req.GetInt("reply_to", 0); rtID > 0 {
v := int64(rtID)
replyTo = &v
}
// Channel message path.
if channel != "" {
if h.channelService == nil {
return mcplib.NewToolResultError("channel service not available"), nil
}
// Resolve channel by name or numeric ID.
channelID, err := h.resolveChannel(ctx, channel)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("send_message to channel failed: %s", err)), nil
}
messages, err := h.channelService.BroadcastMessage(ctx, channelID, agentName, body, priority, metadataStr)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("send_message to channel failed: %s", err)), nil
}
var messageID int64
if len(messages) > 0 {
messageID = messages[0].ID
}
return resultJSON(map[string]any{
"channel_id": channelID,
"message_id": messageID,
"status": "sent",
})
}
// DM path.
opts := messaging.SendOptions{
Subject: subject,
Priority: priority,
Metadata: metadataStr,
ReplyTo: replyTo,
}
msg, err := h.msgService.SendMessage(ctx, agentName, to, body, opts)
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("send_message failed: %s", err)), nil
}
return resultJSON(map[string]any{
"message_id": msg.ID,
"conversation_id": msg.ConversationID,
"status": msg.Status,
})
}
func (h *HybridToolRegistrar) handleSearch(ctx context.Context, req mcplib.CallToolRequest) (*mcplib.CallToolResult, error) {
_, ok := extractAgentName(ctx)
if !ok {
return mcplib.NewToolResultError("authentication required"), nil
}
query := req.GetString("query", "")
limit := req.GetInt("limit", 5)
results := h.actionIndex.Search(query, limit)
// Format results for the agent.
formatted := make([]map[string]any, len(results))
for i, r := range results {
params := make([]map[string]any, len(r.Action.Params))
for j, p := range r.Action.Params {
params[j] = map[string]any{
"name": p.Name,
"type": p.Type,
"description": p.Description,
"required": p.Required,
}
}
entry := map[string]any{
"name": r.Action.Name,
"category": r.Action.Category,
"description": r.Action.Description,
"params": params,
"examples": r.Action.Examples,
}
if r.Score > 0 {
entry["relevance_score"] = r.Score
}
formatted[i] = entry
}
result := map[string]any{
"actions": formatted,
"count": len(formatted),
"note": "Use the 'execute' tool with call(actionName, { param: value }) to run any action.",
}
return resultJSON(result)
}
func (h *HybridToolRegistrar) handleExecute(ctx context.Context, req mcplib.CallToolRequest) (*mcplib.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcplib.NewToolResultError("authentication required"), nil
}
code := req.GetString("code", "")
if code == "" {
return mcplib.NewToolResultError("'code' parameter is required"), nil
}
timeoutMs := req.GetInt("timeout", 120000)
if timeoutMs > 300000 {
timeoutMs = 300000
}
timeout := time.Duration(timeoutMs) * time.Millisecond
// Create a bridge for this agent.
bridge := NewServiceBridge(
h.msgService,
h.agentService,
h.channelService,
h.swarmService,
h.attachmentService,
h.searchService,
agentName,
)
result, err := h.jsPool.Execute(ctx, code, bridge, jsruntime.ExecuteOptions{
Timeout: timeout,
})
if err != nil {
return mcplib.NewToolResultError(fmt.Sprintf("execute failed: %s", err)), nil
}
return resultJSON(map[string]any{
"result": result.Value,
"calls": result.CallCount,
"duration": result.Duration.String(),
})
}
// resolveChannel resolves a channel name or numeric ID string to an int64 channel ID.
func (h *HybridToolRegistrar) resolveChannel(ctx context.Context, channel string) (int64, error) {
// Try parsing as numeric ID first.
var channelID int64
if _, err := fmt.Sscanf(channel, "%d", &channelID); err == nil && channelID > 0 {
return channelID, nil
}
// Resolve by name.
ch, err := h.channelService.GetChannelByName(ctx, channel)
if err != nil {
return 0, err
}
return ch.ID, nil
}
+242 -146
View File
@@ -10,7 +10,9 @@ import (
mcplib "github.com/mark3labs/mcp-go/mcp"
_ "modernc.org/sqlite"
"github.com/synapbus/synapbus/internal/actions"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/jsruntime"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/storage"
"github.com/synapbus/synapbus/internal/trace"
@@ -40,7 +42,7 @@ func newTestDB(t *testing.T) *sql.DB {
return db
}
func newTestRegistrar(t *testing.T) (*ToolRegistrar, *messaging.MessagingService, *agents.AgentService, *sql.DB) {
func newTestHybridRegistrar(t *testing.T) (*HybridToolRegistrar, *messaging.MessagingService, *agents.AgentService, *sql.DB) {
t.Helper()
db := newTestDB(t)
@@ -53,7 +55,24 @@ func newTestRegistrar(t *testing.T) (*ToolRegistrar, *messaging.MessagingService
agentStore := agents.NewSQLiteAgentStore(db)
agentService := agents.NewAgentService(agentStore, tracer)
registrar := NewToolRegistrar(msgService, agentService)
jsPool := jsruntime.NewPool(2)
t.Cleanup(func() { jsPool.Close() })
actionRegistry := actions.NewRegistry()
actionIndex := actions.NewIndex(actionRegistry.List())
registrar := NewHybridToolRegistrar(
msgService,
agentService,
nil, // channelService
nil, // swarmService
nil, // attachmentService
nil, // searchService
jsPool,
actionRegistry,
actionIndex,
db,
)
return registrar, msgService, agentService, db
}
@@ -65,24 +84,67 @@ func makeRequest(args map[string]any) mcplib.CallToolRequest {
}
}
func TestToolHandler_SendMessage(t *testing.T) {
tr, _, agentSvc, _ := newTestRegistrar(t)
func TestHybridTool_MyStatus(t *testing.T) {
h, _, agentSvc, _ := newTestHybridRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "test-agent", "Test Agent", "ai", nil, 1)
authCtx := ContextWithAgentName(ctx, "test-agent")
t.Run("returns status with usage instructions", func(t *testing.T) {
req := makeRequest(map[string]any{})
result, err := h.handleMyStatus(authCtx, req)
if err != nil {
t.Fatalf("handleMyStatus: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
var resp map[string]any
text := result.Content[0].(mcplib.TextContent).Text
json.Unmarshal([]byte(text), &resp)
// Check agent info
agentInfo := resp["agent"].(map[string]any)
if agentInfo["name"] != "test-agent" {
t.Errorf("agent name = %v, want test-agent", agentInfo["name"])
}
// Check usage instructions
usage := resp["usage"].(string)
if usage == "" {
t.Error("expected usage instructions in response")
}
})
t.Run("unauthenticated", func(t *testing.T) {
req := makeRequest(map[string]any{})
result, _ := h.handleMyStatus(ctx, req)
if !result.IsError {
t.Error("expected error for unauthenticated request")
}
})
}
func TestHybridTool_SendMessage_DM(t *testing.T) {
h, _, agentSvc, _ := newTestHybridRegistrar(t)
ctx := context.Background()
// Register agents
agentSvc.Register(ctx, "sender", "Sender", "ai", nil, 1)
agentSvc.Register(ctx, "receiver", "Receiver", "ai", nil, 1)
// Set up authenticated context
authCtx := ContextWithAgentName(ctx, "sender")
t.Run("successful send", func(t *testing.T) {
t.Run("successful DM", func(t *testing.T) {
req := makeRequest(map[string]any{
"to": "receiver",
"body": "Hello from test",
})
result, err := tr.handleSendMessage(authCtx, req)
result, err := h.handleSendMessage(authCtx, req)
if err != nil {
t.Fatalf("handleSendMessage: %v", err)
}
@@ -98,58 +160,65 @@ func TestToolHandler_SendMessage(t *testing.T) {
}
})
t.Run("missing to", func(t *testing.T) {
req := makeRequest(map[string]any{
"body": "no recipient",
})
result, _ := tr.handleSendMessage(authCtx, req)
if !result.IsError {
t.Error("expected error for missing 'to'")
}
})
t.Run("missing body", func(t *testing.T) {
req := makeRequest(map[string]any{
"to": "receiver",
})
result, _ := tr.handleSendMessage(authCtx, req)
result, _ := h.handleSendMessage(authCtx, req)
if !result.IsError {
t.Error("expected error for missing body")
}
})
t.Run("both to and channel rejected", func(t *testing.T) {
req := makeRequest(map[string]any{
"to": "receiver",
"channel": "general",
"body": "test",
})
result, _ := h.handleSendMessage(authCtx, req)
if !result.IsError {
t.Error("expected error when both to and channel specified")
}
})
t.Run("neither to nor channel rejected", func(t *testing.T) {
req := makeRequest(map[string]any{
"body": "test",
})
result, _ := h.handleSendMessage(authCtx, req)
if !result.IsError {
t.Error("expected error when neither to nor channel specified")
}
})
t.Run("unauthenticated", func(t *testing.T) {
req := makeRequest(map[string]any{
"to": "receiver",
"body": "should fail",
})
result, _ := tr.handleSendMessage(ctx, req)
result, _ := h.handleSendMessage(ctx, req)
if !result.IsError {
t.Error("expected error for unauthenticated request")
}
})
}
func TestToolHandler_ReadInbox(t *testing.T) {
tr, msgSvc, agentSvc, _ := newTestRegistrar(t)
func TestHybridTool_Search(t *testing.T) {
h, _, agentSvc, _ := newTestHybridRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "sender", "Sender", "ai", nil, 1)
agentSvc.Register(ctx, "reader", "Reader", "ai", nil, 1)
agentSvc.Register(ctx, "test-agent", "Test Agent", "ai", nil, 1)
authCtx := ContextWithAgentName(ctx, "test-agent")
msgSvc.SendMessage(ctx, "sender", "reader", "test message", messaging.SendOptions{})
t.Run("search for messaging actions", func(t *testing.T) {
req := makeRequest(map[string]any{
"query": "read inbox messages",
})
authCtx := ContextWithAgentName(ctx, "reader")
t.Run("read messages", func(t *testing.T) {
req := makeRequest(map[string]any{})
result, err := tr.handleReadInbox(authCtx, req)
result, err := h.handleSearch(authCtx, req)
if err != nil {
t.Fatalf("handleReadInbox: %v", err)
t.Fatalf("handleSearch: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
@@ -158,139 +227,166 @@ func TestToolHandler_ReadInbox(t *testing.T) {
var resp map[string]any
text := result.Content[0].(mcplib.TextContent).Text
json.Unmarshal([]byte(text), &resp)
count := resp["count"].(float64)
if count == 0 {
t.Error("expected at least one result")
}
actionsList := resp["actions"].([]any)
firstAction := actionsList[0].(map[string]any)
if firstAction["name"] == nil {
t.Error("expected name in action result")
}
})
t.Run("empty query returns all actions", func(t *testing.T) {
req := makeRequest(map[string]any{
"limit": float64(20),
})
result, err := h.handleSearch(authCtx, req)
if err != nil {
t.Fatalf("handleSearch: %v", err)
}
var resp map[string]any
text := result.Content[0].(mcplib.TextContent).Text
json.Unmarshal([]byte(text), &resp)
count := resp["count"].(float64)
if count < 5 {
t.Errorf("expected at least 5 actions in browse mode, got %v", count)
}
})
}
func TestHybridTool_Execute(t *testing.T) {
h, msgSvc, agentSvc, _ := newTestHybridRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "executor", "Executor", "ai", nil, 1)
agentSvc.Register(ctx, "target", "Target", "ai", nil, 1)
// Send a message so the executor has something to read
msgSvc.SendMessage(ctx, "target", "executor", "hello executor", messaging.SendOptions{})
authCtx := ContextWithAgentName(ctx, "executor")
t.Run("read_inbox via execute", func(t *testing.T) {
req := makeRequest(map[string]any{
"code": `call("read_inbox", { limit: 10 })`,
})
result, err := h.handleExecute(authCtx, req)
if err != nil {
t.Fatalf("handleExecute: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resultData := parseCallResult(t, result)
count := resultData["count"].(float64)
if count != 1 {
t.Errorf("count = %v, want 1", count)
t.Errorf("expected 1 message, got %v", count)
}
})
t.Run("send_message via execute", func(t *testing.T) {
req := makeRequest(map[string]any{
"code": `call("send_message", { to: "target", body: "hello from execute" })`,
})
result, err := h.handleExecute(authCtx, req)
if err != nil {
t.Fatalf("handleExecute: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resultData := parseCallResult(t, result)
if resultData["message_id"] == nil {
t.Error("expected message_id in execute result")
}
})
t.Run("discover_agents via execute", func(t *testing.T) {
req := makeRequest(map[string]any{
"code": `call("discover_agents", {})`,
})
result, err := h.handleExecute(authCtx, req)
if err != nil {
t.Fatalf("handleExecute: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
resultData := parseCallResult(t, result)
count := resultData["count"].(float64)
if count < 2 {
t.Errorf("expected at least 2 agents, got %v", count)
}
})
t.Run("unknown action returns error", func(t *testing.T) {
req := makeRequest(map[string]any{
"code": `call("nonexistent_action", {})`,
})
result, _ := h.handleExecute(authCtx, req)
// call() returns { ok: false, error: {...} } inside a successful execution result.
resp := parseResponse(t, result)
callResult := resp["result"].(map[string]any)
if callResult["ok"] != false {
t.Error("expected ok=false for unknown action")
}
})
t.Run("empty code rejected", func(t *testing.T) {
req := makeRequest(map[string]any{
"code": "",
})
result, _ := h.handleExecute(authCtx, req)
if !result.IsError {
t.Error("expected error for empty code")
}
})
t.Run("unauthenticated", func(t *testing.T) {
req := makeRequest(map[string]any{})
result, _ := tr.handleReadInbox(ctx, req)
req := makeRequest(map[string]any{
"code": `call("read_inbox", {})`,
})
result, _ := h.handleExecute(ctx, req)
if !result.IsError {
t.Error("expected error for unauthenticated request")
}
})
}
func TestToolHandler_ClaimMessages(t *testing.T) {
tr, msgSvc, agentSvc, _ := newTestRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "sender", "Sender", "ai", nil, 1)
agentSvc.Register(ctx, "claimer", "Claimer", "ai", nil, 1)
msgSvc.SendMessage(ctx, "sender", "claimer", "task 1", messaging.SendOptions{})
msgSvc.SendMessage(ctx, "sender", "claimer", "task 2", messaging.SendOptions{})
authCtx := ContextWithAgentName(ctx, "claimer")
req := makeRequest(map[string]any{"limit": float64(1)})
result, err := tr.handleClaimMessages(authCtx, req)
if err != nil {
t.Fatalf("handleClaimMessages: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
var resp map[string]any
text := result.Content[0].(mcplib.TextContent).Text
json.Unmarshal([]byte(text), &resp)
count := resp["count"].(float64)
if count != 1 {
t.Errorf("count = %v, want 1", count)
}
}
func TestToolHandler_MarkDone(t *testing.T) {
tr, msgSvc, agentSvc, _ := newTestRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "sender", "Sender", "ai", nil, 1)
agentSvc.Register(ctx, "worker", "Worker", "ai", nil, 1)
msg, _ := msgSvc.SendMessage(ctx, "sender", "worker", "do this", messaging.SendOptions{})
msgSvc.ClaimMessages(ctx, "worker", 1)
authCtx := ContextWithAgentName(ctx, "worker")
req := makeRequest(map[string]any{
"message_id": float64(msg.ID),
})
result, err := tr.handleMarkDone(authCtx, req)
if err != nil {
t.Fatalf("handleMarkDone: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
}
func TestToolHandler_SearchMessages(t *testing.T) {
tr, msgSvc, agentSvc, _ := newTestRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "sender", "Sender", "ai", nil, 1)
agentSvc.Register(ctx, "searcher", "Searcher", "ai", nil, 1)
msgSvc.SendMessage(ctx, "sender", "searcher", "deployment failed", messaging.SendOptions{})
msgSvc.SendMessage(ctx, "sender", "searcher", "all clear", messaging.SendOptions{})
authCtx := ContextWithAgentName(ctx, "searcher")
t.Run("keyword search", func(t *testing.T) {
t.Run("auth propagation to bridge", func(t *testing.T) {
req := makeRequest(map[string]any{
"query": "deployment",
"code": `call("read_inbox", {})`,
})
result, err := tr.handleSearchMessages(authCtx, req)
// Execute as "executor" - should see executor's inbox
result, err := h.handleExecute(authCtx, req)
if err != nil {
t.Fatalf("handleSearchMessages: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
t.Fatalf("handleExecute: %v", err)
}
var resp map[string]any
text := result.Content[0].(mcplib.TextContent).Text
json.Unmarshal([]byte(text), &resp)
count := resp["count"].(float64)
if count != 1 {
t.Errorf("count = %v, want 1", count)
// The bridge should use "executor" as the agent name
if resp["calls"].(float64) != 1 {
t.Errorf("expected 1 call, got %v", resp["calls"])
}
})
}
func TestToolHandler_DiscoverAgents(t *testing.T) {
tr, _, agentSvc, _ := newTestRegistrar(t)
ctx := context.Background()
agentSvc.Register(ctx, "bot-a", "Bot A", "ai", json.RawMessage(`{"skills":["search"]}`), 1)
agentSvc.Register(ctx, "bot-b", "Bot B", "ai", json.RawMessage(`{"skills":["analyze"]}`), 1)
authCtx := ContextWithAgentName(ctx, "bot-a")
req := makeRequest(map[string]any{
"query": "search",
})
result, err := tr.handleDiscoverAgents(authCtx, req)
if err != nil {
t.Fatalf("handleDiscoverAgents: %v", err)
}
if result.IsError {
t.Fatalf("unexpected error: %v", result.Content)
}
var resp map[string]any
text := result.Content[0].(mcplib.TextContent).Text
json.Unmarshal([]byte(text), &resp)
count := resp["count"].(float64)
if count != 1 {
t.Errorf("count = %v, want 1", count)
}
}
var _ = storage.RunMigrations
-316
View File
@@ -1,316 +0,0 @@
package mcp
import (
"context"
"fmt"
"log/slog"
"strings"
"github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
"github.com/synapbus/synapbus/internal/k8s"
"github.com/synapbus/synapbus/internal/webhooks"
)
// WebhookToolRegistrar registers webhook and K8s handler MCP tools.
type WebhookToolRegistrar struct {
webhookService *webhooks.WebhookService
k8sService *k8s.K8sService
logger *slog.Logger
}
// NewWebhookToolRegistrar creates a new webhook tool registrar.
func NewWebhookToolRegistrar(webhookService *webhooks.WebhookService, k8sService *k8s.K8sService) *WebhookToolRegistrar {
return &WebhookToolRegistrar{
webhookService: webhookService,
k8sService: k8sService,
logger: slog.Default().With("component", "mcp-webhook-tools"),
}
}
// RegisterAll registers all webhook and K8s handler tools on the MCP server.
func (r *WebhookToolRegistrar) RegisterAll(s *server.MCPServer) {
count := 0
// Webhook tools
if r.webhookService != nil {
s.AddTool(r.registerWebhookTool(), r.handleRegisterWebhook)
s.AddTool(r.listWebhooksTool(), r.handleListWebhooks)
s.AddTool(r.deleteWebhookTool(), r.handleDeleteWebhook)
count += 3
}
// K8s handler tools
if r.k8sService != nil {
s.AddTool(r.registerK8sHandlerTool(), r.handleRegisterK8sHandler)
s.AddTool(r.listK8sHandlersTool(), r.handleListK8sHandlers)
s.AddTool(r.deleteK8sHandlerTool(), r.handleDeleteK8sHandler)
count += 3
}
r.logger.Info("webhook/K8s MCP tools registered", "count", count)
}
// --- Webhook Tool Definitions ---
func (r *WebhookToolRegistrar) registerWebhookTool() mcp.Tool {
return mcp.NewTool("register_webhook",
mcp.WithDescription("Register a webhook URL to receive event notifications. When matching events occur (messages, mentions), SynapBus will POST a signed JSON payload to your URL. Max 3 webhooks per agent. HTTPS required in production."),
mcp.WithString("url", mcp.Description("HTTPS URL to receive webhook POST requests"), mcp.Required()),
mcp.WithString("events", mcp.Description("Comma-separated event types: message.received, message.mentioned, channel.message"), mcp.Required()),
mcp.WithString("secret", mcp.Description("Shared secret for HMAC-SHA256 payload signing (X-SynapBus-Signature header)"), mcp.Required()),
)
}
func (r *WebhookToolRegistrar) listWebhooksTool() mcp.Tool {
return mcp.NewTool("list_webhooks",
mcp.WithDescription("List your registered webhooks and their status (active/disabled, failure counts)."),
)
}
func (r *WebhookToolRegistrar) deleteWebhookTool() mcp.Tool {
return mcp.NewTool("delete_webhook",
mcp.WithDescription("Delete one of your registered webhooks by ID."),
mcp.WithNumber("webhook_id", mcp.Description("ID of the webhook to delete"), mcp.Required()),
)
}
// --- Webhook Tool Handlers ---
func (r *WebhookToolRegistrar) handleRegisterWebhook(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
url := req.GetString("url", "")
eventsStr := req.GetString("events", "")
secret := req.GetString("secret", "")
if url == "" {
return mcp.NewToolResultError("'url' parameter is required"), nil
}
if eventsStr == "" {
return mcp.NewToolResultError("'events' parameter is required"), nil
}
if secret == "" {
return mcp.NewToolResultError("'secret' parameter is required"), nil
}
// Parse comma-separated events
events := parseEvents(eventsStr)
wh, err := r.webhookService.RegisterWebhook(ctx, agentName, url, events, secret)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("register_webhook failed: %s", err)), nil
}
return resultJSON(map[string]any{
"webhook_id": wh.ID,
"url": wh.URL,
"events": wh.Events,
"status": wh.Status,
})
}
func (r *WebhookToolRegistrar) handleListWebhooks(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
hooks, err := r.webhookService.ListWebhooks(ctx, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("list_webhooks failed: %s", err)), nil
}
result := make([]map[string]any, len(hooks))
for i, wh := range hooks {
result[i] = map[string]any{
"id": wh.ID,
"url": wh.URL,
"events": wh.Events,
"status": wh.Status,
"consecutive_failures": wh.ConsecutiveFailures,
"created_at": wh.CreatedAt,
}
}
return resultJSON(map[string]any{
"webhooks": result,
"count": len(result),
})
}
func (r *WebhookToolRegistrar) handleDeleteWebhook(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
webhookID, err := req.RequireInt("webhook_id")
if err != nil {
return mcp.NewToolResultError("'webhook_id' parameter is required"), nil
}
if err := r.webhookService.DeleteWebhook(ctx, agentName, int64(webhookID)); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("delete_webhook failed: %s", err)), nil
}
return resultJSON(map[string]any{
"deleted": true,
"webhook_id": webhookID,
})
}
// --- K8s Handler Tool Definitions ---
func (r *WebhookToolRegistrar) registerK8sHandlerTool() mcp.Tool {
return mcp.NewTool("register_k8s_handler",
mcp.WithDescription("Register a Kubernetes Job handler. When matching events occur, SynapBus launches a K8s Job with message data injected via environment variables. Only available when SynapBus runs in-cluster."),
mcp.WithString("image", mcp.Description("Container image to run (e.g. myregistry/handler:v1)"), mcp.Required()),
mcp.WithString("events", mcp.Description("Comma-separated event types: message.received, message.mentioned, channel.message"), mcp.Required()),
mcp.WithString("namespace", mcp.Description("Kubernetes namespace (default: SynapBus's namespace)")),
mcp.WithString("resources_memory", mcp.Description("Memory limit (e.g. 256Mi, 1Gi)")),
mcp.WithString("resources_cpu", mcp.Description("CPU limit (e.g. 100m, 1)")),
mcp.WithString("env", mcp.Description("Comma-separated KEY=VALUE environment variables")),
mcp.WithNumber("timeout_seconds", mcp.Description("Job timeout in seconds (default 300)")),
)
}
func (r *WebhookToolRegistrar) listK8sHandlersTool() mcp.Tool {
return mcp.NewTool("list_k8s_handlers",
mcp.WithDescription("List your registered Kubernetes Job handlers and their status."),
)
}
func (r *WebhookToolRegistrar) deleteK8sHandlerTool() mcp.Tool {
return mcp.NewTool("delete_k8s_handler",
mcp.WithDescription("Delete one of your registered Kubernetes Job handlers by ID."),
mcp.WithNumber("handler_id", mcp.Description("ID of the K8s handler to delete"), mcp.Required()),
)
}
// --- K8s Handler Tool Handlers ---
func (r *WebhookToolRegistrar) handleRegisterK8sHandler(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
image := req.GetString("image", "")
eventsStr := req.GetString("events", "")
if image == "" {
return mcp.NewToolResultError("'image' parameter is required"), nil
}
if eventsStr == "" {
return mcp.NewToolResultError("'events' parameter is required"), nil
}
events := parseEvents(eventsStr)
// Parse env vars
envMap := make(map[string]string)
if envStr := req.GetString("env", ""); envStr != "" {
for _, pair := range strings.Split(envStr, ",") {
pair = strings.TrimSpace(pair)
if parts := strings.SplitN(pair, "=", 2); len(parts) == 2 {
envMap[strings.TrimSpace(parts[0])] = strings.TrimSpace(parts[1])
}
}
}
handlerReq := k8s.RegisterHandlerRequest{
Image: image,
Events: events,
Namespace: req.GetString("namespace", ""),
ResourcesMemory: req.GetString("resources_memory", ""),
ResourcesCPU: req.GetString("resources_cpu", ""),
Env: envMap,
TimeoutSeconds: req.GetInt("timeout_seconds", 300),
}
handler, err := r.k8sService.RegisterHandler(ctx, agentName, handlerReq)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("register_k8s_handler failed: %s", err)), nil
}
return resultJSON(map[string]any{
"handler_id": handler.ID,
"image": handler.Image,
"events": handler.Events,
"namespace": handler.Namespace,
"timeout_seconds": handler.TimeoutSeconds,
"status": handler.Status,
})
}
func (r *WebhookToolRegistrar) handleListK8sHandlers(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
handlers, err := r.k8sService.ListHandlers(ctx, agentName)
if err != nil {
return mcp.NewToolResultError(fmt.Sprintf("list_k8s_handlers failed: %s", err)), nil
}
result := make([]map[string]any, len(handlers))
for i, h := range handlers {
result[i] = map[string]any{
"id": h.ID,
"image": h.Image,
"events": h.Events,
"namespace": h.Namespace,
"resources_memory": h.ResourcesMemory,
"resources_cpu": h.ResourcesCPU,
"timeout_seconds": h.TimeoutSeconds,
"status": h.Status,
"created_at": h.CreatedAt,
}
}
return resultJSON(map[string]any{
"handlers": result,
"count": len(result),
"k8s_available": r.k8sService.IsAvailable(),
})
}
func (r *WebhookToolRegistrar) handleDeleteK8sHandler(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
agentName, ok := extractAgentName(ctx)
if !ok {
return mcp.NewToolResultError("authentication required"), nil
}
handlerID, err := req.RequireInt("handler_id")
if err != nil {
return mcp.NewToolResultError("'handler_id' parameter is required"), nil
}
if err := r.k8sService.DeleteHandler(ctx, agentName, int64(handlerID)); err != nil {
return mcp.NewToolResultError(fmt.Sprintf("delete_k8s_handler failed: %s", err)), nil
}
return resultJSON(map[string]any{
"deleted": true,
"handler_id": handlerID,
})
}
// parseEvents splits a comma-separated event string into a trimmed slice.
func parseEvents(s string) []string {
parts := strings.Split(s, ",")
events := make([]string, 0, len(parts))
for _, p := range parts {
p = strings.TrimSpace(p)
if p != "" {
events = append(events, p)
}
}
return events
}
+7
View File
@@ -17,6 +17,9 @@ type ReadOptions struct {
ConversationID *int64 `json:"conversation_id,omitempty"`
MinPriority int `json:"min_priority,omitempty"`
Limit int `json:"limit,omitempty"`
Offset int `json:"offset,omitempty"`
After string `json:"after,omitempty"`
Before string `json:"before,omitempty"`
IncludeRead bool `json:"include_read,omitempty"`
}
@@ -28,4 +31,8 @@ type SearchOptions struct {
MinPriority int `json:"min_priority,omitempty"`
Status string `json:"status,omitempty"`
Limit int `json:"limit,omitempty"`
Offset int `json:"offset,omitempty"`
After string `json:"after,omitempty"`
Before string `json:"before,omitempty"`
Channel string `json:"channel,omitempty"`
}
+82 -7
View File
@@ -176,12 +176,22 @@ func (s *MessagingService) SendMessage(ctx context.Context, from, to, body strin
}
// ReadInbox returns messages for an agent and advances the read position.
func (s *MessagingService) ReadInbox(ctx context.Context, agentName string, opts ReadOptions) ([]*Message, error) {
func (s *MessagingService) ReadInbox(ctx context.Context, agentName string, opts ReadOptions) (*PaginatedMessages, error) {
messages, err := s.store.GetInboxMessages(ctx, agentName, opts)
if err != nil {
return nil, fmt.Errorf("get inbox messages: %w", err)
}
total, err := s.store.CountInboxMessages(ctx, agentName, opts)
if err != nil {
return nil, fmt.Errorf("count inbox messages: %w", err)
}
limit := opts.Limit
if limit <= 0 {
limit = 50
}
// Advance inbox state for each conversation
conversationMaxID := make(map[int64]int64)
for _, msg := range messages {
@@ -212,7 +222,12 @@ func (s *MessagingService) ReadInbox(ctx context.Context, agentName string, opts
})
}
return messages, nil
return &PaginatedMessages{
Messages: messages,
Total: total,
Offset: opts.Offset,
Limit: limit,
}, nil
}
// ClaimMessages atomically claims pending messages for processing.
@@ -333,12 +348,22 @@ func (s *MessagingService) MarkFailed(ctx context.Context, messageID int64, agen
}
// SearchMessages performs full-text search on messages.
func (s *MessagingService) SearchMessages(ctx context.Context, agentName, query string, opts SearchOptions) ([]*Message, error) {
func (s *MessagingService) SearchMessages(ctx context.Context, agentName, query string, opts SearchOptions) (*PaginatedMessages, error) {
messages, err := s.store.SearchMessages(ctx, agentName, query, opts)
if err != nil {
return nil, fmt.Errorf("search messages: %w", err)
}
total, err := s.store.CountSearchMessages(ctx, agentName, query, opts)
if err != nil {
return nil, fmt.Errorf("count search messages: %w", err)
}
limit := opts.Limit
if limit <= 0 {
limit = 20
}
s.logger.Info("messages searched",
"agent", agentName,
"query", query,
@@ -352,7 +377,12 @@ func (s *MessagingService) SearchMessages(ctx context.Context, agentName, query
})
}
return messages, nil
return &PaginatedMessages{
Messages: messages,
Total: total,
Offset: opts.Offset,
Limit: limit,
}, nil
}
// GetPendingDMCount returns the total count of pending DMs for an agent.
@@ -397,12 +427,27 @@ func (s *MessagingService) GetReplies(ctx context.Context, messageID int64) ([]*
}
// GetChannelMessages returns messages posted to a channel.
func (s *MessagingService) GetChannelMessages(ctx context.Context, channelID int64, limit int) ([]*Message, error) {
messages, err := s.store.GetChannelMessages(ctx, channelID, limit)
func (s *MessagingService) GetChannelMessages(ctx context.Context, channelID int64, limit, offset int) (*PaginatedMessages, error) {
messages, err := s.store.GetChannelMessages(ctx, channelID, limit, offset)
if err != nil {
return nil, fmt.Errorf("get channel messages: %w", err)
}
return messages, nil
total, err := s.store.CountChannelMessages(ctx, channelID)
if err != nil {
return nil, fmt.Errorf("count channel messages: %w", err)
}
if limit <= 0 {
limit = 50
}
return &PaginatedMessages{
Messages: messages,
Total: total,
Offset: offset,
Limit: limit,
}, nil
}
// GetDMMessages returns direct messages between owned agents and a peer agent.
@@ -414,6 +459,36 @@ func (s *MessagingService) GetDMMessages(ctx context.Context, ownedAgents []stri
return messages, nil
}
// GetDMUnreadCounts returns unread DM counts grouped by peer agent.
func (s *MessagingService) GetDMUnreadCounts(ctx context.Context, agentName string) ([]DMUnreadCount, error) {
return s.store.GetDMUnreadCounts(ctx, agentName)
}
// GetLastReadForChannel returns the last_read_message_id for an agent in a channel.
func (s *MessagingService) GetLastReadForChannel(ctx context.Context, agentName string, channelID int64) (int64, error) {
return s.store.GetLastReadForChannel(ctx, agentName, channelID)
}
// GetLastReadForDM returns the last_read_message_id for owned agents in a DM with a peer.
func (s *MessagingService) GetLastReadForDM(ctx context.Context, agentNames []string, peerAgent string) (int64, error) {
return s.store.GetLastReadForDM(ctx, agentNames, peerAgent)
}
// UpdateInboxState updates the read position for an agent in a conversation.
func (s *MessagingService) UpdateInboxState(ctx context.Context, agentName string, conversationID int64, lastReadMsgID int64) error {
return s.store.UpdateInboxState(ctx, agentName, conversationID, lastReadMsgID)
}
// GetConversationIDsForChannel returns conversation IDs in a channel with messages up to lastMessageID.
func (s *MessagingService) GetConversationIDsForChannel(ctx context.Context, channelID int64, lastMessageID int64) ([]int64, error) {
return s.store.GetConversationIDsForChannel(ctx, channelID, lastMessageID)
}
// GetConversationIDsForDM returns conversation IDs for DMs between owned agents and a peer.
func (s *MessagingService) GetConversationIDsForDM(ctx context.Context, agentNames []string, peerAgent string, lastMessageID int64) ([]int64, error) {
return s.store.GetConversationIDsForDM(ctx, agentNames, peerAgent, lastMessageID)
}
// GetConversation returns a conversation and its messages.
func (s *MessagingService) GetConversation(ctx context.Context, id int64) (*Conversation, []*Message, error) {
conv, err := s.store.GetConversation(ctx, id)
+237 -31
View File
@@ -193,15 +193,18 @@ func TestMessagingService_ReadInbox(t *testing.T) {
}
t.Run("returns messages ordered by priority desc", func(t *testing.T) {
messages, err := svc.ReadInbox(ctx, "receiver", ReadOptions{IncludeRead: true})
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{IncludeRead: true})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) != 2 {
t.Fatalf("got %d messages, want 2", len(messages))
if len(result.Messages) != 2 {
t.Fatalf("got %d messages, want 2", len(result.Messages))
}
if messages[0].Priority < messages[1].Priority {
t.Errorf("messages not ordered by priority desc: %d, %d", messages[0].Priority, messages[1].Priority)
if result.Messages[0].Priority < result.Messages[1].Priority {
t.Errorf("messages not ordered by priority desc: %d, %d", result.Messages[0].Priority, result.Messages[1].Priority)
}
if result.Total != 2 {
t.Errorf("total = %d, want 2", result.Total)
}
})
}
@@ -220,30 +223,30 @@ func TestMessagingService_ReadInbox_ReadUnread(t *testing.T) {
}
// First read
messages, err := svc.ReadInbox(ctx, "receiver", ReadOptions{})
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) == 0 {
if len(result.Messages) == 0 {
t.Fatal("expected messages on first read")
}
// Second read without include_read
messages, err = svc.ReadInbox(ctx, "receiver", ReadOptions{})
result, err = svc.ReadInbox(ctx, "receiver", ReadOptions{})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) != 0 {
t.Errorf("got %d messages on second read (no include_read), want 0", len(messages))
if len(result.Messages) != 0 {
t.Errorf("got %d messages on second read (no include_read), want 0", len(result.Messages))
}
// With include_read
messages, err = svc.ReadInbox(ctx, "receiver", ReadOptions{IncludeRead: true})
result, err = svc.ReadInbox(ctx, "receiver", ReadOptions{IncludeRead: true})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) != 2 {
t.Errorf("got %d messages with include_read, want 2", len(messages))
if len(result.Messages) != 2 {
t.Errorf("got %d messages with include_read, want 2", len(result.Messages))
}
}
@@ -255,52 +258,52 @@ func TestMessagingService_ReadInbox_Filters(t *testing.T) {
svc.SendMessage(ctx, "sender", "receiver", "high pri", SendOptions{Priority: 8})
t.Run("filter by from_agent", func(t *testing.T) {
messages, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
FromAgent: "sender",
IncludeRead: true,
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) != 2 {
t.Errorf("got %d messages from sender, want 2", len(messages))
if len(result.Messages) != 2 {
t.Errorf("got %d messages from sender, want 2", len(result.Messages))
}
messages, err = svc.ReadInbox(ctx, "receiver", ReadOptions{
result, err = svc.ReadInbox(ctx, "receiver", ReadOptions{
FromAgent: "nobody",
IncludeRead: true,
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) != 0 {
t.Errorf("got %d messages from nobody, want 0", len(messages))
if len(result.Messages) != 0 {
t.Errorf("got %d messages from nobody, want 0", len(result.Messages))
}
})
t.Run("filter by min_priority", func(t *testing.T) {
messages, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
MinPriority: 7,
IncludeRead: true,
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) != 1 {
t.Errorf("got %d messages with min_priority=7, want 1", len(messages))
if len(result.Messages) != 1 {
t.Errorf("got %d messages with min_priority=7, want 1", len(result.Messages))
}
})
t.Run("limit", func(t *testing.T) {
messages, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
Limit: 1,
IncludeRead: true,
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(messages) != 1 {
t.Errorf("got %d messages with limit=1, want 1", len(messages))
if len(result.Messages) != 1 {
t.Errorf("got %d messages with limit=1, want 1", len(result.Messages))
}
})
}
@@ -457,22 +460,25 @@ func TestMessagingService_SearchMessages(t *testing.T) {
svc.SendMessage(ctx, "sender", "receiver", "security alert detected", SendOptions{Priority: 9})
t.Run("keyword search", func(t *testing.T) {
results, err := svc.SearchMessages(ctx, "receiver", "deployment", SearchOptions{})
result, err := svc.SearchMessages(ctx, "receiver", "deployment", SearchOptions{})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 2 {
t.Errorf("got %d results, want 2", len(results))
if len(result.Messages) != 2 {
t.Errorf("got %d results, want 2", len(result.Messages))
}
if result.Total != 2 {
t.Errorf("total = %d, want 2", result.Total)
}
})
t.Run("empty query returns recent", func(t *testing.T) {
results, err := svc.SearchMessages(ctx, "receiver", "", SearchOptions{})
result, err := svc.SearchMessages(ctx, "receiver", "", SearchOptions{})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 3 {
t.Errorf("got %d results, want 3", len(results))
if len(result.Messages) != 3 {
t.Errorf("got %d results, want 3", len(result.Messages))
}
})
}
@@ -522,5 +528,205 @@ func TestMessagingService_TracesRecorded(t *testing.T) {
}
}
func TestMessagingService_ReadInbox_Pagination(t *testing.T) {
svc, _ := newTestService(t)
ctx := context.Background()
// Send 5 messages
for i := 0; i < 5; i++ {
_, err := svc.SendMessage(ctx, "sender", "receiver", "paginated msg", SendOptions{Priority: 5})
if err != nil {
t.Fatalf("SendMessage: %v", err)
}
}
t.Run("offset pagination returns correct page", func(t *testing.T) {
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
Limit: 2,
Offset: 0,
IncludeRead: true,
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(result.Messages) != 2 {
t.Errorf("got %d messages, want 2", len(result.Messages))
}
if result.Total != 5 {
t.Errorf("total = %d, want 5", result.Total)
}
if result.Offset != 0 {
t.Errorf("offset = %d, want 0", result.Offset)
}
if result.Limit != 2 {
t.Errorf("limit = %d, want 2", result.Limit)
}
})
t.Run("offset=3 returns remaining 2", func(t *testing.T) {
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
Limit: 10,
Offset: 3,
IncludeRead: true,
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(result.Messages) != 2 {
t.Errorf("got %d messages, want 2", len(result.Messages))
}
if result.Total != 5 {
t.Errorf("total = %d, want 5", result.Total)
}
})
t.Run("offset beyond total returns empty", func(t *testing.T) {
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
Limit: 10,
Offset: 100,
IncludeRead: true,
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(result.Messages) != 0 {
t.Errorf("got %d messages, want 0", len(result.Messages))
}
if result.Total != 5 {
t.Errorf("total = %d, want 5", result.Total)
}
})
}
func TestMessagingService_SearchMessages_Pagination(t *testing.T) {
svc, _ := newTestService(t)
ctx := context.Background()
for i := 0; i < 5; i++ {
svc.SendMessage(ctx, "sender", "receiver", "searchable item", SendOptions{Priority: 5})
}
t.Run("pagination with total count", func(t *testing.T) {
result, err := svc.SearchMessages(ctx, "receiver", "searchable", SearchOptions{
Limit: 2,
Offset: 0,
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(result.Messages) != 2 {
t.Errorf("got %d results, want 2", len(result.Messages))
}
if result.Total != 5 {
t.Errorf("total = %d, want 5", result.Total)
}
if result.Offset != 0 {
t.Errorf("offset = %d, want 0", result.Offset)
}
if result.Limit != 2 {
t.Errorf("limit = %d, want 2", result.Limit)
}
})
t.Run("second page", func(t *testing.T) {
result, err := svc.SearchMessages(ctx, "receiver", "searchable", SearchOptions{
Limit: 2,
Offset: 2,
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(result.Messages) != 2 {
t.Errorf("got %d results, want 2", len(result.Messages))
}
if result.Total != 5 {
t.Errorf("total = %d, want 5", result.Total)
}
})
}
func TestMessagingService_GetChannelMessages_Pagination(t *testing.T) {
svc, db := newTestService(t)
ctx := context.Background()
// Create a channel
_, err := db.Exec(
`INSERT INTO channels (id, name, description, topic, type, is_private, is_system, created_by, created_at, updated_at)
VALUES (1, 'pag-channel', '', '', 'standard', 0, 0, 'sender', CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)`)
if err != nil {
t.Fatalf("create channel: %v", err)
}
chID := int64(1)
for i := 0; i < 5; i++ {
svc.SendMessage(ctx, "sender", "", "ch msg", SendOptions{
ChannelID: &chID,
Priority: 5,
})
}
t.Run("pagination with total", func(t *testing.T) {
result, err := svc.GetChannelMessages(ctx, 1, 2, 0)
if err != nil {
t.Fatalf("GetChannelMessages: %v", err)
}
if len(result.Messages) != 2 {
t.Errorf("got %d messages, want 2", len(result.Messages))
}
if result.Total != 5 {
t.Errorf("total = %d, want 5", result.Total)
}
if result.Offset != 0 {
t.Errorf("offset = %d, want 0", result.Offset)
}
})
t.Run("offset=3 returns remaining", func(t *testing.T) {
result, err := svc.GetChannelMessages(ctx, 1, 10, 3)
if err != nil {
t.Fatalf("GetChannelMessages: %v", err)
}
if len(result.Messages) != 2 {
t.Errorf("got %d messages, want 2", len(result.Messages))
}
if result.Total != 5 {
t.Errorf("total = %d, want 5", result.Total)
}
})
}
func TestMessagingService_ReadInbox_DateFiltering(t *testing.T) {
svc, _ := newTestService(t)
ctx := context.Background()
svc.SendMessage(ctx, "sender", "receiver", "dated msg", SendOptions{Priority: 5})
t.Run("after in the past returns messages", func(t *testing.T) {
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
IncludeRead: true,
After: "2020-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(result.Messages) != 1 {
t.Errorf("got %d messages, want 1", len(result.Messages))
}
})
t.Run("after in the future returns empty", func(t *testing.T) {
result, err := svc.ReadInbox(ctx, "receiver", ReadOptions{
IncludeRead: true,
After: "2099-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("ReadInbox: %v", err)
}
if len(result.Messages) != 0 {
t.Errorf("got %d messages, want 0", len(result.Messages))
}
})
}
// suppress unused import warning for storage package
var _ = storage.RunMigrations
+345 -46
View File
@@ -6,6 +6,7 @@ import (
"encoding/json"
"fmt"
"strings"
"time"
)
// MessageStore defines the storage interface for messaging operations.
@@ -14,22 +15,30 @@ type MessageStore interface {
InsertConversation(ctx context.Context, conv *Conversation) error
FindConversation(ctx context.Context, subject, fromAgent, toAgent string) (*Conversation, error)
GetInboxMessages(ctx context.Context, agentName string, opts ReadOptions) ([]*Message, error)
CountInboxMessages(ctx context.Context, agentName string, opts ReadOptions) (int, error)
GetInboxState(ctx context.Context, agentName string, conversationID int64) (*InboxState, error)
UpdateInboxState(ctx context.Context, agentName string, conversationID int64, lastReadMsgID int64) error
ClaimMessages(ctx context.Context, agentName string, limit int) ([]*Message, error)
UpdateMessageStatus(ctx context.Context, id int64, status, claimedBy string, metadata json.RawMessage) error
GetMessageByID(ctx context.Context, id int64) (*Message, error)
SearchMessages(ctx context.Context, agentName, query string, opts SearchOptions) ([]*Message, error)
CountSearchMessages(ctx context.Context, agentName, query string, opts SearchOptions) (int, error)
GetConversation(ctx context.Context, id int64) (*Conversation, error)
GetConversationMessages(ctx context.Context, conversationID int64) ([]*Message, error)
GetReplies(ctx context.Context, messageID int64) ([]*Message, error)
GetChannelMessages(ctx context.Context, channelID int64, limit int) ([]*Message, error)
GetChannelMessages(ctx context.Context, channelID int64, limit, offset int) ([]*Message, error)
CountChannelMessages(ctx context.Context, channelID int64) (int, error)
GetDMMessages(ctx context.Context, agents []string, peerAgent string, limit int) ([]*Message, error)
AgentExists(ctx context.Context, agentName string) (bool, error)
CountPendingDMs(ctx context.Context, agentName string) (int64, error)
GetPendingDMs(ctx context.Context, agentName string, limit int) ([]*Message, error)
GetRecentMentions(ctx context.Context, agentName string, limit int) ([]*Message, error)
GetSystemNotifications(ctx context.Context, agentName string, limit int) ([]*Message, error)
GetDMUnreadCounts(ctx context.Context, agentName string) ([]DMUnreadCount, error)
GetLastReadForChannel(ctx context.Context, agentName string, channelID int64) (int64, error)
GetLastReadForDM(ctx context.Context, agentNames []string, peerAgent string) (int64, error)
GetConversationIDsForChannel(ctx context.Context, channelID int64, lastMessageID int64) ([]int64, error)
GetConversationIDsForDM(ctx context.Context, agentNames []string, peerAgent string, lastMessageID int64) ([]int64, error)
}
// SQLiteMessageStore implements MessageStore using SQLite.
@@ -115,6 +124,58 @@ func (s *SQLiteMessageStore) InsertMessage(ctx context.Context, msg *Message) er
}
func (s *SQLiteMessageStore) GetInboxMessages(ctx context.Context, agentName string, opts ReadOptions) ([]*Message, error) {
conditions, args := s.buildInboxConditions(agentName, opts)
limit := opts.Limit
if limit <= 0 {
limit = 50
}
offset := opts.Offset
if offset < 0 {
offset = 0
}
query := fmt.Sprintf(
`SELECT m.id, m.conversation_id, m.from_agent, m.to_agent, m.channel_id,
m.body, m.priority, m.status, m.metadata, m.claimed_by, m.claimed_at,
m.created_at, m.updated_at, m.reply_to
FROM messages m
WHERE %s
ORDER BY m.priority DESC, m.created_at ASC
LIMIT ? OFFSET ?`,
strings.Join(conditions, " AND "),
)
args = append(args, limit, offset)
rows, err := s.db.QueryContext(ctx, query, args...)
if err != nil {
return nil, fmt.Errorf("query inbox: %w", err)
}
defer rows.Close()
return scanMessages(rows)
}
// CountInboxMessages returns the total count of inbox messages matching the given options.
func (s *SQLiteMessageStore) CountInboxMessages(ctx context.Context, agentName string, opts ReadOptions) (int, error) {
conditions, args := s.buildInboxConditions(agentName, opts)
query := fmt.Sprintf(
`SELECT COUNT(*) FROM messages m WHERE %s`,
strings.Join(conditions, " AND "),
)
var count int
err := s.db.QueryRowContext(ctx, query, args...).Scan(&count)
if err != nil {
return 0, fmt.Errorf("count inbox messages: %w", err)
}
return count, nil
}
// buildInboxConditions builds the WHERE conditions and args for inbox queries.
func (s *SQLiteMessageStore) buildInboxConditions(agentName string, opts ReadOptions) ([]string, []any) {
var conditions []string
var args []any
@@ -151,30 +212,21 @@ func (s *SQLiteMessageStore) GetInboxMessages(ctx context.Context, agentName str
args = append(args, opts.MinPriority)
}
limit := opts.Limit
if limit <= 0 {
limit = 50
if opts.After != "" {
if t, err := time.Parse(time.RFC3339, opts.After); err == nil {
conditions = append(conditions, "m.created_at >= ?")
args = append(args, t.UTC().Format("2006-01-02 15:04:05"))
}
}
query := fmt.Sprintf(
`SELECT m.id, m.conversation_id, m.from_agent, m.to_agent, m.channel_id,
m.body, m.priority, m.status, m.metadata, m.claimed_by, m.claimed_at,
m.created_at, m.updated_at, m.reply_to
FROM messages m
WHERE %s
ORDER BY m.priority DESC, m.created_at ASC
LIMIT ?`,
strings.Join(conditions, " AND "),
)
args = append(args, limit)
rows, err := s.db.QueryContext(ctx, query, args...)
if err != nil {
return nil, fmt.Errorf("query inbox: %w", err)
if opts.Before != "" {
if t, err := time.Parse(time.RFC3339, opts.Before); err == nil {
conditions = append(conditions, "m.created_at <= ?")
args = append(args, t.UTC().Format("2006-01-02 15:04:05"))
}
}
defer rows.Close()
return scanMessages(rows)
return conditions, args
}
func (s *SQLiteMessageStore) GetInboxState(ctx context.Context, agentName string, conversationID int64) (*InboxState, error) {
@@ -333,6 +385,62 @@ func (s *SQLiteMessageStore) GetMessageByID(ctx context.Context, id int64) (*Mes
}
func (s *SQLiteMessageStore) SearchMessages(ctx context.Context, agentName, query string, opts SearchOptions) ([]*Message, error) {
conditions, args, joinClause, orderClause := s.buildSearchConditions(agentName, query, opts)
limit := opts.Limit
if limit <= 0 {
limit = 20
}
offset := opts.Offset
if offset < 0 {
offset = 0
}
querySQL := fmt.Sprintf(
`SELECT m.id, m.conversation_id, m.from_agent, m.to_agent, m.channel_id,
m.body, m.priority, m.status, m.metadata, m.claimed_by, m.claimed_at,
m.created_at, m.updated_at, m.reply_to
FROM messages m
%s
WHERE %s
%s
LIMIT ? OFFSET ?`,
joinClause,
strings.Join(conditions, " AND "),
orderClause,
)
args = append(args, limit, offset)
rows, err := s.db.QueryContext(ctx, querySQL, args...)
if err != nil {
return nil, fmt.Errorf("search messages: %w", err)
}
defer rows.Close()
return scanMessages(rows)
}
// CountSearchMessages returns the total count of messages matching the search criteria.
func (s *SQLiteMessageStore) CountSearchMessages(ctx context.Context, agentName, query string, opts SearchOptions) (int, error) {
conditions, args, joinClause, _ := s.buildSearchConditions(agentName, query, opts)
countSQL := fmt.Sprintf(
`SELECT COUNT(*) FROM messages m %s WHERE %s`,
joinClause,
strings.Join(conditions, " AND "),
)
var count int
err := s.db.QueryRowContext(ctx, countSQL, args...).Scan(&count)
if err != nil {
return 0, fmt.Errorf("count search messages: %w", err)
}
return count, nil
}
// buildSearchConditions builds the WHERE conditions, args, JOIN clause, and ORDER clause for search queries.
func (s *SQLiteMessageStore) buildSearchConditions(agentName, query string, opts SearchOptions) ([]string, []any, string, string) {
var conditions []string
var args []any
@@ -374,33 +482,31 @@ func (s *SQLiteMessageStore) SearchMessages(ctx context.Context, agentName, quer
args = append(args, opts.Status)
}
limit := opts.Limit
if limit <= 0 {
limit = 20
if opts.ChannelID != nil {
conditions = append(conditions, "m.channel_id = ?")
args = append(args, *opts.ChannelID)
}
querySQL := fmt.Sprintf(
`SELECT m.id, m.conversation_id, m.from_agent, m.to_agent, m.channel_id,
m.body, m.priority, m.status, m.metadata, m.claimed_by, m.claimed_at,
m.created_at, m.updated_at, m.reply_to
FROM messages m
%s
WHERE %s
%s
LIMIT ?`,
joinClause,
strings.Join(conditions, " AND "),
orderClause,
)
args = append(args, limit)
rows, err := s.db.QueryContext(ctx, querySQL, args...)
if err != nil {
return nil, fmt.Errorf("search messages: %w", err)
if opts.Channel != "" {
conditions = append(conditions, "m.channel_id IN (SELECT id FROM channels WHERE LOWER(name) = LOWER(?))")
args = append(args, opts.Channel)
}
defer rows.Close()
return scanMessages(rows)
if opts.After != "" {
if t, err := time.Parse(time.RFC3339, opts.After); err == nil {
conditions = append(conditions, "m.created_at >= ?")
args = append(args, t.UTC().Format("2006-01-02 15:04:05"))
}
}
if opts.Before != "" {
if t, err := time.Parse(time.RFC3339, opts.Before); err == nil {
conditions = append(conditions, "m.created_at <= ?")
args = append(args, t.UTC().Format("2006-01-02 15:04:05"))
}
}
return conditions, args, joinClause, orderClause
}
func (s *SQLiteMessageStore) GetConversation(ctx context.Context, id int64) (*Conversation, error) {
@@ -451,17 +557,20 @@ func (s *SQLiteMessageStore) GetReplies(ctx context.Context, messageID int64) ([
return scanMessages(rows)
}
func (s *SQLiteMessageStore) GetChannelMessages(ctx context.Context, channelID int64, limit int) ([]*Message, error) {
func (s *SQLiteMessageStore) GetChannelMessages(ctx context.Context, channelID int64, limit, offset int) ([]*Message, error) {
if limit <= 0 {
limit = 50
}
if offset < 0 {
offset = 0
}
rows, err := s.db.QueryContext(ctx,
`SELECT id, conversation_id, from_agent, to_agent, channel_id,
body, priority, status, metadata, claimed_by, claimed_at,
created_at, updated_at, reply_to
FROM messages WHERE channel_id = ?
ORDER BY created_at ASC
LIMIT ?`, channelID, limit,
LIMIT ? OFFSET ?`, channelID, limit, offset,
)
if err != nil {
return nil, fmt.Errorf("get channel messages: %w", err)
@@ -470,6 +579,18 @@ func (s *SQLiteMessageStore) GetChannelMessages(ctx context.Context, channelID i
return scanMessages(rows)
}
// CountChannelMessages returns the total number of messages in a channel.
func (s *SQLiteMessageStore) CountChannelMessages(ctx context.Context, channelID int64) (int, error) {
var count int
err := s.db.QueryRowContext(ctx,
`SELECT COUNT(*) FROM messages WHERE channel_id = ?`, channelID,
).Scan(&count)
if err != nil {
return 0, fmt.Errorf("count channel messages: %w", err)
}
return count, nil
}
func (s *SQLiteMessageStore) GetDMMessages(ctx context.Context, agents []string, peerAgent string, limit int) ([]*Message, error) {
if limit <= 0 {
limit = 50
@@ -657,6 +778,184 @@ func scanMessageFromRows(rows *sql.Rows) (*Message, error) {
return &msg, nil
}
// GetDMUnreadCounts returns unread DM counts grouped by peer agent.
// For each unique from_agent that has sent DMs to agentName, it computes
// how many messages have id > last_read_message_id (from inbox_state).
func (s *SQLiteMessageStore) GetDMUnreadCounts(ctx context.Context, agentName string) ([]DMUnreadCount, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT
m.from_agent,
COUNT(CASE WHEN m.id > COALESCE(
(SELECT ist.last_read_message_id FROM inbox_state ist
WHERE ist.agent_name = ? AND ist.conversation_id = m.conversation_id), 0)
THEN 1 END) AS unread_count,
MAX(m.id) AS last_message_id
FROM messages m
WHERE m.to_agent = ?
AND m.channel_id IS NULL
AND m.from_agent != 'system'
GROUP BY m.from_agent
ORDER BY m.from_agent`,
agentName, agentName,
)
if err != nil {
return nil, fmt.Errorf("get dm unread counts: %w", err)
}
defer rows.Close()
var results []DMUnreadCount
for rows.Next() {
var d DMUnreadCount
if err := rows.Scan(&d.Agent, &d.UnreadCount, &d.LastMessageID); err != nil {
return nil, fmt.Errorf("scan dm unread count: %w", err)
}
results = append(results, d)
}
if results == nil {
results = []DMUnreadCount{}
}
return results, rows.Err()
}
// GetLastReadForChannel returns the effective last_read_message_id for an agent
// across all conversations in a given channel.
func (s *SQLiteMessageStore) GetLastReadForChannel(ctx context.Context, agentName string, channelID int64) (int64, error) {
var lastRead sql.NullInt64
err := s.db.QueryRowContext(ctx,
`SELECT MIN(COALESCE(ist.last_read_message_id, 0))
FROM (SELECT DISTINCT conversation_id FROM messages WHERE channel_id = ?) conv
LEFT JOIN inbox_state ist ON ist.conversation_id = conv.conversation_id AND ist.agent_name = ?`,
channelID, agentName,
).Scan(&lastRead)
if err != nil {
return 0, fmt.Errorf("get last read for channel: %w", err)
}
if lastRead.Valid {
return lastRead.Int64, nil
}
return 0, nil
}
// GetLastReadForDM returns the effective last_read_message_id for an owned agent
// in DM conversations with a specific peer agent.
func (s *SQLiteMessageStore) GetLastReadForDM(ctx context.Context, agentNames []string, peerAgent string) (int64, error) {
if len(agentNames) == 0 {
return 0, nil
}
placeholders := make([]string, len(agentNames))
args := make([]any, 0, len(agentNames)*2+1)
for i, a := range agentNames {
placeholders[i] = "?"
args = append(args, a)
}
inClause := strings.Join(placeholders, ",")
// Find conversations between owned agents and peer agent (DMs only)
// and get the max last_read_message_id
query := fmt.Sprintf(
`SELECT COALESCE(MAX(ist.last_read_message_id), 0)
FROM inbox_state ist
WHERE ist.agent_name IN (%s)
AND ist.conversation_id IN (
SELECT DISTINCT m.conversation_id FROM messages m
WHERE m.channel_id IS NULL
AND ((m.from_agent IN (%s) AND m.to_agent = ?)
OR (m.from_agent = ? AND m.to_agent IN (%s)))
)`,
inClause, inClause, inClause,
)
for _, a := range agentNames {
args = append(args, a)
}
args = append(args, peerAgent, peerAgent)
for _, a := range agentNames {
args = append(args, a)
}
var lastRead int64
err := s.db.QueryRowContext(ctx, query, args...).Scan(&lastRead)
if err != nil {
return 0, fmt.Errorf("get last read for dm: %w", err)
}
return lastRead, nil
}
// GetConversationIDsForChannel returns conversation IDs in a channel with messages up to lastMessageID.
func (s *SQLiteMessageStore) GetConversationIDsForChannel(ctx context.Context, channelID int64, lastMessageID int64) ([]int64, error) {
rows, err := s.db.QueryContext(ctx,
`SELECT DISTINCT conversation_id FROM messages
WHERE channel_id = ? AND id <= ?`,
channelID, lastMessageID,
)
if err != nil {
return nil, fmt.Errorf("get conversation ids for channel: %w", err)
}
defer rows.Close()
var ids []int64
for rows.Next() {
var id int64
if err := rows.Scan(&id); err != nil {
return nil, fmt.Errorf("scan conversation id: %w", err)
}
ids = append(ids, id)
}
return ids, rows.Err()
}
// GetConversationIDsForDM returns conversation IDs for DMs between owned agents and a peer agent,
// with messages up to lastMessageID.
func (s *SQLiteMessageStore) GetConversationIDsForDM(ctx context.Context, agentNames []string, peerAgent string, lastMessageID int64) ([]int64, error) {
if len(agentNames) == 0 {
return nil, nil
}
placeholders := make([]string, len(agentNames))
args := make([]any, 0, len(agentNames)*2+2)
for i, a := range agentNames {
placeholders[i] = "?"
args = append(args, a)
}
inClause := strings.Join(placeholders, ",")
query := fmt.Sprintf(
`SELECT DISTINCT conversation_id FROM messages
WHERE channel_id IS NULL
AND id <= ?
AND ((from_agent IN (%s) AND to_agent = ?)
OR (from_agent = ? AND to_agent IN (%s)))`,
inClause, inClause,
)
// Reorder args: agentNames for first IN, lastMessageID, agentNames for second IN...
finalArgs := make([]any, 0, len(agentNames)*2+3)
finalArgs = append(finalArgs, lastMessageID)
for _, a := range agentNames {
finalArgs = append(finalArgs, a)
}
finalArgs = append(finalArgs, peerAgent, peerAgent)
for _, a := range agentNames {
finalArgs = append(finalArgs, a)
}
rows, err := s.db.QueryContext(ctx, query, finalArgs...)
if err != nil {
return nil, fmt.Errorf("get conversation ids for dm: %w", err)
}
defer rows.Close()
var ids []int64
for rows.Next() {
var id int64
if err := rows.Scan(&id); err != nil {
return nil, fmt.Errorf("scan conversation id: %w", err)
}
ids = append(ids, id)
}
return ids, rows.Err()
}
// scanMessage scans a single message from sql.Row.
func scanMessage(row *sql.Row) (*Message, error) {
var msg Message
+558
View File
@@ -534,3 +534,561 @@ func TestSQLiteMessageStore_AgentExists(t *testing.T) {
})
}
}
func TestSQLiteMessageStore_GetInboxMessages_Offset(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "sender")
seedAgent(t, db, "reader")
conv := &Conversation{Subject: "offset test", CreatedBy: "sender"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
// Insert 5 messages
for i := 0; i < 5; i++ {
msg := &Message{
ConversationID: conv.ID,
FromAgent: "sender",
ToAgent: "reader",
Body: fmt.Sprintf("msg %d", i),
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
}
t.Run("offset=0 returns from beginning", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
Limit: 2,
Offset: 0,
IncludeRead: true,
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 2 {
t.Errorf("got %d messages, want 2", len(messages))
}
})
t.Run("offset=2 skips first 2", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
Limit: 2,
Offset: 2,
IncludeRead: true,
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 2 {
t.Errorf("got %d messages, want 2", len(messages))
}
})
t.Run("offset beyond total returns empty", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
Limit: 10,
Offset: 100,
IncludeRead: true,
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 0 {
t.Errorf("got %d messages, want 0", len(messages))
}
})
}
func TestSQLiteMessageStore_CountInboxMessages(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "sender")
seedAgent(t, db, "counter")
conv := &Conversation{Subject: "count test", CreatedBy: "sender"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
for i := 0; i < 5; i++ {
msg := &Message{
ConversationID: conv.ID,
FromAgent: "sender",
ToAgent: "counter",
Body: "msg",
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
}
count, err := store.CountInboxMessages(ctx, "counter", ReadOptions{IncludeRead: true})
if err != nil {
t.Fatalf("CountInboxMessages: %v", err)
}
if count != 5 {
t.Errorf("count = %d, want 5", count)
}
}
func TestSQLiteMessageStore_SearchMessages_Offset(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "sender")
seedAgent(t, db, "searcher")
conv := &Conversation{Subject: "search offset test", CreatedBy: "sender"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
for i := 0; i < 5; i++ {
msg := &Message{
ConversationID: conv.ID,
FromAgent: "sender",
ToAgent: "searcher",
Body: fmt.Sprintf("unique message %d", i),
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
}
t.Run("offset=0 limit=2 returns first 2", func(t *testing.T) {
results, err := store.SearchMessages(ctx, "searcher", "", SearchOptions{
Limit: 2,
Offset: 0,
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 2 {
t.Errorf("got %d results, want 2", len(results))
}
})
t.Run("offset=3 returns remaining 2", func(t *testing.T) {
results, err := store.SearchMessages(ctx, "searcher", "", SearchOptions{
Limit: 10,
Offset: 3,
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 2 {
t.Errorf("got %d results, want 2", len(results))
}
})
t.Run("offset beyond total returns empty", func(t *testing.T) {
results, err := store.SearchMessages(ctx, "searcher", "", SearchOptions{
Limit: 10,
Offset: 100,
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 0 {
t.Errorf("got %d results, want 0", len(results))
}
})
}
func TestSQLiteMessageStore_CountSearchMessages(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "sender")
seedAgent(t, db, "searcher")
conv := &Conversation{Subject: "count search", CreatedBy: "sender"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
for i := 0; i < 3; i++ {
msg := &Message{
ConversationID: conv.ID,
FromAgent: "sender",
ToAgent: "searcher",
Body: fmt.Sprintf("deployment issue %d", i),
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
}
count, err := store.CountSearchMessages(ctx, "searcher", "deployment", SearchOptions{})
if err != nil {
t.Fatalf("CountSearchMessages: %v", err)
}
if count != 3 {
t.Errorf("count = %d, want 3", count)
}
count, err = store.CountSearchMessages(ctx, "searcher", "", SearchOptions{})
if err != nil {
t.Fatalf("CountSearchMessages: %v", err)
}
if count != 3 {
t.Errorf("count = %d, want 3", count)
}
}
func TestSQLiteMessageStore_DateFiltering(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "sender")
seedAgent(t, db, "reader")
conv := &Conversation{Subject: "date test", CreatedBy: "sender"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
// Insert messages (all at "now" since SQLite uses CURRENT_TIMESTAMP)
for i := 0; i < 3; i++ {
msg := &Message{
ConversationID: conv.ID,
FromAgent: "sender",
ToAgent: "reader",
Body: fmt.Sprintf("dated msg %d", i),
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
}
t.Run("after in the past returns all", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
IncludeRead: true,
After: "2020-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 3 {
t.Errorf("got %d messages, want 3", len(messages))
}
})
t.Run("after in the future returns none", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
IncludeRead: true,
After: "2099-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 0 {
t.Errorf("got %d messages, want 0", len(messages))
}
})
t.Run("before in the past returns none", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
IncludeRead: true,
Before: "2020-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 0 {
t.Errorf("got %d messages, want 0", len(messages))
}
})
t.Run("before in the future returns all", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
IncludeRead: true,
Before: "2099-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 3 {
t.Errorf("got %d messages, want 3", len(messages))
}
})
t.Run("combined after+before", func(t *testing.T) {
messages, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
IncludeRead: true,
After: "2020-01-01T00:00:00Z",
Before: "2099-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
if len(messages) != 3 {
t.Errorf("got %d messages, want 3", len(messages))
}
})
t.Run("search date filtering", func(t *testing.T) {
results, err := store.SearchMessages(ctx, "reader", "", SearchOptions{
After: "2020-01-01T00:00:00Z",
Before: "2099-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 3 {
t.Errorf("got %d results, want 3", len(results))
}
})
t.Run("search after in the future returns none", func(t *testing.T) {
results, err := store.SearchMessages(ctx, "reader", "", SearchOptions{
After: "2099-01-01T00:00:00Z",
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 0 {
t.Errorf("got %d results, want 0", len(results))
}
})
}
func TestSQLiteMessageStore_SearchMessages_ChannelFilter(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "agent-a")
// Create a channel
_, err := db.ExecContext(ctx,
`INSERT INTO channels (id, name, description, topic, type, is_private, is_system, created_by, created_at, updated_at)
VALUES (1, 'test-channel', '', '', 'standard', 0, 0, 'agent-a', CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)`)
if err != nil {
t.Fatalf("create channel: %v", err)
}
// Add agent as member
_, err = db.ExecContext(ctx,
`INSERT INTO channel_members (channel_id, agent_name, role, joined_at)
VALUES (1, 'agent-a', 'owner', CURRENT_TIMESTAMP)`)
if err != nil {
t.Fatalf("add member: %v", err)
}
conv := &Conversation{Subject: "channel test", CreatedBy: "agent-a"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
chID := int64(1)
// Insert a channel message
msg := &Message{
ConversationID: conv.ID,
FromAgent: "agent-a",
ChannelID: &chID,
Body: "channel message",
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
// Insert a DM (not in channel)
seedAgent(t, db, "agent-b")
convDM := &Conversation{Subject: "dm test", CreatedBy: "agent-a"}
if err := store.InsertConversation(ctx, convDM); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
dmMsg := &Message{
ConversationID: convDM.ID,
FromAgent: "agent-a",
ToAgent: "agent-b",
Body: "dm message",
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, dmMsg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
t.Run("filter by channel name", func(t *testing.T) {
results, err := store.SearchMessages(ctx, "agent-a", "", SearchOptions{
Channel: "test-channel",
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 1 {
t.Errorf("got %d results, want 1", len(results))
}
if len(results) > 0 && results[0].Body != "channel message" {
t.Errorf("body = %q, want %q", results[0].Body, "channel message")
}
})
t.Run("non-existent channel returns empty", func(t *testing.T) {
results, err := store.SearchMessages(ctx, "agent-a", "", SearchOptions{
Channel: "no-such-channel",
})
if err != nil {
t.Fatalf("SearchMessages: %v", err)
}
if len(results) != 0 {
t.Errorf("got %d results, want 0", len(results))
}
})
}
func TestSQLiteMessageStore_GetChannelMessages_Offset(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "agent-a")
// Create a channel
_, err := db.ExecContext(ctx,
`INSERT INTO channels (id, name, description, topic, type, is_private, is_system, created_by, created_at, updated_at)
VALUES (1, 'offset-channel', '', '', 'standard', 0, 0, 'agent-a', CURRENT_TIMESTAMP, CURRENT_TIMESTAMP)`)
if err != nil {
t.Fatalf("create channel: %v", err)
}
conv := &Conversation{Subject: "ch offset", CreatedBy: "agent-a"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
chID := int64(1)
for i := 0; i < 5; i++ {
msg := &Message{
ConversationID: conv.ID,
FromAgent: "agent-a",
ChannelID: &chID,
Body: fmt.Sprintf("ch msg %d", i),
Priority: 5,
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
}
t.Run("offset=0 limit=3", func(t *testing.T) {
messages, err := store.GetChannelMessages(ctx, 1, 3, 0)
if err != nil {
t.Fatalf("GetChannelMessages: %v", err)
}
if len(messages) != 3 {
t.Errorf("got %d messages, want 3", len(messages))
}
})
t.Run("offset=3 returns remaining", func(t *testing.T) {
messages, err := store.GetChannelMessages(ctx, 1, 10, 3)
if err != nil {
t.Fatalf("GetChannelMessages: %v", err)
}
if len(messages) != 2 {
t.Errorf("got %d messages, want 2", len(messages))
}
})
t.Run("count channel messages", func(t *testing.T) {
count, err := store.CountChannelMessages(ctx, 1)
if err != nil {
t.Fatalf("CountChannelMessages: %v", err)
}
if count != 5 {
t.Errorf("count = %d, want 5", count)
}
})
}
func TestSQLiteMessageStore_CombinedFiltersAndPagination(t *testing.T) {
db := newTestDB(t)
store := NewSQLiteMessageStore(db)
ctx := context.Background()
seedAgent(t, db, "sender")
seedAgent(t, db, "reader")
conv := &Conversation{Subject: "combined", CreatedBy: "sender"}
if err := store.InsertConversation(ctx, conv); err != nil {
t.Fatalf("InsertConversation: %v", err)
}
for i := 0; i < 10; i++ {
msg := &Message{
ConversationID: conv.ID,
FromAgent: "sender",
ToAgent: "reader",
Body: fmt.Sprintf("combined msg %d", i),
Priority: 5 + (i % 3),
Status: StatusPending,
}
if err := store.InsertMessage(ctx, msg); err != nil {
t.Fatalf("InsertMessage: %v", err)
}
}
t.Run("filters + offset + limit", func(t *testing.T) {
// Get all with min_priority=6 first to know expected count
all, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
MinPriority: 6,
IncludeRead: true,
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
// Now paginate through
page1, err := store.GetInboxMessages(ctx, "reader", ReadOptions{
MinPriority: 6,
Limit: 2,
Offset: 0,
IncludeRead: true,
})
if err != nil {
t.Fatalf("GetInboxMessages: %v", err)
}
count, err := store.CountInboxMessages(ctx, "reader", ReadOptions{
MinPriority: 6,
IncludeRead: true,
})
if err != nil {
t.Fatalf("CountInboxMessages: %v", err)
}
if count != len(all) {
t.Errorf("count = %d, want %d", count, len(all))
}
if len(page1) > 2 {
t.Errorf("page1 got %d messages, want at most 2", len(page1))
}
})
}
+15
View File
@@ -57,6 +57,14 @@ type DeadLetter struct {
CreatedAt time.Time `json:"created_at"`
}
// PaginatedMessages holds a page of messages with total count.
type PaginatedMessages struct {
Messages []*Message `json:"messages"`
Total int `json:"total"`
Offset int `json:"offset"`
Limit int `json:"limit"`
}
// InboxState tracks per-agent, per-conversation read position.
type InboxState struct {
AgentName string `json:"agent_name"`
@@ -64,3 +72,10 @@ type InboxState struct {
LastReadMessageID int64 `json:"last_read_message_id"`
UpdatedAt time.Time `json:"updated_at"`
}
// DMUnreadCount holds the unread DM count for a specific peer agent.
type DMUnreadCount struct {
Agent string `json:"agent"`
UnreadCount int `json:"unread_count"`
LastMessageID int64 `json:"last_message_id"`
}
+2 -1
View File
@@ -207,11 +207,12 @@ func (s *Service) fulltextSearch(ctx context.Context, agentName string, opts Sea
msgOpts.ChannelID = opts.ChannelID
}
messages, err := s.msgService.SearchMessages(ctx, agentName, opts.Query, msgOpts)
paginated, err := s.msgService.SearchMessages(ctx, agentName, opts.Query, msgOpts)
if err != nil {
return nil, fmt.Errorf("fulltext search: %w", err)
}
messages := paginated.Messages
results := make([]*SearchResult, len(messages))
for i, msg := range messages {
results[i] = &SearchResult{
+6 -6
View File
@@ -8,29 +8,29 @@
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=DM+Sans:wght@400;500;600;700&family=Instrument+Sans:wght@400;500;600;700&family=JetBrains+Mono:wght@400;500&display=swap" rel="stylesheet">
<link href="/_app/immutable/entry/start.B4zIRc6l.js" rel="modulepreload">
<link href="/_app/immutable/chunks/k7nCSttu.js" rel="modulepreload">
<link href="/_app/immutable/entry/start.DpHKCwmv.js" rel="modulepreload">
<link href="/_app/immutable/chunks/BRBotovi.js" rel="modulepreload">
<link href="/_app/immutable/chunks/DBeLgT1-.js" rel="modulepreload">
<link href="/_app/immutable/chunks/SAcaBy3_.js" rel="modulepreload">
<link href="/_app/immutable/chunks/DL-Ee-iM.js" rel="modulepreload">
<link href="/_app/immutable/chunks/BCvik_Lu.js" rel="modulepreload">
<link href="/_app/immutable/chunks/BdrVqzRy.js" rel="modulepreload">
<link href="/_app/immutable/entry/app.UyBC-CXX.js" rel="modulepreload">
<link href="/_app/immutable/entry/app.B_lhmyMs.js" rel="modulepreload">
</head>
<body data-sveltekit-preload-data="hover">
<div style="display: contents">
<script>
{
__sveltekit_ymf88 = {
__sveltekit_vhg0t8 = {
base: ""
};
const element = document.currentScript.parentElement;
Promise.all([
import("/_app/immutable/entry/start.B4zIRc6l.js"),
import("/_app/immutable/entry/app.UyBC-CXX.js")
import("/_app/immutable/entry/start.DpHKCwmv.js"),
import("/_app/immutable/entry/app.B_lhmyMs.js")
]).then(([kit, app]) => {
kit.start(app, element);
});
@@ -0,0 +1,37 @@
# Specification Quality Checklist: Hybrid MCP Tool Architecture
**Purpose**: Validate specification completeness and quality before proceeding to planning
**Created**: 2026-03-15
**Feature**: [spec.md](../spec.md)
## Content Quality
- [x] No implementation details (languages, frameworks, APIs)
- [x] Focused on user value and business needs
- [x] Written for non-technical stakeholders
- [x] All mandatory sections completed
## Requirement Completeness
- [x] No [NEEDS CLARIFICATION] markers remain
- [x] Requirements are testable and unambiguous
- [x] Success criteria are measurable
- [x] Success criteria are technology-agnostic (no implementation details)
- [x] All acceptance scenarios are defined
- [x] Edge cases are identified
- [x] Scope is clearly bounded
- [x] Dependencies and assumptions identified
## Feature Readiness
- [x] All functional requirements have clear acceptance criteria
- [x] User scenarios cover primary flows
- [x] Feature meets measurable outcomes defined in Success Criteria
- [x] No implementation details leak into specification
## Notes
- Technology choices (goja, esbuild, BM25) are documented in Assumptions section only. Functional requirements are technology-agnostic (e.g., FR-032 says "transpile TypeScript" without naming a tool).
- FR-035 lists specific APIs to block — this defines security boundaries, not implementation choice.
- FR-022 references "BM25" — this is an algorithm specification, not a framework/library reference.
- All items pass validation after spec review round 1 fixes (enumerated action catalog, memory limits, broadcast semantics, migration note, edge cases). Spec is ready for clarify or plan phase.
+60
View File
@@ -0,0 +1,60 @@
# Implementation Plan: Hybrid MCP Tool Architecture
## Phase 1 — Foundation (parallel, no cross-dependencies)
### Task A: JS/TS Runtime Engine (`internal/jsruntime/`)
Port goja-based runtime from `../mcpproxy-go/internal/jsruntime/`. Simplified for SynapBus:
- `runtime.go` — Execute(code, opts) with sandbox, timeout, call bridge
- `pool.go` — Reusable runtime pool for concurrent executions
- `typescript.go` — esbuild type-stripping transpilation
- `*_test.go` — Table-driven tests for all components
- ToolCaller interface: `Call(ctx, actionName, args) (any, error)`
### Task B: Action Registry + BM25 Search (`internal/actions/`)
- `types.go` — Action struct (name, category, description, params, examples)
- `registry.go` — Registry collecting all 23 action definitions with schemas
- `search.go` — BM25 in-memory search over action docs
- `*_test.go` — Tests for registry + search relevance
- Each action definition maps to an existing service method
### Task C: Pagination + Advanced Filtering
Modify existing service layer (no new packages):
- `messaging/options.go` — Add Offset, After, Before fields to ReadOptions + SearchOptions
- `messaging/store.go` — Update SQL queries for offset pagination + total count + date filtering
- `messaging/service.go` — Return PaginatedResult{Items, Total, Offset, Limit}
- `channels/store.go` — Pagination for GetChannelMessages, ListChannels
- `channels/service.go` — Propagate pagination
- `channels/task_store.go` — Pagination for ListTasks
- `agents/` — Pagination for DiscoverAgents/ListAgents
- Schema migration if indices needed
- Tests for all modified queries
### Task D: CLI Subcommands
Add to existing cobra CLI in `cmd/synapbus/admin.go`:
- `synapbus webhook register|list|delete` — via admin Unix socket
- `synapbus k8s register|list|delete` — via admin Unix socket
- `synapbus attachments gc` — via admin Unix socket
- Server-side: add admin socket handlers in `internal/admin/socket.go`
- Wire webhook/k8s/attachment services into admin.Services struct
- Tests
## Phase 2 — MCP Rewrite (depends on A + B + C)
### Task E: 4-Tool MCP Architecture (`internal/mcp/`)
- Rewrite `server.go` constructor to accept jsruntime + action registry
- New `tools_hybrid.go` — my_status, search, execute, send_message
- Wire execute → jsruntime.Execute() with ToolCaller bridging to action registry
- Wire search → actions.Registry.Search()
- Wire send_message → merged DM + channel messaging
- Remove old registrar files (tools.go handlers, channel_tools.go, swarm_tools.go, webhook_tools.go, tools_attachments.go)
- Keep: server.go (modified), auth.go, connection.go, health.go
- Update main.go constructor call
- Comprehensive tests
## Phase 3 — Documentation (depends on all)
### Task F: Website Docs (`../synapbus-website/`)
- Update MCP tools documentation (4 tools instead of 30)
- Document execute code examples
- Document CLI commands for admin operations
- Update API reference
+224
View File
@@ -0,0 +1,224 @@
# Feature Specification: Hybrid MCP Tool Architecture
**Feature Branch**: `005-hybrid-mcp-tools`
**Created**: 2026-03-15
**Status**: Draft
**Input**: Redesign SynapBus MCP tools from 30 individual tools to a hybrid 4-tool architecture with JS/TS code execution, BM25 tool discovery, pagination, advanced filtering, and CLI subcommands for admin operations.
## User Scenarios & Testing *(mandatory)*
### User Story 1 - Agent Sends a Message (Priority: P1)
An agent connects to SynapBus and sends a direct message to another agent or posts to a channel. This is the most frequent operation and must work without requiring discovery or code execution.
**Why this priority**: Messaging is the core function. Agents should be able to send messages with a single tool call, zero friction.
**Independent Test**: An agent calls `send_message` with a recipient name and body. The message is delivered. No other tools required.
**Acceptance Scenarios**:
1. **Given** an authenticated agent, **When** it calls `send_message` with `to: "agent-bob"` and `body: "Hello"`, **Then** a direct message is delivered to agent-bob's inbox.
2. **Given** an authenticated agent that is a member of channel "general", **When** it calls `send_message` with `channel: "general"` and `body: "Update"`, **Then** the message is posted to the channel and visible to all members.
3. **Given** an authenticated agent, **When** it calls `send_message` with both `to` and `channel` specified, **Then** the system returns an error indicating only one target is allowed.
4. **Given** an authenticated agent, **When** it calls `send_message` with a non-existent recipient, **Then** the system returns a clear error message.
---
### User Story 2 - Agent Discovers Status and Available Actions (Priority: P1)
An agent connects to SynapBus for the first time and calls `my_status` to understand its identity, pending messages, and what actions are available. The response guides the agent to use `search` and `execute` for further operations.
**Why this priority**: This is the onboarding entry point. Without it, agents don't know what's available.
**Independent Test**: An agent calls `my_status` with no parameters and receives a structured response containing identity, pending counts, and instructions for using search/execute.
**Acceptance Scenarios**:
1. **Given** an authenticated agent with 3 pending messages and 2 channel mentions, **When** it calls `my_status`, **Then** it receives its identity, pending message count (3), mention count (2), channel memberships, and usage instructions for `search` and `execute`.
2. **Given** a newly registered agent with no activity, **When** it calls `my_status`, **Then** it receives its identity, zero counts, and clear guidance on getting started.
---
### User Story 3 - Agent Discovers and Executes Any Action (Priority: P1)
An agent needs to perform an operation (e.g., read inbox, join a channel, post a task). It searches for the relevant action using `search`, reviews the schema and examples, then calls `execute` with JS/TS code to perform the operation.
**Why this priority**: This is the core mechanism that replaces 23 individual tools with 2 meta-tools. Without it, agents lose access to all non-direct functionality.
**Independent Test**: An agent calls `search` with query "read inbox", gets back the action schema with parameters and examples, then calls `execute` with JS code `call("read_inbox", {limit: 10})` and receives inbox messages.
**Acceptance Scenarios**:
1. **Given** an authenticated agent, **When** it calls `search` with query `"join channel"`, **Then** it receives a list of matching actions with names, descriptions, parameter schemas, and usage examples ranked by relevance.
2. **Given** an authenticated agent that knows the action name, **When** it calls `execute` with code `call("join_channel", {channel_name: "general"})`, **Then** the agent joins the channel and receives confirmation.
3. **Given** an authenticated agent, **When** it calls `execute` with TypeScript code `const res = call("read_inbox", {limit: 5}); const urgent = res.messages.filter((m: any) => m.priority >= 8); urgent`, **Then** the TypeScript is transpiled and executed, returning only high-priority messages.
4. **Given** an authenticated agent, **When** it calls `execute` with code referencing a non-existent action, **Then** the system returns a clear error with suggestions for similar action names.
5. **Given** an authenticated agent, **When** it calls `execute` with code that runs longer than the timeout, **Then** execution is terminated and an error is returned.
---
### User Story 4 - Agent Searches Messages with Filters and Pagination (Priority: P2)
An agent needs to find specific messages — filtering by date range, sender, channel, or status — and paginate through large result sets. Semantic search can be combined with filters.
**Why this priority**: Agents operating on accumulated history need targeted retrieval. Without filtering and pagination, they either get too much data or miss relevant messages.
**Independent Test**: An agent calls `execute` with `call("search_messages", {query: "deployment", from_agent: "ci-bot", after: "2026-03-01", limit: 10, offset: 20})` and receives page 3 of matching messages.
**Acceptance Scenarios**:
1. **Given** messages from multiple agents across multiple channels, **When** an agent searches with `from_agent: "deploy-bot"` and `after: "2026-03-10"`, **Then** only messages from deploy-bot after March 10 are returned.
2. **Given** 100 matching messages and a request with `limit: 10, offset: 20`, **When** the agent executes the search, **Then** it receives messages 21-30 and a total count indicating 100 matches.
3. **Given** an embedding provider is configured, **When** an agent searches with `query: "production incident"` and `search_mode: "semantic"`, **Then** semantically similar messages are returned ranked by relevance.
4. **Given** a search with filters that match nothing, **When** the agent executes, **Then** an empty result set is returned with total count of 0.
---
### User Story 5 - Human Admin Manages Webhooks and K8s Handlers via CLI (Priority: P2)
A human administrator uses CLI subcommands to register, list, and delete webhooks and Kubernetes job handlers, and to run attachment garbage collection. These operations are no longer available as MCP tools.
**Why this priority**: Infrastructure configuration is a human concern, not an agent concern. Moving these to CLI reduces MCP tool surface and token cost.
**Independent Test**: An admin runs `synapbus webhook register --url https://example.com/hook --events message.received --secret mysecret` and the webhook is created. `synapbus webhook list` shows it.
**Acceptance Scenarios**:
1. **Given** a running SynapBus instance, **When** an admin runs `synapbus webhook register --url <url> --events message.received --secret <secret>`, **Then** a webhook is registered for the specified events.
2. **Given** registered webhooks, **When** an admin runs `synapbus webhook list`, **Then** all webhooks are displayed with ID, URL, events, status, and failure count.
3. **Given** a webhook ID, **When** an admin runs `synapbus webhook delete --id 5`, **Then** the webhook is removed.
4. **Given** a SynapBus instance running in-cluster, **When** an admin runs `synapbus k8s register --image my-agent:latest --events message.received`, **Then** a K8s job handler is registered.
5. **Given** orphaned attachments exist, **When** an admin runs `synapbus attachments gc`, **Then** orphaned files are removed and a summary of reclaimed space is displayed.
---
### User Story 6 - Agent Composes Multi-Step Workflows (Priority: P3)
An agent executes a complex workflow in a single `execute` call — e.g., reading inbox, filtering messages, replying to each, and posting a summary to a channel.
**Why this priority**: Composability reduces round-trips between LLM and SynapBus. While most calls are one-shot, complex agents benefit from chaining operations.
**Independent Test**: An agent calls `execute` with JS code that reads inbox, filters by priority, replies to each, and posts a summary. All operations complete in one tool call.
**Acceptance Scenarios**:
1. **Given** an agent with 5 pending messages, **When** it calls `execute` with code that reads inbox, marks each as done, and posts a summary count to channel "ops", **Then** all 5 messages are marked done and the summary is posted.
2. **Given** an agent composing a workflow, **When** the code makes more calls than the configured maximum, **Then** execution is halted and an error is returned indicating the call limit was exceeded.
---
### Edge Cases
- What happens when `execute` code contains an infinite loop? Timeout enforcement terminates it and returns an error with elapsed time.
- What happens when `execute` code calls an action the agent is not authorized for? The `call()` bridge checks auth per-action and returns a permission error without terminating the script.
- What happens when `search` query matches no actions? An empty result set with a suggestion to broaden the query.
- What happens when TypeScript code has syntax errors? esbuild transpilation fails and returns the syntax error with line/column info.
- What happens when `execute` code tries to access dangerous APIs (require, fetch, setTimeout)? The sandbox blocks them and returns an error listing the disallowed API.
- What happens when `send_message` is called with empty body? Validation error returned.
- What happens when `send_message` `reply_to` references a non-existent message? Validation error returned.
- What happens when `execute` code allocates excessive memory? Memory limit enforcement terminates it and returns an error.
- What happens when an agent calls `search` expecting message results? The tool returns action definitions, not messages. The `search` tool description explicitly states it is for action discovery.
- What happens when pagination offset exceeds total results? Empty result set returned with the total count.
## Requirements *(mandatory)*
### Functional Requirements
**MCP Tool Surface**
- **FR-001**: System MUST expose exactly 4 MCP tools: `my_status`, `search`, `execute`, `send_message`.
- **FR-002**: System MUST remove all 30 previously individual MCP tools and replace them with the 4-tool architecture.
- **FR-003**: All agent-facing operations listed below MUST remain callable as actions via the `execute` tool. The `send_message` action is also accessible as a dedicated MCP tool.
**Action Catalog** (23 operations, by category):
| Category | Actions |
|----------|---------|
| Messaging | `send_message`, `read_inbox`, `claim_messages`, `mark_done`, `search_messages`, `discover_agents` |
| Channels | `create_channel`, `join_channel`, `leave_channel`, `list_channels`, `invite_to_channel`, `kick_from_channel`, `get_channel_messages`, `send_channel_message`, `update_channel` |
| Swarm | `post_task`, `bid_task`, `accept_bid`, `complete_task`, `list_tasks` |
| Attachments | `upload_attachment`, `download_attachment` |
**my_status Tool**
- **FR-010**: `my_status` MUST accept zero parameters and return: agent identity, pending direct message count, channel mention count, channel memberships, system notifications, and usage statistics (channels joined, unread channel messages, total messages sent/received).
- **FR-011**: `my_status` response MUST include instructions guiding agents to use `search` and `execute` for further operations.
**search Tool**
- **FR-020**: `search` MUST accept a natural-language query string and return matching actions ranked by relevance. Note: `search` is for action/tool discovery only — message search is a separate action (`search_messages`) called via `execute`.
- **FR-021**: `search` results MUST include: action name, description, parameter schema, relevance score, and at least one usage example per action.
- **FR-022**: `search` MUST use BM25 full-text ranking over action documentation.
- **FR-023**: `search` MUST accept an optional `limit` parameter (default 5, max 20).
**execute Tool**
- **FR-030**: `execute` MUST accept a `code` parameter containing JavaScript or TypeScript source code.
- **FR-031**: `execute` MUST provide a `call(action_name, args)` function within the execution context that invokes any registered action.
- **FR-032**: `execute` MUST transpile TypeScript to JavaScript before execution (type-stripping only, no semantic validation).
- **FR-033**: `execute` MUST enforce a configurable timeout (default 120 seconds) and terminate execution if exceeded.
- **FR-034**: `execute` MUST enforce a configurable maximum number of `call()` invocations per execution (default 50).
- **FR-035**: `execute` MUST sandbox the runtime by disabling: `require`, `import`, `fetch`, `setTimeout`, `setInterval`, `XMLHttpRequest`, and filesystem/network access.
- **FR-036**: `execute` MUST propagate the calling agent's authentication context to all `call()` invocations.
- **FR-037**: `execute` MUST return the final expression value of the code as the tool result, serialized as JSON.
- **FR-038**: `execute` MUST return clear error messages for: syntax errors (with line/column), runtime errors (with stack trace), timeout, and call limit exceeded.
- **FR-039**: When multiple agents call `execute` concurrently, all executions MUST complete or fail independently without interference.
- **FR-039a**: `execute` MUST enforce a configurable maximum memory usage per execution and terminate if exceeded.
**send_message Tool**
- **FR-040**: `send_message` MUST accept either `to` (agent name for DM) or `channel` (name or ID for channel message), but not both.
- **FR-041**: `send_message` MUST accept: `body` (required), `subject`, `priority` (1-10, default 5), `metadata` (JSON string), `reply_to` (message ID).
- **FR-042**: `send_message` MUST validate that the agent is a member of the target channel before posting.
- **FR-043**: When `channel` is specified, `send_message` MUST broadcast the message to all channel members (preserving current `send_channel_message` semantics). The `channel` parameter MUST accept either a channel name (string) or channel ID (number).
- **FR-044**: When `reply_to` references a non-existent message ID, `send_message` MUST return a validation error.
**Pagination**
- **FR-050**: All list/read actions MUST support offset-based pagination via `offset` (default 0) and `limit` parameters.
- **FR-051**: Paginated responses MUST include `total` count, `offset`, and `limit` in the result.
- **FR-052**: Pagination MUST apply to: `read_inbox`, `get_channel_messages`, `list_channels`, `list_tasks`, `search_messages`, `discover_agents`.
**Advanced Filtering**
- **FR-060**: `search_messages` action MUST support filtering by: `after` (ISO 8601 date), `before` (ISO 8601 date), `from_agent`, `channel`, `status`.
- **FR-061**: `search_messages` MUST support combining text/semantic query with filters (filters narrow the result set, query ranks within it).
- **FR-062**: `read_inbox` action MUST support filtering by: `from_agent`, `min_priority`, `status`, `after`, `before`.
**CLI Subcommands**
- **FR-070**: System MUST provide `synapbus webhook register|list|delete` CLI subcommands with equivalent functionality to the removed MCP tools.
- **FR-071**: System MUST provide `synapbus k8s register|list|delete` CLI subcommands with equivalent functionality to the removed MCP tools.
- **FR-072**: System MUST provide `synapbus attachments gc` CLI subcommand with equivalent functionality to the removed MCP tool.
- **FR-073**: CLI subcommands MUST connect to a running SynapBus instance to perform operations.
### Key Entities
- **Action**: A callable operation with a name, category (messaging/channels/swarm/attachments), description, parameter schema, return schema, and usage examples. Actions are the internal operations that were previously individual MCP tools.
- **Action Index**: A BM25-searchable index built at startup from all registered action definitions. Rebuilt when actions change.
- **Execution Context**: A sandboxed JavaScript runtime instance with: the `call()` bridge function, the calling agent's auth context, timeout/call-limit enforcement, and no external access.
## Success Criteria *(mandatory)*
### Measurable Outcomes
- **SC-001**: MCP tool definitions sent to agents are reduced from 30 to 4.
- **SC-002**: All 23 agent-facing operations remain fully functional and accessible via the execute tool.
- **SC-003**: Agents can discover any action by natural-language search and receive usable schemas and examples within a single search call.
- **SC-004**: The most common operation (sending a message) completes in a single tool call without requiring search or execute.
- **SC-005**: Agents can paginate through result sets of any size using offset/limit and receive total counts for navigation.
- **SC-006**: Message search supports filtering by date, sender, channel, and status, combinable with semantic search.
- **SC-007**: Human administrators can manage all webhook, K8s handler, and attachment GC operations via CLI without requiring MCP access.
- **SC-008**: Code execution completes or times out within the configured limit — no runaway executions.
- **SC-009**: Existing tests continue to pass (service layer unchanged, only MCP transport layer and CLI layer modified).
## Assumptions
- Agents are Claude/GPT-class models capable of writing JavaScript/TypeScript code reliably.
- The goja pure-Go JavaScript engine and esbuild pure-Go transpiler satisfy the zero-CGO constraint.
- BM25 can be implemented with a lightweight in-memory index (no external search engine) since the action catalog is small (~23 entries).
- The `call()` bridge reuses existing service-layer methods — no new business logic is needed for individual actions.
- CLI subcommands will connect to the running instance via the existing admin interface pattern.
- The runtime pool size is configurable and defaults to a reasonable number for single-node deployment (e.g., 10 concurrent runtimes).
- This is a breaking change. Existing agents using the 30 individual MCP tools must be updated to use the 4-tool architecture. No backward compatibility layer is provided.
- TypeScript transpilation uses esbuild (pure Go, zero CGO). BM25 search uses a lightweight in-memory implementation.
@@ -0,0 +1,35 @@
# Specification Quality Checklist: Admin CLI & Docker Fixes
**Purpose**: Validate specification completeness and quality before proceeding to planning
**Created**: 2026-03-15
**Feature**: [spec.md](../spec.md)
## Content Quality
- [x] No implementation details (languages, frameworks, APIs)
- [x] Focused on user value and business needs
- [x] Written for non-technical stakeholders
- [x] All mandatory sections completed
## Requirement Completeness
- [x] No [NEEDS CLARIFICATION] markers remain
- [x] Requirements are testable and unambiguous
- [x] Success criteria are measurable
- [x] Success criteria are technology-agnostic (no implementation details)
- [x] All acceptance scenarios are defined
- [x] Edge cases are identified
- [x] Scope is clearly bounded
- [x] Dependencies and assumptions identified
## Feature Readiness
- [x] All functional requirements have clear acceptance criteria
- [x] User scenarios cover primary flows
- [x] Feature meets measurable outcomes defined in Success Criteria
- [x] No implementation details leak into specification
## Notes
- All items pass. Spec is ready for `/speckit.plan`.
- FR-001 mentions "alpine:3.19" which is an implementation detail, but this is the explicit user request and core to the fix, so it's acceptable.
@@ -0,0 +1,138 @@
# Admin Socket Contract: Channel Commands
**Feature**: 006-admin-cli-docker-fixes
**Date**: 2026-03-15
## Protocol
Unix domain socket at `/data/synapbus.sock` (default). JSON-RPC style, newline-delimited.
## New Commands
### `channels.create`
**Request**:
```json
{
"command": "channels.create",
"args": {
"name": "news-feed",
"description": "News feed channel"
}
}
```
- `name` (string, required): Channel name. Must pass `ValidateChannelName` rules.
- `description` (string, optional): Channel description. Defaults to empty.
**Success Response**:
```json
{
"ok": true,
"data": {
"id": 42,
"name": "news-feed",
"description": "News feed channel",
"type": "standard",
"is_private": false,
"created_by": "system",
"created_at": "2026-03-15T10:00:00Z"
}
}
```
**Error Response** (duplicate name):
```json
{
"ok": false,
"error": "channel already exists"
}
```
**Error Response** (invalid name):
```json
{
"ok": false,
"error": "invalid channel name: ..."
}
```
---
### `channels.join`
**Request**:
```json
{
"command": "channels.join",
"args": {
"channel": "news-feed",
"agent": "my-agent"
}
}
```
- `channel` (string, required): Channel name to join.
- `agent` (string, required): Agent name to add as member.
**Success Response**:
```json
{
"ok": true,
"data": {
"channel": "news-feed",
"agent": "my-agent",
"status": "joined"
}
}
```
**Success Response** (already member, idempotent):
```json
{
"ok": true,
"data": {
"channel": "news-feed",
"agent": "my-agent",
"status": "already_member"
}
}
```
**Error Response** (channel not found):
```json
{
"ok": false,
"error": "channel not found: news-feed"
}
```
## CLI Commands
### `synapbus channels create`
```
Usage:
synapbus channels create [flags]
Flags:
--name string Channel name (required)
--description string Channel description
Global Flags:
--socket string Path to admin Unix socket (default "/data/synapbus.sock")
```
### `synapbus channels join`
```
Usage:
synapbus channels join [flags]
Flags:
--channel string Channel name (required)
--agent string Agent name (required)
Global Flags:
--socket string Path to admin Unix socket (default "/data/synapbus.sock")
```
@@ -0,0 +1,42 @@
# Data Model: Admin CLI & Docker Fixes
**Feature**: 006-admin-cli-docker-fixes
**Date**: 2026-03-15
## No Schema Changes
This feature does not introduce any new database tables, columns, or migrations. All operations use existing entities:
### Existing Entities Used
#### Channel (existing)
- `id` (int64): Auto-increment primary key
- `name` (string): Unique, normalized channel name
- `description` (string): Optional description
- `type` (string): "standard", "blackboard", "auction"
- `is_private` (bool): Whether channel requires invite
- `is_system` (bool): Whether channel is system-managed
- `created_by` (string): Agent name of creator
- `created_at` (timestamp): Creation time
#### Membership (existing)
- `channel_id` (int64): FK to channels
- `agent_name` (string): Name of member agent
- `role` (string): "owner", "member"
- `joined_at` (timestamp): When the agent joined
### Data Flow
```
CLI Command Admin Socket Handler Channel Service
─────────────────────────────────────────────────────────────────────────────
channels create --name X → channels.create {name, desc} → CreateChannel(req)
channels join --ch X --ag Y → channels.join {channel, agent} → GetChannelByName(X)
→ JoinChannel(id, Y)
```
### Validation Rules (existing, no changes)
- Channel names: lowercase, alphanumeric + hyphens, 1-64 chars, no leading/trailing hyphens
- Agent names: must exist in the agent registry
- Channel join: idempotent (re-joining a channel the agent is already in is a no-op)
- Private channels: require a pending invite before join
+74
View File
@@ -0,0 +1,74 @@
# Implementation Plan: Admin CLI & Docker Fixes
**Branch**: `006-admin-cli-docker-fixes` | **Date**: 2026-03-15 | **Spec**: [spec.md](spec.md)
**Input**: Feature specification from `/specs/006-admin-cli-docker-fixes/spec.md`
## Summary
Fix four operational issues blocking reliable admin CLI usage in containerized SynapBus: switch Docker base image from `scratch` to `alpine:3.19` so admin socket CLI works via `kubectl exec`, add `synapbus channels create` and `synapbus channels join` CLI commands backed by new admin socket handlers, and change the default socket path from relative `./data/synapbus.sock` to absolute `/data/synapbus.sock`.
## Technical Context
**Language/Version**: Go 1.25+ (per go.mod)
**Primary Dependencies**: spf13/cobra (CLI), go-chi/chi (HTTP), mark3labs/mcp-go (MCP)
**Storage**: modernc.org/sqlite (pure Go, zero CGO)
**Testing**: `go test ./...` (table-driven tests)
**Target Platform**: linux/amd64, darwin/arm64 (Docker + local dev)
**Project Type**: CLI / web-service (single binary)
**Performance Goals**: Admin socket commands complete in < 1 second
**Constraints**: Zero CGO, single binary, pure Go
**Scale/Scope**: Single instance, admin-only operations
## Constitution Check
*GATE: Must pass before Phase 0 research. Re-check after Phase 1 design.*
| Principle | Status | Notes |
|-----------|--------|-------|
| I. Local-First, Single Binary | PASS | No new external dependencies. Alpine base image only adds shell availability. |
| II. MCP-Native | PASS | Changes are admin CLI only, no MCP interface changes. |
| III. Pure Go, Zero CGO | PASS | No new Go dependencies. Dockerfile still builds with `CGO_ENABLED=0`. |
| IV. Multi-Tenant with Ownership | PASS | Admin socket is localhost-only, trusted operator context. |
| V. Embedded OAuth 2.1 | N/A | No auth changes. |
| VI. Semantic-Ready Storage | N/A | No storage schema changes. |
| VII. Swarm Intelligence | N/A | No swarm pattern changes. |
| VIII. Observable by Default | PASS | Channel create/join are traced via existing channel service. |
| IX. Progressive Complexity | PASS | New CLI commands add no complexity for basic usage. |
| X. Web UI | N/A | No UI changes. |
**Gate Result**: PASS — no violations.
## Project Structure
### Documentation (this feature)
```text
specs/006-admin-cli-docker-fixes/
├── plan.md # This file
├── research.md # Phase 0 output
├── data-model.md # Phase 1 output
├── quickstart.md # Phase 1 output
├── contracts/ # Phase 1 output (admin socket protocol)
└── tasks.md # Phase 2 output (via /speckit.tasks)
```
### Source Code (repository root)
```text
# Files modified:
Dockerfile # scratch → alpine:3.19
cmd/synapbus/admin.go # Add channels create/join commands, fix default socket path
internal/admin/socket.go # Add channels.create and channels.join handlers
cmd/synapbus/admin_test.go # Tests for new CLI commands
# Files unchanged but referenced:
internal/channels/service.go # CreateChannel, JoinChannel (already exist)
internal/channels/store.go # GetChannelByName (already exists)
internal/admin/server.go # Services struct (already has Channels field)
```
**Structure Decision**: This feature modifies 3 existing files and adds no new files. All changes fit within the existing project structure.
## Complexity Tracking
No constitution violations to justify.
@@ -0,0 +1,61 @@
# Quickstart: Admin CLI & Docker Fixes
**Feature**: 006-admin-cli-docker-fixes
## Build & Deploy
```bash
# Build Docker image (now uses alpine base)
docker build -t synapbus:dev .
# Run locally
./synapbus serve --port 8080 --data ./data
```
## New CLI Commands
### Create a channel
```bash
# With description
synapbus channels create --name news-feed --description "News feed channel"
# Without description
synapbus channels create --name alerts
```
### Join an agent to a channel
```bash
synapbus channels join --channel news-feed --agent research-mcpproxy
```
### In Kubernetes
```bash
# Now works because alpine base image provides /bin/sh
kubectl exec -n synapbus deploy/synapbus -- /synapbus channels create --name news-feed
kubectl exec -n synapbus deploy/synapbus -- /synapbus channels join --channel news-feed --agent my-agent
kubectl exec -n synapbus deploy/synapbus -- /synapbus channels list
```
## Socket Path
The default socket path is now `/data/synapbus.sock` (absolute). Override with:
```bash
# Environment variable
export SYNAPBUS_SOCKET=/custom/path/synapbus.sock
# CLI flag
synapbus --socket /custom/path/synapbus.sock channels list
```
## Verification
```bash
# Verify Docker image base
docker run --rm synapbus:dev sh -c "cat /etc/os-release"
# Should show Alpine Linux
# Verify socket path default
synapbus --help | grep socket
# Should show: --socket string Path to admin Unix socket (default "/data/synapbus.sock")
```
@@ -0,0 +1,49 @@
# Research: Admin CLI & Docker Fixes
**Feature**: 006-admin-cli-docker-fixes
**Date**: 2026-03-15
## R1: Alpine vs Scratch Docker Base Image
**Decision**: Use `alpine:3.19` as the runtime base image.
**Rationale**: The `scratch` image has no shell, no `/bin/sh`, no filesystem utilities. This means `kubectl exec` cannot spawn any process other than the entrypoint binary itself. Since admin CLI commands need to connect to the Unix socket created by the running server process, exec'd processes need a working environment. Alpine adds ~7MB but provides `/bin/sh`, basic filesystem operations, and a working process environment.
**Alternatives considered**:
- `distroless/static` (Google): No shell, same problem as scratch.
- `busybox`: Works but no package manager. Alpine is the standard minimal base.
- `debian-slim`: ~80MB, unnecessarily large.
## R2: Admin Socket Protocol for Channel Operations
**Decision**: Add `channels.create` and `channels.join` commands to the existing admin socket dispatch table, following the exact pattern of existing commands (e.g., `agent.create`, `webhook.register`).
**Rationale**: The admin socket already has a well-established request/response pattern: JSON-RPC style `{command, args}` → `{ok, data, error}`. The channel service already exposes `CreateChannel` and `JoinChannel` methods. The admin server already holds a reference to the channel service via `Services.Channels`. No new wiring needed.
**Alternatives considered**:
- HTTP admin API endpoint: Would require API key protection (user explicitly rejected this approach).
- Direct database manipulation via CLI: Bypasses service layer validation, unsafe.
## R3: Default Socket Path
**Decision**: Change default from `./data/synapbus.sock` to `/data/synapbus.sock` (absolute).
**Rationale**: In containers, the working directory is `/` and the data volume is mounted at `/data`. The relative path `./data/synapbus.sock` resolves to `/data/synapbus.sock` from `/`, but this is confusing and fragile. An absolute default matches the Dockerfile's `--data /data` argument and the Helm chart's `volumeMount` at `/data`.
The `SYNAPBUS_SOCKET` environment variable and `--socket` flag still allow overriding for development (e.g., `--socket ./data/synapbus.sock` for local dev).
**Alternatives considered**:
- Keep relative path: Works in containers but confusing for users.
- Use `$SYNAPBUS_DATA_DIR/synapbus.sock` as default: Over-engineered; the socket path flag already exists.
## R4: `channels.create` Admin Handler Design
**Decision**: The `channels.create` handler accepts `{name, description}` args, calls `channelService.CreateChannel` with `created_by: "system"`, and returns the created channel as JSON.
**Rationale**: Admin socket commands are implicitly trusted (localhost-only, process-level access). Using `"system"` as the creator matches the pattern used for the default `#general` channel. The `description` field is optional (defaults to empty string).
## R5: `channels.join` Admin Handler Design
**Decision**: The `channels.join` handler accepts `{channel, agent}` args, looks up the channel by name via `GetChannelByName`, then calls `JoinChannel(channelID, agentName)`. Returns success message.
**Rationale**: The CLI uses channel names (not IDs) because operators work with names. The service's `JoinChannel` already handles idempotency (re-joining is a no-op) and private channel invite checks.
+118
View File
@@ -0,0 +1,118 @@
# Feature Specification: Admin CLI & Docker Fixes
**Feature Branch**: `006-admin-cli-docker-fixes`
**Created**: 2026-03-15
**Status**: Draft
**Input**: User description: "Fix admin socket accessibility in Docker, add channels create/join CLI commands, fix default socket path"
## User Scenarios & Testing *(mandatory)*
### User Story 1 - Admin CLI Works in Kubernetes Pods (Priority: P1)
An operator needs to run admin CLI commands inside a Kubernetes pod (e.g., `kubectl exec -n synapbus deploy/synapbus -- /synapbus channels list`). With the current `scratch` base image, there is no shell and the admin socket is unreachable via exec'd processes. Switching to `alpine` allows `kubectl exec` with a shell and gives the admin CLI a working environment.
**Why this priority**: This is a blocker — without this fix, all admin CLI operations fail after pod restart in production.
**Independent Test**: Build Docker image with alpine base, deploy to a test pod, run `kubectl exec ... -- /synapbus channels list` and verify it returns results.
**Acceptance Scenarios**:
1. **Given** a SynapBus pod running with the alpine-based image, **When** an operator runs `kubectl exec deploy/synapbus -- /synapbus channels list`, **Then** the command executes and returns channel data over the admin socket.
2. **Given** a SynapBus pod running with the alpine-based image, **When** an operator runs `kubectl exec deploy/synapbus -- sh`, **Then** they get an interactive shell.
---
### User Story 2 - Create Channels via CLI (Priority: P1)
An operator needs to create channels without using the Web UI or REST API with session cookies. The `synapbus channels create` command should create a channel via the admin socket.
**Why this priority**: Required for automated provisioning scripts and headless setups.
**Independent Test**: Start SynapBus server, run `synapbus channels create --name test-channel --description "A test channel"`, then verify with `synapbus channels list`.
**Acceptance Scenarios**:
1. **Given** a running SynapBus server, **When** an operator runs `synapbus channels create --name news-feed --description "News feed channel"`, **Then** the channel is created and a success response with channel details is printed.
2. **Given** a running SynapBus server, **When** an operator runs `synapbus channels create --name news-feed` without `--description`, **Then** the channel is created with an empty description.
3. **Given** a channel named "news-feed" already exists, **When** an operator runs `synapbus channels create --name news-feed`, **Then** an appropriate error message is displayed.
---
### User Story 3 - Join Agents to Channels via CLI (Priority: P1)
An operator needs to add agents to channels via the admin CLI so agents can post messages. The `synapbus channels join` command should add an agent to a channel's membership.
**Why this priority**: Agents cannot post to channels they haven't joined; this is required for initial agent setup and automation.
**Independent Test**: Create a channel and an agent, run `synapbus channels join --channel test-channel --agent my-agent`, then verify with `synapbus channels show --name test-channel`.
**Acceptance Scenarios**:
1. **Given** a channel "test-channel" and agent "my-agent" exist, **When** an operator runs `synapbus channels join --channel test-channel --agent my-agent`, **Then** the agent is added as a member and a success response is printed.
2. **Given** an agent is already a member of "test-channel", **When** an operator runs `synapbus channels join --channel test-channel --agent my-agent`, **Then** the operation succeeds idempotently (no error).
3. **Given** channel "nonexistent" does not exist, **When** an operator runs `synapbus channels join --channel nonexistent --agent my-agent`, **Then** an error message indicates the channel was not found.
---
### User Story 4 - Absolute Default Socket Path (Priority: P2)
The default socket path for admin CLI commands is currently `./data/synapbus.sock` (relative). In containers where CWD varies, this is confusing. The default should be `/data/synapbus.sock` (absolute) to match the container layout.
**Why this priority**: Quality-of-life improvement; the current relative path works but is confusing.
**Independent Test**: Run `synapbus --help` and verify the default socket path shows `/data/synapbus.sock`.
**Acceptance Scenarios**:
1. **Given** the `--socket` flag is not provided, **When** the CLI resolves the admin socket path, **Then** it defaults to `/data/synapbus.sock`.
2. **Given** the `SYNAPBUS_SOCKET` environment variable is set, **When** the CLI resolves the admin socket path, **Then** it uses the environment variable value.
3. **Given** the `--socket` flag is provided with a custom path, **When** the CLI resolves the admin socket path, **Then** it uses the custom path.
---
### Edge Cases
- What happens when channel name contains invalid characters? The existing `ValidateChannelName` rules apply, and the CLI reports the validation error.
- What happens when the admin socket is not reachable? The CLI prints a connection error with "is synapbus serve running?" hint.
- What happens when an agent name doesn't exist during channel join? The operation fails with a clear error message from the channel service.
- What happens when the `--name` flag is missing on `channels create`? Cobra enforces the required flag and prints usage.
## Requirements *(mandatory)*
### Functional Requirements
- **FR-001**: The Docker image MUST use `alpine:3.19` as the runtime base image instead of `scratch`.
- **FR-002**: The system MUST provide a `synapbus channels create` CLI command with `--name` (required) and `--description` (optional) flags.
- **FR-003**: The `channels create` command MUST send a `channels.create` request over the admin socket and display the result.
- **FR-004**: The admin socket server MUST handle `channels.create` commands by creating a channel via the channel service.
- **FR-005**: The system MUST provide a `synapbus channels join` CLI command with `--channel` (required) and `--agent` (required) flags.
- **FR-006**: The `channels join` command MUST send a `channels.join` request over the admin socket and display the result.
- **FR-007**: The admin socket server MUST handle `channels.join` commands by looking up the channel by name and adding the agent as a member.
- **FR-008**: The default value of the `--socket` persistent flag MUST be `/data/synapbus.sock` (absolute path).
- **FR-009**: The `SYNAPBUS_SOCKET` environment variable MUST override the default socket path when the flag is not explicitly set.
- **FR-010**: The Docker image MUST remain minimal — only the binary, TLS certs, and timezone data should be included from the build stage.
### Key Entities
- **Channel**: Named communication space with type, description, privacy flag, and member list.
- **Agent**: Named entity (AI or human) that can be a member of channels.
- **Admin Socket**: Unix domain socket at a known path, used by CLI commands to communicate with the running server.
## Success Criteria *(mandatory)*
### Measurable Outcomes
- **SC-001**: Operators can execute all admin CLI commands inside a Kubernetes pod via `kubectl exec` without errors.
- **SC-002**: `synapbus channels create --name <name>` successfully creates a channel and returns channel details within 1 second.
- **SC-003**: `synapbus channels join --channel <name> --agent <name>` successfully adds an agent to a channel within 1 second.
- **SC-004**: The default socket path displayed in help text is `/data/synapbus.sock`.
- **SC-005**: The Docker image size remains under 50MB (alpine adds minimal overhead vs scratch).
## Assumptions
- Alpine 3.19 is acceptable as the runtime base image (adds ~7MB over scratch).
- The `channels.create` admin command uses `"system"` as the `created_by` field since admin socket operations are implicitly trusted.
- The `channels.join` admin command adds the agent with the `"member"` role (not owner).
- Channel type defaults to `"standard"` if not specified.
- No `--private` or `--type` flags are needed for the initial `channels create` command — they can be added later.
- The Helm chart deployment.yaml does not need changes since it already passes `--data /data`.
+44
View File
@@ -0,0 +1,44 @@
# Tasks: Admin CLI & Docker Fixes
**Feature**: 006-admin-cli-docker-fixes
**Created**: 2026-03-15
**Plan**: [plan.md](plan.md)
## Phase 1: Setup
- [x] **T01**: Change default socket path from `./data/synapbus.sock` to `/data/synapbus.sock` in `cmd/synapbus/admin.go` (line 922) and update the `SYNAPBUS_SOCKET` env var check comparison string.
- Files: `cmd/synapbus/admin.go`
## Phase 2: Core — Admin Socket Handlers
- [x] **T02**: Add `channels.create` handler to `internal/admin/socket.go` dispatch table and implement `handleChannelsCreate` method.
- Files: `internal/admin/socket.go`
- Depends on: T01
- [x] **T03**: Add `channels.join` handler to `internal/admin/socket.go` dispatch table and implement `handleChannelsJoin` method.
- Files: `internal/admin/socket.go`
- Depends on: T01
## Phase 3: Core — CLI Commands
- [x] **T04**: Add `synapbus channels create` cobra command with `--name` (required) and `--description` (optional) flags in `cmd/synapbus/admin.go`.
- Files: `cmd/synapbus/admin.go`
- Depends on: T02
- [x] **T05**: Add `synapbus channels join` cobra command with `--channel` (required) and `--agent` (required) flags in `cmd/synapbus/admin.go`.
- Files: `cmd/synapbus/admin.go`
- Depends on: T03
## Phase 4: Docker
- [x] **T06**: Change Dockerfile runtime stage from `FROM scratch` to `FROM alpine:3.19` and add `RUN apk add --no-cache ca-certificates tzdata` (removing COPY of certs/tzdata from builder).
- Files: `Dockerfile`
## Phase 5: Tests & Validation
- [x] **T07**: Add unit tests for `channels.create` and `channels.join` admin socket handlers.
- Files: `cmd/synapbus/admin_test.go`
- Depends on: T04, T05
- [x] **T08**: Run `make build` and `make test` to verify all changes compile and pass.
- Depends on: T01-T07
+147 -332
View File
@@ -20,11 +20,13 @@ import (
"github.com/go-chi/chi/v5"
_ "modernc.org/sqlite"
"github.com/synapbus/synapbus/internal/actions"
"github.com/synapbus/synapbus/internal/agents"
"github.com/synapbus/synapbus/internal/apikeys"
"github.com/synapbus/synapbus/internal/attachments"
"github.com/synapbus/synapbus/internal/channels"
"github.com/synapbus/synapbus/internal/console"
"github.com/synapbus/synapbus/internal/jsruntime"
mcpserver "github.com/synapbus/synapbus/internal/mcp"
"github.com/synapbus/synapbus/internal/messaging"
"github.com/synapbus/synapbus/internal/search"
@@ -116,13 +118,20 @@ func setupEnv(t *testing.T) *testEnv {
// Console printer (discard output during tests)
con := console.NewWithWriter(io.Discard)
// Create MCP server
mcpSrv := mcpserver.NewMCPServer(msgService, agentService, channelService, swarmService, attService, searchService, con, nil, nil, db)
// Create JS runtime pool and action registry
jsPool := jsruntime.NewPool(5)
t.Cleanup(func() { jsPool.Close() })
actionRegistry := actions.NewRegistry()
actionIndex := actions.NewIndex(actionRegistry.List())
// Create MCP server with 4 hybrid tools
mcpSrv := mcpserver.NewMCPServer(msgService, agentService, channelService, swarmService, attService, searchService, con, jsPool, actionRegistry, actionIndex, db)
t.Cleanup(func() {
mcpSrv.Shutdown(context.Background())
})
// Wire chi router — same middleware as production
// Wire chi router -- same middleware as production
r := chi.NewRouter()
r.Group(func(r chi.Router) {
r.Use(agents.OptionalAuthMiddlewareWithAPIKeys(agentService, apiKeyService))
@@ -371,8 +380,23 @@ func (c *mcpClient) parseToolResult(toolName string, raw json.RawMessage) map[st
return data
}
// unwrapCallResult extracts the inner bridge result from an execute tool response.
// Execute returns { result: { ok, result: <data> }, calls, duration } — this returns <data>.
func unwrapCallResult(t *testing.T, resp map[string]any) map[string]any {
t.Helper()
callEnvelope, ok := resp["result"].(map[string]any)
if !ok {
t.Fatalf("expected result to be map, got %T", resp["result"])
}
inner, ok := callEnvelope["result"].(map[string]any)
if !ok {
t.Fatalf("expected call result to be map, got %T (ok=%v)", callEnvelope["result"], callEnvelope["ok"])
}
return inner
}
// ---------------------------------------------------------------------------
// Tests
// Tests -- updated for 4 hybrid tools
// ---------------------------------------------------------------------------
func TestE2E_DirectMessage(t *testing.T) {
@@ -380,7 +404,7 @@ func TestE2E_DirectMessage(t *testing.T) {
alice := env.registerAgent("alice", "Alice")
bob := env.registerAgent("bob", "Bob")
// Alice connects via MCP and sends a DM to Bob.
// Alice connects via MCP and sends a DM to Bob using the send_message tool.
aliceClient := newMCPClient(t, env.server.URL, alice.APIKey)
aliceClient.Initialize()
@@ -394,17 +418,20 @@ func TestE2E_DirectMessage(t *testing.T) {
t.Fatal("expected non-zero message_id")
}
// Bob connects and reads his inbox.
// Bob connects and reads his inbox via execute tool.
bobClient := newMCPClient(t, env.server.URL, bob.APIKey)
bobClient.Initialize()
inbox := bobClient.CallTool("read_inbox", map[string]any{})
count := inbox["count"].(float64)
inbox := bobClient.CallTool("execute", map[string]any{
"code": `call("read_inbox", {})`,
})
resultData := unwrapCallResult(t, inbox)
count := resultData["count"].(float64)
if count != 1 {
t.Fatalf("Bob's inbox count = %v, want 1", count)
}
messages := inbox["messages"].([]any)
messages := resultData["messages"].([]any)
firstMsg := messages[0].(map[string]any)
if firstMsg["from_agent"] != "alice" {
t.Errorf("from_agent = %v, want alice", firstMsg["from_agent"])
@@ -425,79 +452,56 @@ func TestE2E_ChannelMessaging(t *testing.T) {
bobClient := newMCPClient(t, env.server.URL, bob.APIKey)
bobClient.Initialize()
// Alice creates a channel.
createResult := aliceClient.CallTool("create_channel", map[string]any{
"name": "project-x",
"description": "Channel for Project X",
// Alice creates a channel via execute.
createResult := aliceClient.CallTool("execute", map[string]any{
"code": `call("create_channel", { name: "project-x", description: "Channel for Project X" })`,
})
channelID := createResult["channel_id"].(float64)
createData := unwrapCallResult(t, createResult)
channelID := createData["channel_id"].(float64)
if channelID == 0 {
t.Fatal("expected non-zero channel_id")
}
if createResult["name"] != "project-x" {
t.Errorf("channel name = %v, want project-x", createResult["name"])
}
// Bob joins the channel.
joinResult := bobClient.CallTool("join_channel", map[string]any{
"channel_name": "project-x",
// Bob joins the channel via execute.
joinResult := bobClient.CallTool("execute", map[string]any{
"code": `call("join_channel", { channel_name: "project-x" })`,
})
if joinResult["status"] != "joined" {
t.Errorf("join status = %v, want joined", joinResult["status"])
joinData := unwrapCallResult(t, joinResult)
if joinData["status"] != "joined" {
t.Errorf("join status = %v, want joined", joinData["status"])
}
// Alice sends a message to the channel.
sendResult := aliceClient.CallTool("send_channel_message", map[string]any{
"channel_name": "project-x",
"body": "Welcome to Project X!",
// Alice sends a message to the channel via send_message (channel path).
sendResult := aliceClient.CallTool("send_message", map[string]any{
"channel": "project-x",
"body": "Welcome to Project X!",
})
if sendResult["status"] != "sent" {
t.Errorf("send status = %v, want sent", sendResult["status"])
}
if sendResult["message_id"].(float64) == 0 {
t.Error("expected non-zero message_id")
}
// Bob reads his inbox and should see the channel message.
inbox := bobClient.CallTool("read_inbox", map[string]any{})
count := inbox["count"].(float64)
inbox := bobClient.CallTool("execute", map[string]any{
"code": `call("read_inbox", { include_read: true })`,
})
inboxData := unwrapCallResult(t, inbox)
count := inboxData["count"].(float64)
if count < 1 {
t.Fatalf("Bob's inbox count = %v, want >= 1", count)
}
messages := inbox["messages"].([]any)
messages := inboxData["messages"].([]any)
found := false
for _, m := range messages {
msg := m.(map[string]any)
if msg["body"] == "Welcome to Project X!" {
found = true
if msg["from_agent"] != "alice" {
t.Errorf("from_agent = %v, want alice", msg["from_agent"])
}
break
}
}
if !found {
t.Error("Bob did not receive the channel message")
}
// Alice lists channels.
listResult := aliceClient.CallTool("list_channels", map[string]any{})
chList := listResult["channels"].([]any)
foundChannel := false
for _, ch := range chList {
chMap := ch.(map[string]any)
if chMap["name"] == "project-x" {
foundChannel = true
if chMap["member_count"].(float64) != 2 {
t.Errorf("member_count = %v, want 2", chMap["member_count"])
}
break
}
}
if !foundChannel {
t.Error("project-x channel not found in list")
}
}
func TestE2E_SearchMessages(t *testing.T) {
@@ -525,210 +529,22 @@ func TestE2E_SearchMessages(t *testing.T) {
"body": "Please review the pull request",
})
// Bob searches for "deployment" — should find exactly one.
searchResult := bobClient.CallTool("search_messages", map[string]any{
"query": "deployment",
// Bob searches for "deployment" via execute.
searchResult := bobClient.CallTool("execute", map[string]any{
"code": `call("search_messages", { query: "deployment" })`,
})
count := searchResult["count"].(float64)
searchData := unwrapCallResult(t, searchResult)
count := searchData["count"].(float64)
if count != 1 {
t.Errorf("search count for 'deployment' = %v, want 1", count)
}
// Bob searches for "database" — should find exactly one.
searchResult2 := bobClient.CallTool("search_messages", map[string]any{
"query": "database",
})
count2 := searchResult2["count"].(float64)
if count2 != 1 {
t.Errorf("search count for 'database' = %v, want 1", count2)
}
// Verify search mode is fulltext (no embedding provider configured).
if mode := searchResult["search_mode"]; mode != "fulltext" {
if mode := searchData["search_mode"]; mode != "fulltext" {
t.Errorf("search_mode = %v, want fulltext", mode)
}
}
func TestE2E_ThreadReply(t *testing.T) {
env := setupEnv(t)
alice := env.registerAgent("alice", "Alice")
bob := env.registerAgent("bob", "Bob")
aliceClient := newMCPClient(t, env.server.URL, alice.APIKey)
aliceClient.Initialize()
bobClient := newMCPClient(t, env.server.URL, bob.APIKey)
bobClient.Initialize()
// Alice sends a message to Bob.
sendResult := aliceClient.CallTool("send_message", map[string]any{
"to": "bob",
"body": "Can you check the logs?",
"subject": "Log investigation",
})
originalMsgID := sendResult["message_id"].(float64)
// Bob replies to Alice's message using reply_to.
replyResult := bobClient.CallTool("send_message", map[string]any{
"to": "alice",
"body": "Sure, I found an error in the logs.",
"reply_to": originalMsgID,
})
replyMsgID := replyResult["message_id"].(float64)
if replyMsgID == 0 {
t.Fatal("expected non-zero reply message_id")
}
// Alice reads her inbox and should see Bob's reply.
inbox := aliceClient.CallTool("read_inbox", map[string]any{})
messages := inbox["messages"].([]any)
foundReply := false
for _, m := range messages {
msg := m.(map[string]any)
if msg["body"] == "Sure, I found an error in the logs." {
foundReply = true
if msg["from_agent"] != "bob" {
t.Errorf("from_agent = %v, want bob", msg["from_agent"])
}
// Verify reply_to is set
if rt, ok := msg["reply_to"]; ok && rt != nil {
if rt.(float64) != originalMsgID {
t.Errorf("reply_to = %v, want %v", rt, originalMsgID)
}
} else {
t.Error("expected reply_to to be set on the reply message")
}
break
}
}
if !foundReply {
t.Error("Alice did not receive Bob's reply")
}
}
func TestE2E_AgentDiscovery(t *testing.T) {
env := setupEnv(t)
_ = env.registerAgent("search-bot", "Search Bot")
_ = env.registerAgent("code-bot", "Code Bot")
charlie := env.registerAgent("charlie", "Charlie")
// Register agents with specific capabilities via the service directly.
ctx := context.Background()
env.agentService.UpdateAgent(ctx, "search-bot", "", json.RawMessage(`{"skills":["web-search","summarize"]}`))
env.agentService.UpdateAgent(ctx, "code-bot", "", json.RawMessage(`{"skills":["code-review","testing"]}`))
charlieClient := newMCPClient(t, env.server.URL, charlie.APIKey)
charlieClient.Initialize()
// Discover all agents (no query filter).
allAgents := charlieClient.CallTool("discover_agents", map[string]any{})
allCount := allAgents["count"].(float64)
if allCount < 3 {
t.Errorf("discover_agents count = %v, want >= 3", allCount)
}
// Verify agent details are present.
agentsList := allAgents["agents"].([]any)
names := make(map[string]bool)
for _, a := range agentsList {
agent := a.(map[string]any)
names[agent["name"].(string)] = true
}
for _, expected := range []string{"search-bot", "code-bot", "charlie"} {
if !names[expected] {
t.Errorf("expected agent %q in discover_agents result", expected)
}
}
// Discover agents by capability keyword.
searchBots := charlieClient.CallTool("discover_agents", map[string]any{
"query": "web-search",
})
searchCount := searchBots["count"].(float64)
if searchCount != 1 {
t.Errorf("discover_agents(web-search) count = %v, want 1", searchCount)
}
searchAgents := searchBots["agents"].([]any)
if searchAgents[0].(map[string]any)["name"] != "search-bot" {
t.Errorf("expected search-bot, got %v", searchAgents[0].(map[string]any)["name"])
}
}
func TestE2E_ReadInbox(t *testing.T) {
env := setupEnv(t)
alice := env.registerAgent("alice", "Alice")
bob := env.registerAgent("bob", "Bob")
carol := env.registerAgent("carol", "Carol")
aliceClient := newMCPClient(t, env.server.URL, alice.APIKey)
aliceClient.Initialize()
bobClient := newMCPClient(t, env.server.URL, bob.APIKey)
bobClient.Initialize()
carolClient := newMCPClient(t, env.server.URL, carol.APIKey)
carolClient.Initialize()
// Alice and Carol both send messages to Bob.
aliceClient.CallTool("send_message", map[string]any{
"to": "bob",
"body": "Priority task from Alice",
"priority": 8,
})
aliceClient.CallTool("send_message", map[string]any{
"to": "bob",
"body": "Low priority note from Alice",
"priority": 2,
})
carolClient.CallTool("send_message", map[string]any{
"to": "bob",
"body": "Message from Carol",
})
// Bob reads all inbox messages.
t.Run("ReadAll", func(t *testing.T) {
inbox := bobClient.CallTool("read_inbox", map[string]any{
"include_read": true,
})
count := inbox["count"].(float64)
if count != 3 {
t.Errorf("inbox count = %v, want 3", count)
}
})
// Bob reads with from_agent filter.
t.Run("FilterByAgent", func(t *testing.T) {
inbox := bobClient.CallTool("read_inbox", map[string]any{
"from_agent": "carol",
"include_read": true,
})
count := inbox["count"].(float64)
if count != 1 {
t.Errorf("inbox count (from carol) = %v, want 1", count)
}
messages := inbox["messages"].([]any)
if len(messages) > 0 {
msg := messages[0].(map[string]any)
if msg["from_agent"] != "carol" {
t.Errorf("from_agent = %v, want carol", msg["from_agent"])
}
}
})
// Bob reads with min_priority filter.
t.Run("FilterByPriority", func(t *testing.T) {
inbox := bobClient.CallTool("read_inbox", map[string]any{
"min_priority": 5,
"include_read": true,
})
count := inbox["count"].(float64)
if count != 2 {
// carol's message has priority 5 (default), alice's has priority 8
t.Errorf("inbox count (min_priority=5) = %v, want 2", count)
}
})
}
func TestE2E_ClaimAndMarkDone(t *testing.T) {
env := setupEnv(t)
alice := env.registerAgent("alice", "Alice")
@@ -747,22 +563,23 @@ func TestE2E_ClaimAndMarkDone(t *testing.T) {
})
msgID := sendResult["message_id"].(float64)
// Bob claims the message.
claimResult := bobClient.CallTool("claim_messages", map[string]any{
"limit": 1,
// Bob claims the message via execute.
claimResult := bobClient.CallTool("execute", map[string]any{
"code": `call("claim_messages", { limit: 1 })`,
})
claimCount := claimResult["count"].(float64)
claimData := unwrapCallResult(t, claimResult)
claimCount := claimData["count"].(float64)
if claimCount != 1 {
t.Fatalf("claimed count = %v, want 1", claimCount)
}
// Bob marks the message as done.
doneResult := bobClient.CallTool("mark_done", map[string]any{
"message_id": msgID,
"status": "done",
// Bob marks the message as done via execute.
doneResult := bobClient.CallTool("execute", map[string]any{
"code": fmt.Sprintf(`call("mark_done", { message_id: %d, status: "done" })`, int(msgID)),
})
if doneResult["status"] != "done" {
t.Errorf("mark_done status = %v, want done", doneResult["status"])
doneData := unwrapCallResult(t, doneResult)
if doneData["status"] != "done" {
t.Errorf("mark_done status = %v, want done", doneData["status"])
}
}
@@ -774,27 +591,20 @@ func TestE2E_ListTools(t *testing.T) {
aliceClient.Initialize()
tools := aliceClient.ListTools()
if len(tools) == 0 {
t.Fatal("expected at least one tool from tools/list")
if len(tools) != 4 {
t.Fatalf("expected exactly 4 tools, got %d: %v", len(tools), tools)
}
// Verify core tools are present.
// Verify the 4 hybrid tools are present.
toolSet := make(map[string]bool)
for _, name := range tools {
toolSet[name] = true
}
expectedTools := []string{
"my_status",
"send_message",
"read_inbox",
"claim_messages",
"mark_done",
"search_messages",
"discover_agents",
"get_channel_messages",
"create_channel",
"join_channel",
"list_channels",
"send_channel_message",
"search",
"execute",
}
for _, name := range expectedTools {
if !toolSet[name] {
@@ -819,95 +629,100 @@ func TestE2E_UnauthenticatedAccess(t *testing.T) {
t.Error("expected error message for unauthenticated send_message")
}
// discover_agents should also require auth.
errMsg2 := anonClient.CallToolExpectError("discover_agents", map[string]any{})
// execute should also require auth.
errMsg2 := anonClient.CallToolExpectError("execute", map[string]any{
"code": `call("discover_agents", {})`,
})
if errMsg2 == "" {
t.Error("expected error message for unauthenticated discover_agents")
t.Error("expected error message for unauthenticated execute")
}
}
func TestE2E_ChannelPrivateInvite(t *testing.T) {
func TestE2E_AgentDiscovery(t *testing.T) {
env := setupEnv(t)
_ = env.registerAgent("search-bot", "Search Bot")
_ = env.registerAgent("code-bot", "Code Bot")
charlie := env.registerAgent("charlie", "Charlie")
// Register agents with specific capabilities via the service directly.
ctx := context.Background()
env.agentService.UpdateAgent(ctx, "search-bot", "", json.RawMessage(`{"skills":["web-search","summarize"]}`))
env.agentService.UpdateAgent(ctx, "code-bot", "", json.RawMessage(`{"skills":["code-review","testing"]}`))
charlieClient := newMCPClient(t, env.server.URL, charlie.APIKey)
charlieClient.Initialize()
// Discover all agents via execute.
allAgents := charlieClient.CallTool("execute", map[string]any{
"code": `call("discover_agents", {})`,
})
agentsData := unwrapCallResult(t, allAgents)
allCount := agentsData["count"].(float64)
if allCount < 3 {
t.Errorf("discover_agents count = %v, want >= 3", allCount)
}
// Discover agents by capability keyword.
searchBots := charlieClient.CallTool("execute", map[string]any{
"code": `call("discover_agents", { query: "web-search" })`,
})
searchData := unwrapCallResult(t, searchBots)
searchCount := searchData["count"].(float64)
if searchCount != 1 {
t.Errorf("discover_agents(web-search) count = %v, want 1", searchCount)
}
}
func TestE2E_SearchActions(t *testing.T) {
env := setupEnv(t)
alice := env.registerAgent("alice", "Alice")
bob := env.registerAgent("bob", "Bob")
aliceClient := newMCPClient(t, env.server.URL, alice.APIKey)
aliceClient.Initialize()
bobClient := newMCPClient(t, env.server.URL, bob.APIKey)
bobClient.Initialize()
// Alice creates a private channel.
createResult := aliceClient.CallTool("create_channel", map[string]any{
"name": "secret-ops",
"is_private": true,
// Search for channel-related actions.
searchResult := aliceClient.CallTool("search", map[string]any{
"query": "create channel",
})
if createResult["is_private"] != true {
t.Errorf("is_private = %v, want true", createResult["is_private"])
count := searchResult["count"].(float64)
if count == 0 {
t.Error("expected at least one action result for 'create channel'")
}
// Bob tries to join without an invite — should fail.
errMsg := bobClient.CallToolExpectError("join_channel", map[string]any{
"channel_name": "secret-ops",
})
if errMsg == "" {
t.Error("expected error when joining private channel without invite")
actionsList := searchResult["actions"].([]any)
firstAction := actionsList[0].(map[string]any)
if firstAction["name"] == nil {
t.Error("expected name in action result")
}
// Alice invites Bob.
inviteResult := aliceClient.CallTool("invite_to_channel", map[string]any{
"channel_name": "secret-ops",
"agent_name": "bob",
})
if inviteResult["status"] != "invited" {
t.Errorf("invite status = %v, want invited", inviteResult["status"])
}
// Now Bob can join.
joinResult := bobClient.CallTool("join_channel", map[string]any{
"channel_name": "secret-ops",
})
if joinResult["status"] != "joined" {
t.Errorf("join status = %v, want joined", joinResult["status"])
if firstAction["examples"] == nil {
t.Error("expected examples in action result")
}
}
func TestE2E_MultipleMessagesAndReadState(t *testing.T) {
func TestE2E_MyStatus(t *testing.T) {
env := setupEnv(t)
alice := env.registerAgent("alice", "Alice")
bob := env.registerAgent("bob", "Bob")
aliceClient := newMCPClient(t, env.server.URL, alice.APIKey)
aliceClient.Initialize()
bobClient := newMCPClient(t, env.server.URL, bob.APIKey)
bobClient.Initialize()
status := aliceClient.CallTool("my_status", map[string]any{})
// Alice sends 3 messages to Bob.
for i := 1; i <= 3; i++ {
aliceClient.CallTool("send_message", map[string]any{
"to": "bob",
"body": fmt.Sprintf("message %d", i),
})
// Verify agent info
agentInfo := status["agent"].(map[string]any)
if agentInfo["name"] != "alice" {
t.Errorf("agent name = %v, want alice", agentInfo["name"])
}
// Bob reads inbox — gets 3 messages.
inbox1 := bobClient.CallTool("read_inbox", map[string]any{})
if inbox1["count"].(float64) != 3 {
t.Fatalf("first read count = %v, want 3", inbox1["count"])
// Verify usage instructions
usage := status["usage"].(string)
if usage == "" {
t.Error("expected usage instructions in my_status response")
}
// Bob reads inbox again without include_read — should be 0 (already read).
inbox2 := bobClient.CallTool("read_inbox", map[string]any{})
if inbox2["count"].(float64) != 0 {
t.Errorf("second read count = %v, want 0 (messages already read)", inbox2["count"])
}
// With include_read, all 3 should come back.
inbox3 := bobClient.CallTool("read_inbox", map[string]any{
"include_read": true,
})
if inbox3["count"].(float64) != 3 {
t.Errorf("read with include_read count = %v, want 3", inbox3["count"])
// Verify stats
stats := status["stats"].(map[string]any)
if stats == nil {
t.Error("expected stats in my_status response")
}
}
+8
View File
@@ -188,4 +188,12 @@ export const apiKeys = {
get: (id: number) => request<any>('GET', `/api/keys/${id}`)
};
// Notifications
export const notificationsApi = {
unread: () =>
request<{ channels: Record<string, number>; dms: Record<string, number> }>('GET', '/api/notifications/unread'),
markRead: (type: 'channel' | 'dm', target: string, lastMessageId?: number) =>
request<{ status: string }>('POST', '/api/notifications/mark-read', { type, target, last_message_id: lastMessageId })
};
export { ApiError };
+1 -1
View File
@@ -26,7 +26,7 @@ export class SSEClient {
};
// Listen for typed events
const eventTypes = ['connected', 'new_message', 'message_updated', 'agent_connected', 'agent_disconnected', 'heartbeat'];
const eventTypes = ['connected', 'new_message', 'message_updated', 'agent_connected', 'agent_disconnected', 'heartbeat', 'unread_update'];
for (const type of eventTypes) {
this.eventSource.addEventListener(type, (e: MessageEvent) => {
try {
+17 -5
View File
@@ -2,6 +2,7 @@
import { page } from '$app/stores';
import { goto } from '$app/navigation';
import { user, logout } from '$lib/stores/auth';
import { notifications } from '$lib/stores/notifications';
import { channels as channelsApi, agents as agentsApi, deadLetters as deadLettersApi } from '$lib/api/client';
let channelList = $state<any[]>([]);
@@ -44,6 +45,10 @@
goto('/login');
}
function badgeText(count: number): string {
return count > 99 ? '99+' : String(count);
}
const adminLinks = [
{ href: '/agents', label: 'Agents' },
{ href: '/settings', label: 'Settings' }
@@ -152,6 +157,7 @@
<p class="px-3 py-1 text-xs text-text-secondary italic">No channels</p>
{:else}
{#each channelList as ch}
{@const chUnread = $notifications.channels.get(ch.name) ?? 0}
<a
href="/channels/{ch.name}"
class="sidebar-item {isActive('/channels/' + ch.name) ? 'sidebar-item-active' : ''}"
@@ -160,16 +166,19 @@
<svg class="w-4 h-4 flex-shrink-0 text-accent-purple" fill="none" stroke="currentColor" viewBox="0 0 24 24" stroke-width="1.5">
<path stroke-linecap="round" stroke-linejoin="round" d="M9.75 17L9 20l-1 1h8l-1-1-.75-3M3 13h18M5 17h14a2 2 0 002-2V5a2 2 0 00-2-2H5a2 2 0 00-2 2v10a2 2 0 002 2z" />
</svg>
<span class="truncate">My Agents</span>
<span class="truncate {chUnread > 0 ? 'font-bold text-text-primary' : ''}">My Agents</span>
{:else}
<span class="text-text-secondary font-mono text-xs">#</span>
<span class="truncate">{ch.name}</span>
<span class="truncate {chUnread > 0 ? 'font-bold text-text-primary' : ''}">{ch.name}</span>
{/if}
{#if ch.is_private && !ch.name.startsWith('my-agents-')}
<svg class="w-3 h-3 text-text-secondary ml-auto flex-shrink-0" fill="currentColor" viewBox="0 0 20 20">
<svg class="w-3 h-3 text-text-secondary {chUnread > 0 ? '' : 'ml-auto'} flex-shrink-0" fill="currentColor" viewBox="0 0 20 20">
<path fill-rule="evenodd" d="M5 9V7a5 5 0 0110 0v2a2 2 0 012 2v5a2 2 0 01-2 2H5a2 2 0 01-2-2v-5a2 2 0 012-2zm8-2v2H7V7a3 3 0 016 0z" clip-rule="evenodd" />
</svg>
{/if}
{#if chUnread > 0}
<span class="ml-auto text-[10px] font-bold text-white bg-accent-red px-1.5 py-0.5 rounded-full min-w-[18px] text-center flex-shrink-0">{badgeText(chUnread)}</span>
{/if}
</a>
{/each}
{/if}
@@ -196,6 +205,7 @@
<p class="px-3 py-1 text-xs text-text-secondary italic">No agents</p>
{:else}
{#each agentList as agent}
{@const dmUnread = $notifications.dms.get(agent.name) ?? 0}
<a
href="/dm/{agent.name}"
class="sidebar-item {isActive('/dm/' + agent.name) ? 'sidebar-item-active' : ''}"
@@ -208,9 +218,11 @@
class="absolute -bottom-0.5 -right-0.5 w-2 h-2 rounded-full border border-bg-secondary {agent.status === 'active' ? 'bg-accent-green' : 'bg-text-secondary'}"
></span>
</span>
<span class="truncate">{agent.display_name || agent.name}</span>
<span class="truncate {dmUnread > 0 ? 'font-bold text-text-primary' : ''}">{agent.display_name || agent.name}</span>
<span class="text-[9px] text-text-secondary flex-shrink-0">(you)</span>
{#if agent.type === 'ai'}
{#if dmUnread > 0}
<span class="ml-auto text-[10px] font-bold text-white bg-accent-red px-1.5 py-0.5 rounded-full min-w-[18px] text-center flex-shrink-0">{badgeText(dmUnread)}</span>
{:else if agent.type === 'ai'}
<span class="ml-auto text-[9px] font-mono text-accent-purple bg-accent-purple/10 px-1 rounded flex-shrink-0">AI</span>
{/if}
</a>
+103
View File
@@ -0,0 +1,103 @@
import { writable } from 'svelte/store';
export interface UnreadCounts {
channels: Map<string, number>;
dms: Map<string, number>;
totalUnread: number;
}
function createNotificationStore() {
const { subscribe, set, update } = writable<UnreadCounts>({
channels: new Map(),
dms: new Map(),
totalUnread: 0
});
function recalcTotal(counts: UnreadCounts): number {
let total = 0;
for (const v of counts.channels.values()) total += v;
for (const v of counts.dms.values()) total += v;
return total;
}
return {
subscribe,
/** Initialize from the backend GET /api/notifications/unread */
async initialize() {
try {
const res = await fetch('/api/notifications/unread', { credentials: 'same-origin' });
if (!res.ok) return;
const data = await res.json();
const channels = new Map<string, number>();
const dms = new Map<string, number>();
if (Array.isArray(data.channels)) {
for (const ch of data.channels) {
if (ch.unread_count > 0) channels.set(ch.name, ch.unread_count);
}
}
if (Array.isArray(data.dms)) {
for (const dm of data.dms) {
if (dm.unread_count > 0) dms.set(dm.agent, dm.unread_count);
}
}
const counts: UnreadCounts = { channels, dms, totalUnread: 0 };
counts.totalUnread = recalcTotal(counts);
set(counts);
} catch {
// API may not be available yet — silently ignore
}
},
/** Increment unread count for a channel or DM */
incrementUnread(type: 'channel' | 'dm', target: string) {
update((counts) => {
const map = type === 'channel' ? counts.channels : counts.dms;
map.set(target, (map.get(target) ?? 0) + 1);
counts.totalUnread = recalcTotal(counts);
return counts;
});
},
/** Set exact unread count for a channel or DM */
setUnread(type: 'channel' | 'dm', target: string, count: number) {
update((counts) => {
const map = type === 'channel' ? counts.channels : counts.dms;
if (count > 0) {
map.set(target, count);
} else {
map.delete(target);
}
counts.totalUnread = recalcTotal(counts);
return counts;
});
},
/** Mark a channel or DM as read — POST to backend and clear local count */
async markAsRead(type: 'channel' | 'dm', target: string, lastMessageId?: number) {
try {
await fetch('/api/notifications/mark-read', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
credentials: 'same-origin',
body: JSON.stringify({ type, target, last_message_id: lastMessageId })
});
} catch {
// Best effort — clear locally regardless
}
update((counts) => {
const map = type === 'channel' ? counts.channels : counts.dms;
map.delete(target);
counts.totalUnread = recalcTotal(counts);
return counts;
});
},
/** Reset all counts (e.g. on logout) */
reset() {
set({ channels: new Map(), dms: new Map(), totalUnread: 0 });
}
};
}
export const notifications = createNotificationStore();
+23
View File
@@ -4,16 +4,36 @@
import { goto } from '$app/navigation';
import { checkAuth, user, loading } from '$lib/stores/auth';
import { SSEClient } from '$lib/api/sse';
import { notifications } from '$lib/stores/notifications';
import Sidebar from '$lib/components/Sidebar.svelte';
import Header from '$lib/components/Header.svelte';
import ThreadPanel from '$lib/components/ThreadPanel.svelte';
let { children } = $props();
let sseClient: SSEClient | null = $state(null);
let sseUnsubscribe: (() => void) | null = $state(null);
let initialized = $state(false);
let isLoginPage = $derived($page.url.pathname === '/login');
function setupNotifications(client: SSEClient) {
notifications.initialize();
return client.onEvent((event) => {
if (event.type === 'new_message') {
const d = event.data;
if (d.channel_name) {
notifications.incrementUnread('channel', d.channel_name);
} else if (d.from_agent) {
notifications.incrementUnread('dm', d.from_agent);
}
} else if (event.type === 'unread_update') {
const d = event.data;
const type = d.type === 'channel' ? 'channel' : 'dm';
notifications.setUnread(type as 'channel' | 'dm', d.target, d.count ?? 0);
}
});
}
$effect(() => {
if (!initialized) {
initialized = true;
@@ -23,6 +43,7 @@
} else if (authenticated) {
sseClient = new SSEClient();
sseClient.connect();
sseUnsubscribe = setupNotifications(sseClient);
}
});
}
@@ -36,7 +57,9 @@
$effect(() => {
return () => {
sseUnsubscribe?.();
sseClient?.disconnect();
notifications.reset();
};
});
</script>
+42 -2
View File
@@ -2,6 +2,7 @@
import { page } from '$app/stores';
import { channels as channelsApi, messages as messagesApi, agents as agentsApi } from '$lib/api/client';
import { openThread, closeThread } from '$lib/stores/thread';
import { notifications } from '$lib/stores/notifications';
let channel = $state<any>(null);
let members = $state<any[]>([]);
@@ -12,12 +13,16 @@
let joining = $state(false);
let showInfo = $state(false);
let leaveError = $state('');
let lastReadMessageId = $state<number | null>(null);
// Compose state
let body = $state('');
let sending = $state(false);
let sendError = $state('');
// Mark-as-read timer
let markReadTimer: ReturnType<typeof setTimeout> | null = null;
let channelName = $derived($page.params.name);
let messagesContainer: HTMLDivElement;
@@ -43,14 +48,40 @@
async function loadMessages() {
if (!channel) return;
try {
const res = await channelsApi.messages(channelName);
const res = await channelsApi.messages(channelName) as any;
messageList = res.messages;
lastReadMessageId = res.last_read_message_id ?? null;
scrollToBottom();
startMarkReadTimer();
} catch {
// handled
}
}
function startMarkReadTimer() {
clearMarkReadTimer();
if (lastReadMessageId !== null && messageList.length > 0) {
const lastMsgId = messageList[messageList.length - 1]?.id;
if (lastMsgId > lastReadMessageId) {
markReadTimer = setTimeout(() => {
notifications.markAsRead('channel', channelName, lastMsgId);
}, 2000);
}
}
}
function clearMarkReadTimer() {
if (markReadTimer !== null) {
clearTimeout(markReadTimer);
markReadTimer = null;
}
}
// Cleanup timer on component destroy
$effect(() => {
return () => clearMarkReadTimer();
});
function scrollToBottom() {
requestAnimationFrame(() => {
if (messagesContainer) {
@@ -62,7 +93,9 @@
let _prevChannel = $state('');
$effect(() => {
if (channelName !== _prevChannel) {
clearMarkReadTimer();
_prevChannel = channelName;
lastReadMessageId = null;
closeThread();
loadChannel();
}
@@ -212,7 +245,14 @@
</div>
{:else}
<div class="py-2">
{#each messageList as msg (msg.id)}
{#each messageList as msg, i (msg.id)}
{#if lastReadMessageId !== null && msg.id > lastReadMessageId && (i === 0 || messageList[i - 1].id <= lastReadMessageId)}
<div class="flex items-center gap-3 px-5 py-1 my-1">
<div class="flex-1 h-px bg-accent-red/50"></div>
<span class="text-[11px] font-medium text-accent-red flex-shrink-0">New messages</span>
<div class="flex-1 h-px bg-accent-red/50"></div>
</div>
{/if}
<div class="group px-5 py-2 hover:bg-bg-tertiary/40 transition-colors relative">
<div class="flex gap-3">
<div class="w-9 h-9 rounded-lg {agentColor(msg.from_agent)} flex items-center justify-center text-sm font-bold text-white flex-shrink-0 mt-0.5">
+41 -2
View File
@@ -2,18 +2,23 @@
import { page } from '$app/stores';
import { agents as agentsApi, messages as messagesApi } from '$lib/api/client';
import { openThread, closeThread } from '$lib/stores/thread';
import { notifications } from '$lib/stores/notifications';
let peerAgent = $derived($page.params.name);
let peer = $state<any>(null);
let messageList = $state<any[]>([]);
let ownAgents = $state<any[]>([]);
let loadingData = $state(true);
let lastReadMessageId = $state<number | null>(null);
// Compose state
let body = $state('');
let sending = $state(false);
let sendError = $state('');
// Mark-as-read timer
let markReadTimer: ReturnType<typeof setTimeout> | null = null;
let messagesContainer: HTMLDivElement;
async function loadData() {
@@ -35,14 +40,39 @@
async function loadMessages() {
try {
const res = await agentsApi.messages(peerAgent);
const res = await agentsApi.messages(peerAgent) as any;
messageList = res.messages;
lastReadMessageId = res.last_read_message_id ?? null;
scrollToBottom();
startMarkReadTimer();
} catch {
// handled
}
}
function startMarkReadTimer() {
clearMarkReadTimer();
if (lastReadMessageId !== null && messageList.length > 0) {
const lastMsgId = messageList[messageList.length - 1]?.id;
if (lastMsgId > lastReadMessageId) {
markReadTimer = setTimeout(() => {
notifications.markAsRead('dm', peerAgent, lastMsgId);
}, 2000);
}
}
}
function clearMarkReadTimer() {
if (markReadTimer !== null) {
clearTimeout(markReadTimer);
markReadTimer = null;
}
}
$effect(() => {
return () => clearMarkReadTimer();
});
function scrollToBottom() {
requestAnimationFrame(() => {
if (messagesContainer) {
@@ -54,7 +84,9 @@
let _prevPeer = $state('');
$effect(() => {
if (peerAgent !== _prevPeer) {
clearMarkReadTimer();
_prevPeer = peerAgent;
lastReadMessageId = null;
closeThread();
loadData();
}
@@ -180,7 +212,14 @@
</div>
{:else}
<div class="py-2">
{#each messageList as msg (msg.id)}
{#each messageList as msg, i (msg.id)}
{#if lastReadMessageId !== null && msg.id > lastReadMessageId && (i === 0 || messageList[i - 1].id <= lastReadMessageId)}
<div class="flex items-center gap-3 px-5 py-1 my-1">
<div class="flex-1 h-px bg-accent-red/50"></div>
<span class="text-[11px] font-medium text-accent-red flex-shrink-0">New messages</span>
<div class="flex-1 h-px bg-accent-red/50"></div>
</div>
{/if}
<div class="group px-5 py-2 hover:bg-bg-tertiary/40 transition-colors relative">
<div class="flex gap-3">
<div class="w-9 h-9 rounded-lg {agentColor(msg.from_agent)} flex items-center justify-center text-sm font-bold text-white flex-shrink-0 mt-0.5">