Implements the compile-in plugin system designed in spec 019:
- internal/plugin/ (~1,300 LOC):
* Tiny Plugin interface + 10 optional HasX capability sub-interfaces
* Host struct with Logger / DB / Messenger / Channels / Attachments /
Search / Secrets / Events / Config / DataDir / Tracer / Metrics /
DefaultOwner / BaseURL
* Registry with panic-on-duplicate, stability-level tracking, capability
indexing (MCP tools, actions, panels, channel types, routes, event
subscribers, CLI commands)
* Migrator: per-plugin SHA-256-checksum'd migration chain, namespaced
plugin_<name>_* table enforcement, idempotent re-apply
* Three-phase lifecycle (Migrate → Init → Start) with panic-safe
wrappers around every plugin call; failure per plugin isolated,
core continues
* YAML config loader that preserves unknown top-level keys on round-trip
* Status store exposing /api/plugins/status JSON
* Restart helpers (Noop + SignalRestarter); graceful reload is
in-process for the demo
- internal/plugin/plugintest/ (~345 LOC):
* NopHost(t) with in-memory modernc.org/sqlite
* Run(t, plugin) full-lifecycle smoke helper
* Assertions: HasTool, HasAction, HasPanel, HasChannelType,
HasMigration, PluginStarted, PluginFailed
* ScopedSecrets that returns ErrSecretNotFound for cross-plugin
reads (satisfies SC-006)
- internal/plugins/demo/ (canonical showcase):
* Plugin that exercises every HasX capability (migrations, actions,
HTTP routes, web panel, lifecycle, config schema, stability)
* Own SQL migration creating plugin_demo_notes
* Embedded HTML panel that fetches notes via JS
* 4 unit tests covering smoke, full capability registration, action
handlers, and config-driven max_notes limit
- cmd/plugindemo/ (~290 LOC):
* Demo HTTP server wiring registry to chi
* Mounts /api/plugins/status, /api/admin/plugins/{name}/{enable,disable},
/api/actions/{name}, /api/plugins/<name>/* (per-plugin REST),
/ui/plugins/<name>/ (per-plugin UI)
* SIGHUP-triggered config reload + registry rebuild + mux swap
* SIGTERM/SIGINT graceful shutdown
- test/integration/ (~357 LOC, build-tag "integration"):
* 6 end-to-end tests against a spawned plugindemo binary
* Enable/disable round-trip with data preservation
* SIGHUP reload timing (measured 41 ms — SC-008 target is 2 s)
* Action-404 on disabled plugin, panel-404 on disabled plugin
* REST endpoints + UI panel reachable
Contract deviation: admin toggle endpoints moved from
/api/plugins/{name}/{enable,disable} to /api/admin/plugins/{name}/{...}
to avoid URL collision with chi per-plugin route mounts. rest.md updated.
Scope deferred to next session (mechanical follow-ups):
- Port internal/wiki/ to internal/plugins/wiki/
- Squash 26 migrations to schema/000_initial.sql
- Backup scripts for live kubic instance
- Remaining 9 plugin extractions
- Boundary-lint static analyzer
- Wire into cmd/synapbus/main.go
All unit + integration tests green. Chrome UI smoke test passes.
autonomous_summary.md carries the full verification record.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
105 lines
2.8 KiB
Go
105 lines
2.8 KiB
Go
package plugintest
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"testing"
|
|
|
|
"github.com/synapbus/synapbus/internal/plugin"
|
|
)
|
|
|
|
// HasTool asserts the registry exposes a tool with the given name.
|
|
func HasTool(t *testing.T, reg *plugin.Registry, name string) {
|
|
t.Helper()
|
|
if _, ok := reg.MCPTool(name); !ok {
|
|
t.Fatalf("expected MCP tool %q to be registered; got %v", name, reg.MCPTools())
|
|
}
|
|
}
|
|
|
|
// HasAction asserts the registry exposes an action with the given name.
|
|
func HasAction(t *testing.T, reg *plugin.Registry, name string) {
|
|
t.Helper()
|
|
if _, ok := reg.Action(name); !ok {
|
|
t.Fatalf("expected action %q to be registered; got %v", name, reg.Actions())
|
|
}
|
|
}
|
|
|
|
// HasPanel asserts the registry exposes a panel with the given ID.
|
|
func HasPanel(t *testing.T, reg *plugin.Registry, id string) {
|
|
t.Helper()
|
|
for _, p := range reg.Panels() {
|
|
if p.ID == id {
|
|
return
|
|
}
|
|
}
|
|
t.Fatalf("expected panel with id %q", id)
|
|
}
|
|
|
|
// HasChannelType asserts the registry exposes a channel type with the given name.
|
|
func HasChannelType(t *testing.T, reg *plugin.Registry, name string) {
|
|
t.Helper()
|
|
if _, ok := reg.ChannelType(name); !ok {
|
|
t.Fatalf("expected channel type %q to be registered", name)
|
|
}
|
|
}
|
|
|
|
// HasMigration asserts the named plugin has applied a migration at the given version.
|
|
func HasMigration(t *testing.T, db *sql.DB, plugin string, version int) {
|
|
t.Helper()
|
|
versions, err := applied(db, plugin)
|
|
if err != nil {
|
|
t.Fatalf("HasMigration: %v", err)
|
|
}
|
|
for _, v := range versions {
|
|
if v == version {
|
|
return
|
|
}
|
|
}
|
|
t.Fatalf("plugin %q: migration %d not applied (have %v)", plugin, version, versions)
|
|
}
|
|
|
|
// PluginStarted asserts the named plugin has status == started.
|
|
func PluginStarted(t *testing.T, reg *plugin.Registry, name string) {
|
|
t.Helper()
|
|
s, ok := reg.Status().Get(name)
|
|
if !ok {
|
|
t.Fatalf("plugin %q not in status store", name)
|
|
}
|
|
if s.Status != plugin.StatusStarted {
|
|
t.Fatalf("plugin %q: expected status started, got %q (error=%q)", name, s.Status, s.ErrorMessage)
|
|
}
|
|
}
|
|
|
|
// PluginFailed asserts the named plugin has status == failed and an error message.
|
|
func PluginFailed(t *testing.T, reg *plugin.Registry, name string) {
|
|
t.Helper()
|
|
s, ok := reg.Status().Get(name)
|
|
if !ok {
|
|
t.Fatalf("plugin %q not in status store", name)
|
|
}
|
|
if s.Status != plugin.StatusFailed {
|
|
t.Fatalf("plugin %q: expected status failed, got %q", name, s.Status)
|
|
}
|
|
if s.ErrorMessage == "" {
|
|
t.Fatalf("plugin %q: failed status should carry an error message", name)
|
|
}
|
|
}
|
|
|
|
func applied(db *sql.DB, plugin string) ([]int, error) {
|
|
rows, err := db.QueryContext(context.Background(),
|
|
`SELECT version FROM plugin_migrations WHERE plugin = ? ORDER BY version`, plugin)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer rows.Close()
|
|
var out []int
|
|
for rows.Next() {
|
|
var v int
|
|
if err := rows.Scan(&v); err != nil {
|
|
return nil, err
|
|
}
|
|
out = append(out, v)
|
|
}
|
|
return out, nil
|
|
}
|