Algis DumbrisandClaude Opus 4.7
494e8f83e9
Implements the compile-in plugin system designed in spec 019:
- internal/plugin/ (~1,300 LOC):
* Tiny Plugin interface + 10 optional HasX capability sub-interfaces
* Host struct with Logger / DB / Messenger / Channels / Attachments /
Search / Secrets / Events / Config / DataDir / Tracer / Metrics /
DefaultOwner / BaseURL
* Registry with panic-on-duplicate, stability-level tracking, capability
indexing (MCP tools, actions, panels, channel types, routes, event
subscribers, CLI commands)
* Migrator: per-plugin SHA-256-checksum'd migration chain, namespaced
plugin_<name>_* table enforcement, idempotent re-apply
* Three-phase lifecycle (Migrate → Init → Start) with panic-safe
wrappers around every plugin call; failure per plugin isolated,
core continues
* YAML config loader that preserves unknown top-level keys on round-trip
* Status store exposing /api/plugins/status JSON
* Restart helpers (Noop + SignalRestarter); graceful reload is
in-process for the demo
- internal/plugin/plugintest/ (~345 LOC):
* NopHost(t) with in-memory modernc.org/sqlite
* Run(t, plugin) full-lifecycle smoke helper
* Assertions: HasTool, HasAction, HasPanel, HasChannelType,
HasMigration, PluginStarted, PluginFailed
* ScopedSecrets that returns ErrSecretNotFound for cross-plugin
reads (satisfies SC-006)
- internal/plugins/demo/ (canonical showcase):
* Plugin that exercises every HasX capability (migrations, actions,
HTTP routes, web panel, lifecycle, config schema, stability)
* Own SQL migration creating plugin_demo_notes
* Embedded HTML panel that fetches notes via JS
* 4 unit tests covering smoke, full capability registration, action
handlers, and config-driven max_notes limit
- cmd/plugindemo/ (~290 LOC):
* Demo HTTP server wiring registry to chi
* Mounts /api/plugins/status, /api/admin/plugins/{name}/{enable,disable},
/api/actions/{name}, /api/plugins/<name>/* (per-plugin REST),
/ui/plugins/<name>/ (per-plugin UI)
* SIGHUP-triggered config reload + registry rebuild + mux swap
* SIGTERM/SIGINT graceful shutdown
- test/integration/ (~357 LOC, build-tag "integration"):
* 6 end-to-end tests against a spawned plugindemo binary
* Enable/disable round-trip with data preservation
* SIGHUP reload timing (measured 41 ms — SC-008 target is 2 s)
* Action-404 on disabled plugin, panel-404 on disabled plugin
* REST endpoints + UI panel reachable
Contract deviation: admin toggle endpoints moved from
/api/plugins/{name}/{enable,disable} to /api/admin/plugins/{name}/{...}
to avoid URL collision with chi per-plugin route mounts. rest.md updated.
Scope deferred to next session (mechanical follow-ups):
- Port internal/wiki/ to internal/plugins/wiki/
- Squash 26 migrations to schema/000_initial.sql
- Backup scripts for live kubic instance
- Remaining 9 plugin extractions
- Boundary-lint static analyzer
- Wire into cmd/synapbus/main.go
All unit + integration tests green. Chrome UI smoke test passes.
autonomous_summary.md carries the full verification record.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
81 lines
2.4 KiB
Go
81 lines
2.4 KiB
Go
package plugin_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/synapbus/synapbus/internal/plugin"
|
|
)
|
|
|
|
// minimalPlugin is the smallest plugin that satisfies the Plugin interface.
|
|
type minimalPlugin struct{ name, version string }
|
|
|
|
func (p *minimalPlugin) Name() string { return p.name }
|
|
func (p *minimalPlugin) Version() string { return p.version }
|
|
func (p *minimalPlugin) Init(ctx context.Context, host plugin.Host) error { return nil }
|
|
|
|
func TestNewRegistry_RejectsInvalidName(t *testing.T) {
|
|
_, err := plugin.NewRegistry([]plugin.Plugin{&minimalPlugin{name: "Bad-Name", version: "0.1"}}, nil)
|
|
if err == nil {
|
|
t.Fatal("expected error for invalid plugin name")
|
|
}
|
|
}
|
|
|
|
func TestNewRegistry_RejectsDuplicate(t *testing.T) {
|
|
_, err := plugin.NewRegistry([]plugin.Plugin{
|
|
&minimalPlugin{name: "alpha", version: "0.1"},
|
|
&minimalPlugin{name: "alpha", version: "0.2"},
|
|
}, nil)
|
|
if err == nil {
|
|
t.Fatal("expected error for duplicate plugin name")
|
|
}
|
|
}
|
|
|
|
func TestNewRegistry_EnabledByConfig(t *testing.T) {
|
|
cfg := &plugin.FileConfig{
|
|
Plugins: map[string]plugin.PluginConfig{
|
|
"alpha": {Enabled: true, Config: map[string]any{"x": 1}},
|
|
"beta": {Enabled: false},
|
|
},
|
|
}
|
|
reg, err := plugin.NewRegistry([]plugin.Plugin{
|
|
&minimalPlugin{name: "alpha", version: "0.1"},
|
|
&minimalPlugin{name: "beta", version: "0.1"},
|
|
&minimalPlugin{name: "gamma", version: "0.1"}, // not in config, so disabled
|
|
}, cfg)
|
|
if err != nil {
|
|
t.Fatalf("NewRegistry: %v", err)
|
|
}
|
|
if got := reg.Enabled(); len(got) != 1 || got[0] != "alpha" {
|
|
t.Fatalf("expected only [alpha] enabled, got %v", got)
|
|
}
|
|
if all := reg.All(); len(all) != 3 {
|
|
t.Fatalf("expected 3 registered, got %v", all)
|
|
}
|
|
}
|
|
|
|
func TestRegistry_RespectsRegistrationOrder(t *testing.T) {
|
|
cfg := &plugin.FileConfig{
|
|
Plugins: map[string]plugin.PluginConfig{
|
|
"zeta": {Enabled: true},
|
|
"alpha": {Enabled: true},
|
|
"mu": {Enabled: true},
|
|
},
|
|
}
|
|
reg, err := plugin.NewRegistry([]plugin.Plugin{
|
|
&minimalPlugin{name: "zeta", version: "0.1"},
|
|
&minimalPlugin{name: "alpha", version: "0.1"},
|
|
&minimalPlugin{name: "mu", version: "0.1"},
|
|
}, cfg)
|
|
if err != nil {
|
|
t.Fatalf("NewRegistry: %v", err)
|
|
}
|
|
got := reg.Enabled()
|
|
want := []string{"zeta", "alpha", "mu"}
|
|
for i := range want {
|
|
if got[i] != want[i] {
|
|
t.Fatalf("registration order broken: got %v, want %v", got, want)
|
|
}
|
|
}
|
|
}
|