Algis DumbrisandClaude Opus 4.7
494e8f83e9
Implements the compile-in plugin system designed in spec 019:
- internal/plugin/ (~1,300 LOC):
* Tiny Plugin interface + 10 optional HasX capability sub-interfaces
* Host struct with Logger / DB / Messenger / Channels / Attachments /
Search / Secrets / Events / Config / DataDir / Tracer / Metrics /
DefaultOwner / BaseURL
* Registry with panic-on-duplicate, stability-level tracking, capability
indexing (MCP tools, actions, panels, channel types, routes, event
subscribers, CLI commands)
* Migrator: per-plugin SHA-256-checksum'd migration chain, namespaced
plugin_<name>_* table enforcement, idempotent re-apply
* Three-phase lifecycle (Migrate → Init → Start) with panic-safe
wrappers around every plugin call; failure per plugin isolated,
core continues
* YAML config loader that preserves unknown top-level keys on round-trip
* Status store exposing /api/plugins/status JSON
* Restart helpers (Noop + SignalRestarter); graceful reload is
in-process for the demo
- internal/plugin/plugintest/ (~345 LOC):
* NopHost(t) with in-memory modernc.org/sqlite
* Run(t, plugin) full-lifecycle smoke helper
* Assertions: HasTool, HasAction, HasPanel, HasChannelType,
HasMigration, PluginStarted, PluginFailed
* ScopedSecrets that returns ErrSecretNotFound for cross-plugin
reads (satisfies SC-006)
- internal/plugins/demo/ (canonical showcase):
* Plugin that exercises every HasX capability (migrations, actions,
HTTP routes, web panel, lifecycle, config schema, stability)
* Own SQL migration creating plugin_demo_notes
* Embedded HTML panel that fetches notes via JS
* 4 unit tests covering smoke, full capability registration, action
handlers, and config-driven max_notes limit
- cmd/plugindemo/ (~290 LOC):
* Demo HTTP server wiring registry to chi
* Mounts /api/plugins/status, /api/admin/plugins/{name}/{enable,disable},
/api/actions/{name}, /api/plugins/<name>/* (per-plugin REST),
/ui/plugins/<name>/ (per-plugin UI)
* SIGHUP-triggered config reload + registry rebuild + mux swap
* SIGTERM/SIGINT graceful shutdown
- test/integration/ (~357 LOC, build-tag "integration"):
* 6 end-to-end tests against a spawned plugindemo binary
* Enable/disable round-trip with data preservation
* SIGHUP reload timing (measured 41 ms — SC-008 target is 2 s)
* Action-404 on disabled plugin, panel-404 on disabled plugin
* REST endpoints + UI panel reachable
Contract deviation: admin toggle endpoints moved from
/api/plugins/{name}/{enable,disable} to /api/admin/plugins/{name}/{...}
to avoid URL collision with chi per-plugin route mounts. rest.md updated.
Scope deferred to next session (mechanical follow-ups):
- Port internal/wiki/ to internal/plugins/wiki/
- Squash 26 migrations to schema/000_initial.sql
- Backup scripts for live kubic instance
- Remaining 9 plugin extractions
- Boundary-lint static analyzer
- Wire into cmd/synapbus/main.go
All unit + integration tests green. Chrome UI smoke test passes.
autonomous_summary.md carries the full verification record.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
104 lines
2.3 KiB
Go
104 lines
2.3 KiB
Go
package plugin_test
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/synapbus/synapbus/internal/plugin"
|
|
)
|
|
|
|
const sampleYAML = `
|
|
port: 8080
|
|
plugins:
|
|
wiki:
|
|
enabled: true
|
|
config:
|
|
max_revisions: 100
|
|
marketplace:
|
|
enabled: false
|
|
`
|
|
|
|
func TestLoadConfig_ReadsPlugins(t *testing.T) {
|
|
dir := t.TempDir()
|
|
p := filepath.Join(dir, "synapbus.yaml")
|
|
if err := os.WriteFile(p, []byte(sampleYAML), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
cfg, err := plugin.LoadConfig(p)
|
|
if err != nil {
|
|
t.Fatalf("LoadConfig: %v", err)
|
|
}
|
|
if !cfg.IsEnabled("wiki") {
|
|
t.Fatalf("expected wiki enabled")
|
|
}
|
|
if cfg.IsEnabled("marketplace") {
|
|
t.Fatalf("expected marketplace disabled")
|
|
}
|
|
if cfg.IsEnabled("ghost") {
|
|
t.Fatalf("expected unknown plugin disabled")
|
|
}
|
|
}
|
|
|
|
func TestLoadConfig_RoundTripPreservesUnknownKeys(t *testing.T) {
|
|
dir := t.TempDir()
|
|
p := filepath.Join(dir, "synapbus.yaml")
|
|
if err := os.WriteFile(p, []byte(sampleYAML), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
cfg, err := plugin.LoadConfig(p)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Flip marketplace enabled and save.
|
|
cfg.SetEnabled("marketplace", true)
|
|
if err := cfg.Save(p); err != nil {
|
|
t.Fatalf("Save: %v", err)
|
|
}
|
|
cfg2, err := plugin.LoadConfig(p)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !cfg2.IsEnabled("marketplace") {
|
|
t.Fatal("round-trip lost the flip")
|
|
}
|
|
raw, err := os.ReadFile(p)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !containsBytes(raw, []byte("port: 8080")) {
|
|
t.Fatalf("unknown top-level key 'port' not preserved:\n%s", raw)
|
|
}
|
|
}
|
|
|
|
func TestLoadConfig_MissingFileIsEmptyNotError(t *testing.T) {
|
|
cfg, err := plugin.LoadConfig("/nonexistent/path/synapbus.yaml")
|
|
if err != nil {
|
|
t.Fatalf("missing file should not be an error: %v", err)
|
|
}
|
|
if cfg.IsEnabled("anything") {
|
|
t.Fatalf("empty config should not enable anything")
|
|
}
|
|
}
|
|
|
|
func TestValidatePluginNames_RejectsInvalid(t *testing.T) {
|
|
cfg := &plugin.FileConfig{Plugins: map[string]plugin.PluginConfig{
|
|
"BadName": {Enabled: true},
|
|
}}
|
|
if err := cfg.ValidatePluginNames(); err == nil {
|
|
t.Fatal("expected rejection of invalid plugin name")
|
|
}
|
|
}
|
|
|
|
func containsBytes(haystack, needle []byte) bool {
|
|
if len(needle) > len(haystack) {
|
|
return false
|
|
}
|
|
for i := 0; i <= len(haystack)-len(needle); i++ {
|
|
if string(haystack[i:i+len(needle)]) == string(needle) {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|