Algis DumbrisandClaude Opus 4.7
494e8f83e9
Implements the compile-in plugin system designed in spec 019:
- internal/plugin/ (~1,300 LOC):
* Tiny Plugin interface + 10 optional HasX capability sub-interfaces
* Host struct with Logger / DB / Messenger / Channels / Attachments /
Search / Secrets / Events / Config / DataDir / Tracer / Metrics /
DefaultOwner / BaseURL
* Registry with panic-on-duplicate, stability-level tracking, capability
indexing (MCP tools, actions, panels, channel types, routes, event
subscribers, CLI commands)
* Migrator: per-plugin SHA-256-checksum'd migration chain, namespaced
plugin_<name>_* table enforcement, idempotent re-apply
* Three-phase lifecycle (Migrate → Init → Start) with panic-safe
wrappers around every plugin call; failure per plugin isolated,
core continues
* YAML config loader that preserves unknown top-level keys on round-trip
* Status store exposing /api/plugins/status JSON
* Restart helpers (Noop + SignalRestarter); graceful reload is
in-process for the demo
- internal/plugin/plugintest/ (~345 LOC):
* NopHost(t) with in-memory modernc.org/sqlite
* Run(t, plugin) full-lifecycle smoke helper
* Assertions: HasTool, HasAction, HasPanel, HasChannelType,
HasMigration, PluginStarted, PluginFailed
* ScopedSecrets that returns ErrSecretNotFound for cross-plugin
reads (satisfies SC-006)
- internal/plugins/demo/ (canonical showcase):
* Plugin that exercises every HasX capability (migrations, actions,
HTTP routes, web panel, lifecycle, config schema, stability)
* Own SQL migration creating plugin_demo_notes
* Embedded HTML panel that fetches notes via JS
* 4 unit tests covering smoke, full capability registration, action
handlers, and config-driven max_notes limit
- cmd/plugindemo/ (~290 LOC):
* Demo HTTP server wiring registry to chi
* Mounts /api/plugins/status, /api/admin/plugins/{name}/{enable,disable},
/api/actions/{name}, /api/plugins/<name>/* (per-plugin REST),
/ui/plugins/<name>/ (per-plugin UI)
* SIGHUP-triggered config reload + registry rebuild + mux swap
* SIGTERM/SIGINT graceful shutdown
- test/integration/ (~357 LOC, build-tag "integration"):
* 6 end-to-end tests against a spawned plugindemo binary
* Enable/disable round-trip with data preservation
* SIGHUP reload timing (measured 41 ms — SC-008 target is 2 s)
* Action-404 on disabled plugin, panel-404 on disabled plugin
* REST endpoints + UI panel reachable
Contract deviation: admin toggle endpoints moved from
/api/plugins/{name}/{enable,disable} to /api/admin/plugins/{name}/{...}
to avoid URL collision with chi per-plugin route mounts. rest.md updated.
Scope deferred to next session (mechanical follow-ups):
- Port internal/wiki/ to internal/plugins/wiki/
- Squash 26 migrations to schema/000_initial.sql
- Backup scripts for live kubic instance
- Remaining 9 plugin extractions
- Boundary-lint static analyzer
- Wire into cmd/synapbus/main.go
All unit + integration tests green. Chrome UI smoke test passes.
autonomous_summary.md carries the full verification record.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
56 lines
1.5 KiB
Go
56 lines
1.5 KiB
Go
package plugintest
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/synapbus/synapbus/internal/plugin"
|
|
)
|
|
|
|
// Run exercises a plugin's full lifecycle against a NopHost:
|
|
// 1. Apply migrations.
|
|
// 2. Init.
|
|
// 3. If HasLifecycle: Start then Shutdown.
|
|
// Fails the test on any error. This is the canonical smoke-test a plugin
|
|
// author runs.
|
|
func Run(t *testing.T, p plugin.Plugin) {
|
|
t.Helper()
|
|
host := NopHost(t)
|
|
if !plugin.ValidateName(p.Name()) {
|
|
t.Fatalf("invalid plugin name %q", p.Name())
|
|
}
|
|
ctx := context.Background()
|
|
if _, err := plugin.ApplyMigrations(ctx, host.DB, p); err != nil {
|
|
t.Fatalf("ApplyMigrations: %v", err)
|
|
}
|
|
if err := p.Init(ctx, host); err != nil {
|
|
t.Fatalf("Init: %v", err)
|
|
}
|
|
if hl, ok := p.(plugin.HasLifecycle); ok {
|
|
if err := hl.Start(ctx); err != nil {
|
|
t.Fatalf("Start: %v", err)
|
|
}
|
|
if err := hl.Shutdown(ctx); err != nil {
|
|
t.Fatalf("Shutdown: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// RunRegistry drives an entire Registry through InitAll with a factory that
|
|
// produces a NopHost per plugin. Useful for testing lifecycle interactions
|
|
// between multiple plugins (failure isolation, ordering, etc.).
|
|
func RunRegistry(t *testing.T, reg *plugin.Registry) {
|
|
t.Helper()
|
|
host := NopHost(t)
|
|
ctx := context.Background()
|
|
factory := func(name string, _ plugin.CapabilityContext) plugin.Host {
|
|
h := host
|
|
h.Secrets = NewScopedSecrets(name)
|
|
h.Logger = h.Logger.With("plugin", name)
|
|
return h
|
|
}
|
|
if err := reg.InitAll(ctx, factory); err != nil {
|
|
t.Fatalf("InitAll: %v", err)
|
|
}
|
|
}
|