Files
synapbus/internal/plugin/migrator_test.go
T
Algis DumbrisandClaude Opus 4.7 494e8f83e9 feat(plugin): plugin framework + plugintest + demo plugin + integration tests
Implements the compile-in plugin system designed in spec 019:

- internal/plugin/ (~1,300 LOC):
  * Tiny Plugin interface + 10 optional HasX capability sub-interfaces
  * Host struct with Logger / DB / Messenger / Channels / Attachments /
    Search / Secrets / Events / Config / DataDir / Tracer / Metrics /
    DefaultOwner / BaseURL
  * Registry with panic-on-duplicate, stability-level tracking, capability
    indexing (MCP tools, actions, panels, channel types, routes, event
    subscribers, CLI commands)
  * Migrator: per-plugin SHA-256-checksum'd migration chain, namespaced
    plugin_<name>_* table enforcement, idempotent re-apply
  * Three-phase lifecycle (Migrate → Init → Start) with panic-safe
    wrappers around every plugin call; failure per plugin isolated,
    core continues
  * YAML config loader that preserves unknown top-level keys on round-trip
  * Status store exposing /api/plugins/status JSON
  * Restart helpers (Noop + SignalRestarter); graceful reload is
    in-process for the demo

- internal/plugin/plugintest/ (~345 LOC):
  * NopHost(t) with in-memory modernc.org/sqlite
  * Run(t, plugin) full-lifecycle smoke helper
  * Assertions: HasTool, HasAction, HasPanel, HasChannelType,
    HasMigration, PluginStarted, PluginFailed
  * ScopedSecrets that returns ErrSecretNotFound for cross-plugin
    reads (satisfies SC-006)

- internal/plugins/demo/ (canonical showcase):
  * Plugin that exercises every HasX capability (migrations, actions,
    HTTP routes, web panel, lifecycle, config schema, stability)
  * Own SQL migration creating plugin_demo_notes
  * Embedded HTML panel that fetches notes via JS
  * 4 unit tests covering smoke, full capability registration, action
    handlers, and config-driven max_notes limit

- cmd/plugindemo/ (~290 LOC):
  * Demo HTTP server wiring registry to chi
  * Mounts /api/plugins/status, /api/admin/plugins/{name}/{enable,disable},
    /api/actions/{name}, /api/plugins/<name>/* (per-plugin REST),
    /ui/plugins/<name>/ (per-plugin UI)
  * SIGHUP-triggered config reload + registry rebuild + mux swap
  * SIGTERM/SIGINT graceful shutdown

- test/integration/ (~357 LOC, build-tag "integration"):
  * 6 end-to-end tests against a spawned plugindemo binary
  * Enable/disable round-trip with data preservation
  * SIGHUP reload timing (measured 41 ms — SC-008 target is 2 s)
  * Action-404 on disabled plugin, panel-404 on disabled plugin
  * REST endpoints + UI panel reachable

Contract deviation: admin toggle endpoints moved from
/api/plugins/{name}/{enable,disable} to /api/admin/plugins/{name}/{...}
to avoid URL collision with chi per-plugin route mounts. rest.md updated.

Scope deferred to next session (mechanical follow-ups):
- Port internal/wiki/ to internal/plugins/wiki/
- Squash 26 migrations to schema/000_initial.sql
- Backup scripts for live kubic instance
- Remaining 9 plugin extractions
- Boundary-lint static analyzer
- Wire into cmd/synapbus/main.go

All unit + integration tests green. Chrome UI smoke test passes.
autonomous_summary.md carries the full verification record.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-19 07:14:27 +03:00

99 lines
2.9 KiB
Go

package plugin_test
import (
"context"
"database/sql"
"testing"
_ "modernc.org/sqlite"
"github.com/synapbus/synapbus/internal/plugin"
)
type migPlugin struct {
name string
migs []plugin.Migration
}
func (p *migPlugin) Name() string { return p.name }
func (p *migPlugin) Version() string { return "0.1.0" }
func (p *migPlugin) Init(ctx context.Context, host plugin.Host) error { return nil }
func (p *migPlugin) Migrations() []plugin.Migration { return p.migs }
func openMem(t *testing.T) *sql.DB {
t.Helper()
db, err := sql.Open("sqlite", ":memory:")
if err != nil {
t.Fatal(err)
}
t.Cleanup(func() { _ = db.Close() })
return db
}
func TestApplyMigrations_AppliesOnce(t *testing.T) {
db := openMem(t)
p := &migPlugin{name: "demo", migs: []plugin.Migration{
{Version: 1, Name: "001", SQL: `CREATE TABLE plugin_demo_t (id INTEGER);`},
}}
res, err := plugin.ApplyMigrations(context.Background(), db, p)
if err != nil {
t.Fatalf("apply: %v", err)
}
if len(res.Applied) != 1 || res.Applied[0] != 1 {
t.Fatalf("expected applied=[1], got %+v", res.Applied)
}
// Running twice is a no-op.
res2, err := plugin.ApplyMigrations(context.Background(), db, p)
if err != nil {
t.Fatalf("reapply: %v", err)
}
if len(res2.Applied) != 0 {
t.Fatalf("expected no-op on second apply, got %+v", res2.Applied)
}
}
func TestApplyMigrations_RefusesChecksumMismatch(t *testing.T) {
db := openMem(t)
p := &migPlugin{name: "demo", migs: []plugin.Migration{
{Version: 1, Name: "001", SQL: `CREATE TABLE plugin_demo_t (id INTEGER);`},
}}
if _, err := plugin.ApplyMigrations(context.Background(), db, p); err != nil {
t.Fatal(err)
}
// Modify the SQL for the same version.
p.migs[0].SQL = `CREATE TABLE plugin_demo_t (id INTEGER, name TEXT);`
_, err := plugin.ApplyMigrations(context.Background(), db, p)
if err == nil {
t.Fatal("expected checksum mismatch error")
}
}
func TestApplyMigrations_RejectsUnprefixedTable(t *testing.T) {
db := openMem(t)
p := &migPlugin{name: "demo", migs: []plugin.Migration{
{Version: 1, Name: "001", SQL: `CREATE TABLE wrong_table (id INTEGER);`},
}}
_, err := plugin.ApplyMigrations(context.Background(), db, p)
if err == nil {
t.Fatal("expected rejection for unprefixed table name")
}
}
func TestApplyMigrations_AppliedVersionsReflectsState(t *testing.T) {
db := openMem(t)
p := &migPlugin{name: "demo", migs: []plugin.Migration{
{Version: 1, Name: "001", SQL: `CREATE TABLE plugin_demo_a (id INTEGER);`},
{Version: 2, Name: "002", SQL: `CREATE TABLE plugin_demo_b (id INTEGER);`},
}}
if _, err := plugin.ApplyMigrations(context.Background(), db, p); err != nil {
t.Fatal(err)
}
vs, err := plugin.AppliedVersions(context.Background(), db, "demo")
if err != nil {
t.Fatal(err)
}
if len(vs) != 2 || vs[0] != 1 || vs[1] != 2 {
t.Fatalf("expected [1,2], got %+v", vs)
}
}