From f952ff25f65481e53d0b065f2b09ec7b6c68b431 Mon Sep 17 00:00:00 2001 From: aler9 <46489434+aler9@users.noreply.github.com> Date: Sun, 14 Aug 2022 13:14:08 +0200 Subject: [PATCH] remove useless append() --- internal/core/rtsp_session.go | 2 +- internal/core/rtsp_source.go | 2 +- internal/core/streamtrack_h264.go | 4 ++-- internal/hls/muxer_variant_fmp4_segmenter.go | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/core/rtsp_session.go b/internal/core/rtsp_session.go index 8d2e6138..c87bf2a7 100644 --- a/internal/core/rtsp_session.go +++ b/internal/core/rtsp_session.go @@ -395,7 +395,7 @@ func (s *rtspSession) onPacketRTP(ctx *gortsplib.ServerHandlerOnPacketRTPCtx) { rtpPacket: ctx.Packet, ptsEqualsDTS: ctx.PTSEqualsDTS, pts: ctx.H264PTS, - h264NALUs: append([][]byte(nil), ctx.H264NALUs...), + h264NALUs: ctx.H264NALUs, }) } else { s.stream.writeData(&data{ diff --git a/internal/core/rtsp_source.go b/internal/core/rtsp_source.go index 0992ab03..24366151 100644 --- a/internal/core/rtsp_source.go +++ b/internal/core/rtsp_source.go @@ -146,7 +146,7 @@ func (s *rtspSource) run(ctx context.Context) error { rtpPacket: ctx.Packet, ptsEqualsDTS: ctx.PTSEqualsDTS, pts: ctx.H264PTS, - h264NALUs: append([][]byte(nil), ctx.H264NALUs...), + h264NALUs: ctx.H264NALUs, }) } else { res.stream.writeData(&data{ diff --git a/internal/core/streamtrack_h264.go b/internal/core/streamtrack_h264.go index c6ebe6ab..a4da2536 100644 --- a/internal/core/streamtrack_h264.go +++ b/internal/core/streamtrack_h264.go @@ -40,12 +40,12 @@ func (t *streamTrackH264) updateTrackParameters(nalus [][]byte) { switch typ { case h264.NALUTypeSPS: if !bytes.Equal(nalu, t.track.SafeSPS()) { - t.track.SafeSetSPS(append([]byte(nil), nalu...)) + t.track.SafeSetSPS(nalu) } case h264.NALUTypePPS: if !bytes.Equal(nalu, t.track.SafePPS()) { - t.track.SafeSetPPS(append([]byte(nil), nalu...)) + t.track.SafeSetPPS(nalu) } } } diff --git a/internal/hls/muxer_variant_fmp4_segmenter.go b/internal/hls/muxer_variant_fmp4_segmenter.go index 67c8975c..a241ba76 100644 --- a/internal/hls/muxer_variant_fmp4_segmenter.go +++ b/internal/hls/muxer_variant_fmp4_segmenter.go @@ -163,7 +163,7 @@ func (m *muxerVariantFMP4Segmenter) writeH264Entry(sample *fmp4.VideoSample) err m.videoFirstIDRReceived = true m.videoDTSExtractor = h264.NewDTSExtractor() - m.videoSPS = append([]byte(nil), m.videoTrack.SafeSPS()...) + m.videoSPS = m.videoTrack.SafeSPS() var err error sample.DTS, err = m.videoDTSExtractor.Extract(sample.NALUs, sample.PTS) @@ -249,7 +249,7 @@ func (m *muxerVariantFMP4Segmenter) writeH264Entry(sample *fmp4.VideoSample) err // if SPS changed, reset adjusted part duration if spsChanged { - m.videoSPS = append([]byte(nil), sps...) + m.videoSPS = sps m.firstSegmentFinalized = false m.sampleDurations = make(map[time.Duration]struct{}) }