From d21506182bfd7d2d991b1b750ddbe2e86e0dfd55 Mon Sep 17 00:00:00 2001 From: Alessandro Ros Date: Sun, 19 May 2024 13:46:47 +0200 Subject: [PATCH] webrtc: fix returning code 404 when a stream does not exist (#3369) --- internal/servers/webrtc/server_test.go | 2 +- internal/servers/webrtc/session.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/servers/webrtc/server_test.go b/internal/servers/webrtc/server_test.go index e21b04f0..12f02d67 100644 --- a/internal/servers/webrtc/server_test.go +++ b/internal/servers/webrtc/server_test.go @@ -90,7 +90,7 @@ func (pm *dummyPathManager) AddPublisher(_ defs.PathAddPublisherReq) (defs.Path, func (pm *dummyPathManager) AddReader(req defs.PathAddReaderReq) (defs.Path, *stream.Stream, error) { if req.AccessRequest.Name == "nonexisting" { - return nil, nil, &defs.PathNoOnePublishingError{} + return nil, nil, defs.PathNoOnePublishingError{} } return pm.path, pm.path.stream, nil } diff --git a/internal/servers/webrtc/session.go b/internal/servers/webrtc/session.go index cf6cc42e..ef549ef9 100644 --- a/internal/servers/webrtc/session.go +++ b/internal/servers/webrtc/session.go @@ -518,7 +518,7 @@ func (s *session) runRead() (int, error) { return http.StatusUnauthorized, err } - var terr2 *defs.PathNoOnePublishingError + var terr2 defs.PathNoOnePublishingError if errors.As(err, &terr2) { return http.StatusNotFound, err }